chore: do not send field context as tag for deprecated fields (#8902)

This commit is contained in:
Srikanth Chekuri 2025-08-24 11:14:12 +05:30 committed by GitHub
parent 4d72f47758
commit a7ddd2ddf0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -66,9 +66,46 @@ function getSignalType(dataSource: string): 'traces' | 'logs' | 'metrics' {
return 'metrics'; return 'metrics';
} }
/** function isDeprecatedField(fieldName: string): boolean {
* Creates base spec for builder queries const deprecatedIntrinsicFields = [
*/ 'traceID',
'spanID',
'parentSpanID',
'spanKind',
'durationNano',
'statusCode',
'statusMessage',
'statusCodeString',
];
const deprecatedCalculatedFields = [
'responseStatusCode',
'externalHttpUrl',
'httpUrl',
'externalHttpMethod',
'httpMethod',
'httpHost',
'dbName',
'dbOperation',
'hasError',
'isRemote',
'serviceName',
'httpRoute',
'msgSystem',
'msgOperation',
'dbSystem',
'rpcSystem',
'rpcService',
'rpcMethod',
'peerService',
];
return (
deprecatedIntrinsicFields.includes(fieldName) ||
deprecatedCalculatedFields.includes(fieldName)
);
}
function createBaseSpec( function createBaseSpec(
queryData: IBuilderQuery, queryData: IBuilderQuery,
requestType: RequestType, requestType: RequestType,
@ -140,16 +177,29 @@ function createBaseSpec(
selectFields: isEmpty(nonEmptySelectColumns) selectFields: isEmpty(nonEmptySelectColumns)
? undefined ? undefined
: nonEmptySelectColumns?.map( : nonEmptySelectColumns?.map(
(column: any): TelemetryFieldKey => ({ (column: any): TelemetryFieldKey => {
name: column.name ?? column.key, const fieldName = column.name ?? column.key;
const isDeprecated = isDeprecatedField(fieldName);
const fieldObj: TelemetryFieldKey = {
name: fieldName,
fieldDataType: fieldDataType:
column?.fieldDataType ?? (column?.dataType as FieldDataType), column?.fieldDataType ?? (column?.dataType as FieldDataType),
fieldContext: column?.fieldContext ?? (column?.type as FieldContext),
signal: column?.signal ?? undefined, signal: column?.signal ?? undefined,
}), };
// Only add fieldContext if the field is NOT deprecated
if (!isDeprecated && fieldName !== 'name') {
fieldObj.fieldContext =
column?.fieldContext ?? (column?.type as FieldContext);
}
return fieldObj;
},
), ),
}; };
} }
// Utility to parse aggregation expressions with optional alias // Utility to parse aggregation expressions with optional alias
export function parseAggregations( export function parseAggregations(
expression: string, expression: string,