External/signoz
1
0
Fork 0
mirror of https://github.com/SigNoz/signoz.git synced 2025-12-17 07:26:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: fix the flaky test (#9255)

Browse Source 
* fix: fix the flaky test

* chore: remove unnecessary changes
This commit is contained in:
Shaheer Kochai 2025-10-06 21:02:12 +04:30 committed by GitHub
parent c770a1a4e1
commit a22ef64bb0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
frontend/src/container/SpanDetailsDrawer/__tests__/SpanDetailsDrawer.test.tsx
View File

@ -261,18 +261,16 @@ describe('SpanDetailsDrawer', () => {
const logsButton = screen.getByRole('radio', { name: /logs/i }); const logsButton = screen.getByRole('radio', { name: /logs/i });
fireEvent.click(logsButton); fireEvent.click(logsButton);
// Wait for logs view to open // Wait for logs view to open and logs to be displayed
await waitFor(() => { await waitFor(() => {
expect(screen.getByTestId('overlay-scrollbar')).toBeInTheDocument(); expect(screen.getByTestId('overlay-scrollbar')).toBeInTheDocument();
});
// Verify logs are displayed
await waitFor(() => {
// eslint-disable-next-line sonarjs/no-duplicate-string // eslint-disable-next-line sonarjs/no-duplicate-string
expect(screen.getByTestId('raw-log-span-log-1')).toBeInTheDocument(); expect(screen.getByTestId('raw-log-span-log-1')).toBeInTheDocument();
// eslint-disable-next-line sonarjs/no-duplicate-string
expect(screen.getByTestId('raw-log-span-log-2')).toBeInTheDocument(); expect(screen.getByTestId('raw-log-span-log-2')).toBeInTheDocument();
// eslint-disable-next-line sonarjs/no-duplicate-string // eslint-disable-next-line sonarjs/no-duplicate-string
expect(screen.getByTestId('raw-log-context-log-before')).toBeInTheDocument(); expect(screen.getByTestId('raw-log-context-log-before')).toBeInTheDocument();
// eslint-disable-next-line sonarjs/no-duplicate-string
expect(screen.getByTestId('raw-log-context-log-after')).toBeInTheDocument(); expect(screen.getByTestId('raw-log-context-log-after')).toBeInTheDocument();
}); });
}); });
@ -285,12 +283,9 @@ describe('SpanDetailsDrawer', () => {
fireEvent.click(logsButton); fireEvent.click(logsButton);
// Wait for all API calls to complete // Wait for all API calls to complete
await waitFor( await waitFor(() => {
() => { expect(GetMetricQueryRange).toHaveBeenCalledTimes(3);
expect(GetMetricQueryRange).toHaveBeenCalledTimes(3); });
},
{ timeout: 5000 },
);
// Verify the three distinct queries were made // Verify the three distinct queries were made
const [spanQuery, beforeQuery, afterQuery] = apiCallHistory; const [spanQuery, beforeQuery, afterQuery] = apiCallHistory;
@ -319,12 +314,9 @@ describe('SpanDetailsDrawer', () => {
fireEvent.click(logsButton); fireEvent.click(logsButton);
// Wait for all API calls to complete // Wait for all API calls to complete
await waitFor( await waitFor(() => {
() => { expect(GetMetricQueryRange).toHaveBeenCalledTimes(3);
expect(GetMetricQueryRange).toHaveBeenCalledTimes(3); });
},
{ timeout: 5000 },
);
const [spanQuery, beforeQuery, afterQuery] = apiCallHistory; const [spanQuery, beforeQuery, afterQuery] = apiCallHistory;
@ -484,9 +476,17 @@ describe('SpanDetailsDrawer', () => {
const logsButton = screen.getByRole('radio', { name: /logs/i }); const logsButton = screen.getByRole('radio', { name: /logs/i });
fireEvent.click(logsButton); fireEvent.click(logsButton);
// Wait for logs to load // Wait for all API calls to complete first
await waitFor(() => {
expect(GetMetricQueryRange).toHaveBeenCalledTimes(3);
});
// Wait for all logs to be rendered - both span logs and context logs
await waitFor(() => { await waitFor(() => {
expect(screen.getByTestId('raw-log-span-log-1')).toBeInTheDocument(); expect(screen.getByTestId('raw-log-span-log-1')).toBeInTheDocument();
expect(screen.getByTestId('raw-log-span-log-2')).toBeInTheDocument();
expect(screen.getByTestId('raw-log-context-log-before')).toBeInTheDocument();
expect(screen.getByTestId('raw-log-context-log-after')).toBeInTheDocument();
}); });
// Verify span logs are highlighted // Verify span logs are highlighted