External/signoz
1
0
Fork 0
mirror of https://github.com/SigNoz/signoz.git synced 2025-12-18 16:07:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: added for comparison across group by and merges debugging quantile exact

Browse Source
This commit is contained in:
nikhilmantri0902 2025-08-19 00:56:43 +05:30
parent c4762045a6
commit 2fb7fe49ef
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/query-service/app/clickhouseReader/reader.go
View File

@ -428,7 +428,7 @@ func (r *ClickHouseReader) GetServicesOG(ctx context.Context, queryParams *model
query := fmt.Sprintf( query := fmt.Sprintf(
`SELECT `SELECT
quantile(0.99)(duration_nano) as p99, quantileExact(0.99)(duration_nano) as p99,
avg(duration_nano) as avgDuration, avg(duration_nano) as avgDuration,
count(*) as numCalls count(*) as numCalls
FROM %s.%s FROM %s.%s
@ -553,7 +553,7 @@ func (r *ClickHouseReader) GetServices(ctx context.Context, queryParams *model.G
query := fmt.Sprintf(` query := fmt.Sprintf(`
SELECT SELECT
resource_string_service$$name AS serviceName, resource_string_service$$name AS serviceName,
quantile(0.99)(duration_nano) AS p99, quantileExact(0.99)(duration_nano) AS p99,
avg(duration_nano) AS avgDuration, avg(duration_nano) AS avgDuration,
count(*) AS numCalls, count(*) AS numCalls,
countIf(statusCode = 2) AS numErrors countIf(statusCode = 2) AS numErrors
@ -797,7 +797,6 @@ func getStatusFilters(query string, statusParams []string, excludeMap map[string
} }
return query return query
} }
func createTagQueryFromTagQueryParams(queryParams []model.TagQueryParam) []model.TagQuery { func createTagQueryFromTagQueryParams(queryParams []model.TagQueryParam) []model.TagQuery {
tags := []model.TagQuery{} tags := []model.TagQuery{}
for _, tag := range queryParams { for _, tag := range queryParams {
@ -1023,8 +1022,8 @@ func (r *ClickHouseReader) GetTopOperations(ctx context.Context, queryParams *mo
query := fmt.Sprintf(` query := fmt.Sprintf(`
SELECT SELECT
quantile(0.5)(durationNano) as p50, quantile(0.5)(durationNano) as p50,
quantile(0.95)(durationNano) as p95, quantileExact(0.95)(durationNano) as p95,
quantile(0.99)(durationNano) as p99, quantileExact(0.99)(durationNano) as p99,
COUNT(*) as numCalls, COUNT(*) as numCalls,
countIf(status_code=2) as errorCount, countIf(status_code=2) as errorCount,
name name
@ -1542,7 +1541,6 @@ func getLocalTableName(tableName string) string {
return tableNameSplit[0] + "." + strings.Split(tableNameSplit[1], "distributed_")[1] return tableNameSplit[0] + "." + strings.Split(tableNameSplit[1], "distributed_")[1]
} }
func (r *ClickHouseReader) setTTLLogs(ctx context.Context, orgID string, params *model.TTLParams) (*model.SetTTLResponseItem, *model.ApiError) { func (r *ClickHouseReader) setTTLLogs(ctx context.Context, orgID string, params *model.TTLParams) (*model.SetTTLResponseItem, *model.ApiError) {
// uuid is used as transaction id // uuid is used as transaction id
uuidWithHyphen := uuid.New() uuidWithHyphen := uuid.New()
@ -2323,7 +2321,6 @@ func (r *ClickHouseReader) ListErrors(ctx context.Context, queryParams *model.Li
return &getErrorResponses, nil return &getErrorResponses, nil
} }
func (r *ClickHouseReader) CountErrors(ctx context.Context, queryParams *model.CountErrorsParams) (uint64, *model.ApiError) { func (r *ClickHouseReader) CountErrors(ctx context.Context, queryParams *model.CountErrorsParams) (uint64, *model.ApiError) {
var errorCount uint64 var errorCount uint64
@ -3095,7 +3092,6 @@ func (r *ClickHouseReader) GetMetricAttributeKeys(ctx context.Context, req *v3.F
return &response, nil return &response, nil
} }
func (r *ClickHouseReader) GetMeterAttributeKeys(ctx context.Context, req *v3.FilterAttributeKeyRequest) (*v3.FilterAttributeKeyResponse, error) { func (r *ClickHouseReader) GetMeterAttributeKeys(ctx context.Context, req *v3.FilterAttributeKeyRequest) (*v3.FilterAttributeKeyResponse, error) {
var query string var query string
var err error var err error
@ -3841,7 +3837,6 @@ func readRow(vars []interface{}, columnNames []string, countOfNumberCols int) ([
} }
return groupBy, groupAttributes, groupAttributesArray, nil return groupBy, groupAttributes, groupAttributesArray, nil
} }
func readRowsForTimeSeriesResult(rows driver.Rows, vars []interface{}, columnNames []string, countOfNumberCols int) ([]*v3.Series, error) { func readRowsForTimeSeriesResult(rows driver.Rows, vars []interface{}, columnNames []string, countOfNumberCols int) ([]*v3.Series, error) {
// when groupBy is applied, each combination of cartesian product // when groupBy is applied, each combination of cartesian product
// of attribute values is a separate series. Each item in seriesToPoints // of attribute values is a separate series. Each item in seriesToPoints
@ -4637,7 +4632,6 @@ func (r *ClickHouseReader) ReadRuleStateHistoryByRuleID(
return timeline, nil return timeline, nil
} }
func (r *ClickHouseReader) ReadRuleStateHistoryTopContributorsByRuleID( func (r *ClickHouseReader) ReadRuleStateHistoryTopContributorsByRuleID(
ctx context.Context, ruleID string, params *model.QueryRuleStateHistory) ([]model.RuleStateHistoryContributor, error) { ctx context.Context, ruleID string, params *model.QueryRuleStateHistory) ([]model.RuleStateHistoryContributor, error) {
query := fmt.Sprintf(`SELECT query := fmt.Sprintf(`SELECT
@ -5226,7 +5220,6 @@ func (r *ClickHouseReader) GetActiveTimeSeriesForMetricName(ctx context.Context,
} }
return timeSeries, nil return timeSeries, nil
} }
func (r *ClickHouseReader) ListSummaryMetrics(ctx context.Context, orgID valuer.UUID, req *metrics_explorer.SummaryListMetricsRequest) (*metrics_explorer.SummaryListMetricsResponse, *model.ApiError) { func (r *ClickHouseReader) ListSummaryMetrics(ctx context.Context, orgID valuer.UUID, req *metrics_explorer.SummaryListMetricsRequest) (*metrics_explorer.SummaryListMetricsResponse, *model.ApiError) {
var args []interface{} var args []interface{}
@ -6023,7 +6016,6 @@ func (r *ClickHouseReader) GetInspectMetrics(ctx context.Context, req *metrics_e
Series: &seriesList, Series: &seriesList,
}, nil }, nil
} }
func (r *ClickHouseReader) GetInspectMetricsFingerprints(ctx context.Context, attributes []string, req *metrics_explorer.InspectMetricsRequest) ([]string, *model.ApiError) { func (r *ClickHouseReader) GetInspectMetricsFingerprints(ctx context.Context, attributes []string, req *metrics_explorer.InspectMetricsRequest) ([]string, *model.ApiError) {
// Build dynamic key selections and JSON extracts // Build dynamic key selections and JSON extracts
var jsonExtracts []string var jsonExtracts []string