From 26d55875f5ff0948b1b5aca8448e81ec6f18fd9e Mon Sep 17 00:00:00 2001
From: Amlan Kumar Nandy <45410599+amlannandy@users.noreply.github.com>
Date: Mon, 7 Jul 2025 23:34:17 +0700
Subject: [PATCH] chore: fix metrics explorer events (#8411)

---
 .../MetricsExplorer/Summary/Summary.tsx       | 19 ++++++++++---------
 .../src/container/MetricsExplorer/events.ts   |  2 +-
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/frontend/src/container/MetricsExplorer/Summary/Summary.tsx b/frontend/src/container/MetricsExplorer/Summary/Summary.tsx
index f265efa70c62..a7db5085526a 100644
--- a/frontend/src/container/MetricsExplorer/Summary/Summary.tsx
+++ b/frontend/src/container/MetricsExplorer/Summary/Summary.tsx
@@ -75,15 +75,14 @@ function Summary(): JSX.Element {
 	useEffect(() => {
 		logEvent(MetricsExplorerEvents.TabChanged, {
 			[MetricsExplorerEventKeys.Tab]: 'summary',
+			[MetricsExplorerEventKeys.TimeRange]: {
+				startTime: convertNanoToMilliseconds(minTime),
+				endTime: convertNanoToMilliseconds(maxTime),
+			},
 		});
+		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, []);
 
-	useEffect(() => {
-		logEvent(MetricsExplorerEvents.TimeUpdated, {
-			[MetricsExplorerEventKeys.Tab]: 'summary',
-		});
-	}, [maxTime, minTime]);
-
 	// This is used to avoid the filters from being serialized with the id
 	const queryFiltersWithoutId = useMemo(() => {
 		const filtersWithoutId = {
@@ -168,9 +167,11 @@ function Summary(): JSX.Element {
 				[SUMMARY_FILTERS_KEY]: JSON.stringify(value),
 			});
 			setCurrentPage(1);
-			logEvent(MetricsExplorerEvents.FilterApplied, {
-				[MetricsExplorerEventKeys.Tab]: 'summary',
-			});
+			if (value.items.length > 0) {
+				logEvent(MetricsExplorerEvents.FilterApplied, {
+					[MetricsExplorerEventKeys.Tab]: 'summary',
+				});
+			}
 		},
 		[setSearchParams, searchParams],
 	);
diff --git a/frontend/src/container/MetricsExplorer/events.ts b/frontend/src/container/MetricsExplorer/events.ts
index 014f533cfd16..d3341931a8a3 100644
--- a/frontend/src/container/MetricsExplorer/events.ts
+++ b/frontend/src/container/MetricsExplorer/events.ts
@@ -6,7 +6,6 @@ export enum MetricsExplorerEvents {
 	ModalOpened = 'Metrics Explorer: Modal opened',
 	MetricClicked = 'Metrics Explorer: Metric clicked',
 	FilterApplied = 'Metrics Explorer: Filter applied',
-	TimeUpdated = 'Metrics Explorer: Time updated',
 	TreemapViewChanged = 'Metrics Explorer: Treemap view changed',
 	PageNumberChanged = 'Metrics Explorer: Page number changed',
 	PageSizeChanged = 'Metrics Explorer: Page size changed',
@@ -48,4 +47,5 @@ export enum MetricsExplorerEventKeys {
 	YAxisUnit = 'yAxisUnit',
 	ViewName = 'viewName',
 	Filters = 'filters',
+	TimeRange = 'timeRange',
 }