From 0218f701b2611a62e4a92f3d0cecf22fb4fca4b6 Mon Sep 17 00:00:00 2001 From: Vikrant Gupta Date: Fri, 20 Sep 2024 18:12:16 +0530 Subject: [PATCH] fix: alerts links are broken when there is a space in value (#6043) * fix: space between values being converted as + sign in alerts generated links * fix: added inline comment * fix: added inline comment --- .../src/hooks/queryBuilder/useGetCompositeQueryParam.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/hooks/queryBuilder/useGetCompositeQueryParam.ts b/frontend/src/hooks/queryBuilder/useGetCompositeQueryParam.ts index 442531a15b20..efef00022a0f 100644 --- a/frontend/src/hooks/queryBuilder/useGetCompositeQueryParam.ts +++ b/frontend/src/hooks/queryBuilder/useGetCompositeQueryParam.ts @@ -13,7 +13,11 @@ export const useGetCompositeQueryParam = (): Query | null => { try { if (!compositeQuery) return null; - parsedCompositeQuery = JSON.parse(decodeURIComponent(compositeQuery)); + // MDN reference - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/decodeURIComponent#decoding_query_parameters_from_a_url + // MDN reference to support + characters using encoding - https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams#preserving_plus_signs add later + parsedCompositeQuery = JSON.parse( + decodeURIComponent(compositeQuery.replace(/\+/g, ' ')), + ); } catch (e) { parsedCompositeQuery = null; }