mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
96401f4c10
* feat(forge): Phase 2 — Gitea provider, per-call routing, host registry Gitea support lands behind the Phase-1 seam: - GiteaProvider (services/forge/gitea.py): Gitea v1 transport addressed by instance host (api base from the project's git_url). Where Gitea's wire contract diverges from GitHub's, the provider adapts responses back into the shapes GitService already classifies (ShapedResponse): `token` auth scheme, duplicate-PR 409→422 with the "already exists" text GitService keys on, commit statuses reshaped into check_runs / workflow_runs envelopes, APPROVE→APPROVED review mapping, Do-keyed POST merge, merge-method repo keys, label-color '#' prefix, client-side head/base PR filtering. Deliberate postures per the spec: zero-workflows fail-open (statuses-free repo → no_ci_configured) and merge_branch as a shaped 501 (env-sync cascade lands on missing_ref; the shared local-git fallback is Phase-2.1). - ForgeRouter (services/forge/router.py): GitService._forge now routes per call from RepoRef.host — every existing call site unchanged in shape. RepoRef gains an optional host; _parse_git_url returns the host-stamped ref and it is threaded through GitService/release executor instead of being rebuilt from strings (helpers re-signatured to take RepoRef). - Host registry (services/forge/registry.py): in-memory host→provider map, self-healing — ProjectService.get/get_by_slug re-register on every read; provider_for resolves gitea projects by git_url host. - Registration validation now accepts git_provider="gitea"; GitLab remains recognized-but-rejected. Panel: the read-only Forge badge becomes a real picker (Auto-detect / GitHub-GHE / Gitea / GitLab disabled). Plain git (clone/fetch/push) needs no changes — the Basic-auth extraheader works on Gitea unchanged. Gates: mypy 392 files, xenon A, full unit suite 6356 green, integration suite 2257 green. * feat(forge): live-Gitea contract suite + scheme support + slash-safe refs Hardening from running the provider against a real dockerized Gitea 1.22.6 (the spec's Phase-2 contract suite, now committed as the env-gated tests/e2e_smoke/test_gitea_live.py — self-seeding: creates its own repo, pushes real commits, and drives PR open → duplicate reshape → list/filter → diff → review → labels → commit-status CI reshapes → squash merge → branch delete → release, plus a live verification of the x-access-token Basic-auth git-CLI claim). Two real findings fixed: - Branch refs weren't URL-encoded — every RoboCo branch carries slashes (feature/backend/...), and Gitea's router 404s on the extra path segments. list_ci_runs + delete_branch_ref now quote the ref (regression-pinned in the unit suite). - The API base hardcoded https; a LAN instance serving plain http is a real deployment shape. GiteaProvider gains a scheme (recorded per host by the registry from the project's git_url). ShapedResponse moves to forge/shaping.py (shared by the upcoming GitLab transport, which needs its text override for diff reassembly). * feat(forge): Phase 3 GitLab provider + Phase 2.1 local-merge fallback GitLabProvider (services/forge/gitlab.py): GitLab v4 transport addressed by host+scheme, subgroup-safe (the MR project path packs into RepoRef.owner, URL-encoded per call). Adapters translate MR semantics into the GitHub shapes GitService classifies: iid→number, source/target_branch→head/base with a merged bool, per-file diffs reassembled into unified-diff text (ShapedResponse text override, 3-page cap), approve-vs-note review routing (GitLab has no request-changes verb), pipelines/statuses reshaped into workflow_runs/check_runs, merge-method repo-key mapping, duplicate-MR 409→422. Reviewer mirroring is skipped (needs numeric ids RoboCo doesn't store); provisioning stays Phase 4. gitlab.com now auto-detects at registration like github.com; self-hosted GitLab sets the provider explicitly (panel picker enabled). Phase 2.1: neither Gitea nor GitLab has GitHub's server-side merges API — their merge_branch returns a shaped 501 and GitService.sync_env_branch now runs the shared local-git fallback (_local_merge_branch: throwaway clone → ancestor check → merge → push; a conflict aborts with the remote untouched; same status vocabulary as the merges-API path). Also aligns the whole tree with the full gate's tests/-scoped mypy (provider-test responder typing, e2e_smoke's stale owner/repo shapes). Gates: mypy 1229 files clean, xenon A, unit suite 6393 green, forge suites 85 green, panel typecheck/lint clean. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
133 lines
4.6 KiB
Python
133 lines
4.6 KiB
Python
"""Forge provider detection + registration-time validation — pure, no DB/IO."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from roboco.foundation.policy.forge import (
|
|
KNOWN_PROVIDERS,
|
|
detect_provider,
|
|
validate_project_forge,
|
|
)
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# detect_provider — host extraction across https/ssh/.git/subgroup shapes
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_detect_https_github() -> None:
|
|
assert detect_provider("https://github.com/owner/repo.git") == "github"
|
|
|
|
|
|
def test_detect_https_github_no_dot_git_suffix() -> None:
|
|
assert detect_provider("https://github.com/owner/repo") == "github"
|
|
|
|
|
|
def test_detect_https_github_with_token_userinfo() -> None:
|
|
url = "https://x-access-token:ghp_abc123@github.com/owner/repo.git"
|
|
assert detect_provider(url) == "github"
|
|
|
|
|
|
def test_detect_ssh_scp_syntax_github() -> None:
|
|
assert detect_provider("git@github.com:owner/repo.git") == "github"
|
|
|
|
|
|
def test_detect_ssh_url_scheme_github() -> None:
|
|
assert detect_provider("ssh://git@github.com/owner/repo.git") == "github"
|
|
|
|
|
|
def test_detect_https_gitlab_com() -> None:
|
|
assert detect_provider("https://gitlab.com/group/project.git") == "gitlab"
|
|
|
|
|
|
def test_detect_ssh_scp_syntax_gitlab() -> None:
|
|
assert detect_provider("git@gitlab.com:group/project.git") == "gitlab"
|
|
|
|
|
|
def test_detect_gitlab_subgroup_path_still_detects_host() -> None:
|
|
# Subgroup paths (3+ segments) don't change host resolution — detect_provider
|
|
# only looks at the host, never the path shape.
|
|
url = "https://gitlab.com/group/subgroup/project.git"
|
|
assert detect_provider(url) == "gitlab"
|
|
|
|
|
|
def test_detect_self_hosted_gitlab_host_is_unresolvable() -> None:
|
|
# A self-hosted host can't be told apart from GHE/Gitea by host alone.
|
|
assert detect_provider("https://gitlab.example.com/group/project.git") is None
|
|
|
|
|
|
def test_detect_self_hosted_https_unknown_host() -> None:
|
|
assert detect_provider("https://git.internal.example/owner/repo.git") is None
|
|
|
|
|
|
def test_detect_bitbucket_host_unresolvable() -> None:
|
|
assert detect_provider("https://bitbucket.org/owner/repo.git") is None
|
|
|
|
|
|
def test_detect_empty_string() -> None:
|
|
assert detect_provider("") is None
|
|
|
|
|
|
def test_detect_unparseable_garbage() -> None:
|
|
assert detect_provider("not a url at all") is None
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# validate_project_forge — the registration-time gate
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_empty_git_url_is_ok() -> None:
|
|
assert validate_project_forge(None, None) is None
|
|
assert validate_project_forge("", None) is None
|
|
|
|
|
|
def test_detected_github_no_explicit_provider_is_ok() -> None:
|
|
assert validate_project_forge("https://github.com/owner/repo.git", None) is None
|
|
|
|
|
|
def test_detected_github_ssh_scp_no_explicit_provider_is_ok() -> None:
|
|
assert validate_project_forge("git@github.com:owner/repo.git", None) is None
|
|
|
|
|
|
def test_explicit_github_provider_is_ok_regardless_of_host() -> None:
|
|
# The GitHub Enterprise escape hatch — a non-github.com host is accepted
|
|
# once the operator explicitly names the provider.
|
|
url = "https://ghe.internal.example/owner/repo.git"
|
|
assert validate_project_forge(url, "github") is None
|
|
|
|
|
|
def test_explicit_gitlab_provider_accepted() -> None:
|
|
"""Phase 3: the GitLab transport is live — explicit gitlab validates."""
|
|
assert (
|
|
validate_project_forge("https://gitlab.com/group/project.git", "gitlab") is None
|
|
)
|
|
|
|
|
|
def test_explicit_gitea_provider_accepted() -> None:
|
|
"""Phase 2: the Gitea transport is live — explicit gitea validates."""
|
|
assert (
|
|
validate_project_forge("https://gitea.example.com/owner/repo.git", "gitea")
|
|
is None
|
|
)
|
|
|
|
|
|
def test_unknown_host_no_explicit_provider_rejected() -> None:
|
|
error = validate_project_forge("https://git.internal.example/owner/repo.git", None)
|
|
assert error is not None
|
|
assert "github" in error.lower()
|
|
|
|
|
|
def test_detected_gitlab_no_explicit_provider_accepted() -> None:
|
|
"""gitlab.com detection is unambiguous — auto-accepted like github.com."""
|
|
assert validate_project_forge("https://gitlab.com/group/project.git", None) is None
|
|
|
|
|
|
def test_unknown_provider_string_rejected_naming_known_providers() -> None:
|
|
error = validate_project_forge("https://github.com/owner/repo.git", "bitbucket")
|
|
assert error is not None
|
|
for provider in KNOWN_PROVIDERS:
|
|
assert provider in error
|
|
|
|
|
|
def test_known_providers_tuple_is_the_documented_set() -> None:
|
|
assert KNOWN_PROVIDERS == ("github", "gitlab", "gitea")
|