mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
76 lines
2.3 KiB
Python
76 lines
2.3 KiB
Python
"""CLI: JSONL findings on stdout, exit 0 when it ran, exit 3 when it could not."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import TYPE_CHECKING
|
|
|
|
from roboco.conventions.__main__ import main
|
|
from roboco.conventions.runner import ValidatorCouldNotRun
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
_EXIT_COULD_NOT_RUN = 3
|
|
|
|
|
|
def _seed_repo(root: Path) -> None:
|
|
routers = root / "app" / "routers"
|
|
routers.mkdir(parents=True)
|
|
(routers / "u.py").write_text(
|
|
"from pydantic import BaseModel\nclass M(BaseModel):\n x: int\n"
|
|
)
|
|
conv = root / ".roboco"
|
|
conv.mkdir()
|
|
(conv / "conventions.yml").write_text(
|
|
"modules:\n - path: app/routers\n purpose: r\n forbidden: [model]\n"
|
|
)
|
|
|
|
|
|
def test_cli_prints_jsonl_and_exits_zero(
|
|
tmp_path: Path, capsys: pytest.CaptureFixture[str]
|
|
) -> None:
|
|
_seed_repo(tmp_path)
|
|
rc = main(["check", "--root", str(tmp_path), "--files", "app/routers/u.py"])
|
|
assert rc == 0
|
|
lines = capsys.readouterr().out.strip().splitlines()
|
|
assert lines
|
|
assert json.loads(lines[0])["rule"] == "no_models_in_routers"
|
|
|
|
|
|
def test_cli_exits_zero_with_no_findings(
|
|
tmp_path: Path, capsys: pytest.CaptureFixture[str]
|
|
) -> None:
|
|
(tmp_path / "clean.py").write_text("def helper():\n return 1\n")
|
|
rc = main(["check", "--root", str(tmp_path), "--files", "clean.py"])
|
|
assert rc == 0
|
|
assert capsys.readouterr().out.strip() == ""
|
|
|
|
|
|
def test_cli_exits_three_on_unparseable_config(
|
|
tmp_path: Path, capsys: pytest.CaptureFixture[str]
|
|
) -> None:
|
|
conv = tmp_path / ".roboco"
|
|
conv.mkdir()
|
|
(conv / "conventions.yml").write_text("modules: [oops\n")
|
|
rc = main(["check", "--root", str(tmp_path), "--files"])
|
|
assert rc == _EXIT_COULD_NOT_RUN
|
|
assert "error" in capsys.readouterr().err
|
|
|
|
|
|
def test_cli_exits_three_when_validator_cannot_run(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
|
|
) -> None:
|
|
(tmp_path / "x.py").write_text("x = 1\n")
|
|
|
|
def boom(*_args: object, **_kw: object) -> list:
|
|
raise ValidatorCouldNotRun("no grammar")
|
|
|
|
monkeypatch.setattr("roboco.conventions.__main__.run", boom)
|
|
rc = main(["check", "--root", str(tmp_path), "--files", "x.py"])
|
|
assert rc == _EXIT_COULD_NOT_RUN
|
|
payload = json.loads(capsys.readouterr().err)
|
|
assert "error" in payload
|