mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* feat(video): Phase A — VideoEngine origination spine + held-source gates
New default-off engine skeleton: opens a UX/UI authoring task (source=video, assigned to a ux-dev, LOW complexity to clear the dev-needs-subtasks guard) and materializes a held CEO-approval draft (source=video_post). Excludes video_post from all three held-source skip sites; adds the video_draft marker, six config flags, and the feature-flag entries. Origination + gate behavior unit-tested.
* refactor(orchestrator): fold _dispatch_dev_work skip chain into a helper
The per-source if/continue chain grew past xenon's --max-absolute B when the video_post held source joined it. Extract _is_non_dev_dispatch_source (every held-CEO source plus the two Board exploration sources) so the dev loop's skip is one flat call. Behavior-identical.
* feat(video): Phase B — propose_video do-tool (metadata-only, team-gated)
UX/UI dev records a video's composition ref + per-platform captions onto the authoring task's video_draft marker. Team-gated at runtime via _caller_team (Role.DEVELOPER can't tell a ux-dev from a be-dev). Resolves the caller's ACTIVE task via get_active_task_for_agent, not an oldest-first scan that would clobber a second open video task. Metadata only, no render. Wired through do_server + route + schema; added to _DEV_DO.
* feat(video): Phase D — render loop + RemotionRenderer client
Orchestrator-async _video_render_loop renders a completed authoring task's merged composition to MP4 (vertical + square) via the remotion-renderer sidecar and materializes the held video_post draft. RemotionRenderer tars the read-clone's motion/ source, POSTs it, and saves the returned MP4 bytes to a TASK-scoped local path (no shared volume; a composition is reused across videos so a composition-scoped path would clobber an earlier draft). Render failures bounded-retry (read-clone catch-up window, transient sidecar) up to a cap, then terminal-fail. Client tested vs a mock transport; loop vs a mock renderer + real DB.
* feat(video): Phase C — release / spotlight / on-demand video triggers
Three entry points open a UX/UI video-authoring task via VideoEngine.open_video_task: (1) a published release drafts a companion video — best-effort in ReleaseProposalService.approve, never fails the publish; script from the CHANGELOG via the local model with a template fallback. (2) propose_feature_spotlight gains optional wants_video/video_script — best-effort, gated on video_on_spotlight, default-off leaves the spotlight flow byte-for-byte unchanged. (3) POST /video/request (CEO-only) for an on-demand brief, with clean disabled/not_opened responses. All gated on video_engine_enabled.
* fix(video): savepoint-isolate video-task inserts (F042 poisoned session)
The best-effort try/except around open_video_task (release-publish + spotlight hooks) swallowed the Python exception, but a DBAPI error at the insert flush left the shared session must-rollback — so the caller's next commit (release finalize / request boundary) threw PendingRollbackError: the release stuck 'pending' after actually publishing, or the spotlight draft + HTTP response were lost. Wrap both inserts (open_video_task, _originate_video_post) in a begin_nested savepoint (the repo's established F042 pattern) so a DB error rolls back only the insert. open_video_task returns None (every caller already handles it); _originate_video_post propagates to the render loop's handler. Regression test: an insert FK error returns None with the session left usable. Dormant while the flags were off; armed on the NAS.
* feat(video): Phase G — motion/ package + remotion-renderer sidecar + compose
In-repo Remotion v4 motion/ package (ReleaseAnnouncement composition; calculateMetadata returns 1080x1920 vertical / 1080x1080 square from inputProps.orientation) + a credential-free remotion-renderer sidecar: untar the POSTed motion/ source, bundle (LRU-cached per source sha), selectComposition + renderMedia h264, stream the MP4 bytes back — matching the RemotionRenderer client contract. docker/remotion.Dockerfile on Debian (Chrome apt deps, build-time Chrome pre-warm, ffmpeg bundled in @remotion/renderer). Wired into both compose files (roboco_default only, shm_size 1gb, /health check) + the release publish matrix. Verified via a real local render of both cuts; the Debian docker build is the CEO's to run.
* chore(video): D-hardening — video_post source_task_id + render-loop docstring
Add a source_task_id back-reference to the video_post held-draft marker (traceability from a draft to its authoring task; also makes the render loop's two-key idempotency check wireable later). Fix the render-loop test's stale docstring ('never retried' -> bounded-retry). Both from the Phase D critic's non-blocking follow-ups.
* feat(video): Phase E1 — VideoPostService + heartbeat mutex (approve->post)
CEO-approve->post service: heartbeat-renewed Redis mutex (fail-closed, grace=ttl-2*heartbeat), re-read-in-lock double-post guard, per-platform durable commits (asyncio.shield-ed, settle-before-rollback on lock-loss), all writes inside the lock (captions validated pre-lock, applied in-lock — no stale whole-column clobber), idempotent, per-platform retry-skip. Poster interfaces (X/TikTok, mocked here). Reject + list-held-drafts. Survived 3 adversarial rounds; residual = a crash in the poster->commit window (CEO-gated low-freq, documented).
* fix(video): G-hardening — renderer leaks + Share Tech Mono brand font
Sidecar: give bundle() an explicit outDir tracked + deleted on LRU eviction (was leaking ~19MB remotion-webpack-bundle-* per source); res.on('close') cleanup so an aborted/retried download no longer leaks its remotion-out-* MP4 dir. Fonts: vendor Share Tech Mono (roboco-website brand font) as the display face (self-hosted woff2, 400-weight, headline fontWeight 700->400 to avoid faux-bold) + self-hosted Inter body — no gstatic fetch at render time (lsof-verified). Extras: composition_id whitelist (400) + Multer error middleware (400/413).
* feat(video): Phase E2 — X v2 + TikTok posters, tiktok_credentials, routes
LiveXVideoPoster (X v2 chunked media upload: init/append/finalize/STATUS-poll -> tweet w/ media_ids, OAuth1 signer reused). LiveTikTokPoster (OAuth2 inbox: init -> chunked PUT with asymmetric final chunk -> status-fetch; 401 -> refresh_token grant, rotated token persisted). tiktok_credentials Fernet singleton + migration 062 (single head). Routes: CEO approve/reject + list held drafts + write-only tiktok creds, wiring real posters into VideoPostService. Residual: a lock-loss right after a token-refresh flush can discard the rotated token (same rare CEO-gated class as the documented post->commit window).
* feat(video): Phase F — panel video-post queue + TikTok creds card + flags
video-post-queue.tsx: <video> MP4 preview with 9:16/1:1 cut switch, per-platform editable captions (280/2200 counters, over-limit disables approve), approve/reject, Request-a-video dialog. tiktok-credentials-card.tsx (4 write-only OAuth2 fields). feature-flags-card inlines TikTokCredentialsForm under video_engine_enabled. Mounted in command-center. tsc/eslint clean, 273 panel tests green. NOTE: needs the GET /video/posts/{id}/media route + mp4_paths on VideoPostResponse (folded into H) for the preview source.
* feat(video): Phase H — media route + e2e smoke + NAS arming + docs
GET /video/posts/{id}/media?cut= (CEO-gated FileResponse of the rendered MP4; closes the panel preview gap) + mp4_paths on VideoPostResponse. e2e smoke tests/e2e_smoke/test_video_pipeline.py (full flow, sidecar+X/TikTok mocked; asserts dispatcher skips, render-loop materialize, propose_video team-gate, approve idempotency). NAS arming: docker-compose.yml/.yaml ROBOCO_VIDEO_ENGINE_ENABLED/ON_RELEASE/ON_SPOTLIGHT default-on (.yaml resynced to .yml); registry stays off. CLAUDE.md video-engine section + CHANGELOG. Fixed 2 pre-existing route-test pollution leaks. Full suite 11763 passed.
* fix(video): auth-carrying preview, media route confinement, VideoPost type drift
Three fixes along the video preview path:
1. panel video preview auth: the <video> element was pointed straight at
GET /video/posts/{id}/media, but a native <video src> GET carries none
of axios's X-Agent-ID/X-Agent-Role headers — so in the default
header-trust deployment the request 401s. Fetch the cut via
videoApi.getMediaBlob (axios, responseType: blob) and drive <video>
off a URL.createObjectURL result instead. The object URL is revoked
on cut-change (the previous cut's URL) and on unmount, so neither
cut switches nor row teardown leak blob URLs.
2. backend media route confinement: GET /video/posts/{id}/media now
resolves mp4_path and refuses it with 404 when it falls outside
settings.video_output_dir. Defense-in-depth against any future
writer of mp4_paths serving files from arbitrary disk locations.
3. panel VideoPost type/comment drift: added mp4_paths to the
VideoPost interface (the committed VideoPostResponse already
carries it), and corrected the stale comment on videoMediaUrl
that claimed no route served the rendered bytes — the route has
existed since the media endpoint landed; the comment now describes
why getMediaBlob exists instead of a direct <video src>.
* Persist rendered videos to data in physical storage.
* ++
* docs(video): 0.18.0 CHANGELOG entry + RAG + map reference for video engine
- Move the video engine bullet from [Unreleased] into [0.18.0] and note
the ROBOCO_VIDEO_OUTPUT_DIR bind-mount persistence.
- Add docs/rag/architecture/video-engine.md (mirrors x-engine.md shape:
enable/disable, three triggers, render loop + sidecar, CEO gate, media
route confinement, credentials).
- Reference the video render loop in docs/map/orchestrator.md's engine list.
* chore(video): re-bump to 0.19.0 + sync registry compose defaults
Version was wrongly bumped to 0.18.0; 0.18.0 is an already-released
section. Restore its 2026-07-04 date and move the video-engine CHANGELOG
bullet into a new [0.19.0] - 2026-07-05 section above it. Bump
pyproject.toml, roboco/__init__.py, roboco/config.py (app_version),
panel/package.json, and the motion/README inputProps example to 0.19.0.
docker-compose.registry.yml: add ROBOCO_VIDEO_ENGINE_ENABLED /
_VIDEO_ON_RELEASE / _VIDEO_ON_SPOTLIGHT defaulted false (NAS arms them
true), and comment out the video-renders bind mount with a short note
so the public registry image ships video off by default. Structural
sync with docker-compose.yml maintained.
* fix(video): rate-limit /render + reflow motion/README
CodeQL flagged js/missing-rate-limiting on the renderer /render route.
The sidecar is container-network-only with one trusted caller (the
orchestrator, which renders cuts serially), so this limiter is a
retry-storm ceiling (30/min, well above legit render rate), not the
primary control. Also reflows motion/README.md hard-wrapped prose that
failed the markdown quality gate.
* fix(build): finish pnpm 11 migration + regen verb tables
The panel Docker image build failed on `pnpm install --frozen-lockfile`:
node:22-alpine's corepack resolved to its bundled pnpm 11, but
panel/package.json pinned packageManager to pnpm@10.25.0, and pnpm 11
refuses to run against that pin. The Dockerfiles were already written for
pnpm 11 (comments, CI=true, strictDepBuilds); the package.json pin was the
stale outlier. Finish the migration instead of working around it:
- panel/package.json: packageManager pnpm@10.25.0 -> pnpm@11.10.0; drop the
`pnpm` field (pnpm 11 ignores it — build approval lives in
panel/pnpm-workspace.yaml's allowBuilds). Lockfile unchanged (pnpm 11
accepts it as-is); frozen-lockfile verified.
- remotion-renderer/package.json: pin packageManager pnpm@11.10.0 for
determinism (was relying on corepack's implicit default); engines.node
>=22.13 (pnpm 11 requirement).
- docker/panel.Dockerfile + docker/remotion.Dockerfile: `corepack prepare
pnpm@11.10.0 --activate` so the build uses the pinned version explicitly
instead of trusting corepack's bundled default (which a future
node:22-alpine could change).
- .github/workflows/panel-ci.yml: Node 20 -> 22 (pnpm 11 requires
Node >=22.13; Node 20 fails the engines check).
Also regenerate agents/prompts/_generated/{developer,head_marketing,verbs}.md
— the video engine added propose_video and extended propose_feature_spotlight
(wants_video, video_script) but the verb tables weren't refreshed, failing
the foundation-check quality gate.
* chore(build): approve esbuild build script in remotion pnpm-workspace.yaml
pnpm 11 generated this file with a placeholder ('set this to true or false')
during install; resolve it to true so local dev of the renderer doesn't
re-prompt. esbuild's postinstall only verifies the prebuilt platform binary
(@esbuild/<platform> is installed as an optional dep), so approving it is
safe and silences the ERR_PNPM_IGNORED_BUILDS warning.
* fix(build): copy pnpm-workspace.yaml into panel + remotion images
pnpm 11 hard-errors with [ERR_PNPM_IGNORED_BUILDS] (exit 1) when a
dependency ships a postinstall script that isn't approved in
allowBuilds. Both Dockerfiles copied only package.json + pnpm-lock.yaml,
so the build-approval map in pnpm-workspace.yaml never made it into the
image — the remotion image build died on esbuild@0.28.1's postinstall.
Copy pnpm-workspace.yaml alongside the manifests in both images. In
panel, this also drops the --config.strictDepBuilds=false workaround:
with sharp and unrs-resolver now approved, their postinstalls run and
install the platform-specific binaries (previously skipped, leaving
sharp without its @img/sharp-* binary at runtime).
Verified locally: remotion + panel `pnpm install --frozen-lockfile`
exit 0 with the workspace file present; both exit 1 without it.
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
753 lines
28 KiB
Python
753 lines
28 KiB
Python
"""VideoPostService coverage: approve posts per-platform (idempotent), reject
|
|
cancels.
|
|
|
|
Mirrors the X-post service tests. The heartbeat-mutex acquire/release are
|
|
patched (no live Redis in tests, matching the project's `_no_live_redis`
|
|
fixture) so approve exercises the real per-platform dispatch + status-
|
|
transition path; the run_guarded renew loop is left unpatched — its heartbeat
|
|
calls fail fast against the poisoned test Redis and are swallowed exactly as
|
|
in production, so no separate mock is needed there.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import contextlib
|
|
from typing import TYPE_CHECKING, cast
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.db.tables import AgentTable, ProjectTable, TaskTable
|
|
from roboco.foundation import identity as _foundation
|
|
from roboco.foundation.policy.content import markers
|
|
from roboco.models.base import (
|
|
AgentRole,
|
|
AgentStatus,
|
|
Complexity,
|
|
Team,
|
|
)
|
|
from roboco.models.base import TaskNature as TN
|
|
from roboco.models.base import TaskStatus as TS
|
|
from roboco.models.base import TaskType as TT
|
|
from roboco.services.heartbeat_mutex import HeartbeatMutex
|
|
from roboco.services.task import VIDEO_POST_SOURCE, TaskService
|
|
from roboco.services.video_post_service import (
|
|
TikTokPoster,
|
|
TikTokUploadResult,
|
|
VideoCaptionTooLongError,
|
|
VideoPostService,
|
|
XVideoPoster,
|
|
XVideoPostResult,
|
|
get_video_post_service,
|
|
)
|
|
from sqlalchemy import delete
|
|
from sqlalchemy.ext.asyncio import (
|
|
AsyncEngine,
|
|
AsyncSession,
|
|
async_sessionmaker,
|
|
create_async_engine,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from uuid import UUID
|
|
|
|
SYSTEM_UUID = _foundation.AGENTS["system"].uuid
|
|
SECRETARY_UUID = _foundation.AGENTS["secretary-1"].uuid
|
|
TWO = 2
|
|
VERTICAL_MP4 = "/render/out/1-vertical.mp4"
|
|
SQUARE_MP4 = "/render/out/1-square.mp4"
|
|
|
|
|
|
class _StubXPoster(XVideoPoster):
|
|
def __init__(
|
|
self,
|
|
*,
|
|
posted: bool = True,
|
|
video_id: str = "x-vid-1",
|
|
raises: bool = False,
|
|
) -> None:
|
|
self._posted = posted
|
|
self._video_id = video_id
|
|
self._raises = raises
|
|
self.calls: list[tuple[str, str]] = []
|
|
|
|
@property
|
|
def configured(self) -> bool:
|
|
return True
|
|
|
|
async def post_video(self, *, mp4_path: str, caption: str) -> XVideoPostResult:
|
|
self.calls.append((mp4_path, caption))
|
|
if self._raises:
|
|
raise RuntimeError("simulated X network failure")
|
|
if not self._posted:
|
|
return XVideoPostResult(posted=False, video_id=None, detail="rejected by X")
|
|
return XVideoPostResult(posted=True, video_id=self._video_id, detail="posted")
|
|
|
|
|
|
class _StubTikTokPoster(TikTokPoster):
|
|
def __init__(
|
|
self,
|
|
*,
|
|
uploaded: bool = True,
|
|
publish_id: str = "tt-pub-1",
|
|
raises: bool = False,
|
|
) -> None:
|
|
self._uploaded = uploaded
|
|
self._publish_id = publish_id
|
|
self._raises = raises
|
|
self.calls: list[tuple[str, str]] = []
|
|
|
|
@property
|
|
def configured(self) -> bool:
|
|
return True
|
|
|
|
async def upload_to_inbox(
|
|
self, *, mp4_path: str, caption: str
|
|
) -> TikTokUploadResult:
|
|
self.calls.append((mp4_path, caption))
|
|
if self._raises:
|
|
raise RuntimeError("simulated TikTok network failure")
|
|
if not self._uploaded:
|
|
return TikTokUploadResult(
|
|
uploaded=False, publish_id=None, detail="rejected by TikTok"
|
|
)
|
|
return TikTokUploadResult(
|
|
uploaded=True, publish_id=self._publish_id, detail="uploaded"
|
|
)
|
|
|
|
|
|
async def _seed_video_post(
|
|
session: AsyncSession,
|
|
*,
|
|
platforms: list[str] | None = None,
|
|
x_caption: str = "Check out this clip",
|
|
tiktok_caption: str = "Check out this clip on TikTok",
|
|
) -> TaskTable:
|
|
for uuid, slug, role in (
|
|
(SYSTEM_UUID, "system", AgentRole.SYSTEM),
|
|
(SECRETARY_UUID, "secretary-1", AgentRole.SECRETARY),
|
|
):
|
|
if await session.get(AgentTable, uuid) is None:
|
|
session.add(
|
|
AgentTable(
|
|
id=uuid,
|
|
name=slug,
|
|
slug=slug,
|
|
role=role,
|
|
team=None,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
)
|
|
await session.flush()
|
|
project = ProjectTable(
|
|
id=uuid4(),
|
|
name="RoboCo",
|
|
slug=f"roboco-{uuid4().hex[:6]}",
|
|
git_url="https://example.com/roboco.git",
|
|
assigned_cell=Team.BACKEND,
|
|
created_by=SYSTEM_UUID,
|
|
)
|
|
session.add(project)
|
|
await session.flush()
|
|
task = TaskTable(
|
|
id=uuid4(),
|
|
title="Video post: release 1.0",
|
|
description="script",
|
|
acceptance_criteria=["CEO approves or rejects the draft"],
|
|
status=TS.PENDING,
|
|
priority=2,
|
|
task_type=TT.ADMINISTRATIVE,
|
|
nature=TN.NON_TECHNICAL,
|
|
estimated_complexity=Complexity.LOW,
|
|
project_id=project.id,
|
|
created_by=SYSTEM_UUID,
|
|
assigned_to=SECRETARY_UUID,
|
|
team=Team.MAIN_PM,
|
|
source=VIDEO_POST_SOURCE,
|
|
confirmed_by_human=False,
|
|
)
|
|
session.add(task)
|
|
await session.flush()
|
|
markers.set_video_draft(
|
|
task,
|
|
{
|
|
"occasion": "release 1.0",
|
|
"script": "script",
|
|
"platforms": platforms if platforms is not None else ["x", "tiktok"],
|
|
"mp4_paths": {"vertical": VERTICAL_MP4, "square": SQUARE_MP4},
|
|
"x_caption": x_caption,
|
|
"tiktok_caption": tiktok_caption,
|
|
"render_status": "rendered",
|
|
},
|
|
)
|
|
await session.flush()
|
|
return task
|
|
|
|
|
|
def _svc(
|
|
session: AsyncSession, *, x_poster: XVideoPoster, tiktok_poster: TikTokPoster
|
|
) -> VideoPostService:
|
|
return get_video_post_service(
|
|
session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
)
|
|
|
|
|
|
def _id(task: TaskTable) -> UUID:
|
|
"""The ORM id typed as stdlib ``uuid.UUID`` for service-call sites."""
|
|
return cast("UUID", task.id)
|
|
|
|
|
|
_LOCKED = (
|
|
patch.object(HeartbeatMutex, "acquire", AsyncMock(return_value="tok")),
|
|
patch.object(HeartbeatMutex, "release", AsyncMock(return_value=None)),
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_posts_both_platforms_and_completes(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(_id(task))
|
|
assert result is not None
|
|
assert result.status == "posted"
|
|
assert result.posted == {"x": "x-vid-1", "tiktok": "tt-pub-1"}
|
|
# X gets the square cut, TikTok the vertical cut.
|
|
assert x_poster.calls == [(SQUARE_MP4, "Check out this clip")]
|
|
assert tiktok_poster.calls == [(VERTICAL_MP4, "Check out this clip on TikTok")]
|
|
await db_session.refresh(task)
|
|
assert task.status == TS.COMPLETED
|
|
draft = markers.get_video_draft(task)
|
|
assert draft is not None
|
|
assert draft["x_posted_id"] == "x-vid-1"
|
|
assert draft["tiktok_posted_id"] == "tt-pub-1"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_single_platform_only_calls_that_poster(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
task = await _seed_video_post(db_session, platforms=["x"])
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(_id(task))
|
|
assert result is not None
|
|
assert result.status == "posted"
|
|
assert result.posted == {"x": "x-vid-1"}
|
|
assert x_poster.calls == [(SQUARE_MP4, "Check out this clip")]
|
|
assert tiktok_poster.calls == [] # never invoked — not in this draft's platforms
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_is_idempotent_second_call_is_noop(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
svc = _svc(db_session, x_poster=x_poster, tiktok_poster=tiktok_poster)
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
first = await svc.approve(_id(task))
|
|
second = await svc.approve(_id(task))
|
|
assert first is not None
|
|
assert first.status == "posted"
|
|
assert second is not None
|
|
assert second.status == "already_posted"
|
|
assert second.posted == {"x": "x-vid-1", "tiktok": "tt-pub-1"}
|
|
# Neither poster was called a second time.
|
|
assert len(x_poster.calls) == 1
|
|
assert len(tiktok_poster.calls) == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_concurrent_lock_held_returns_in_progress(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
with patch.object(HeartbeatMutex, "acquire", AsyncMock(return_value=None)):
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(_id(task))
|
|
assert result is not None
|
|
assert result.status == "already_in_progress"
|
|
assert x_poster.calls == []
|
|
assert tiktok_poster.calls == []
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_redis_unavailable_fails_closed(db_session: AsyncSession) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
broken = MagicMock()
|
|
broken.set = AsyncMock(side_effect=ConnectionError("redis down"))
|
|
broken.aclose = AsyncMock()
|
|
with patch("roboco.services.heartbeat_mutex.redis.from_url", return_value=broken):
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(_id(task))
|
|
assert result is not None
|
|
assert result.status == "redis_unavailable"
|
|
assert x_poster.calls == []
|
|
assert tiktok_poster.calls == []
|
|
await db_session.refresh(task)
|
|
assert task.status == TS.PENDING # never advanced without the mutex
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_applies_edited_captions_before_posting(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(
|
|
_id(task),
|
|
x_caption="Edited X caption",
|
|
tiktok_caption="Edited TikTok caption",
|
|
)
|
|
assert result is not None
|
|
assert result.status == "posted"
|
|
assert x_poster.calls == [(SQUARE_MP4, "Edited X caption")]
|
|
assert tiktok_poster.calls == [(VERTICAL_MP4, "Edited TikTok caption")]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_rejects_edited_x_caption_over_280_chars(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
svc = _svc(db_session, x_poster=_StubXPoster(), tiktok_poster=_StubTikTokPoster())
|
|
with pytest.raises(VideoCaptionTooLongError):
|
|
await svc.approve(_id(task), x_caption="x" * 281)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_rejects_edited_tiktok_caption_over_2200_chars(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
svc = _svc(db_session, x_poster=_StubXPoster(), tiktok_poster=_StubTikTokPoster())
|
|
with pytest.raises(VideoCaptionTooLongError):
|
|
await svc.approve(_id(task), tiktok_caption="x" * 2201)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_partial_failure_keeps_task_open_and_persists_the_success(
|
|
db_session: AsyncSession, _test_database_url: str
|
|
) -> None:
|
|
"""Unlike every other approve() test in this file, this one commits a
|
|
non-terminal (PENDING) video_post row via db_session and never drives it
|
|
to a terminal state — every other test either never commits (rolled
|
|
back at teardown) or ends COMPLETED (excluded from the open-task
|
|
queries). Left behind, it leaks into the shared session-scoped test DB
|
|
and breaks list_open_video_posts()/list_open_video_post_drafts()
|
|
assertions in test_video_engine.py / test_video_render_loop.py, which
|
|
run later in the same pytest session. Clean it up via its own
|
|
committed session regardless of pass/fail."""
|
|
task = await _seed_video_post(db_session)
|
|
task_id = _id(task)
|
|
project_id = task.project_id
|
|
try:
|
|
x_poster = _StubXPoster(posted=False)
|
|
tiktok_poster = _StubTikTokPoster()
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(task_id)
|
|
assert result is not None
|
|
assert result.status == "posted_partial"
|
|
assert result.posted == {"tiktok": "tt-pub-1"}
|
|
await db_session.refresh(task)
|
|
assert task.status == TS.PENDING # not completed — X still needs a retry
|
|
draft = markers.get_video_draft(task)
|
|
assert draft is not None
|
|
assert draft["tiktok_posted_id"] == "tt-pub-1"
|
|
assert "x_posted_id" not in draft
|
|
finally:
|
|
cleanup, cleanup_engine = await _fresh_session(_test_database_url)
|
|
try:
|
|
await cleanup.execute(delete(TaskTable).where(TaskTable.id == task_id))
|
|
await cleanup.execute(
|
|
delete(ProjectTable).where(ProjectTable.id == project_id)
|
|
)
|
|
await cleanup.commit()
|
|
finally:
|
|
await _dispose(cleanup, cleanup_engine)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_retry_skips_the_already_posted_platform(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
"""A retry after a partial failure must not re-post the platform that
|
|
already succeeded — only the still-pending one is attempted again."""
|
|
task = await _seed_video_post(db_session)
|
|
x_poster = _StubXPoster(posted=False)
|
|
tiktok_poster = _StubTikTokPoster()
|
|
svc = _svc(db_session, x_poster=x_poster, tiktok_poster=tiktok_poster)
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
first = await svc.approve(_id(task))
|
|
assert first is not None
|
|
assert first.status == "posted_partial"
|
|
x_poster._posted = True # credentials fixed between attempts
|
|
second = await svc.approve(_id(task))
|
|
assert second is not None
|
|
assert second.status == "posted"
|
|
assert second.posted == {"x": "x-vid-1", "tiktok": "tt-pub-1"}
|
|
# TikTok succeeded on attempt 1 and must not be re-uploaded on the retry;
|
|
# X failed on attempt 1 so IS legitimately retried (and succeeds this time).
|
|
assert len(tiktok_poster.calls) == 1
|
|
assert len(x_poster.calls) == TWO
|
|
|
|
|
|
async def _fresh_session(url: str) -> tuple[AsyncSession, AsyncEngine]:
|
|
"""A session on a brand-new engine/connection (caller disposes)."""
|
|
engine = create_async_engine(url, future=True)
|
|
factory = async_sessionmaker(
|
|
bind=engine, class_=AsyncSession, expire_on_commit=False
|
|
)
|
|
return factory(), engine
|
|
|
|
|
|
async def _dispose(session: AsyncSession, engine: AsyncEngine) -> None:
|
|
with contextlib.suppress(Exception):
|
|
await session.rollback()
|
|
await engine.dispose()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_partial_failure_persists_success_durably_across_sessions(
|
|
db_session: AsyncSession, _test_database_url: str
|
|
) -> None:
|
|
"""`db_session` read-your-own-writes can hide a durability gap: platform
|
|
1 (x) posts, platform 2 (tiktok)'s poster RAISES. X's posted-id must be
|
|
committed for real — visible from a completely INDEPENDENT session and
|
|
connection, not merely flushed on the session that ran approve() — and a
|
|
retry from yet another fresh session must not re-invoke x's poster."""
|
|
task = await _seed_video_post(db_session)
|
|
task_id = _id(task)
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster(raises=True)
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(task_id)
|
|
assert result is not None
|
|
assert result.status == "posted_partial"
|
|
assert result.posted == {"x": "x-vid-1"}
|
|
|
|
# A brand-new session/connection — never touched db_session — must see
|
|
# x's posted id as durably committed, not just flushed-in-memory there.
|
|
fresh, fresh_engine = await _fresh_session(_test_database_url)
|
|
try:
|
|
fresh_task = await fresh.get(TaskTable, task_id)
|
|
assert fresh_task is not None
|
|
assert fresh_task.status == TS.PENDING
|
|
fresh_draft = markers.get_video_draft(fresh_task)
|
|
assert fresh_draft is not None
|
|
assert fresh_draft["x_posted_id"] == "x-vid-1"
|
|
assert "tiktok_posted_id" not in fresh_draft
|
|
finally:
|
|
await _dispose(fresh, fresh_engine)
|
|
|
|
# Retry from yet ANOTHER fresh session (a brand-new request): x must not
|
|
# be re-invoked — only the still-pending tiktok platform is retried.
|
|
tiktok_poster._raises = False
|
|
retry_session, retry_engine = await _fresh_session(_test_database_url)
|
|
try:
|
|
with _LOCKED[0], _LOCKED[1]:
|
|
retry = await _svc(
|
|
retry_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(task_id)
|
|
finally:
|
|
await _dispose(retry_session, retry_engine)
|
|
assert retry is not None
|
|
assert retry.status == "posted"
|
|
assert retry.posted == {"x": "x-vid-1", "tiktok": "tt-pub-1"}
|
|
assert len(x_poster.calls) == 1 # never re-invoked on the retry
|
|
assert len(tiktok_poster.calls) == TWO # the raise, then the successful retry
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_unknown_task_returns_none(db_session: AsyncSession) -> None:
|
|
result = await _svc(
|
|
db_session, x_poster=_StubXPoster(), tiktok_poster=_StubTikTokPoster()
|
|
).approve(uuid4())
|
|
assert result is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reject_records_reason_and_cancels(db_session: AsyncSession) -> None:
|
|
task = await _seed_video_post(db_session)
|
|
updated = await _svc(
|
|
db_session, x_poster=_StubXPoster(), tiktok_poster=_StubTikTokPoster()
|
|
).reject(_id(task), "Doesn't match the release")
|
|
assert updated is not None
|
|
assert updated.status == TS.CANCELLED
|
|
assert markers.get_video_reject_reason(updated) == "Doesn't match the release"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_held_video_posts_excludes_terminal(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
open_task = await _seed_video_post(db_session)
|
|
rejected_task = await _seed_video_post(db_session)
|
|
svc = _svc(db_session, x_poster=_StubXPoster(), tiktok_poster=_StubTikTokPoster())
|
|
await svc.reject(_id(rejected_task), "not relevant")
|
|
held = await svc.list_held_video_posts()
|
|
ids = {t.id for t in held}
|
|
assert open_task.id in ids
|
|
assert rejected_task.id not in ids
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_commits_before_releasing_the_lock(
|
|
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""The double-post guard depends on this ordering: every commit (each
|
|
platform success, then COMPLETED) must be durable before the lock is
|
|
released, or a racing approve could acquire the lock the instant it's
|
|
dropped and post again before a commit lands. Both platforms succeed
|
|
here, so this lands 3 commits (one per platform + COMPLETED) — asserts
|
|
the ordering property, not a hard-coded count of an implementation
|
|
detail."""
|
|
task = await _seed_video_post(db_session)
|
|
order: list[str] = []
|
|
|
|
real_commit = db_session.commit
|
|
|
|
async def _spy_commit() -> None:
|
|
await real_commit()
|
|
order.append("commit")
|
|
|
|
monkeypatch.setattr(db_session, "commit", _spy_commit)
|
|
|
|
async def _spy_release(_self: HeartbeatMutex, _token: str) -> None:
|
|
order.append("release")
|
|
|
|
with (
|
|
patch.object(HeartbeatMutex, "acquire", AsyncMock(return_value="tok")),
|
|
patch.object(HeartbeatMutex, "release", _spy_release),
|
|
):
|
|
result = await _svc(
|
|
db_session, x_poster=_StubXPoster(), tiktok_poster=_StubTikTokPoster()
|
|
).approve(_id(task))
|
|
assert result is not None
|
|
assert result.status == "posted"
|
|
assert order[-1] == "release"
|
|
assert order.count("release") == 1
|
|
assert order[:-1] == ["commit"] * (len(order) - 1)
|
|
assert len(order) > 1 # at least one commit landed before the release
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_rechecks_completed_under_lock_and_never_reposts(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
"""A concurrent approve wins the lock, posts, and commits COMPLETED after
|
|
our pre-lock read. Once we acquire the lock, the in-lock re-read must see
|
|
COMPLETED and short-circuit — never re-posting."""
|
|
task = await _seed_video_post(db_session)
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
|
|
async def _win_the_race(_self: HeartbeatMutex) -> str:
|
|
draft = dict(markers.get_video_draft(task) or {})
|
|
draft["x_posted_id"] = "x-winner"
|
|
draft["tiktok_posted_id"] = "tt-winner"
|
|
markers.set_video_draft(task, draft)
|
|
task.status = TS.COMPLETED
|
|
await db_session.flush()
|
|
return "tok"
|
|
|
|
with (
|
|
patch.object(HeartbeatMutex, "acquire", _win_the_race),
|
|
patch.object(HeartbeatMutex, "release", AsyncMock(return_value=None)),
|
|
):
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(_id(task))
|
|
assert result is not None
|
|
assert result.status == "already_posted"
|
|
assert result.posted == {"x": "x-winner", "tiktok": "tt-winner"}
|
|
assert x_poster.calls == []
|
|
assert tiktok_poster.calls == []
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_concurrent_caption_edit_does_not_erase_a_committed_posted_id(
|
|
db_session: AsyncSession, _test_database_url: str
|
|
) -> None:
|
|
"""RC1 regression: a caption edit must never write the draft column
|
|
before the lock. The old pre-lock flush computed its update from a read
|
|
taken before a genuinely concurrent approve (a different session/
|
|
connection) posted + committed a platform's id; once THIS session later
|
|
commits under the lock, that stale write won and erased the concurrent
|
|
commit — the retry re-posted the platform (a double-post)."""
|
|
task = await _seed_video_post(db_session, platforms=["x", "tiktok"])
|
|
task_id = _id(task)
|
|
await db_session.commit() # externally visible to the "concurrent" session below
|
|
|
|
real_get = TaskService.get
|
|
injected = False
|
|
|
|
async def _get_then_inject_concurrent_post(
|
|
self: TaskService, tid: UUID
|
|
) -> TaskTable | None:
|
|
"""Fires once, right after the outer pre-lock read — the exact
|
|
window between our read and our own (would-be) pre-lock write."""
|
|
nonlocal injected
|
|
result = await real_get(self, tid)
|
|
if not injected:
|
|
injected = True
|
|
other, other_engine = await _fresh_session(_test_database_url)
|
|
try:
|
|
other_task = await other.get(TaskTable, tid)
|
|
assert other_task is not None
|
|
other_draft = dict(markers.get_video_draft(other_task) or {})
|
|
other_draft["x_posted_id"] = "x-concurrent"
|
|
markers.set_video_draft(other_task, other_draft)
|
|
await other.commit()
|
|
finally:
|
|
await _dispose(other, other_engine)
|
|
return result
|
|
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
with (
|
|
patch.object(TaskService, "get", _get_then_inject_concurrent_post),
|
|
_LOCKED[0],
|
|
_LOCKED[1],
|
|
):
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(task_id, x_caption="Edited X caption")
|
|
|
|
assert result is not None
|
|
# X must never be re-posted — the concurrently committed id survives.
|
|
assert x_poster.calls == []
|
|
assert result.posted.get("x") == "x-concurrent"
|
|
assert tiktok_poster.calls == [(VERTICAL_MP4, "Check out this clip on TikTok")]
|
|
|
|
fresh, fresh_engine = await _fresh_session(_test_database_url)
|
|
try:
|
|
final = await fresh.get(TaskTable, task_id)
|
|
assert final is not None
|
|
final_draft = markers.get_video_draft(final)
|
|
assert final_draft is not None
|
|
assert final_draft["x_posted_id"] == "x-concurrent" # not erased
|
|
assert final_draft["x_caption"] == "Edited X caption" # edit still applied
|
|
finally:
|
|
await _dispose(fresh, fresh_engine)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_approve_cancel_during_a_platform_commit_leaves_it_durable_and_usable(
|
|
db_session: AsyncSession,
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
_test_database_url: str,
|
|
) -> None:
|
|
"""RC2 regression: a lock-loss cancellation firing while a per-platform
|
|
commit is in flight used to interrupt asyncio's own await on that
|
|
commit — rolling it back (so a retry re-posts the same platform) and
|
|
leaving the session unusable for anything that runs after (a route's
|
|
get_db teardown 500s on the poisoned session). Fixed: the commit is
|
|
asyncio.shield()ed so it always finishes, and the lock_lost path rolls
|
|
back explicitly so the session is guaranteed clean for reuse.
|
|
|
|
A lock_lost result never reaches _finalize_post, so the task is left
|
|
PENDING (non-terminal) even though its one platform posted — unlike
|
|
every other approve() test in this file, this one must clean up its own
|
|
committed row (see the note on test_approve_partial_failure_keeps_task_
|
|
open_and_persists_the_success for why that matters)."""
|
|
task = await _seed_video_post(db_session, platforms=["x"])
|
|
task_id = _id(task)
|
|
project_id = task.project_id
|
|
await db_session.commit() # a prior committed transaction, isolating the
|
|
# racy platform-commit below to its OWN transaction — so a rollback of
|
|
# that transaction can't also undo the seed itself.
|
|
|
|
try:
|
|
x_poster = _StubXPoster()
|
|
tiktok_poster = _StubTikTokPoster()
|
|
|
|
real_commit = db_session.commit
|
|
commit_started = asyncio.Event()
|
|
|
|
async def _slow_commit() -> None:
|
|
commit_started.set()
|
|
await real_commit()
|
|
|
|
monkeypatch.setattr(db_session, "commit", _slow_commit)
|
|
|
|
async def _lose_the_lock_once_committing(
|
|
_self: HeartbeatMutex, _token: str
|
|
) -> bool:
|
|
await commit_started.wait()
|
|
return False # lock lost -- cancels the guarded task fail-closed
|
|
|
|
with (
|
|
patch.object(HeartbeatMutex, "acquire", AsyncMock(return_value="tok")),
|
|
patch.object(HeartbeatMutex, "release", AsyncMock(return_value=None)),
|
|
patch.object(
|
|
HeartbeatMutex, "heartbeat_once", _lose_the_lock_once_committing
|
|
),
|
|
):
|
|
result = await _svc(
|
|
db_session, x_poster=x_poster, tiktok_poster=tiktok_poster
|
|
).approve(task_id)
|
|
|
|
assert result is not None
|
|
assert result.status == "lock_lost"
|
|
assert x_poster.calls == [(SQUARE_MP4, "Check out this clip")] # it DID post
|
|
|
|
# Durable: a brand-new connection sees the id even though the
|
|
# guarded task was cancelled mid-commit.
|
|
fresh, fresh_engine = await _fresh_session(_test_database_url)
|
|
try:
|
|
final = await fresh.get(TaskTable, task_id)
|
|
assert final is not None
|
|
final_draft = markers.get_video_draft(final)
|
|
assert final_draft is not None
|
|
assert final_draft["x_posted_id"] == "x-vid-1"
|
|
finally:
|
|
await _dispose(fresh, fresh_engine)
|
|
|
|
# The session itself must still be usable afterward — not poisoned
|
|
# by the cancelled-mid-commit path.
|
|
monkeypatch.setattr(db_session, "commit", real_commit)
|
|
check = await db_session.get(TaskTable, task_id)
|
|
assert check is not None
|
|
await db_session.commit() # would raise if the session were poisoned
|
|
finally:
|
|
cleanup, cleanup_engine = await _fresh_session(_test_database_url)
|
|
try:
|
|
await cleanup.execute(delete(TaskTable).where(TaskTable.id == task_id))
|
|
await cleanup.execute(
|
|
delete(ProjectTable).where(ProjectTable.id == project_id)
|
|
)
|
|
await cleanup.commit()
|
|
finally:
|
|
await _dispose(cleanup, cleanup_engine)
|