mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* fix(auth): pass agent UUID to CLI-arg MCP servers (optimal/docs/search) The container token is HMAC-signed over the agent UUID (#314), but the optimal/docs/search MCP servers received the slug as their CLI arg and sent X-Agent-ID=<slug>, so every research/RAG/docs call 401ed with signature mismatch under enforced auth. Pass the already-computed agent_uuid in the three args lists instead. * fix(gateway): include remediate in gateway.rejected audit details Conventions-gate rejections carry the offending file:line listing only in the envelope's remediate field, which the audit row dropped -- ops logs showed just the violation count with no way to see what blocked. * fix(gateway): return envelope on do/commit git failure A GitError from the commit verb propagated to the generic middleware handler, so agents got a raw error blob with no remediate/next. Catch it and return an error envelope; 'no changes added to commit' with an explicit files list now names the mismatch and the omit-files fallback. * fix(agent-sdk): absolute rejection cap breaks slow-drip verb loops The verb circuit breaker only counted rejections inside a 60s sliding window, so an agent retrying i_am_done every 3-4 minutes looped for 30+ minutes without tripping it. Add a session-scoped cumulative per-(verb, task) cap at 3x the windowed limit that trips regardless of pacing. * feat(a2a): CEO chime-in interjects into the viewed conversation Previously reply_as_ceo re-homed the message into a canonical CEO<->target conversation with no panel surface, so a chime-in reported success but was invisible and only opportunistically delivered. interject_as_ceo now inserts the message into the conversation being viewed (from_agent=ceo, directed via an @target content prefix), bumps that conversation's counters with the unread ping keyed to the addressed participant, and both participants see it in transcript and read_a2a. * feat(panel): manual spawn carries task + message, surfaces refusals The agent detail page spawned with no request body (task/message impossible), the spawn button could double-fire (2.5ms double-POST seen live), and refusal reasons never reached the UI: readiness refusals were generic 500s and the already-running no-op looked like success. Detail page now uses SpawnAgentDialog, a synchronous ref guard blocks re-entry, AgentReadinessError maps to 409 with its reason shown, already_running is signalled and toasted, and a task_id builds a task-aware prompt instructing the claim (task_id alone never did), with the CEO's message appended as a note. * test(panel): align a2a page test with the interjection footer copy The chime-in rebuild changed the composer footer; the page-level test asserting the old copy was outside the rebuild's scoped vitest run. * fix(api): commit the request DB session before the response is sent FastAPI unwinds yield-dependencies after the response bytes go out, so get_db's post-yield commit raced the client's next request -- a verb could return ok while its claim/status write was still uncommitted (the e2e ok-without-effect flake family), and a failed commit was silently lost behind an already-sent 200. DbCommitMiddleware (innermost, pure ASGI) commits the session stashed by get_db_committed before forwarding http.response.start; commit failure now surfaces as a 5xx. get_db is untouched for its direct non-request callers. * fix(db): invalidate, not rollback, the session on request cancellation With the commit moved into the send path, the flow-verb timeout can cancel mid-commit; rolling back then issues another command over an asyncpg connection stranded mid-wire-protocol, and the poisoned connection segfaults uvloop/asyncpg when a later checkout recycles it (3/3 identical CI faulthandler dumps). On CancelledError discard the connection via session.invalidate() -- SQLAlchemy's documented handling for a timeout during commit -- and keep rollback for plain exceptions. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
121 lines
3.6 KiB
TypeScript
121 lines
3.6 KiB
TypeScript
"use client";
|
|
|
|
import { useRef, useState } from "react";
|
|
import { useSpawnAgent } from "@/hooks/use-agents";
|
|
import { getErrorMessage } from "@/lib/api/client";
|
|
import { Button } from "@/components/ui/button";
|
|
import { Input } from "@/components/ui/input";
|
|
import { Label } from "@/components/ui/label";
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
DialogTrigger,
|
|
DialogDescription,
|
|
} from "@/components/ui/dialog";
|
|
import { DropdownMenuItem } from "@/components/ui/dropdown-menu";
|
|
import { Play } from "lucide-react";
|
|
import { toast } from "sonner";
|
|
|
|
interface SpawnAgentDialogProps {
|
|
agentId: string;
|
|
agentName: string;
|
|
trigger?: React.ReactNode;
|
|
}
|
|
|
|
export function SpawnAgentDialog({
|
|
agentId,
|
|
agentName,
|
|
trigger,
|
|
}: SpawnAgentDialogProps) {
|
|
const [open, setOpen] = useState(false);
|
|
const [taskId, setTaskId] = useState("");
|
|
const [initialPrompt, setInitialPrompt] = useState("");
|
|
const spawnAgent = useSpawnAgent();
|
|
// Synchronous re-entrancy guard: `spawnAgent.isPending` only flips on a
|
|
// re-render, which lags a fast double-click/double-fire by a tick or two —
|
|
// the guard below blocks a second call within the same synchronous burst
|
|
// regardless of render timing.
|
|
const submittingRef = useRef(false);
|
|
|
|
const handleSpawn = async () => {
|
|
if (submittingRef.current) return;
|
|
submittingRef.current = true;
|
|
try {
|
|
const result = await spawnAgent.mutateAsync({
|
|
agentId,
|
|
request: {
|
|
task_id: taskId || undefined,
|
|
initial_prompt: initialPrompt || undefined,
|
|
},
|
|
});
|
|
if (result.already_running) {
|
|
toast.info(`Agent ${agentName} already running — spawn skipped`);
|
|
} else {
|
|
toast.success(`Agent ${agentName} spawned successfully`);
|
|
}
|
|
setOpen(false);
|
|
resetForm();
|
|
} catch (error) {
|
|
toast.error(getErrorMessage(error));
|
|
} finally {
|
|
submittingRef.current = false;
|
|
}
|
|
};
|
|
|
|
const resetForm = () => {
|
|
setTaskId("");
|
|
setInitialPrompt("");
|
|
};
|
|
|
|
const defaultTrigger = (
|
|
<DropdownMenuItem onSelect={(e) => e.preventDefault()}>
|
|
<Play className="h-4 w-4 mr-2" />
|
|
Spawn
|
|
</DropdownMenuItem>
|
|
);
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={setOpen}>
|
|
<DialogTrigger asChild>{trigger || defaultTrigger}</DialogTrigger>
|
|
<DialogContent>
|
|
<DialogHeader>
|
|
<DialogTitle>Spawn {agentName}</DialogTitle>
|
|
<DialogDescription>
|
|
Start this agent with optional task assignment and initial prompt.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
<div className="space-y-4">
|
|
<div className="space-y-2">
|
|
<Label htmlFor="taskId">Task ID (optional)</Label>
|
|
<Input
|
|
id="taskId"
|
|
value={taskId}
|
|
onChange={(e) => setTaskId(e.target.value)}
|
|
placeholder="UUID of task to assign"
|
|
/>
|
|
</div>
|
|
<div className="space-y-2">
|
|
<Label htmlFor="initialPrompt">Initial Prompt (optional)</Label>
|
|
<Input
|
|
id="initialPrompt"
|
|
value={initialPrompt}
|
|
onChange={(e) => setInitialPrompt(e.target.value)}
|
|
placeholder="Initial instructions for the agent"
|
|
/>
|
|
</div>
|
|
<div className="flex justify-end gap-2">
|
|
<Button variant="outline" onClick={() => setOpen(false)}>
|
|
Cancel
|
|
</Button>
|
|
<Button onClick={handleSpawn} disabled={spawnAgent.isPending}>
|
|
{spawnAgent.isPending ? "Spawning..." : "Spawn Agent"}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|