mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
79 lines
2.6 KiB
Python
79 lines
2.6 KiB
Python
"""Runner: per-file dispatch, waiver filtering, fail-loud on grammar failure."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
import pytest
|
|
from roboco.conventions.grammars import GrammarUnavailable
|
|
from roboco.conventions.runner import ValidatorCouldNotRun, run
|
|
from roboco.foundation.policy.conventions.models import (
|
|
ConventionsStandard,
|
|
Module,
|
|
Waiver,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
_MODEL_PY = b"from pydantic import BaseModel\nclass M(BaseModel):\n x: int\n"
|
|
|
|
|
|
def _write(root: Path, rel: str, content: bytes) -> None:
|
|
path = root / rel
|
|
path.parent.mkdir(parents=True, exist_ok=True)
|
|
path.write_bytes(content)
|
|
|
|
|
|
def test_runner_flags_python_model_in_router(tmp_path: Path) -> None:
|
|
_write(tmp_path, "app/routers/users.py", _MODEL_PY)
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/routers", purpose="r", forbidden=["model"])]
|
|
)
|
|
findings = run(tmp_path, ["app/routers/users.py"], std)
|
|
assert [f.rule for f in findings] == ["no_models_in_routers"]
|
|
|
|
|
|
def test_runner_drops_waived_finding(tmp_path: Path) -> None:
|
|
_write(tmp_path, "app/routers/legacy.py", _MODEL_PY)
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/routers", purpose="r", forbidden=["model"])],
|
|
waivers=[
|
|
Waiver(
|
|
path="app/routers/legacy.py", rule="no_models_in_routers", reason="x"
|
|
)
|
|
],
|
|
)
|
|
assert run(tmp_path, ["app/routers/legacy.py"], std) == []
|
|
|
|
|
|
def test_runner_flags_ts_component_in_wrong_module(tmp_path: Path) -> None:
|
|
_write(tmp_path, "src/pages/Home.tsx", b"export const Home = () => <div/>;\n")
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="src/pages", purpose="pages", forbidden=["component"])]
|
|
)
|
|
findings = run(tmp_path, ["src/pages/Home.tsx"], std)
|
|
assert any(f.kind == "component" for f in findings)
|
|
|
|
|
|
def test_runner_skips_unsupported_extension(tmp_path: Path) -> None:
|
|
_write(tmp_path, "README.md", b"# hi\n")
|
|
assert run(tmp_path, ["README.md"], ConventionsStandard()) == []
|
|
|
|
|
|
def test_runner_skips_missing_file(tmp_path: Path) -> None:
|
|
assert run(tmp_path, ["gone.py"], ConventionsStandard()) == []
|
|
|
|
|
|
def test_runner_is_fail_loud_on_grammar_failure(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
_write(tmp_path, "x.py", b"x = 1\n")
|
|
|
|
def boom(_source: bytes) -> list:
|
|
raise GrammarUnavailable("python")
|
|
|
|
monkeypatch.setattr("roboco.conventions.classify_python.classify_definitions", boom)
|
|
with pytest.raises(ValidatorCouldNotRun):
|
|
run(tmp_path, ["x.py"], ConventionsStandard())
|