mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
94 lines
3.0 KiB
Python
94 lines
3.0 KiB
Python
"""Placement checks: a def whose kind is forbidden in its module is flagged."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
|
|
from roboco.conventions.placement import Definition, check_placement
|
|
from roboco.foundation.policy.conventions.models import (
|
|
ConventionsStandard,
|
|
Module,
|
|
Rule,
|
|
)
|
|
|
|
_MODEL_LINE = 2
|
|
_DEFS: list[Definition] = [("UserCreate", _MODEL_LINE, "model")]
|
|
|
|
|
|
def test_forbidden_kind_in_module_is_flagged() -> None:
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/routers", purpose="routes", forbidden=["model"])]
|
|
)
|
|
findings = check_placement("app/routers/users.py", _DEFS, std)
|
|
assert len(findings) == 1
|
|
f = findings[0]
|
|
assert f.kind == "model"
|
|
assert f.rule == "no_models_in_routers"
|
|
assert f.level == "block"
|
|
assert f.line == _MODEL_LINE
|
|
assert "app/routers" in f.message
|
|
|
|
|
|
def test_allowed_kind_in_module_is_not_flagged() -> None:
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/models", purpose="models", forbidden=["route"])]
|
|
)
|
|
assert check_placement("app/models/user.py", _DEFS, std) == []
|
|
|
|
|
|
def test_no_matching_module_yields_no_finding() -> None:
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/routers", purpose="routes", forbidden=["model"])]
|
|
)
|
|
assert check_placement("lib/helpers.py", _DEFS, std) == []
|
|
|
|
|
|
def test_rule_level_from_standard_is_respected() -> None:
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/routers", purpose="routes", forbidden=["model"])],
|
|
rules={"no_models_in_routers": Rule(name="no_models_in_routers", level="warn")},
|
|
)
|
|
findings = check_placement("app/routers/users.py", _DEFS, std)
|
|
assert findings[0].level == "warn"
|
|
|
|
|
|
def test_longest_matching_module_wins() -> None:
|
|
std = ConventionsStandard(
|
|
modules=[
|
|
Module(path="app", purpose="root", forbidden=[]),
|
|
Module(path="app/routers", purpose="routes", forbidden=["model"]),
|
|
]
|
|
)
|
|
findings = check_placement("app/routers/users.py", _DEFS, std)
|
|
assert len(findings) == 1
|
|
assert findings[0].kind == "model"
|
|
|
|
|
|
def test_prefix_must_be_on_a_path_boundary() -> None:
|
|
# "app/routers" must not match "app/routers_legacy/..." spuriously.
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/routers", purpose="routes", forbidden=["model"])]
|
|
)
|
|
assert check_placement("app/routers_legacy/users.py", _DEFS, std) == []
|
|
|
|
|
|
def test_finding_serializes_to_json_line() -> None:
|
|
std = ConventionsStandard(
|
|
modules=[Module(path="app/routers", purpose="routes", forbidden=["model"])]
|
|
)
|
|
f = check_placement("app/routers/users.py", _DEFS, std)[0]
|
|
payload = json.loads(f.as_json())
|
|
assert payload["rule"] == "no_models_in_routers"
|
|
assert payload["file"] == "app/routers/users.py"
|
|
assert payload["line"] == _MODEL_LINE
|
|
assert payload["level"] == "block"
|
|
assert set(payload) == {
|
|
"file",
|
|
"line",
|
|
"kind",
|
|
"rule",
|
|
"level",
|
|
"message",
|
|
"fix_hint",
|
|
}
|