mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
4d4bf084c5
Convention: no type:ignore/noqa, and pre-existing violations still violate. The make-quality gate runs 'mypy roboco/ tests/', but the prior commits' gates only ran mypy on production files, masking 64 type errors across 15 test files (method-assign, unused-ignore, no-untyped-def, attr-defined, union-attr, has-type, index, misc). Fixed without any type:ignore: - method-assign (svc.session.X = / svc.method = AsyncMock()): hold a local 'session: MagicMock'/'AsyncMock' and assert on it, or stub via object.__setattr__ / monkeypatch / a typed '_bind' helper returning Any, or alias 'cc: Any = c' (the pattern the file already used). - unused 'type: ignore[assignment]' (real code was method-assign): removed; replaced with the no-suppression patterns above. - 'Callable[...] has no attribute assert_*': keep a typed local ref to the AsyncMock and assert on the local, not the method-typed attr. - no-untyped-def: annotate helper params (Any / pytest.MonkeyPatch). - attr-defined / index / union-attr: type the helper as Any, narrow with an 'is not None' assert, or add the missing attr to a fake. - has-type / return-value: fix the declared return type to the tuple the function actually returns. - PLC0415 inline imports: hoisted to top-level. test_pr_gate_notifies_pm._stub_gate_path converted fully to the 'cc: Any = c' alias (it already used it for one attr) so its five '# type: ignore[method-assign]' suppressions are gone. mypy tests/: 64 errors -> 0 (538 files). ruff check tests/: clean. All 84 tests in the touched files pass.
61 lines
2.2 KiB
Python
61 lines
2.2 KiB
Python
"""PlaybooksIndexPlugin — index_type + pure metadata/URI methods.
|
|
|
|
Mirrors the other index-plugin unit tests (instantiate via __new__, exercise the
|
|
pure methods). The embed + pgvector ingest/search path is inherited from
|
|
BaseIndexPlugin (shared, proven by the other 8 plugins) and runs live.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
from roboco.models.optimal import IndexType
|
|
from roboco.services.optimal_brain.indexes.playbooks import PlaybooksIndexPlugin
|
|
|
|
|
|
def _plugin() -> PlaybooksIndexPlugin:
|
|
return PlaybooksIndexPlugin.__new__(PlaybooksIndexPlugin)
|
|
|
|
|
|
def test_index_type_is_playbooks() -> None:
|
|
assert _plugin().index_type == IndexType.PLAYBOOKS
|
|
|
|
|
|
def test_prepare_metadata_marks_approved_with_routing_fields() -> None:
|
|
md = _plugin().prepare_metadata(
|
|
"content", playbook_id="pb-1", team="backend", scope="org", tags=["retry"]
|
|
)
|
|
assert md["type"] == "playbook"
|
|
assert md["playbook_id"] == "pb-1"
|
|
assert md["team"] == "backend"
|
|
assert md["scope"] == "org"
|
|
assert md["tags"] == ["retry"]
|
|
# Only approved playbooks are ever indexed — the metadata says so.
|
|
assert md["status"] == "approved"
|
|
|
|
|
|
def test_build_source_uri_with_id() -> None:
|
|
assert _plugin().build_source_uri(doc_id="pb-1") == "roboco://playbooks/pb-1"
|
|
|
|
|
|
def test_build_source_uri_none_when_missing() -> None:
|
|
assert _plugin().build_source_uri(doc_id=None) is None
|
|
|
|
|
|
def test_delete_playbook_removes_its_chunks_by_source() -> None:
|
|
"""F011: deleting a playbook removes its embedded chunks from the vector
|
|
store by the playbook's source URI (idempotent — no-op if absent). A
|
|
rejected/archived playbook must not stay retrievable in the PLAYBOOKS index."""
|
|
plugin = PlaybooksIndexPlugin.__new__(PlaybooksIndexPlugin)
|
|
store = MagicMock()
|
|
store.delete_by_source = AsyncMock(return_value=None)
|
|
# Bypass the initialized-guard property so the unit test doesn't need a
|
|
# live pgvector store.
|
|
object.__setattr__(plugin, "_initialized", True)
|
|
object.__setattr__(plugin, "_store", store)
|
|
|
|
asyncio.run(plugin.delete_playbook("pb-42"))
|
|
|
|
store.delete_by_source.assert_awaited_once_with("roboco://playbooks/pb-42")
|