mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
e77c3b7a63
* feat(board): Board Program registry — generic trigger/dedup/originate/LEARN engine
One registry (foundation/policy/board_programs.py) + one BoardProgramEngine +
one orchestrator loop replace the bespoke roadmap/spotlight loops, behavior-
preserved: same sources, dispatch routing, one-open-cycle dedup (ledger rows
auto-close when their exploration task goes terminal, so x_feature's
complete-at-propose flow can't wedge), and live per-program interval
overrides with the tick capped at 1h.
program_armed() is the single arming chokepoint: the settings-store
board_program.<key>.enabled override when present, else the legacy flag —
routed through BoardProgramEngine, RoadmapEngine.run_cycle, and XEngine's
spotlight gate, so the panel toggle can never be a silent no-op against a
legacy boot flag.
LEARN: board_program_cycles (migration 087) accrues per-item CEO decisions
(exact attribution by exploration_task_id where the caller holds it) and
feeds the last closed cycles back into both exploration prompts. The
strategy engine's idle signal now opens a roadmap cycle (enabled+dedup
respected) instead of only nudging.
Per-project scoping (migration 088, projects.board_programs, dual polarity):
plain keys opt a project INTO project-scoped programs; "!key" opts it OUT
of an org-scoped program's outputs (default eligible — parity). Enforced at
propose_roadmap (names the excluded project) and defensively at materialize;
validation rejects unknown keys and meaningless polarity both directions.
API: GET /api/board-programs + POST /api/board-programs/{key}/run-now
(CEO-gated); settings keys for both migrated programs.
* feat(panel): Board Programs card + per-project program controls
Business page gains a Programs tab: per-program rows (role, trigger, scope,
open-cycle badge), enabled switch on the settings-store key, Run now
(disabled while a cycle is open). The edit-project dialog gains the
program controls next to the CI-watch/video toggles: participates-in
checkboxes for project-scoped programs, excluded-from checkboxes for
org-scoped outputs.
* test(board): full-gate hermeticity — mypy casts + shared-DB purge fixtures
make quality runs one pytest process over all suites against the shared
persistent DB: integration collects before unit, so the board-programs API
test's committed run-now state (settings-store overrides, an open cycle row,
its board_roadmap task) poisoned 13 downstream unit tests that pass in
isolation. The polluter now purges its own committed state in fixture
teardown, and the four consumer files get an autouse per-test purge
(board_program.% settings keys, ledger rows, open exploration tasks) so
they are hermetic regardless of collection order. Also the four
cast("UUID", ...) sites the tests-scope mypy run requires.
* feat(panel): re-home per-project program controls onto the settings page
Wave C deleted the edit-project dialog these controls originally landed in;
they now live on the project settings page's budget/ops card next to the
CI-watch/video toggles — participates-in switches for project-scoped
programs, excluded-from switches for org-scoped outputs, dual-polarity
tooltips, order-independent dirty tracking. Nine makeProject test fixtures
gain the required board_programs field the rebase left behind.
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
62 lines
2.1 KiB
Python
62 lines
2.1 KiB
Python
"""The generic Board Program orchestrator loop — replaces
|
|
``_roadmap_engine_loop`` / ``_x_feature_spotlight_loop`` (see
|
|
tests/unit/services/test_board_program_engine.py for the engine's own
|
|
trigger/dedup/LEARN coverage; this file covers the orchestrator-loop shell
|
|
only: interval computation + the sleep/tick/heartbeat wiring).
|
|
|
|
Unlike the two collapsed loops, ``_board_program_loop`` has no single static
|
|
disablement gate — each program's enablement is checked per-tick inside
|
|
``BoardProgramEngine``, DB-backed — so there is no "returns immediately when
|
|
disabled" behavior to test here; that guarantee now lives in
|
|
test_board_program_engine.py's disabled-program coverage.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from roboco.runtime.orchestrator import AgentOrchestrator
|
|
|
|
TWO_TICKS = 2
|
|
ONE_HOUR_SECONDS = 3600
|
|
|
|
|
|
def _orch() -> Any:
|
|
"""Bypass __init__ — the loop helper under test needs only the
|
|
heartbeats dict and ``_running``."""
|
|
o = AgentOrchestrator.__new__(AgentOrchestrator)
|
|
o._loop_heartbeats = {}
|
|
o._running = True
|
|
return o
|
|
|
|
|
|
def test_board_program_interval_is_shortest_registered_cadence_capped() -> None:
|
|
orch = _orch()
|
|
interval = orch._board_program_interval_seconds()
|
|
# x_feature's 1-day default is the shortest of the two registered
|
|
# programs, well above the 300s floor — capped at the 3600s ceiling.
|
|
assert interval == ONE_HOUR_SECONDS
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_board_program_loop_one_tick_exception_does_not_crash_loop() -> None:
|
|
"""A raising cycle is logged and the loop keeps ticking — mirrors every
|
|
other engine loop's ``except Exception: logger.exception(...)`` shape."""
|
|
orch = _orch()
|
|
calls = {"n": 0}
|
|
|
|
async def _cycle() -> None:
|
|
calls["n"] += 1
|
|
if calls["n"] >= TWO_TICKS:
|
|
orch._running = False
|
|
raise RuntimeError("boom")
|
|
|
|
orch._run_board_program_cycle = AsyncMock(side_effect=_cycle)
|
|
|
|
with patch("asyncio.sleep", new=AsyncMock()):
|
|
await orch._board_program_loop()
|
|
|
|
assert calls["n"] == TWO_TICKS
|