mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
879afc14a4
* fix(board): LEARN decisions name the item, not its per-cycle index A cycle's reject reasons are rendered into the NEXT cycle's exploration prompt, but the ref recorded alongside each reason was the item's stored id (item-0/item-1) — a per-cycle index that means something different every cycle and appears nowhere the explorer can resolve. The reason survived the loop; what it was about did not. Record the item's title instead, via a shared learn_ref() helper (falls back to the id when title-less, and reads target_task_title for Scales, whose items name the live task they mutate). * chore(lint): satisfy ruff 0.16 — keyword-only signatures and markdown formatting The dev toolchain resolved ruff 0.16.0, which stabilises PLR0917 (too many positional arguments) and formats python code blocks inside markdown. Both fired repo-wide and neither had anything to do with the code they flagged. - 36 signatures gain a `*` so their tail arguments are keyword-only, and the 104 call sites that passed them positionally are converted. mypy was the safety net for the static ones; the full suite caught nine more that only bind at runtime (the MCP tool functions, whose real callers already pass named JSON arguments). - 28 markdown files reformatted by 0.16's code-block formatter. - One RUF036 (`None` mid-union) autofixed in the GitLab provider. * fix(gateway): log the reason when a verb rejects A rejected envelope rides an HTTP 200, its body is never logged, and there is no trace table — so in the access log a verb an agent could not satisfy looks identical to one that worked. On 2026-07-25 four Board Programs (Periscope, Sentinel, Scales, Barfly) each POSTed their propose verb three or four times, persisted nothing, and left their exploration tasks PENDING; the reason was unrecoverable afterwards, from the logs or from the agents' own transcripts. Log error/message/remediate/missing plus the calling agent at envelope_to_response — the one chokepoint every v1 flow and do route returns through. Success envelopes stay silent. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
240 lines
8.5 KiB
Python
240 lines
8.5 KiB
Python
"""Every Envelope rejection from a Choreographer verb writes an audit row.
|
|
|
|
Choreographer takes an ``audit`` dependency but historically never invoked
|
|
it. The result: every rejection envelope (invalid_state, not_authorized,
|
|
tracing_gap, not_found) silently disappeared. With no forensic trail, a
|
|
stuck flow had no breadcrumbs.
|
|
|
|
These tests pin the ``gateway.rejected`` audit-write behavior across the
|
|
range of rejection-returning verbs, including:
|
|
|
|
- not_authorized rejections (PM cannot execute code, role-typed claim)
|
|
- invalid_state rejections (no active task, expected status mismatch)
|
|
- tracing_gap rejections (missing notes, missing journal entries)
|
|
- not_found rejections (unknown task id)
|
|
|
|
The audit call is fire-and-forget; an exception inside ``log_event`` must
|
|
not propagate or alter the envelope returned to the agent.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.services.gateway.choreographer import Choreographer, ChoreographerDeps
|
|
from roboco.services.gateway.envelope import Envelope
|
|
|
|
|
|
def _make_deps(**overrides: Any) -> ChoreographerDeps:
|
|
base: dict[str, Any] = {
|
|
"task": AsyncMock(),
|
|
"work_session": AsyncMock(),
|
|
"git": AsyncMock(),
|
|
"a2a": AsyncMock(),
|
|
"journal": AsyncMock(),
|
|
"audit": AsyncMock(),
|
|
"evidence_repo": AsyncMock(),
|
|
}
|
|
base.update(overrides)
|
|
repo = base["evidence_repo"]
|
|
for method in (
|
|
"list_unread_a2a",
|
|
"list_unread_mentions",
|
|
"list_pending_notifications",
|
|
"task_metadata_gaps",
|
|
"recent_team_activity",
|
|
"blockers_in_lane",
|
|
"journal_highlights_for_task",
|
|
):
|
|
getattr(repo, method).return_value = []
|
|
# C8: default-fresh journal:decision so PM-decision gate passes.
|
|
# Tests that exercise the gate boundary stub their own value.
|
|
# The check matches MagicMock and AsyncMock (the two default sentinel
|
|
# types pytest's unittest.mock leaves on un-stubbed return_values).
|
|
_ldef = base["journal"].latest_decision_at.return_value
|
|
if type(_ldef).__name__ in ("MagicMock", "AsyncMock"):
|
|
base["journal"].latest_decision_at.return_value = datetime.now(UTC)
|
|
return ChoreographerDeps(**base)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Primary acceptance test: PM cannot claim a code task — not_authorized path
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_pm_cannot_execute_code_writes_audit_row() -> None:
|
|
"""A cell_pm calling i_will_work_on on a code task must:
|
|
|
|
1. Return an Envelope with error == 'not_authorized'
|
|
2. Write a gateway.rejected audit event with verb + reason details
|
|
"""
|
|
aid = uuid4()
|
|
tid = uuid4()
|
|
code_task = MagicMock(
|
|
id=tid,
|
|
status="pending",
|
|
assigned_to=aid,
|
|
task_type="code",
|
|
priority=1,
|
|
parent_task_id=None,
|
|
sequence=0,
|
|
team="backend",
|
|
)
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = code_task
|
|
task_svc.agent_for.return_value = MagicMock(role="cell_pm", team="backend")
|
|
task_svc.list_in_progress_for_agent.return_value = []
|
|
task_svc.list_paused_for_agent.return_value = []
|
|
task_svc.get_subtasks.return_value = []
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.i_will_work_on(agent_id=aid, task_id=tid, plan="x")
|
|
|
|
assert env.error == "not_authorized"
|
|
audit_svc.log_event.assert_awaited()
|
|
args = audit_svc.log_event.await_args
|
|
assert args.kwargs["event_type"] == "gateway.rejected"
|
|
assert args.kwargs["details"]["verb"] == "i_will_work_on"
|
|
assert args.kwargs["details"]["reason"] == "not_authorized"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# not_found path: unknown task id
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_unknown_task_writes_audit_row() -> None:
|
|
"""not_found rejection (unknown task id) is audited."""
|
|
aid = uuid4()
|
|
tid = uuid4()
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = None
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.i_am_done(aid, tid, notes="something")
|
|
|
|
assert env.error == "not_found"
|
|
audit_svc.log_event.assert_awaited()
|
|
args = audit_svc.log_event.await_args
|
|
assert args.kwargs["event_type"] == "gateway.rejected"
|
|
assert args.kwargs["details"]["verb"] == "i_am_done"
|
|
assert args.kwargs["details"]["reason"] == "not_found"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Happy path must NOT write an audit row.
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_successful_verb_does_not_write_audit_row() -> None:
|
|
"""Successful (non-error) Envelope must not emit gateway.rejected audit."""
|
|
aid = uuid4()
|
|
task_svc = AsyncMock()
|
|
task_svc.list_assigned_for_agent.return_value = []
|
|
task_svc.list_paused_for_agent.return_value = []
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.give_me_work(aid)
|
|
|
|
# No rejection, so no audit row.
|
|
assert env.error is None
|
|
audit_svc.log_event.assert_not_awaited()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Audit failure must NOT block the verb (best-effort rule).
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_audit_log_event_failure_does_not_propagate() -> None:
|
|
"""If log_event raises, the verb still returns the rejection envelope."""
|
|
aid = uuid4()
|
|
tid = uuid4()
|
|
task_svc = AsyncMock()
|
|
# Unknown task id triggers not_found rejection on i_am_done.
|
|
task_svc.get.return_value = None
|
|
audit_svc = AsyncMock()
|
|
audit_svc.log_event.side_effect = RuntimeError("audit DB down")
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
# Must not raise; the rejection envelope should still come back.
|
|
env = await c.i_am_done(aid, tid, notes="x")
|
|
|
|
assert env.error == "not_found"
|
|
audit_svc.log_event.assert_awaited()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# remediate must ride along into the audit row — it's the only place a
|
|
# conventions-gate rejection's file:line violation listing lives.
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_rejection_remediate_lands_in_audit_details() -> None:
|
|
"""A rejection's `remediate` hint is copied into the audit row's details.
|
|
|
|
Without this, an operator reading `gateway.rejected` audit rows for a
|
|
conventions-gate rejection sees only the summary message — the
|
|
actionable detail lives solely in `remediate`.
|
|
"""
|
|
aid = uuid4()
|
|
tid = uuid4()
|
|
code_task = MagicMock(
|
|
id=tid,
|
|
status="pending",
|
|
assigned_to=aid,
|
|
task_type="code",
|
|
priority=1,
|
|
parent_task_id=None,
|
|
sequence=0,
|
|
team="backend",
|
|
)
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = code_task
|
|
task_svc.agent_for.return_value = MagicMock(role="cell_pm", team="backend")
|
|
task_svc.list_in_progress_for_agent.return_value = []
|
|
task_svc.list_paused_for_agent.return_value = []
|
|
task_svc.get_subtasks.return_value = []
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.i_will_work_on(agent_id=aid, task_id=tid, plan="x")
|
|
|
|
assert env.error == "not_authorized"
|
|
assert env.remediate
|
|
args = audit_svc.log_event.await_args
|
|
assert args.kwargs["details"]["remediate"] == env.remediate
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_rejection_without_remediate_omits_audit_key() -> None:
|
|
"""A rejection with no remediate must not add a null key to the row."""
|
|
aid = uuid4()
|
|
tid = uuid4()
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
env = Envelope(error="not_found", message="bare rejection, no remediate")
|
|
|
|
await c._emit_rejection(env, agent_id=aid, task_id=tid, verb="test_verb")
|
|
|
|
args = audit_svc.log_event.await_args
|
|
assert "remediate" not in args.kwargs["details"]
|