Files
roboco/tests/integration/test_api_resources.py
T
6cf99a1b0a [beb8cae1] Type-gate tests/ under mypy — fix all errors and flip quality gate (#156) (#157)
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154)

* [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py

- Create tests/__init__.py as empty package marker
- Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py
- Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py
- Add return type annotations to _stub_get_optimal, _source, and factory functions
- Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin
- Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub
- Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py
- Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object
- All 487 source files pass mypy with 0 errors; 2312 unit tests pass

* [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/

Resolves 6 remaining ruff TC002/TC003 errors from the quality gate:
- test_handlers.py: Iterator → TYPE_CHECKING
- test_quality_gate.py: pathlib → TYPE_CHECKING
- test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING
- test_streaming.py: Iterator → TYPE_CHECKING
- test_notification.py: AsyncIterator → TYPE_CHECKING

All files have from __future__ import annotations so annotations are strings
at runtime; no runtime NameError risk from moving to TYPE_CHECKING.

* [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files

* [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets

---------



* [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155)

* [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/

- Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.)
- Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches
- Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py
- Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/
- No runtime logic changed — annotations and cast() only

* [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate

- Quote all cast() type arguments per ruff TC006 rule (cast("T", x))
- Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form)
- Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.)
- No runtime logic changed — annotation-only changeset

* [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only)

The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy
roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing
tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast
targets already check `roboco/ tests/` — the lint target now matches gate scope.

---------



---------

Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev>
Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
2026-06-14 13:43:46 +02:00

130 lines
3.8 KiB
Python

"""api.utils.resources coverage."""
from __future__ import annotations
import uuid
from http import HTTPStatus
from typing import TYPE_CHECKING, cast
from uuid import uuid4
import pytest
from fastapi import HTTPException
from roboco.api.utils.resources import (
get_by_field_or_404,
get_or_404,
require_membership,
require_ownership,
require_recipient,
)
from roboco.db.tables import AgentTable
from roboco.models import AgentRole, AgentStatus, Team
if TYPE_CHECKING:
from sqlalchemy.ext.asyncio import AsyncSession
@pytest.mark.asyncio
async def test_get_or_404_finds_existing(db_session: AsyncSession) -> None:
agent = AgentTable(
id=uuid4(),
name="Dev",
slug=f"d-{uuid4().hex[:8]}",
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
status=AgentStatus.ACTIVE,
model_config={},
system_prompt="x",
capabilities=[],
permissions={},
metrics={},
)
db_session.add(agent)
await db_session.flush()
fetched = await get_or_404(db_session, AgentTable, cast("uuid.UUID", agent.id))
assert fetched.id == agent.id
@pytest.mark.asyncio
async def test_get_or_404_raises_when_missing(db_session: AsyncSession) -> None:
with pytest.raises(HTTPException) as exc:
await get_or_404(db_session, AgentTable, uuid4(), "Agent")
assert exc.value.status_code == HTTPStatus.NOT_FOUND
@pytest.mark.asyncio
async def test_get_by_field_or_404_finds(db_session: AsyncSession) -> None:
agent = AgentTable(
id=uuid4(),
name="Dev2",
slug=f"d2-{uuid4().hex[:8]}",
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
status=AgentStatus.ACTIVE,
model_config={},
system_prompt="x",
capabilities=[],
permissions={},
metrics={},
)
db_session.add(agent)
await db_session.flush()
fetched = await get_by_field_or_404(
db_session, AgentTable, "slug", agent.slug, "Agent"
)
assert fetched.id == agent.id
@pytest.mark.asyncio
async def test_get_by_field_or_404_raises(db_session: AsyncSession) -> None:
with pytest.raises(HTTPException) as exc:
await get_by_field_or_404(db_session, AgentTable, "slug", "ghost-slug", "Agent")
assert exc.value.status_code == HTTPStatus.NOT_FOUND
# ---------------------------------------------------------------------------
# Ownership / Recipients / Membership
# ---------------------------------------------------------------------------
def test_require_ownership_passes_for_owner() -> None:
aid = uuid4()
resource = type("R", (), {"owner": aid})()
require_ownership(resource, "owner", aid, "edit")
def test_require_ownership_raises_for_other_agent() -> None:
resource = type("R", (), {"owner": uuid4()})()
with pytest.raises(HTTPException) as exc:
require_ownership(resource, "owner", uuid4(), "edit")
assert exc.value.status_code == HTTPStatus.FORBIDDEN
def test_require_ownership_no_owner_passes() -> None:
resource = type("R", (), {"owner": None})()
# Should not raise — no owner means open access.
require_ownership(resource, "owner", uuid4(), "edit")
def test_require_recipient_passes() -> None:
aid = uuid4()
require_recipient([uuid4(), aid, uuid4()], aid)
def test_require_recipient_raises() -> None:
with pytest.raises(HTTPException) as exc:
require_recipient([uuid4(), uuid4()], uuid4())
assert exc.value.status_code == HTTPStatus.FORBIDDEN
def test_require_membership_passes() -> None:
aid = uuid4()
require_membership([uuid4(), aid], aid, "channel")
def test_require_membership_raises() -> None:
with pytest.raises(HTTPException) as exc:
require_membership([uuid4()], uuid4(), "channel")
assert exc.value.status_code == HTTPStatus.FORBIDDEN