mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
4f7dd7a336
TodoWrite is Anthropic's private session-local scratchpad — agents use it to track their own immediate next steps. It does NOT surface to the panel's Progress tab and is NOT a substitute for progress(task_id, message, percentage). Smoke run 3 didn't show this conflation yet, but Wave D's new progress() directive risks it. - base.md gets the canonical "TodoWrite vs progress()" callout - developer.md + documenter.md (the two roles with progress()) get inline reminders in their verb tables: "NOT TodoWrite" Spec ref: docs/superpowers/specs/2026-05-12-post-smoke-3-fixes-design.md section E4.
59 lines
2.1 KiB
Python
59 lines
2.1 KiB
Python
"""Wave E2: agents.role column is typed as the postgres enum named 'agentrole'.
|
|
|
|
Anti-regression for the SQLAlchemy enum-naming binding. Without the
|
|
`_PG_ENUM_NAME_OVERRIDES["Role"] = "agentrole"` entry in
|
|
`roboco/db/tables.py`, SQLAlchemy infers the postgres type name from the
|
|
Python class name (`Role` → `role`), producing the `operator does not
|
|
exist: agentrole = role` regression smoke run 2 hit.
|
|
|
|
This test pins the invariant — every column typed `Role`/`AgentRole`
|
|
binds to the canonical `agentrole` postgres type.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
import pytest
|
|
from sqlalchemy import text
|
|
|
|
if TYPE_CHECKING:
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_agents_role_uses_agentrole_type(db_session: AsyncSession) -> None:
|
|
"""agents.role.udt_name == 'agentrole' — never 'role'."""
|
|
result = await db_session.execute(
|
|
text(
|
|
"SELECT udt_name FROM information_schema.columns "
|
|
"WHERE table_name = 'agents' AND column_name = 'role'"
|
|
)
|
|
)
|
|
row = result.first()
|
|
assert row is not None, "agents.role column missing from test DB"
|
|
assert row[0] == "agentrole", (
|
|
f"agents.role typed as {row[0]!r}, expected 'agentrole' — "
|
|
f"the SQLAlchemy enum binding is missing the name='agentrole' "
|
|
f"override in roboco/db/tables.py::_PG_ENUM_NAME_OVERRIDES"
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_no_stray_role_enum_type_exists(db_session: AsyncSession) -> None:
|
|
"""No postgres enum named 'role' should exist — only 'agentrole'."""
|
|
result = await db_session.execute(
|
|
text(
|
|
"SELECT typname FROM pg_type "
|
|
"WHERE typname IN ('role', 'agentrole') "
|
|
"ORDER BY typname"
|
|
)
|
|
)
|
|
typenames = [row[0] for row in result]
|
|
assert "agentrole" in typenames, "agentrole enum type missing"
|
|
assert "role" not in typenames, (
|
|
"stray 'role' enum type exists — Base.metadata.create_all "
|
|
"produced both 'role' and 'agentrole'. Check "
|
|
"roboco/db/tables.py::_str_enum for missing name= override."
|
|
)
|