mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
b1f1a91066
The single non-empty/non-placeholder gate caught a lone banned token (wip) and below-floor strings, but multi-token soup made entirely of placeholders (wip wip, tbd / na, todo todo todo) slipped through both checks. Add an all-tokens-filler test that strips edge punctuation per token and rejects when every meaningful token is banned — without flagging real prose that merely contains a filler word (none of the tests failed). Strengthens every content model + gateway anti-soup guard that composes reject_trivial.
104 lines
3.5 KiB
Python
104 lines
3.5 KiB
Python
"""Shared validation primitives for structured agent content.
|
|
|
|
Two jobs:
|
|
|
|
- ``reject_trivial`` — the non-empty / non-placeholder gate, reused by every
|
|
content model's field validators. Raises ``ValueError`` so it composes with
|
|
Pydantic field validators (which collect ``ValueError`` into a
|
|
``ValidationError``).
|
|
- ``ContentValidationError`` — the public, gateway-facing exception. The
|
|
top-level ``validate_content`` (in :mod:`.models`) converts Pydantic's
|
|
``ValidationError`` into this so callers get a single ``(field, reason)``
|
|
shape to build a remediation envelope from.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import string
|
|
from typing import Any
|
|
|
|
# Placeholder tokens that are never an acceptable whole-field value. Extends the
|
|
# commit-validator's banned single-word list (services/gateway/commit_validator).
|
|
BANNED_PHRASES: frozenset[str] = frozenset(
|
|
{
|
|
"wip",
|
|
"tmp",
|
|
"tbd",
|
|
"todo",
|
|
"asdf",
|
|
"oops",
|
|
"stuff",
|
|
"things",
|
|
"n/a",
|
|
"na",
|
|
"none",
|
|
"null",
|
|
"-",
|
|
"--",
|
|
"...",
|
|
".",
|
|
"x",
|
|
}
|
|
)
|
|
|
|
|
|
class ContentValidationError(Exception):
|
|
"""A structured-content payload failed validation.
|
|
|
|
Carries the offending ``field`` and a human ``reason`` so the gateway can
|
|
return a remediable envelope (``{error, message, remediate, missing}``).
|
|
"""
|
|
|
|
def __init__(self, field: str, reason: str) -> None:
|
|
self.field = field
|
|
self.reason = reason
|
|
super().__init__(f"{field}: {reason}")
|
|
|
|
|
|
def _all_tokens_filler(text: str) -> bool:
|
|
"""True when every whitespace token (sans edge punctuation) is a placeholder.
|
|
|
|
Catches multi-token soup that no single check would — ``wip wip``,
|
|
``tbd / na``, ``todo todo todo`` — without flagging real prose that merely
|
|
*contains* a filler word (``none of the tests failed``). Pure-punctuation
|
|
tokens (``/``) strip to empty and are dropped before the all-filler test.
|
|
"""
|
|
meaningful = [
|
|
stripped
|
|
for tok in text.split()
|
|
if (stripped := tok.strip(string.punctuation).lower())
|
|
]
|
|
return bool(meaningful) and all(tok in BANNED_PHRASES for tok in meaningful)
|
|
|
|
|
|
def reject_trivial(value: str, *, field: str, min_chars: int = 1) -> str:
|
|
"""Return the trimmed value, or raise ``ValueError`` if it is trivial.
|
|
|
|
Trivial = empty, shorter than ``min_chars``, a known placeholder token, or a
|
|
string whose every token is a placeholder (``wip wip``). Raises
|
|
``ValueError`` (not ``ContentValidationError``) so it can be used directly
|
|
inside Pydantic field validators.
|
|
"""
|
|
text = (value or "").strip()
|
|
if not text:
|
|
raise ValueError(f"{field} must not be empty")
|
|
if len(text) < min_chars:
|
|
raise ValueError(f"{field} must be at least {min_chars} characters")
|
|
if text.lower() in BANNED_PHRASES or _all_tokens_filler(text):
|
|
raise ValueError(f"{field} must not be placeholder text (got {value!r})")
|
|
return text
|
|
|
|
|
|
def coerce_to_list(value: Any) -> Any:
|
|
"""Wrap a lone scalar/dict into a one-element list; pass lists/None through.
|
|
|
|
Mirrors ``api.schemas.v1.do._coerce_to_list``: an agent that passes a single
|
|
string (or dict) where a list is declared is making the well-intentioned
|
|
single-item mistake — wrap it rather than reject it.
|
|
"""
|
|
if value is None or isinstance(value, list):
|
|
return value
|
|
if isinstance(value, str | dict):
|
|
return [value]
|
|
return value
|