Files
roboco/tests/unit/gateway/test_delegate_project_routing.py
T
6cf99a1b0a [beb8cae1] Type-gate tests/ under mypy — fix all errors and flip quality gate (#156) (#157)
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154)

* [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py

- Create tests/__init__.py as empty package marker
- Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py
- Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py
- Add return type annotations to _stub_get_optimal, _source, and factory functions
- Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin
- Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub
- Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py
- Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object
- All 487 source files pass mypy with 0 errors; 2312 unit tests pass

* [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/

Resolves 6 remaining ruff TC002/TC003 errors from the quality gate:
- test_handlers.py: Iterator → TYPE_CHECKING
- test_quality_gate.py: pathlib → TYPE_CHECKING
- test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING
- test_streaming.py: Iterator → TYPE_CHECKING
- test_notification.py: AsyncIterator → TYPE_CHECKING

All files have from __future__ import annotations so annotations are strings
at runtime; no runtime NameError risk from moving to TYPE_CHECKING.

* [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files

* [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets

---------



* [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155)

* [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/

- Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.)
- Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches
- Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py
- Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/
- No runtime logic changed — annotations and cast() only

* [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate

- Quote all cast() type arguments per ruff TC006 rule (cast("T", x))
- Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form)
- Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.)
- No runtime logic changed — annotation-only changeset

* [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only)

The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy
roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing
tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast
targets already check `roboco/ tests/` — the lint target now matches gate scope.

---------



---------

Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev>
Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
2026-06-14 13:43:46 +02:00

126 lines
4.1 KiB
Python

from __future__ import annotations
from datetime import UTC, datetime
from typing import Any
from unittest.mock import AsyncMock, MagicMock
from uuid import uuid4
import pytest
from roboco.services.gateway.choreographer import (
Choreographer,
ChoreographerDeps,
DelegateInputs,
)
def _make_deps(**overrides: Any) -> ChoreographerDeps:
base: dict[str, Any] = {
"task": AsyncMock(),
"work_session": AsyncMock(),
"git": AsyncMock(),
"a2a": AsyncMock(),
"journal": AsyncMock(),
"audit": AsyncMock(),
"evidence_repo": AsyncMock(),
}
base.update(overrides)
repo = base["evidence_repo"]
for m in (
"list_unread_a2a",
"list_unread_mentions",
"list_pending_notifications",
"task_metadata_gaps",
"recent_team_activity",
"blockers_in_lane",
"journal_highlights_for_task",
):
getattr(repo, m).return_value = []
_ldef = base["journal"].latest_decision_at.return_value
if type(_ldef).__name__ in ("MagicMock", "AsyncMock"):
base["journal"].latest_decision_at.return_value = datetime.now(UTC)
return ChoreographerDeps(**base)
def _parent(pm_id: Any, product_id: Any = None, project_id: Any = None) -> MagicMock:
return MagicMock(
id=uuid4(),
project_id=project_id or uuid4(),
product_id=product_id,
status="in_progress",
assigned_to=pm_id,
)
def _inputs(**kw: Any) -> DelegateInputs:
base: dict[str, Any] = {
"title": "Implement endpoint",
"description": "Add /v1/foo endpoint with tests",
"assigned_to": "be-dev-1",
"team": "backend",
"task_type": "code",
"nature": "technical",
"acceptance_criteria": ["GET /v1/foo returns 200 with body"],
}
base.update(kw)
return DelegateInputs(**base)
async def _run(parent: Any, inputs: DelegateInputs, product: Any = None) -> Any:
pm_id = parent.assigned_to
task_svc = AsyncMock()
task_svc.get.return_value = parent
task_svc.agent_for.return_value = MagicMock(role="cell_pm", team="backend")
task_svc.get_subtasks.return_value = []
task_svc.create_subtask.return_value = MagicMock(id=uuid4())
deps = _make_deps(task=task_svc, **({"product": product} if product else {}))
c = Choreographer(deps)
env = await c.delegate(pm_id, parent.id, inputs)
return env, task_svc
@pytest.mark.asyncio
async def test_explicit_project_id_overrides_everything() -> None:
override = uuid4()
parent = _parent(uuid4(), product_id=uuid4())
env, task_svc = await _run(parent, _inputs(project_id=override))
assert env.error is None, env.as_dict()
req = task_svc.create_subtask.call_args.args[0]
assert req.project_id == override
@pytest.mark.asyncio
async def test_product_map_resolves_project_when_no_override() -> None:
mapped = uuid4()
product_id = uuid4()
parent = _parent(uuid4(), product_id=product_id)
product = AsyncMock()
product.project_for.return_value = mapped
env, task_svc = await _run(parent, _inputs(), product=product)
assert env.error is None, env.as_dict()
req = task_svc.create_subtask.call_args.args[0]
assert req.project_id == mapped
assert req.product_id == product_id # inherited onto the subtask
product.project_for.assert_awaited_once()
@pytest.mark.asyncio
async def test_falls_back_to_parent_project_when_no_product() -> None:
parent = _parent(uuid4(), product_id=None)
env, task_svc = await _run(parent, _inputs())
assert env.error is None, env.as_dict()
req = task_svc.create_subtask.call_args.args[0]
assert req.project_id == parent.project_id
@pytest.mark.asyncio
async def test_partial_product_map_degrades_to_parent_project() -> None:
product_id = uuid4()
parent = _parent(uuid4(), product_id=product_id)
product = AsyncMock()
product.project_for.return_value = None # no mapping for this cell
env, task_svc = await _run(parent, _inputs(), product=product)
assert env.error is None, env.as_dict()
req = task_svc.create_subtask.call_args.args[0]
assert req.project_id == parent.project_id
assert req.product_id == product_id