mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
aa15dc40cc
* fix(release): CI wait polls the prod rung; escape the header tooltip apostrophe get_latest_ci_conclusion defaults to the ladder's head rung, so wait_for_ci searched slave for a release commit that lives on master and timed out after 40 minutes with the run already green. The wait now passes the prod branch explicitly. Also fixes the react/no-unescaped-entities error that turned master's Panel CI red. * fix(panel,video): dead dialog triggers behind tooltips; dotted composition ids render HelpTip nested inside a Dialog/AlertDialog trigger puts the trigger's click handler on the Tooltip root, which renders no DOM — the agents Spawn item and the KB Reindex-All / Delete-index confirms were dead. Tooltips now wrap the triggers. The video renderer accepts interior single dots in composition ids (release-0.25.0) with '..' still unrepresentable, and propose_video refuses an unrenderable id at authoring time. * fix(dispatch): restart-safe PM review turns A leaf task in awaiting_pm_review had no periodic pickup: the closure dispatcher bailed on childless tasks and skipped PR-bearing review tasks as already-promoted, assuming the submit-time PM session was still alive — an assumption every restart breaks. Proven live on the docs-sync leaf after the 0.25.0 redeploy, which also dependency-blocked its sibling dev task. Childless awaiting_pm_review tasks now flow to the PM's review turn, and the merge turn respawns its PM when none is active. * feat(video): verify the rendered artifact, not the source The 14s release-0.25.0 cut shipped with only one of four scenes visibly registering: the dev authored DOM, the smoke asserted DOM, QA read code — nobody consumed the rendered MP4 before the CEO did. Close that loop, and the reject loop behind it: - sidecar frames mode: POST /render with frames=1..32 renders the cut, ffprobes the REAL duration, extracts midpoint-sampled keyframe PNGs (timestamps in filenames), streams a tar.gz back with X-Video-Duration - request_render do-verb (developer/QA, request_sandbox's shape): renders the caller's ACTUAL composition — dev's own worktree (head_sha/dirty provenance), QA a read-only git-archive export of the assembled branch — extracts frames to the container-shared .previews/ path, stamps the render_preview marker, returns the paths as envelope evidence - gate: i_am_done on a source=video task refuses without a stamped render_preview (Requirement.RENDER_VERIFIED; canonical source string moved to foundation as markers.VIDEO_TASK_SOURCE; mirrored in the possibilities-matrix fast path so it cannot bypass the check) - QA claim_review evidence carries video_context (composition id, the dev's preview, a re-render instruction) so review checks output - dev spawn prompt block + a 4th authoring AC order Read-every-frame verification before submitting - reject -> re-author: a CEO reject with a reason opens a fresh authoring task carrying the verbatim feedback + a revise-in-place pointer at the existing composition (best-effort, never fails the reject) — rejection feedback no longer dies on the cancelled draft E2E: rendered the committed release-0.25.0 composition through the new frames mode locally — the returned keyframes show exactly the reported failure (blank frame at 5.8s, only 'Env ladder' by 12.8s), the check the fleet was missing. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
59 lines
2.2 KiB
Python
59 lines
2.2 KiB
Python
"""The RENDER_VERIFIED tracing requirement — i_am_done's video-artifact gate.
|
|
|
|
Pure unit tests against ``foundation.policy.tracing`` (no DB, no
|
|
choreographer): the checker itself, its registration in
|
|
``VERB_REQUIREMENTS["i_am_done"]``, and the "non-video task is untouched"
|
|
contract.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
|
|
from roboco.foundation.policy import tracing as tr
|
|
from roboco.foundation.policy.content import markers
|
|
|
|
|
|
def test_render_verified_is_required_by_i_am_done() -> None:
|
|
assert tr.Requirement.RENDER_VERIFIED in tr.VERB_REQUIREMENTS["i_am_done"]
|
|
|
|
|
|
def test_render_verified_not_required_by_submit_up_or_submit_root() -> None:
|
|
assert tr.Requirement.RENDER_VERIFIED not in tr.VERB_REQUIREMENTS["submit_up"]
|
|
assert tr.Requirement.RENDER_VERIFIED not in tr.VERB_REQUIREMENTS["submit_root"]
|
|
|
|
|
|
def test_non_video_task_passes_regardless_of_marker() -> None:
|
|
task = SimpleNamespace(source="code", orchestration_markers=None)
|
|
assert tr._check_render_verified(task, tr.GateContext()) == []
|
|
|
|
|
|
def test_video_task_without_preview_fails() -> None:
|
|
task = SimpleNamespace(source=markers.VIDEO_TASK_SOURCE, orchestration_markers=None)
|
|
assert tr._check_render_verified(task, tr.GateContext()) == ["render_preview"]
|
|
|
|
|
|
def test_video_task_with_preview_passes() -> None:
|
|
task = SimpleNamespace(
|
|
source=markers.VIDEO_TASK_SOURCE,
|
|
orchestration_markers={markers.RENDER_PREVIEW: {"frames": ["a.png"]}},
|
|
)
|
|
assert tr._check_render_verified(task, tr.GateContext()) == []
|
|
|
|
|
|
def test_i_am_done_requirements_include_the_pre_existing_set_too() -> None:
|
|
"""Adding RENDER_VERIFIED must not have dropped any prior requirement."""
|
|
required = tr.VERB_REQUIREMENTS["i_am_done"]
|
|
for expected in (
|
|
tr.Requirement.COMMITS_AT_LEAST_ONE,
|
|
tr.Requirement.PR_OPEN,
|
|
tr.Requirement.PROGRESS_AT_LEAST_ONE,
|
|
tr.Requirement.SELF_VERIFIED,
|
|
tr.Requirement.JOURNAL_REFLECT,
|
|
tr.Requirement.JOURNAL_DURING_WORK_AT_LEAST_ONE,
|
|
tr.Requirement.ACCEPTANCE_CRITERIA_ADDRESSED,
|
|
tr.Requirement.DEV_NOTES_MIN_CHARS,
|
|
tr.Requirement.FINDINGS_ADDRESSED,
|
|
):
|
|
assert expected in required
|