mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* feat(board): expose board review brief + guard approve-and-start
Slice 1 of the board-informed intake re-draft loop (backend foundation):
- JournalService.board_review_brief(task_id): the PO + Head of Marketing
DECISION_LOG entries for a task, oldest-first, each tagged with author —
the board's review as structured data.
- GET /api/tasks/{task_id}/board-review (PM-or-above) backing the CEO's
approval/redraft surface, so the real board analysis is readable instead
of a placeholder; BoardReviewEntry response schema.
- Guard: approve_and_start now refuses a board task whose review is not
complete (service invariant + precise BOARD_REVIEW_INCOMPLETE at the route).
Previously only the UI hid the button; the backend let an early/rogue call
hand the task to Main PM mid-review.
Tests: brief filtering/ordering + endpoint (200/404) + the two guard paths.
* feat(panel): show real board review at the approve gate + live refresh
Slice 1 frontend of the board-informed intake re-draft loop:
- tasksApi.getBoardReview + useBoardReview hook consume GET
/tasks/{id}/board-review.
- The Approve & Start dialog now renders the actual Product Owner + Head of
Marketing notes (markdown) instead of a static placeholder, so the CEO reads
the board's analysis before approving.
- C2: useTask polls (4s) while a task is still on the board with an
incomplete review, so the Approve & Start button appears as soon as the
board finishes — there is no per-task websocket. Polling stops once
board_review_complete flips.
* feat(intake): board-informed re-draft loop (backend, cold path)
Slice 2 of the re-draft loop:
- update_live_draft: apply a board-informed re-draft to the EXISTING task in
place (title/description/acceptance_criteria) — never a duplicate — then route
it: 'main_pm' hands it to the Main PM via approve_and_start; 'board' clears
board_review_complete for another review round.
- confirm route branches on task_id → update_live_draft vs confirm_live_draft;
LiveConfirmRequest.task_id added (scope taken from the task, not required).
- POST /live/re-interview/{task_id} (PM-or-above): spawns a fresh intake session
seeded with the current draft + the board brief (compose_redraft_message),
scoped to the task's product/project. The cold path + Slice-3 fallback.
- format_board_briefing / compose_redraft_message helpers.
Tests: pure helpers + update_live_draft (main_pm hand-off, re-board reset,
missing-task).
* feat(panel): board-informed re-draft entry + prompter re-draft guidance
Slice 2 panel of the re-draft loop:
- 'Re-draft with board feedback' button on a board-reviewed task detail →
/prompter?redraft=<taskId>.
- usePrompter.startRedraft(taskId): calls POST /prompter/live/re-interview/{id},
scopes the chat to the task, and streams the re-draft; redraftTaskId is
threaded (persisted across reload) so confirm carries task_id and updates the
existing task in place rather than creating a duplicate.
- prompterLiveApi.reInterview; ConfirmPayload.task_id.
- Prompter role prompt: a 'Re-drafting after board review' section so the agent
revises the included draft from the board brief instead of starting over.
Panel verified by CI (no local node_modules).
* feat(intake): keep-alive re-draft — park the intake agent during board review
Slice 3 of the re-draft loop (in-context fidelity; cold path is the fallback):
- Registry: LiveIntakeSession.task_id + park(session_id, task_id) (keep alive
instead of reaping) + find_by_task() for board-completion injection.
- Confirm: the board route (first pass) PARKS the intake agent instead of
reaping, so it keeps the whole interview in context.
- Orchestrator: on board-review completion, inject the synthesized board brief
into the parked session (_inject_board_brief_into_parked_intake) so the
resident prompter re-drafts in-context. No-op when nothing is parked (the
container died / a new intake replaced it) — the cold /re-interview path
covers that. No reaper change needed (an idle parked session spends no tokens
and the budget sweep is the only agent-stopping sweep).
- Panel: confirm(board) keeps the chat alive (parked, redraftTaskId set) with a
notice; the injected revised draft arrives over the existing stream to approve.
Tests: registry park/find_by_task/closed-ignored. Container delivery + the full
panel parked flow need live (container-runtime) verification.
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
152 lines
5.0 KiB
Python
152 lines
5.0 KiB
Python
"""Unit tests for the live intake-session relay (orchestrator side)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import json
|
|
|
|
import httpx
|
|
import pytest
|
|
from roboco.services.prompter_live import (
|
|
PrompterLiveRegistry,
|
|
get_live_registry,
|
|
)
|
|
|
|
|
|
def test_open_get_close() -> None:
|
|
reg = PrompterLiveRegistry()
|
|
session = reg.open("s1", "intake-1")
|
|
assert session.agent_id == "intake-1"
|
|
assert reg.get("s1") is session
|
|
reg.close("s1")
|
|
assert reg.get("s1") is None
|
|
|
|
|
|
def test_park_and_find_by_task() -> None:
|
|
"""A parked session is discoverable by task id for board-feedback injection."""
|
|
reg = PrompterLiveRegistry()
|
|
session = reg.open("s1", "intake-1")
|
|
assert reg.park("s1", "task-abc") is True
|
|
assert session.task_id == "task-abc"
|
|
assert reg.find_by_task("task-abc") is session
|
|
assert reg.find_by_task("task-other") is None
|
|
|
|
|
|
def test_park_missing_session_returns_false() -> None:
|
|
reg = PrompterLiveRegistry()
|
|
assert reg.park("nope", "task-abc") is False
|
|
|
|
|
|
def test_find_by_task_ignores_closed_session() -> None:
|
|
"""A reaped parked session is not returned (the cold re-draft path covers it)."""
|
|
reg = PrompterLiveRegistry()
|
|
reg.open("s1", "intake-1")
|
|
reg.park("s1", "task-abc")
|
|
reg.close("s1")
|
|
assert reg.find_by_task("task-abc") is None
|
|
|
|
|
|
def test_is_alive_tracks_open_and_close() -> None:
|
|
"""is_alive backs the panel's after-reload reconnect decision."""
|
|
reg = PrompterLiveRegistry()
|
|
assert reg.is_alive("s1") is False # never opened
|
|
reg.open("s1", "intake-1")
|
|
assert reg.is_alive("s1") is True
|
|
reg.close("s1")
|
|
assert reg.is_alive("s1") is False # reaped
|
|
|
|
|
|
def test_open_is_idempotent_for_a_live_session() -> None:
|
|
"""Re-opening a live session returns the SAME object (same queue).
|
|
|
|
Regression: a second open() that swapped in a fresh queue orphaned the SSE
|
|
stream — the panel had already captured the first queue, so the agent's
|
|
replies (pushed to the new queue) never reached the browser.
|
|
"""
|
|
reg = PrompterLiveRegistry()
|
|
first = reg.open("s1", "intake-1")
|
|
first.queue.put_nowait({"event": "text"}) # something already queued
|
|
second = reg.open("s1", "intake-1")
|
|
assert second is first # not replaced
|
|
assert second.queue is first.queue # same queue → stream not orphaned
|
|
# After close, a re-open starts fresh (no stale queue carried over).
|
|
reg.close("s1")
|
|
third = reg.open("s1", "intake-1")
|
|
assert third is not first
|
|
assert third.queue.empty()
|
|
|
|
|
|
def test_push_to_unknown_or_closed_returns_false() -> None:
|
|
reg = PrompterLiveRegistry()
|
|
assert reg.push("nope", {"event": "text"}) is False
|
|
reg.open("s1", "intake-1")
|
|
assert reg.push("s1", {"event": "text"}) is True
|
|
reg.close("s1")
|
|
assert reg.push("s1", {"event": "text"}) is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_stream_yields_queued_events_then_ends_on_close() -> None:
|
|
reg = PrompterLiveRegistry()
|
|
reg.open("s1", "intake-1")
|
|
|
|
async def collect() -> list[dict]:
|
|
return [ev async for ev in reg.stream("s1")]
|
|
|
|
task = asyncio.create_task(collect())
|
|
await asyncio.sleep(0) # let the stream capture the session + block on get()
|
|
|
|
reg.push("s1", {"event": "text", "data": "hel"})
|
|
reg.push("s1", {"event": "turn_end", "data": "{}"})
|
|
reg.close("s1") # sentinel ends the stream
|
|
|
|
result = await asyncio.wait_for(task, timeout=1.0)
|
|
assert result == [
|
|
{"event": "text", "data": "hel"},
|
|
{"event": "turn_end", "data": "{}"},
|
|
]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_stream_unknown_session_is_empty() -> None:
|
|
reg = PrompterLiveRegistry()
|
|
assert [ev async for ev in reg.stream("nope")] == []
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_deliver_posts_to_the_container_receiver() -> None:
|
|
seen: dict[str, object] = {}
|
|
|
|
def handler(request: httpx.Request) -> httpx.Response:
|
|
seen["host"] = request.url.host
|
|
seen["path"] = request.url.path
|
|
seen["body"] = json.loads(request.content)
|
|
return httpx.Response(200, json={"ok": True})
|
|
|
|
client = httpx.AsyncClient(transport=httpx.MockTransport(handler))
|
|
reg = PrompterLiveRegistry(http_client=client)
|
|
reg.open("s1", "intake-1")
|
|
|
|
assert await reg.deliver("s1", "hello there") is True
|
|
assert seen["host"] == "roboco-agent-intake-1"
|
|
assert seen["path"] == "/turn"
|
|
assert seen["body"] == {"text": "hello there"}
|
|
await client.aclose()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_deliver_to_unknown_or_failing_returns_false() -> None:
|
|
def fail(_request: httpx.Request) -> httpx.Response:
|
|
return httpx.Response(500)
|
|
|
|
client = httpx.AsyncClient(transport=httpx.MockTransport(fail))
|
|
reg = PrompterLiveRegistry(http_client=client)
|
|
assert await reg.deliver("nope", "hi") is False # unknown session
|
|
reg.open("s1", "intake-1")
|
|
assert await reg.deliver("s1", "hi") is False # 500 from container
|
|
await client.aclose()
|
|
|
|
|
|
def test_registry_singleton() -> None:
|
|
assert get_live_registry() is get_live_registry()
|