mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
96401f4c10
* feat(forge): Phase 2 — Gitea provider, per-call routing, host registry Gitea support lands behind the Phase-1 seam: - GiteaProvider (services/forge/gitea.py): Gitea v1 transport addressed by instance host (api base from the project's git_url). Where Gitea's wire contract diverges from GitHub's, the provider adapts responses back into the shapes GitService already classifies (ShapedResponse): `token` auth scheme, duplicate-PR 409→422 with the "already exists" text GitService keys on, commit statuses reshaped into check_runs / workflow_runs envelopes, APPROVE→APPROVED review mapping, Do-keyed POST merge, merge-method repo keys, label-color '#' prefix, client-side head/base PR filtering. Deliberate postures per the spec: zero-workflows fail-open (statuses-free repo → no_ci_configured) and merge_branch as a shaped 501 (env-sync cascade lands on missing_ref; the shared local-git fallback is Phase-2.1). - ForgeRouter (services/forge/router.py): GitService._forge now routes per call from RepoRef.host — every existing call site unchanged in shape. RepoRef gains an optional host; _parse_git_url returns the host-stamped ref and it is threaded through GitService/release executor instead of being rebuilt from strings (helpers re-signatured to take RepoRef). - Host registry (services/forge/registry.py): in-memory host→provider map, self-healing — ProjectService.get/get_by_slug re-register on every read; provider_for resolves gitea projects by git_url host. - Registration validation now accepts git_provider="gitea"; GitLab remains recognized-but-rejected. Panel: the read-only Forge badge becomes a real picker (Auto-detect / GitHub-GHE / Gitea / GitLab disabled). Plain git (clone/fetch/push) needs no changes — the Basic-auth extraheader works on Gitea unchanged. Gates: mypy 392 files, xenon A, full unit suite 6356 green, integration suite 2257 green. * feat(forge): live-Gitea contract suite + scheme support + slash-safe refs Hardening from running the provider against a real dockerized Gitea 1.22.6 (the spec's Phase-2 contract suite, now committed as the env-gated tests/e2e_smoke/test_gitea_live.py — self-seeding: creates its own repo, pushes real commits, and drives PR open → duplicate reshape → list/filter → diff → review → labels → commit-status CI reshapes → squash merge → branch delete → release, plus a live verification of the x-access-token Basic-auth git-CLI claim). Two real findings fixed: - Branch refs weren't URL-encoded — every RoboCo branch carries slashes (feature/backend/...), and Gitea's router 404s on the extra path segments. list_ci_runs + delete_branch_ref now quote the ref (regression-pinned in the unit suite). - The API base hardcoded https; a LAN instance serving plain http is a real deployment shape. GiteaProvider gains a scheme (recorded per host by the registry from the project's git_url). ShapedResponse moves to forge/shaping.py (shared by the upcoming GitLab transport, which needs its text override for diff reassembly). * feat(forge): Phase 3 GitLab provider + Phase 2.1 local-merge fallback GitLabProvider (services/forge/gitlab.py): GitLab v4 transport addressed by host+scheme, subgroup-safe (the MR project path packs into RepoRef.owner, URL-encoded per call). Adapters translate MR semantics into the GitHub shapes GitService classifies: iid→number, source/target_branch→head/base with a merged bool, per-file diffs reassembled into unified-diff text (ShapedResponse text override, 3-page cap), approve-vs-note review routing (GitLab has no request-changes verb), pipelines/statuses reshaped into workflow_runs/check_runs, merge-method repo-key mapping, duplicate-MR 409→422. Reviewer mirroring is skipped (needs numeric ids RoboCo doesn't store); provisioning stays Phase 4. gitlab.com now auto-detects at registration like github.com; self-hosted GitLab sets the provider explicitly (panel picker enabled). Phase 2.1: neither Gitea nor GitLab has GitHub's server-side merges API — their merge_branch returns a shaped 501 and GitService.sync_env_branch now runs the shared local-git fallback (_local_merge_branch: throwaway clone → ancestor check → merge → push; a conflict aborts with the remote untouched; same status vocabulary as the merges-API path). Also aligns the whole tree with the full gate's tests/-scoped mypy (provider-test responder typing, e2e_smoke's stale owner/repo shapes). Gates: mypy 1229 files clean, xenon A, unit suite 6393 green, forge suites 85 green, panel typecheck/lint clean. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
91 lines
3.2 KiB
Python
91 lines
3.2 KiB
Python
"""ForgeRouter + registry: host-map registration, per-call provider
|
|
resolution off RepoRef.host, and URL parsing that stamps the host.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from roboco.exceptions import GitError
|
|
from roboco.services.forge import registry
|
|
from roboco.services.forge.base import RepoRef
|
|
from roboco.services.forge.gitea import GiteaProvider
|
|
from roboco.services.forge.github import GitHubProvider
|
|
from roboco.services.forge.gitlab import GitLabProvider
|
|
from roboco.services.forge.registry import (
|
|
provider_for,
|
|
register_project_forge,
|
|
)
|
|
from roboco.services.forge.router import ForgeRouter
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clean_host_map() -> None:
|
|
registry._HOST_PROVIDERS.clear()
|
|
|
|
|
|
def test_github_host_needs_no_registration() -> None:
|
|
register_project_forge("https://github.com/acme/widgets.git", "github")
|
|
assert registry._HOST_PROVIDERS == {}
|
|
assert registry.provider_name_for_host("github.com") == "github"
|
|
|
|
|
|
def test_gitea_host_registers_and_resolves() -> None:
|
|
register_project_forge("https://gitea.example.com/acme/widgets.git", "gitea")
|
|
assert registry.provider_name_for_host("gitea.example.com") == "gitea"
|
|
|
|
|
|
def test_router_resolves_provider_from_ref_host() -> None:
|
|
register_project_forge("https://gitea.example.com/acme/widgets.git", "gitea")
|
|
router = ForgeRouter()
|
|
assert isinstance(router._provider_for_ref(RepoRef("a", "b")), GitHubProvider)
|
|
assert isinstance(
|
|
router._provider_for_ref(RepoRef("a", "b", host="gitea.example.com")),
|
|
GiteaProvider,
|
|
)
|
|
|
|
|
|
def test_router_parse_github_url_unchanged() -> None:
|
|
ref = ForgeRouter().parse_repo_ref("git@github.com:acme/widgets.git")
|
|
assert ref == RepoRef("acme", "widgets")
|
|
assert ref.host is None
|
|
|
|
|
|
def test_router_parse_registered_gitea_url_stamps_host() -> None:
|
|
register_project_forge("https://gitea.example.com/acme/widgets.git", "gitea")
|
|
ref = ForgeRouter().parse_repo_ref("https://gitea.example.com/acme/widgets.git")
|
|
assert ref.host == "gitea.example.com"
|
|
|
|
|
|
def test_router_parse_unregistered_host_fails_loud() -> None:
|
|
with pytest.raises(GitError, match="registered project"):
|
|
ForgeRouter().parse_repo_ref("https://git.internal.example/a/b.git")
|
|
|
|
|
|
def test_provider_for_gitea_project_uses_git_url_host() -> None:
|
|
class _Project:
|
|
git_provider = "gitea"
|
|
git_url = "https://gitea.example.com/acme/widgets.git"
|
|
|
|
provider = provider_for(_Project())
|
|
assert isinstance(provider, GiteaProvider)
|
|
|
|
|
|
def test_provider_for_gitlab_project_uses_git_url_host() -> None:
|
|
class _Project:
|
|
git_provider = "gitlab"
|
|
git_url = "https://gitlab.com/acme/widgets.git"
|
|
|
|
assert isinstance(provider_for(_Project()), GitLabProvider)
|
|
|
|
|
|
def test_router_routes_registered_gitlab_host() -> None:
|
|
register_project_forge("https://gitlab.example.com/g/sub/p.git", "gitlab")
|
|
router = ForgeRouter()
|
|
provider = router._provider_for_ref(
|
|
RepoRef("g/sub/p", "", host="gitlab.example.com")
|
|
)
|
|
assert isinstance(provider, GitLabProvider)
|
|
ref = router.parse_repo_ref("https://gitlab.example.com/g/sub/p.git")
|
|
assert ref.owner == "g/sub/p"
|
|
assert ref.host == "gitlab.example.com"
|