mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
6cf99a1b0a
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154) * [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py - Create tests/__init__.py as empty package marker - Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py - Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py - Add return type annotations to _stub_get_optimal, _source, and factory functions - Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin - Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub - Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py - Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object - All 487 source files pass mypy with 0 errors; 2312 unit tests pass * [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/ Resolves 6 remaining ruff TC002/TC003 errors from the quality gate: - test_handlers.py: Iterator → TYPE_CHECKING - test_quality_gate.py: pathlib → TYPE_CHECKING - test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING - test_streaming.py: Iterator → TYPE_CHECKING - test_notification.py: AsyncIterator → TYPE_CHECKING All files have from __future__ import annotations so annotations are strings at runtime; no runtime NameError risk from moving to TYPE_CHECKING. * [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files * [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets --------- * [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155) * [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/ - Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.) - Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches - Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py - Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/ - No runtime logic changed — annotations and cast() only * [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate - Quote all cast() type arguments per ruff TC006 rule (cast("T", x)) - Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form) - Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.) - No runtime logic changed — annotation-only changeset * [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only) The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast targets already check `roboco/ tests/` — the lint target now matches gate scope. --------- --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
98 lines
3.0 KiB
Python
98 lines
3.0 KiB
Python
"""Coverage for `permissions.has_privileged_access` and `permissions.is_pm_role`."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
from typing import TYPE_CHECKING, cast
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.db.tables import AgentTable
|
|
from roboco.models import AgentRole, AgentStatus, Team
|
|
from roboco.services.permissions import has_privileged_access, is_pm_role
|
|
|
|
if TYPE_CHECKING:
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
|
|
def _make_agent(role: AgentRole, team: Team | None = None) -> AgentTable:
|
|
return AgentTable(
|
|
id=uuid4(),
|
|
name=f"agent-{uuid4().hex[:6]}",
|
|
slug=f"a-{uuid4().hex[:6]}",
|
|
role=role,
|
|
team=team,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# has_privileged_access
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_has_privileged_access_ceo_true(db_session: AsyncSession) -> None:
|
|
agent = _make_agent(AgentRole.CEO)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
assert await has_privileged_access(db_session, cast("uuid.UUID", agent.id)) is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_has_privileged_access_developer_false(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
agent = _make_agent(AgentRole.DEVELOPER, Team.BACKEND)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
assert await has_privileged_access(db_session, cast("uuid.UUID", agent.id)) is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_has_privileged_access_unknown_id_false(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
"""Unknown agent id → False."""
|
|
assert await has_privileged_access(db_session, uuid4()) is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# is_pm_role (lines 456-457)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_is_pm_role_main_pm_true(db_session: AsyncSession) -> None:
|
|
agent = _make_agent(AgentRole.MAIN_PM)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
assert await is_pm_role(db_session, cast("uuid.UUID", agent.id)) is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_is_pm_role_developer_false(db_session: AsyncSession) -> None:
|
|
agent = _make_agent(AgentRole.DEVELOPER, Team.BACKEND)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
assert await is_pm_role(db_session, cast("uuid.UUID", agent.id)) is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_is_pm_role_ceo_true(db_session: AsyncSession) -> None:
|
|
agent = _make_agent(AgentRole.CEO)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
assert await is_pm_role(db_session, cast("uuid.UUID", agent.id)) is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_is_pm_role_unknown_id_false(db_session: AsyncSession) -> None:
|
|
"""Unknown agent id → False (covers role is None branch on line 456-457)."""
|
|
assert await is_pm_role(db_session, uuid4()) is False
|