roboco/tests/unit/api/routes/v2/test_flow_dev.py

"""Unit tests for /api/v2/flow/dev/* endpoints.

Uses a minimal FastAPI test client built from the new router only.
No DB required — Choreographer is mocked.
"""

from __future__ import annotations

from unittest.mock import AsyncMock, MagicMock
from uuid import uuid4

import pytest
from fastapi import FastAPI
from fastapi.testclient import TestClient
from roboco.api.deps import get_choreographer
from roboco.api.routes.v2.flow_dev import router

_HTTP_200 = 200
_HTTP_422 = 422

_AGENT_ID = str(uuid4())
_TASK_ID = str(uuid4())
_HEADERS = {"X-Agent-ID": _AGENT_ID, "X-Agent-Role": "developer"}


def _make_envelope(status: str = "ok", task_id: str | None = None) -> MagicMock:
    """Return a mock Envelope whose as_dict() returns a predictable payload."""
    env = MagicMock()
    env.as_dict.return_value = {"status": status, "task_id": task_id, "next": "..."}
    return env


def _build_app(mock_choreographer: MagicMock) -> FastAPI:
    """Build minimal FastAPI app with the flow_dev router and a mocked dep."""
    app = FastAPI()
    app.include_router(router)
    app.dependency_overrides[get_choreographer] = lambda: mock_choreographer
    return app


@pytest.mark.asyncio
async def test_give_me_work_returns_envelope() -> None:
    """POST /api/v2/flow/dev/give_me_work returns 200 with envelope shape."""
    mock_chore = MagicMock()
    mock_chore.give_me_work = AsyncMock(return_value=_make_envelope(status="idle"))
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/give_me_work",
        json={},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_200
    body = resp.json()
    assert body["status"] == "idle"
    mock_chore.give_me_work.assert_awaited_once()


@pytest.mark.asyncio
async def test_i_will_work_on_dispatches_task_id() -> None:
    """POST /api/v2/flow/dev/i_will_work_on forwards task_id and plan."""
    mock_chore = MagicMock()
    mock_chore.i_will_work_on = AsyncMock(
        return_value=_make_envelope(status="in_progress", task_id=_TASK_ID)
    )
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/i_will_work_on",
        json={"task_id": _TASK_ID, "plan": "implement the feature"},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_200
    body = resp.json()
    assert body["status"] == "in_progress"
    mock_chore.i_will_work_on.assert_awaited_once()
    call_args = mock_chore.i_will_work_on.call_args
    # second positional arg is task_id (UUID), third is plan
    assert str(call_args.args[1]) == _TASK_ID
    assert call_args.args[2] == "implement the feature"


@pytest.mark.asyncio
async def test_i_have_committed_dispatches_message() -> None:
    """POST /api/v2/flow/dev/i_have_committed forwards commit message."""
    mock_chore = MagicMock()
    mock_chore.i_have_committed = AsyncMock(
        return_value=_make_envelope(status="in_progress")
    )
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/i_have_committed",
        json={"message": "add auth endpoint"},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_200
    mock_chore.i_have_committed.assert_awaited_once()
    assert mock_chore.i_have_committed.call_args.args[1] == "add auth endpoint"


@pytest.mark.asyncio
async def test_i_am_done_dispatches_task_and_notes() -> None:
    """POST /api/v2/flow/dev/i_am_done forwards task_id and notes."""
    mock_chore = MagicMock()
    mock_chore.i_am_done = AsyncMock(
        return_value=_make_envelope(status="awaiting_qa", task_id=_TASK_ID)
    )
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/i_am_done",
        json={"task_id": _TASK_ID, "notes": "all tests pass"},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_200
    body = resp.json()
    assert body["status"] == "awaiting_qa"
    mock_chore.i_am_done.assert_awaited_once()


@pytest.mark.asyncio
async def test_i_am_blocked_dispatches_reason() -> None:
    """POST /api/v2/flow/dev/i_am_blocked forwards task_id and reason."""
    mock_chore = MagicMock()
    mock_chore.i_am_blocked = AsyncMock(
        return_value=_make_envelope(status="blocked", task_id=_TASK_ID)
    )
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/i_am_blocked",
        json={"task_id": _TASK_ID, "reason": "waiting for design spec"},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_200
    mock_chore.i_am_blocked.assert_awaited_once()
    assert mock_chore.i_am_blocked.call_args.args[2] == "waiting for design spec"


@pytest.mark.asyncio
async def test_i_am_idle_dispatches_agent_id() -> None:
    """POST /api/v2/flow/dev/i_am_idle delegates to Choreographer.i_am_idle."""
    mock_chore = MagicMock()
    mock_chore.i_am_idle = AsyncMock(return_value=_make_envelope(status="idle"))
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/i_am_idle",
        json={},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_200
    body = resp.json()
    assert body["status"] == "idle"
    mock_chore.i_am_idle.assert_awaited_once()


def test_i_have_committed_rejects_empty_message() -> None:
    """POST i_have_committed rejects empty message (min_length=1)."""
    mock_chore = MagicMock()
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/i_have_committed",
        json={"message": ""},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_422


def test_i_am_blocked_rejects_empty_reason() -> None:
    """POST i_am_blocked rejects empty reason (min_length=1)."""
    mock_chore = MagicMock()
    client = TestClient(_build_app(mock_chore))

    resp = client.post(
        "/api/v2/flow/dev/i_am_blocked",
        json={"task_id": _TASK_ID, "reason": ""},
        headers=_HEADERS,
    )

    assert resp.status_code == _HTTP_422