Files
roboco/tests/integration/test_messages_routes.py
T
6cf99a1b0a [beb8cae1] Type-gate tests/ under mypy — fix all errors and flip quality gate (#156) (#157)
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154)

* [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py

- Create tests/__init__.py as empty package marker
- Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py
- Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py
- Add return type annotations to _stub_get_optimal, _source, and factory functions
- Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin
- Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub
- Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py
- Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object
- All 487 source files pass mypy with 0 errors; 2312 unit tests pass

* [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/

Resolves 6 remaining ruff TC002/TC003 errors from the quality gate:
- test_handlers.py: Iterator → TYPE_CHECKING
- test_quality_gate.py: pathlib → TYPE_CHECKING
- test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING
- test_streaming.py: Iterator → TYPE_CHECKING
- test_notification.py: AsyncIterator → TYPE_CHECKING

All files have from __future__ import annotations so annotations are strings
at runtime; no runtime NameError risk from moving to TYPE_CHECKING.

* [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files

* [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets

---------



* [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155)

* [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/

- Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.)
- Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches
- Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py
- Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/
- No runtime logic changed — annotations and cast() only

* [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate

- Quote all cast() type arguments per ruff TC006 rule (cast("T", x))
- Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form)
- Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.)
- No runtime logic changed — annotation-only changeset

* [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only)

The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy
roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing
tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast
targets already check `roboco/ tests/` — the lint target now matches gate scope.

---------



---------

Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev>
Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
2026-06-14 13:43:46 +02:00

340 lines
11 KiB
Python

"""Messages API route coverage."""
from __future__ import annotations
from datetime import UTC, datetime
from http import HTTPStatus
from typing import TYPE_CHECKING, cast
from unittest.mock import AsyncMock, patch
from uuid import UUID, uuid4
import pytest
import pytest_asyncio
from fastapi import FastAPI
from httpx import ASGITransport, AsyncClient
from roboco.api.deps import get_current_agent_id, get_db
from roboco.api.routes.messages import router as messages_router
from roboco.api.schemas.messages import MessageResponse
from roboco.db.tables import AgentTable
from roboco.models import AgentRole, AgentStatus, Team
from roboco.models.base import MessageType
from roboco.services.base import NotFoundError
if TYPE_CHECKING:
from collections.abc import AsyncIterator
from sqlalchemy.ext.asyncio import AsyncSession
@pytest_asyncio.fixture
async def messages_client(
db_session: AsyncSession,
) -> AsyncIterator[dict]:
agent = AgentTable(
id=uuid4(),
name="Dev",
slug=f"be-dev-{uuid4().hex[:8]}",
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
status=AgentStatus.ACTIVE,
model_config={},
system_prompt="dev",
capabilities=[],
permissions={},
metrics={},
)
db_session.add(agent)
await db_session.flush()
app = FastAPI()
app.include_router(messages_router, prefix="/api/messages")
async def _override_db() -> AsyncIterator[AsyncSession]:
yield db_session
async def _override_agent_id() -> UUID:
return cast("UUID", agent.id)
app.dependency_overrides[get_db] = _override_db
app.dependency_overrides[get_current_agent_id] = _override_agent_id
transport = ASGITransport(app=app)
async with AsyncClient(transport=transport, base_url="http://test") as client:
yield {"client": client, "agent": agent}
app.dependency_overrides.clear()
_HDR = {"X-Agent-ID": str(uuid4()), "X-Agent-Role": "developer"}
@pytest.mark.asyncio
async def test_list_messages_unknown_session(messages_client: dict) -> None:
client = messages_client["client"]
response = await client.get(f"/api/messages?session_id={uuid4()}", headers=_HDR)
assert response.status_code == HTTPStatus.NOT_FOUND
@pytest.mark.asyncio
async def test_get_message_not_found(messages_client: dict) -> None:
client = messages_client["client"]
response = await client.get(f"/api/messages/{uuid4()}", headers=_HDR)
assert response.status_code == HTTPStatus.NOT_FOUND
@pytest.mark.asyncio
async def test_send_message_unknown_session(messages_client: dict) -> None:
client = messages_client["client"]
response = await client.post(
"/api/messages",
json={
"session_id": str(uuid4()),
"content": "hello",
},
headers=_HDR,
)
# 400 if session not found / 422 if validation
assert response.status_code in (
HTTPStatus.BAD_REQUEST,
HTTPStatus.NOT_FOUND,
HTTPStatus.UNPROCESSABLE_ENTITY,
)
@pytest.mark.asyncio
async def test_edit_message_not_found(messages_client: dict) -> None:
client = messages_client["client"]
response = await client.patch(
f"/api/messages/{uuid4()}",
json={"new_content": "edited"},
headers=_HDR,
)
assert response.status_code in (
HTTPStatus.NOT_FOUND,
HTTPStatus.UNPROCESSABLE_ENTITY,
)
@pytest.mark.asyncio
async def test_delete_message_not_found(messages_client: dict) -> None:
client = messages_client["client"]
response = await client.delete(f"/api/messages/{uuid4()}", headers=_HDR)
assert response.status_code in (HTTPStatus.NO_CONTENT, HTTPStatus.NOT_FOUND)
# ---------------------------------------------------------------------------
# Service-level tests via mocking
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_list_messages_success_empty(messages_client: dict) -> None:
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.list_messages_for_session = AsyncMock(return_value=([], False))
mock_get.return_value = instance
response = await client.get(f"/api/messages?session_id={uuid4()}", headers=_HDR)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_get_message_after_send_failure(messages_client: dict) -> None:
"""Get-message NotFoundError path."""
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.get_message_or_raise = AsyncMock(side_effect=NotFoundError("missing"))
mock_get.return_value = instance
response = await client.get(f"/api/messages/{uuid4()}", headers=_HDR)
assert response.status_code == HTTPStatus.NOT_FOUND
@pytest.mark.asyncio
async def test_send_message_value_error(messages_client: dict) -> None:
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.send_message = AsyncMock(side_effect=ValueError("session bad"))
mock_get.return_value = instance
response = await client.post(
"/api/messages",
json={
"session_id": str(uuid4()),
"content": "hi",
"type": "dialogue",
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.BAD_REQUEST
@pytest.mark.asyncio
async def test_edit_message_permission_error(messages_client: dict) -> None:
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.edit_message_or_raise = AsyncMock(
side_effect=PermissionError("not yours")
)
mock_get.return_value = instance
response = await client.patch(
f"/api/messages/{uuid4()}",
json={"content": "edited"},
headers=_HDR,
)
assert response.status_code in (
HTTPStatus.FORBIDDEN,
HTTPStatus.UNPROCESSABLE_ENTITY,
)
@pytest.mark.asyncio
async def test_delete_message_permission_error(messages_client: dict) -> None:
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.delete_message_or_raise = AsyncMock(
side_effect=PermissionError("not yours")
)
mock_get.return_value = instance
response = await client.delete(f"/api/messages/{uuid4()}", headers=_HDR)
assert response.status_code == HTTPStatus.FORBIDDEN
@pytest.mark.asyncio
async def test_get_message_returns_response_when_found(messages_client: dict) -> None:
"""Line 79: get_message_or_raise returns a row → message_to_response (200)."""
client = messages_client["client"]
fake_msg = AsyncMock()
msg_id = uuid4()
fake_msg.id = msg_id
fake_response = MessageResponse(
id=msg_id,
agent_id=messages_client["agent"].id,
channel_id=uuid4(),
group_id=uuid4(),
session_id=uuid4(),
type=MessageType.DIALOGUE,
content="hello",
content_length=5,
is_reply=False,
reply_to=None,
mentions=[],
task_id=None,
commit_ref=None,
timestamp=datetime.now(UTC),
edited_at=None,
was_edited=False,
)
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.get_message_or_raise = AsyncMock(return_value=fake_msg)
mock_get.return_value = instance
with patch(
"roboco.api.routes.messages.message_to_response",
return_value=fake_response,
):
response = await client.get(f"/api/messages/{fake_msg.id}", headers=_HDR)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_send_message_success_returns_201(messages_client: dict) -> None:
"""Line 113: success returns the message_to_response."""
fake_msg = AsyncMock()
fake_response = MessageResponse(
id=uuid4(),
agent_id=messages_client["agent"].id,
channel_id=uuid4(),
group_id=uuid4(),
session_id=uuid4(),
type=MessageType.DIALOGUE,
content="hi",
content_length=2,
is_reply=False,
reply_to=None,
mentions=[],
task_id=None,
commit_ref=None,
timestamp=datetime.now(UTC),
edited_at=None,
was_edited=False,
)
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.send_message = AsyncMock(return_value=fake_msg)
mock_get.return_value = instance
with patch(
"roboco.api.routes.messages.message_to_response",
return_value=fake_response,
):
response = await client.post(
"/api/messages",
json={
"session_id": str(uuid4()),
"content": "hello",
"type": "dialogue",
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.CREATED
@pytest.mark.asyncio
async def test_edit_message_not_found_404(messages_client: dict) -> None:
"""Line 138: edit raises NotFoundError → 404."""
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.edit_message_or_raise = AsyncMock(side_effect=NotFoundError("missing"))
mock_get.return_value = instance
response = await client.patch(
f"/api/messages/{uuid4()}",
json={"content": "edited"},
headers=_HDR,
)
assert response.status_code == HTTPStatus.NOT_FOUND
@pytest.mark.asyncio
async def test_edit_message_success_returns_response(messages_client: dict) -> None:
"""Line 141: edit succeeds → message_to_response with was_edited=True."""
fake_msg = AsyncMock()
fake_response = MessageResponse(
id=uuid4(),
agent_id=messages_client["agent"].id,
channel_id=uuid4(),
group_id=uuid4(),
session_id=uuid4(),
type=MessageType.DIALOGUE,
content="edited",
content_length=6,
is_reply=False,
reply_to=None,
mentions=[],
task_id=None,
commit_ref=None,
timestamp=datetime.now(UTC),
edited_at=datetime.now(UTC),
was_edited=True,
)
client = messages_client["client"]
with patch("roboco.api.routes.messages.get_messaging_service") as mock_get:
instance = AsyncMock()
instance.edit_message_or_raise = AsyncMock(return_value=fake_msg)
mock_get.return_value = instance
with patch(
"roboco.api.routes.messages.message_to_response",
return_value=fake_response,
):
response = await client.patch(
f"/api/messages/{uuid4()}",
json={"content": "edited"},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK