mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154) * [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py - Create tests/__init__.py as empty package marker - Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py - Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py - Add return type annotations to _stub_get_optimal, _source, and factory functions - Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin - Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub - Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py - Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object - All 487 source files pass mypy with 0 errors; 2312 unit tests pass * [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/ Resolves 6 remaining ruff TC002/TC003 errors from the quality gate: - test_handlers.py: Iterator → TYPE_CHECKING - test_quality_gate.py: pathlib → TYPE_CHECKING - test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING - test_streaming.py: Iterator → TYPE_CHECKING - test_notification.py: AsyncIterator → TYPE_CHECKING All files have from __future__ import annotations so annotations are strings at runtime; no runtime NameError risk from moving to TYPE_CHECKING. * [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files * [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets --------- * [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155) * [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/ - Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.) - Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches - Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py - Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/ - No runtime logic changed — annotations and cast() only * [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate - Quote all cast() type arguments per ruff TC006 rule (cast("T", x)) - Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form) - Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.) - No runtime logic changed — annotation-only changeset * [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only) The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast targets already check `roboco/ tests/` — the lint target now matches gate scope. --------- --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
132 lines
3.8 KiB
Python
132 lines
3.8 KiB
Python
"""IndexedDocumentRepository coverage."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
import pytest
|
|
import pytest_asyncio
|
|
from roboco.services.repositories.indexed_document import (
|
|
IndexedDocumentRepository,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import AsyncIterator
|
|
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
|
|
@pytest_asyncio.fixture
|
|
async def repo(db_session: AsyncSession) -> AsyncIterator[IndexedDocumentRepository]:
|
|
yield IndexedDocumentRepository(db_session)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_upsert_batch_empty_returns_zero(
|
|
repo: IndexedDocumentRepository,
|
|
) -> None:
|
|
assert await repo.upsert_batch("code", []) == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_upsert_batch_inserts_new(
|
|
repo: IndexedDocumentRepository,
|
|
) -> None:
|
|
docs = [
|
|
{"source": "a/file1.py", "title": "F1", "preview": "x" * 600},
|
|
{"source": "a/file2.py", "title": "F2", "preview": "y"},
|
|
]
|
|
count = await repo.upsert_batch("code", docs)
|
|
_DOCS = 2
|
|
assert count == _DOCS
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_upsert_batch_updates_existing(
|
|
repo: IndexedDocumentRepository,
|
|
) -> None:
|
|
docs = [{"source": "same.py", "title": "Original"}]
|
|
await repo.upsert_batch("code", docs)
|
|
docs[0]["title"] = "Updated"
|
|
count = await repo.upsert_batch("code", docs)
|
|
assert count == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_by_index_type(repo: IndexedDocumentRepository) -> None:
|
|
await repo.upsert_batch(
|
|
"documentation",
|
|
[{"source": "doc1.md", "title": "T1"}, {"source": "doc2.md", "title": "T2"}],
|
|
)
|
|
_DOCS = 2
|
|
rows = await repo.get_by_index_type("documentation")
|
|
assert len(rows) >= _DOCS
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_count_by_index_type(repo: IndexedDocumentRepository) -> None:
|
|
await repo.upsert_batch("standards", [{"source": "s1.md", "title": "S1"}])
|
|
count = await repo.count_by_index_type("standards")
|
|
assert count >= 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_delete_by_index_type(repo: IndexedDocumentRepository) -> None:
|
|
_DOCS = 2
|
|
await repo.upsert_batch(
|
|
"to-delete",
|
|
[{"source": "x.md", "title": "X"}, {"source": "y.md", "title": "Y"}],
|
|
)
|
|
deleted = await repo.delete_by_index_type("to-delete")
|
|
assert deleted >= _DOCS
|
|
assert await repo.count_by_index_type("to-delete") == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_upsert_batch_truncates_long_preview(
|
|
repo: IndexedDocumentRepository,
|
|
) -> None:
|
|
"""Preview is truncated to 500 chars."""
|
|
docs = [{"source": "long.md", "title": "Long", "preview": "a" * 1000}]
|
|
await repo.upsert_batch("code", docs)
|
|
_PREVIEW_MAX = 500
|
|
rows = await repo.get_by_index_type("code")
|
|
matching = [r for r in rows if r.source == "long.md"]
|
|
assert matching
|
|
preview = matching[0].preview
|
|
assert preview is not None
|
|
assert len(preview) <= _PREVIEW_MAX
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_upsert_batch_updates_preview_and_metadata(
|
|
repo: IndexedDocumentRepository,
|
|
) -> None:
|
|
"""Lines 66, 68: update path with preview + metadata fields."""
|
|
# Insert first.
|
|
await repo.upsert_batch(
|
|
"code",
|
|
[{"source": "metadoc.py", "title": "Old", "metadata": {"a": 1}}],
|
|
)
|
|
# Update with preview + metadata.
|
|
await repo.upsert_batch(
|
|
"code",
|
|
[
|
|
{
|
|
"source": "metadoc.py",
|
|
"title": "New",
|
|
"preview": "fresh content",
|
|
"metadata": {"b": 2},
|
|
}
|
|
],
|
|
)
|
|
_A_VALUE = 1
|
|
_B_VALUE = 2
|
|
rows = await repo.get_by_index_type("code")
|
|
matching = [r for r in rows if r.source == "metadoc.py"]
|
|
assert matching
|
|
assert matching[0].preview == "fresh content"
|
|
# Metadata is merged.
|
|
assert matching[0].extra_data["a"] == _A_VALUE
|
|
assert matching[0].extra_data["b"] == _B_VALUE
|