mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
6cf99a1b0a
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154) * [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py - Create tests/__init__.py as empty package marker - Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py - Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py - Add return type annotations to _stub_get_optimal, _source, and factory functions - Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin - Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub - Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py - Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object - All 487 source files pass mypy with 0 errors; 2312 unit tests pass * [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/ Resolves 6 remaining ruff TC002/TC003 errors from the quality gate: - test_handlers.py: Iterator → TYPE_CHECKING - test_quality_gate.py: pathlib → TYPE_CHECKING - test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING - test_streaming.py: Iterator → TYPE_CHECKING - test_notification.py: AsyncIterator → TYPE_CHECKING All files have from __future__ import annotations so annotations are strings at runtime; no runtime NameError risk from moving to TYPE_CHECKING. * [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files * [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets --------- * [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155) * [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/ - Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.) - Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches - Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py - Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/ - No runtime logic changed — annotations and cast() only * [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate - Quote all cast() type arguments per ruff TC006 rule (cast("T", x)) - Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form) - Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.) - No runtime logic changed — annotation-only changeset * [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only) The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast targets already check `roboco/ tests/` — the lint target now matches gate scope. --------- --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
60 lines
2.1 KiB
Python
60 lines
2.1 KiB
Python
"""Envelope.from_decision maps a Decision to the right rejection envelope."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from roboco.foundation.policy import lifecycle as spec
|
|
from roboco.services.gateway.envelope import Envelope
|
|
|
|
|
|
def test_from_decision_not_authorized_maps_to_not_authorized_envelope() -> None:
|
|
d = spec.Decision.reject(
|
|
kind="not_authorized",
|
|
message="role 'developer' may not call delegate",
|
|
remediate="only PMs delegate",
|
|
)
|
|
env = Envelope.from_decision(d, briefing={})
|
|
assert env.error == "not_authorized"
|
|
assert env.message == "role 'developer' may not call delegate"
|
|
assert env.remediate == "only PMs delegate"
|
|
|
|
|
|
def test_from_decision_invalid_state_maps_to_invalid_state_envelope() -> None:
|
|
d = spec.Decision.reject(
|
|
kind="invalid_state",
|
|
message="task in 'pending', 'open_pr' requires ['in_progress']",
|
|
remediate="claim the task first via i_will_work_on",
|
|
)
|
|
env = Envelope.from_decision(d, briefing={})
|
|
assert env.error == "invalid_state"
|
|
|
|
|
|
def test_from_decision_tracing_gap_carries_missing() -> None:
|
|
d = spec.Decision.tracing_gap(
|
|
missing=["plan", "journal:decision"],
|
|
remediate="provide plan and a journal:decision entry",
|
|
)
|
|
env = Envelope.from_decision(d, briefing={})
|
|
assert env.error == "tracing_gap"
|
|
assert env.missing == ["plan", "journal:decision"]
|
|
assert env.remediate == "provide plan and a journal:decision entry"
|
|
|
|
|
|
def test_from_decision_self_review_maps_to_not_authorized_with_hint() -> None:
|
|
d = spec.Decision.reject(
|
|
kind="self_review",
|
|
message="self-review blocked",
|
|
remediate="another QA must review",
|
|
)
|
|
env = Envelope.from_decision(d, briefing={})
|
|
assert env.error == "not_authorized"
|
|
assert env.message is not None
|
|
assert "self-review" in env.message.lower()
|
|
|
|
|
|
def test_from_decision_allowed_raises() -> None:
|
|
"""Constructing a rejection envelope from an allow Decision is a bug."""
|
|
d = spec.Decision.allow()
|
|
with pytest.raises(ValueError, match="cannot build rejection from allow Decision"):
|
|
Envelope.from_decision(d, briefing={})
|