Files
roboco/tests/integration/test_git_routes.py
T
3ccc723cd4 v0.17.0 — Wave 3: sandbox DB, DB isolation, mobile UI, cloud auth, X account, roadmap engine (#303)
* feat(sandbox): throwaway per-agent Postgres/Redis sandbox containers

Orchestrator-provisioned sibling containers per agent spawn
(SandboxProvisioner, roboco/runtime/sandbox.py). Per-project opt-in via
projects.sandbox_services (migration 057); master switch
ROBOCO_SANDBOX_DB_ENABLED, default-off, armed in the NAS compose only.

When active, ROBOCO_TEST_DB_* / ROBOCO_TEST_REDIS_* point at the sandbox
and the prod-creds gate-env injection is suppressed (sandbox replaces,
never coexists). Sandbox lifetime tracks the agent container: teardown at
every removal path, orphan janitor at startup + each reaper tick with a
grace window for mid-flight spawns. The pre-spawn stale-clear spares the
just-provisioned sandbox; provision pre-clears stale same-named
containers from a crash-missed teardown.

Panel: per-project sandbox-service switches in the edit dialog + feature
flag card entry.

* docs: CLAUDE.md entry for the sandboxed dev DB/Redis subsystem

* feat(security): isolate prod Postgres/Redis from agent containers (roboco_data network)

Second user-defined bridge roboco_data carries postgres+redis only; the
orchestrator is multi-homed (default + data). Spawned agents and their
sandbox sidecars stay on roboco_default and can no longer resolve or
reach roboco-postgres:5432 / roboco-redis:6379 (redis has no auth —
membership is its only containment). Normal bridge, so host-published
ports (15432/16379) keep working. Applied to both build composes and
the registry compose; docker-compose.yml re-synced byte-identical with
docker-compose.yaml (it had drifted by the sandbox flag block).

ROBOCO_DB_NETWORK_ISOLATED (config default false, armed alongside the
topology) suppresses the legacy _append_gate_env prod-creds injection:
under isolation those creds dead-end, and unreachable creds are worse
than none. DB-needing projects opt into sandbox_services instead. The
flag is deliberately not a panel feature flag - it must travel with the
compose networks: stanzas.

Preserved by construction: agent<->agent A2A and orchestrator->agent SDK
polls on :9000, MCP->orchestrator on :8000, ollama reachability, docker
exec/inspect (daemon socket), host port publishing.

* feat(panel): full mobile responsiveness pass

Shared primitives: useIsMobile (useSyncExternalStore, hydration-safe,
memoized matchMedia subscribe), ResponsiveTable table->card switch below
md (single subtree mounted, no duplicated interactive rows), scrollable
snap TabsList in the base primitive (justify-center-safe so the first
tab stays reachable on overflow), persistent md:hidden bottom tab bar
(Overview/Tasks/Kanban/Chat, safe-area padded).

Applied: card lists for tasks/projects/products/work-sessions/sessions
+ the three raw metrics tables; CEO approval queue / release proposal /
playbook review action rows stack on narrow; command-center reorders
approvals above the fold on mobile; task-header metadata wraps;
Communications + A2A become URL-driven single-pane drill-downs below lg
(fixes the unconstrained-height ScrollArea bug) with dvh heights;
recharts label density/radius adapts via useIsMobile; git diff viewer
gets mobile font + wrap toggle; vh->dvh sweep; chat composers get
safe-area-inset padding; dashboard main p-4 md:p-6 + pb-20 for the bar.

Verified at 375px on the built app: bottom bar, drawer, approval-first
overview, swipeable kanban tab strip. All gates green (eslint, tsc,
vitest 249, next build 24/24 routes).

* feat(auth): cloud auth via FastAPI Users (default-off, single-user cookie session)

ROBOCO_CLOUD_AUTH_ENABLED (default off) lets the panel/API be exposed
beyond localhost without changing the CEO's local no-login flow while
off — get_agent_context and the WS gate are byte-for-byte unchanged in
off-mode. On: header-trust dies for humans — any agent-role claim (ceo
or a privileged PM/board role) with no valid HMAC token or session
cookie is 401, closing the header-spoof hole on the host-published
:8000 port for every role. The agent-fleet HMAC path and the system
self-PATCH keep working unmodified in both modes.

Single seeded CEO user (migration 058 users table, UserTable), no
registration router — idempotent env-driven upsert at startup by PK.
Cookie transport (httponly/secure/samesite=lax) + a JWTStrategy bound
to a fingerprint of the current password hash (rotating the password
invalidates every prior session). Sliding 30-day session: every
authenticated request re-mints the cookie, so an active session never
expires — no unexpected logouts.

Panel: (auth)/login page + proxy.ts (Next 16 rename of middleware; probes
/auth/status over the docker-internal URL, fails open to off) gate the
dashboard; client.ts gets withCredentials + 401->/login. nginx unchanged.

Review hardening: broadened the on-mode rejection from ceo-only to every
non-CEO role without a valid token (was only closed when
ROBOCO_AGENT_AUTH_REQUIRED was also armed); Next-16 proxy.ts rename to
clear the middleware deprecation warning.

* feat(x): RoboCo X account engine — HoM drafts, per-post CEO approval (default-off)

ROBOCO_X_ENGINE_ENABLED (default off, inert without creds). Mirrors the
ReleaseManagerEngine held-artifact shape: XEngine drafts a post when a
release publishes (via a draft_release_post seam on ReleaseProposalService
.approve) and drafts replies to meaningful mentions (dedicated poll loop,
x_seen_mentions dedup ledger, per-cycle/open caps). Drafting is
local-model-only, clamped to 280 chars. Nothing auto-posts — every tweet
is a held task (source x_post/x_reply, confirmed_by_human=False,
Secretary-owned, dispatcher-skipped) the CEO edits/approves/rejects in a
panel queue.

The four OAuth 1.0a secrets live Fernet-encrypted in a singleton
x_credentials row (migration 059, all-or-nothing, API returns only
has_credentials); decryption is server-side, agents never hold creds or
egress. Hand-rolled OAuth 1.0a HMAC-SHA1 signer, no new dependency;
NullXClient makes the unconfigured path a graceful no-op.

XPostService.approve (CEO-only) is the sole caller of post_tweet.

Review hardening: closed a double-post race — the approve path now
re-reads committed task state inside the Redis lock and commits COMPLETED
before releasing, so a concurrent approve that acquires the lock after the
winner released can't re-post (SET-NX is non-waiting, and the route-level
commit landed after the lock dropped). Added a regression test.

* feat(roadmap): board roadmap engine — PO proposes themed cycles, CEO approves per-item (default-off)

ROBOCO_ROADMAP_ENGINE_ENABLED (default off). Weekly, RoadmapEngine opens
ONE held exploration task (source=board_roadmap, confirmed_by_human=False,
Product-Owner-assigned), deduped to one open cycle. A dedicated one-shot
_dispatch_roadmap_exploration spawns the PO solo (not the two-reviewer
board path, which would also spawn HoM + fire Approve-&-Start). The PO
explores read-only (git/KB/metrics/releases/charter/web) and makes one
propose_roadmap call (PO-only content verb) authoring a themed cycle —
goal + 3-7 item drafts — persisted as a roadmap_cycle marker (no table,
no migration; head stays 059).

The CEO acts per-item in the panel roadmap queue: approve materializes a
BACKLOG task (source=roadmap, no assignee — never auto-starts), reject
records a reason; all-items-terminal completes the exploration task.
RoadmapService is idempotent per item. Dispatchers skip board_roadmap.

Includes a real SQLAlchemy dirty-check fix (deep-copy the JSON marker
before mutating, or the in-place edit + reassign compares equal to its
own baseline and the UPDATE is skipped).

Review hardening: create_task_from_draft now honors a draft-declared
source only from a {prompter, roadmap} whitelist — drafts are
LLM-authored, so an unbounded source could impersonate a privileged
origin (release_manager would even wedge that engine's dedup).

* chore(release): 0.17.0

Wave 3 — six default-off subsystems: sandboxed dev DB/Redis, prod
Postgres/Redis network isolation, full mobile UI pass, cloud auth
(FastAPI Users), the RoboCo X account engine, and the board roadmap
engine. Plus the waves 1+2 work already on master since 0.16.0.

Version bumped across the canonical set (config.py, __init__.py,
pyproject.toml, panel/package.json, uv.lock); CHANGELOG [Unreleased]
cut to [0.17.0]; docs/map delta added.

Compose: every optional feature armed :-true in the NAS composes, OFF
in the user-facing registry compose. Two opt-in exceptions default off
(CLOUD_AUTH — needs email/password/secret + TLS, would otherwise fail
startup; ROUTING_STRICT — fail-closed spawning). DB_NETWORK_ISOLATED
stays on in both (coupled to the roboco_data topology).

* chore(compose): arm cloud_auth + routing_strict ON in the NAS composes

Every feature defaults ON in the NAS composes per policy — these two
were wrongly left off. Both keep the ${VAR:-true} form so the operator
controls the real runtime via .env: cloud auth needs
ROBOCO_CLOUD_AUTH_EMAIL/_PASSWORD/_SECRET + TLS set there before a boot
(else startup fails loud), and routing_strict is fail-closed. Registry
compose keeps both off.

* fix(ci): reflow board.md prose (quality gate) + document v0.17.0 env creds

The roadmap section added hard-wrapped prose that failed the markdown
prose gate; reflowed (token-invariant). Also brought .env.example
current: cloud auth (now armed — needs SECRET or startup fails), routing
strict, the X engine (panel-entered OAuth), and web research.

* fix(ci): reduce cyclomatic complexity of five wave-3 blocks (xenon gate)

The wave-3 subagents introduced C-rank functions the CI xenon gate
rejects (my per-item reviews ran ruff/mypy/pytest but not xenon):
- sandbox.janitor_sweep -> extract _list_labeled_sandboxes /
  _list_live_agent_containers / _prune_grace
- x_client.fetch_mentions -> extract _parse_mention_items
- x_engine.run_cycle -> extract _process_mentions
- orchestrator._dispatch_pm_work -> extract the source-skip into a
  MODULE-level _is_held_ceo_source (module, not method, so the
  wholesale-mocked dispatcher unit tests exercise the real logic)
- auth/seed.ensure_seed_user -> extract _apply_seed_updates (module avg -> A)

Behavior-preserving; full suite green (11902), xenon clean.

* fix(ci): declare pyjwt + fastapi-users-db-sqlalchemy as direct deps (deptry)

The cloud-auth code imports jwt and fastapi_users_db_sqlalchemy directly
but they were only transitive deps (via fastapi-users), which deptry
(quality gate, DEP003) rejects. Declared explicitly; deptry roboco/ clean.
Missed originally because local make quality stopped at earlier gates
before reaching deptry.

* feat(x): gate mention replies behind ROBOCO_X_REPLIES_ENABLED (default off)

Per CEO decision: the X engine should only post about releases by
default. Reading mentions needs a paid X API tier, so the mention-reply
half is now a deliberate opt-in on top of release posting.

New default-off flag x_replies_enabled gates the mentions poll loop
(_x_mentions_poll_loop) and XEngine.run_cycle; release-post drafting
(the release-proposal approve hook) is unaffected and still runs when
x_engine_enabled + credentials are set. Added to FEATURE_FLAGS + the
panel card. Tests: release posting works with replies off; run_cycle +
the poll loop are no-ops with replies off.

* fix: 401 only redirects to /login when cloud auth is on; panel-token strips .env quotes

Two bugs that together dead-ended login in secure mode:
- client.ts redirected to /login on ANY 401, so a mismatched panel
  token (header-trust/secure mode, cloud auth off) bounced the user to a
  login page whose backend route isn't mounted -> 404. Now it probes
  /auth/status (bare fetch, no interceptor re-entry) and only redirects
  when cloud_auth_enabled.
- make panel-token read the .env secret with grep|cut without stripping
  surrounding quotes, so a quoted ROBOCO_AGENT_AUTH_SECRET produced a
  token signed with the quotes included — which never verifies against
  the orchestrator (docker-compose/pydantic unquote the secret). Now
  strips surrounding single/double quotes.

* fix: git-log 500 on '|' in commit message; X queue shows an empty state

- GET /api/git/log 500'd (ValueError: Invalid isoformat) when a commit
  SUBJECT contained a '|' (e.g. the 'curl|sh' lockdown commit): the
  fixed '|' field delimiter let the subject's pipe shift the split so
  author+date collapsed into one field. Switched to \x1f (Unit
  Separator), which can't appear in commit content. Regression test with
  a piped subject.
- The X Post Queue returned null when empty, so there was no visible
  place for the X drafts. It now renders a discoverable empty state
  pointing at Settings -> X credentials.

* docs: bring docs/rag + docs/map current for v0.17.0 (waves 1-3)

Agent-facing RAG corpus and codebase map updated for every feature in
the 0.17.0 span, code-verified:
- wave 3: sandbox DB, DB network isolation, cloud auth, X engine
  (+ x_replies_enabled sub-flag), board roadmap engine — new RAG
  architecture pages + role/tool/config-reference updates; new symbols,
  migrations 057-059, panel surfaces, and the get_agent_context
  dual-path across the map slices.
- waves 1-2: A2A live view + switchboard, prompter memory
  (search_past_tasks), Secretary edit access + PM-lighter scope, the
  PR-gate auto-submit turn cut (ROBOCO_PR_GATE_AUTO_SUBMIT_ENABLED).
- correctness fix: api-routes-schemas.md no longer claims the A2A admin
  routes are reachable by any authenticated agent — they carry a
  _require_ceo gate (wave 2c).

docs/internal, _front.md deltas, and the frozen _complete_map.md
snapshot untouched.

* fix(rag): atomic upsert for indexed-doc tracking (kills e2e segfault)

The indexed-document tracking write used check-then-insert in two paths
(IndexedDocumentRepository.upsert_batch and the file-source
_upsert_doc_record). Under concurrent indexing both callers saw no row
and both inserted, so the second violated uq_indexed_doc_source and
poisoned its transaction — surfacing in CI as the intermittent
_checkin_failed SIGSEGV on the failed connection's pool checkin.

Both paths now use INSERT ... ON CONFLICT DO UPDATE against the
constraint: coalesce keeps an existing title/preview when the new value
is empty (matching the old guards) and metadata is jsonb-merged. The
batch dedupes within itself first (ON CONFLICT can't touch a row twice
in one statement). expire_all after the Core upsert keeps same-session
ORM reads consistent with the merged DB row.

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>
2026-07-03 19:24:00 +02:00

1007 lines
36 KiB
Python

"""Git API route coverage."""
from __future__ import annotations
import uuid
from http import HTTPStatus
from types import SimpleNamespace
from typing import TYPE_CHECKING, cast
from unittest.mock import AsyncMock, MagicMock, patch
from uuid import uuid4
import pytest
import pytest_asyncio
from fastapi import FastAPI
from httpx import ASGITransport, AsyncClient
from roboco.api.deps import get_agent_context, get_db
from roboco.api.routes.git import _translate_error
from roboco.api.routes.git import router as git_router
from roboco.db.tables import AgentTable, ProjectTable
from roboco.exceptions import GitCommandError, GitTimeoutError
from roboco.models import AgentRole, AgentStatus, Team
from roboco.models.permissions import AgentContext
from roboco.services.base import (
NotFoundError,
ServiceError,
UnauthorizedError,
ValidationError,
)
if TYPE_CHECKING:
from collections.abc import AsyncGenerator, AsyncIterator
from sqlalchemy.ext.asyncio import AsyncSession
@pytest_asyncio.fixture
async def git_client(
db_session: AsyncSession,
) -> AsyncIterator[dict]:
agent = AgentTable(
id=uuid4(),
name="Dev",
slug=f"be-dev-{uuid4().hex[:8]}",
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
status=AgentStatus.ACTIVE,
model_config={},
system_prompt="dev",
capabilities=[],
permissions={},
metrics={},
)
db_session.add(agent)
await db_session.flush()
project = ProjectTable(
id=uuid4(),
name="GitProj",
slug=f"git-proj-{uuid4().hex[:6]}",
git_url="https://example.com/r.git",
assigned_cell=Team.BACKEND,
created_by=agent.id,
)
db_session.add(project)
await db_session.flush()
app = FastAPI()
app.include_router(git_router, prefix="/api/git")
async def _override_db() -> AsyncGenerator[AsyncSession]:
yield db_session
async def _override_agent() -> AgentContext:
return AgentContext(
agent_id=cast("uuid.UUID", agent.id),
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
)
app.dependency_overrides[get_db] = _override_db
app.dependency_overrides[get_agent_context] = _override_agent
transport = ASGITransport(app=app)
async with AsyncClient(transport=transport, base_url="http://test") as client:
yield {"client": client, "agent": agent, "project": project, "db": db_session}
app.dependency_overrides.clear()
@pytest_asyncio.fixture
async def pm_git_client(
db_session: AsyncSession,
) -> AsyncIterator[dict]:
"""Like git_client but with CELL_PM role — required for the rebase endpoint."""
agent = AgentTable(
id=uuid4(),
name="PM",
slug=f"be-pm-{uuid4().hex[:8]}",
role=AgentRole.CELL_PM,
team=Team.BACKEND,
status=AgentStatus.ACTIVE,
model_config={},
system_prompt="pm",
capabilities=[],
permissions={},
metrics={},
)
db_session.add(agent)
await db_session.flush()
project = ProjectTable(
id=uuid4(),
name="GitProj",
slug=f"git-proj-{uuid4().hex[:6]}",
git_url="https://example.com/r.git",
assigned_cell=Team.BACKEND,
created_by=agent.id,
)
db_session.add(project)
await db_session.flush()
app = FastAPI()
app.include_router(git_router, prefix="/api/git")
async def _override_db() -> AsyncGenerator[AsyncSession]:
yield db_session
async def _override_agent() -> AgentContext:
return AgentContext(
agent_id=cast("uuid.UUID", agent.id),
role=AgentRole.CELL_PM,
team=Team.BACKEND,
)
app.dependency_overrides[get_db] = _override_db
app.dependency_overrides[get_agent_context] = _override_agent
transport = ASGITransport(app=app)
async with AsyncClient(transport=transport, base_url="http://test") as client:
yield {"client": client, "agent": agent, "project": project, "db": db_session}
app.dependency_overrides.clear()
_HDR = {"X-Agent-ID": str(uuid4()), "X-Agent-Role": "developer"}
# ---------------------------------------------------------------------------
# project resolution
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_status_project_not_found(git_client: dict) -> None:
response = await git_client["client"].get(
"/api/git/status?project_slug=ghost-project", headers=_HDR
)
assert response.status_code == HTTPStatus.NOT_FOUND
# ---------------------------------------------------------------------------
# get_git_status
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_status_success(git_client: dict) -> None:
workspace = "/tmp/ws"
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value=workspace)
svc.get_status = AsyncMock(return_value=("main", False, [], [], [], 0, 0))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/status?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_status_validation_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(side_effect=ValidationError("bad"))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/status?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.BAD_REQUEST
@pytest.mark.asyncio
async def test_status_unauthorized(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(side_effect=UnauthorizedError("nope"))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/status?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.FORBIDDEN
@pytest.mark.asyncio
async def test_status_not_found(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(side_effect=NotFoundError("missing"))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/status?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.NOT_FOUND
@pytest.mark.asyncio
async def test_status_git_timeout_directly() -> None:
"""Exercise _translate_error's GitTimeoutError branch directly.
The route uses `except ServiceError as e` from services.base, but
GitTimeoutError extends roboco.exceptions.ServiceError (different
class), so it never enters _translate_error in practice. We invoke
the helper directly to cover the branch.
"""
err = GitTimeoutError("git status", 10)
http_exc = _translate_error(err)
assert http_exc.status_code == HTTPStatus.GATEWAY_TIMEOUT
@pytest.mark.asyncio
async def test_status_git_command_error_directly() -> None:
"""Direct invocation of _translate_error's GitCommandError branch."""
err = GitCommandError("git status", "stderr")
http_exc = _translate_error(err)
assert http_exc.status_code == HTTPStatus.INTERNAL_SERVER_ERROR
# ---------------------------------------------------------------------------
# log
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_log_with_branch_success(git_client: dict) -> None:
# Fields are \x1f-delimited (not "|"): the second commit's subject contains
# a literal "|" (e.g. "curl|sh") which used to shift the split and land the
# author+date in one field, 500-ing on datetime.fromisoformat.
log_result = MagicMock()
log_result.returncode = 0
log_result.stdout = (
"abc123\x1fabc\x1ffix bug\x1fme\x1f2026-01-01T00:00:00Z\n"
"def456\x1fdef\x1fclose curl|sh RCE\x1fyou\x1f2026-01-01T00:00:01Z\n"
)
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc._run_git = AsyncMock(return_value=log_result)
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/log?project_slug={git_client['project'].slug}&branch=feature/x",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
commits = response.json()["commits"]
assert [c["message"] for c in commits] == ["fix bug", "close curl|sh RCE"]
assert [c["author"] for c in commits] == ["me", "you"]
@pytest.mark.asyncio
async def test_log_no_branch_fetches_current(git_client: dict) -> None:
log_result = MagicMock()
log_result.returncode = 0
log_result.stdout = ""
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.get_current_branch = AsyncMock(return_value="main")
svc._run_git = AsyncMock(return_value=log_result)
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/log?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_log_unknown_branch_returns_empty(git_client: dict) -> None:
log_result = MagicMock()
log_result.returncode = 1
log_result.stderr = "no such branch"
log_result.stdout = ""
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc._run_git = AsyncMock(return_value=log_result)
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/log?project_slug={git_client['project'].slug}&branch=ghost",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
assert response.json()["commits"] == []
@pytest.mark.asyncio
async def test_log_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(side_effect=NotFoundError("no ws"))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/log?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.NOT_FOUND
# ---------------------------------------------------------------------------
# branches
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_branches_local_only(git_client: dict) -> None:
branch_result = MagicMock()
branch_result.stdout = "main|abc123\nfeature/x|def456\n"
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.get_current_branch = AsyncMock(return_value="main")
svc._run_git = AsyncMock(return_value=branch_result)
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/branches?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_branches_with_remote(git_client: dict) -> None:
branch_result = MagicMock()
branch_result.stdout = "main|abc123\nremotes/origin/feature/y|def456\n"
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.get_current_branch = AsyncMock(return_value="main")
svc._run_git = AsyncMock(return_value=branch_result)
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/branches?project_slug={git_client['project'].slug}"
"&include_remote=true",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_branches_skips_empty_lines(git_client: dict) -> None:
"""Line 246: empty line in branch output triggers continue."""
branch_result = MagicMock()
# Embed an empty line between two branches.
branch_result.stdout = "main|abc\n\nfeature/x|def\n"
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.get_current_branch = AsyncMock(return_value="main")
svc._run_git = AsyncMock(return_value=branch_result)
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/branches?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_branches_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(side_effect=NotFoundError("no ws"))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/branches?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.NOT_FOUND
# ---------------------------------------------------------------------------
# diff
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_diff_basic(git_client: dict) -> None:
diff_res = MagicMock(stdout="some diff")
stat_res = MagicMock(stdout="a.py | 2\nb.py | 4\n2 files changed\n")
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc._run_git = AsyncMock(side_effect=[diff_res, stat_res])
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/diff?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_diff_staged_with_file(git_client: dict) -> None:
diff_res = MagicMock(stdout="")
stat_res = MagicMock(stdout="")
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc._run_git = AsyncMock(side_effect=[diff_res, stat_res])
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/diff?project_slug={git_client['project'].slug}"
"&staged=true&file_path=a.py",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_diff_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(side_effect=NotFoundError("no ws"))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/diff?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.NOT_FOUND
# ---------------------------------------------------------------------------
# commit
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_commit_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.commit_for_task = AsyncMock(return_value=("abc123", "msg", 1, 5, 2))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/commit",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
"message": "fix some thing",
"commit_type": "fix",
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_commit_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.commit_for_task = AsyncMock(side_effect=ValidationError("bad"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/commit",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
"message": "fix some thing",
"commit_type": "fix",
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.BAD_REQUEST
# ---------------------------------------------------------------------------
# push
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_push_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.push_for_task = AsyncMock(return_value=("feature/x", 2))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/push",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_push_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.push_for_task = AsyncMock(side_effect=NotFoundError("missing"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/push",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.NOT_FOUND
# ---------------------------------------------------------------------------
# branch/create
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_create_branch_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.create_branch_for_task = AsyncMock(
return_value=("feature/backend/X", "main")
)
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/branch/create",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"branch_type": "feature",
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_create_branch_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.create_branch_for_task = AsyncMock(side_effect=UnauthorizedError("no perm"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/branch/create",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"branch_type": "feature",
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.FORBIDDEN
# ---------------------------------------------------------------------------
# checkout
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_checkout_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.checkout_branch_for_agent = AsyncMock(return_value=None)
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/checkout",
json={
"project_slug": git_client["project"].slug,
"branch": "feature/x",
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_checkout_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.checkout_branch_for_agent = AsyncMock(side_effect=UnauthorizedError("nope"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/checkout",
json={
"project_slug": git_client["project"].slug,
"branch": "master",
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.FORBIDDEN
# ---------------------------------------------------------------------------
# pr/create
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_create_pr_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.create_pr_for_task = AsyncMock(
return_value=(42, "https://github.com/x/y/pull/42", "T", "feat", "main")
)
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pr/create",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_create_pr_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.create_pr_for_task = AsyncMock(side_effect=ValidationError("bad"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pr/create",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.BAD_REQUEST
# ---------------------------------------------------------------------------
# pr/merge
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_merge_pr_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.merge_pr_for_task = AsyncMock(return_value=("main", "abc"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pr/merge",
json={
"project_slug": git_client["project"].slug,
"pr_number": 42,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_merge_pr_service_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.merge_pr_for_task = AsyncMock(side_effect=NotFoundError("no PR"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pr/merge",
json={
"project_slug": git_client["project"].slug,
"pr_number": 42,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.NOT_FOUND
# ---------------------------------------------------------------------------
# UUID resolution path
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_status_with_uuid(git_client: dict) -> None:
"""Pass a UUID string instead of slug — should look up by UUID."""
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.get_status = AsyncMock(return_value=("main", False, [], [], [], 0, 0))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/status?project_slug={git_client['project'].id}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
# ---------------------------------------------------------------------------
# Generic ServiceError -> default 500
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_status_generic_service_error(git_client: dict) -> None:
"""Any other ServiceError becomes 500."""
class CustomError(ServiceError):
pass
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(side_effect=CustomError("err"))
mock_get.return_value = svc
response = await git_client["client"].get(
f"/api/git/status?project_slug={git_client['project'].slug}",
headers=_HDR,
)
assert response.status_code == HTTPStatus.INTERNAL_SERVER_ERROR
# ---------------------------------------------------------------------------
# pull
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_pull_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.pull = AsyncMock(return_value=("main", False, [], [], [], 0, 0))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pull",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
data = response.json()
assert data["current_branch"] == "main"
assert "ahead" in data
assert "behind" in data
assert "has_changes" in data
assert "staged_files" in data
assert "unstaged_files" in data
assert "untracked_files" in data
@pytest.mark.asyncio
async def test_pull_git_command_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.pull = AsyncMock(side_effect=GitCommandError("pull", "network error"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pull",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.INTERNAL_SERVER_ERROR
# ---------------------------------------------------------------------------
# fetch
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_fetch_success(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
_ahead = 2
_behind = 1
svc.fetch = AsyncMock(
return_value=("feature/x", True, ["a.py"], [], [], _ahead, _behind)
)
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/fetch",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
data = response.json()
assert data["current_branch"] == "feature/x"
assert data["ahead"] == _ahead
assert data["behind"] == _behind
assert data["has_changes"] is True
assert "staged_files" in data
assert "unstaged_files" in data
assert "untracked_files" in data
@pytest.mark.asyncio
async def test_fetch_git_command_error(git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.fetch = AsyncMock(side_effect=GitCommandError("fetch", "network error"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/fetch",
json={
"project_slug": git_client["project"].slug,
"task_id": str(uuid4()),
"agent_id": str(uuid4()),
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.INTERNAL_SERVER_ERROR
# ---------------------------------------------------------------------------
# rebase
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_rebase_success(pm_git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.rebase = AsyncMock(return_value=(False, []))
mock_get.return_value = svc
response = await pm_git_client["client"].post(
"/api/git/rebase",
json={
"project_slug": pm_git_client["project"].slug,
"target_branch": "develop",
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
data = response.json()
assert data["conflict"] is False
assert data["conflicted_files"] == []
@pytest.mark.asyncio
async def test_rebase_conflict(pm_git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.rebase = AsyncMock(return_value=(True, ["src/foo.py", "src/bar.py"]))
mock_get.return_value = svc
response = await pm_git_client["client"].post(
"/api/git/rebase",
json={
"project_slug": pm_git_client["project"].slug,
"target_branch": "develop",
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.OK
data = response.json()
assert data["conflict"] is True
assert data["conflicted_files"] == ["src/foo.py", "src/bar.py"]
@pytest.mark.asyncio
async def test_rebase_git_command_error(pm_git_client: dict) -> None:
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.get_workspace = AsyncMock(return_value="/tmp/ws")
svc.rebase = AsyncMock(side_effect=GitCommandError("rebase", "fatal error"))
mock_get.return_value = svc
response = await pm_git_client["client"].post(
"/api/git/rebase",
json={
"project_slug": pm_git_client["project"].slug,
"target_branch": "develop",
},
headers=_HDR,
)
assert response.status_code == HTTPStatus.INTERNAL_SERVER_ERROR
# ---------------------------------------------------------------------------
# task_id Optional — no 422 when task_id is omitted
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_commit_without_task_id_no_422(git_client: dict) -> None:
"""POST /commit without task_id must not return 422 (schema validation error)."""
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.commit_for_task = AsyncMock(
return_value=("abc123", "feat: add thing", 1, 5, 2)
)
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/commit",
json={
"project_slug": git_client["project"].slug,
"agent_id": str(uuid4()),
"message": "add a new thing",
"commit_type": "feat",
},
headers=_HDR,
)
assert response.status_code != HTTPStatus.UNPROCESSABLE_ENTITY
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_push_without_task_id_no_422(git_client: dict) -> None:
"""POST /push without task_id must not return 422 (schema validation error)."""
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.push_for_task = AsyncMock(return_value=("feature/x", 3))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/push",
json={
"project_slug": git_client["project"].slug,
},
headers=_HDR,
)
assert response.status_code != HTTPStatus.UNPROCESSABLE_ENTITY
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_create_pr_without_task_id_no_422(git_client: dict) -> None:
"""POST /pr/create without task_id must not return 422 (schema validation error)."""
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.create_pr_for_task = AsyncMock(
return_value=(
7,
"https://github.com/x/y/pull/7",
"feat: add thing",
"feat/x",
"main",
)
)
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pr/create",
json={
"project_slug": git_client["project"].slug,
},
headers=_HDR,
)
assert response.status_code != HTTPStatus.UNPROCESSABLE_ENTITY
assert response.status_code == HTTPStatus.OK
@pytest.mark.asyncio
async def test_merge_pr_without_task_id_no_422(git_client: dict) -> None:
"""POST /pr/merge without task_id must not return 422 (schema validation error)."""
with patch("roboco.api.routes.git.get_git_service") as mock_get:
svc = AsyncMock()
svc.merge_pr_for_task = AsyncMock(return_value=("main", "deadbeef"))
mock_get.return_value = svc
response = await git_client["client"].post(
"/api/git/pr/merge",
json={
"project_slug": git_client["project"].slug,
"pr_number": 99,
},
headers=_HDR,
)
assert response.status_code != HTTPStatus.UNPROCESSABLE_ENTITY
assert response.status_code == HTTPStatus.OK
# Re-export to keep import alive (TC reorders imports)
_ = SimpleNamespace