mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154) * [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py - Create tests/__init__.py as empty package marker - Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py - Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py - Add return type annotations to _stub_get_optimal, _source, and factory functions - Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin - Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub - Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py - Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object - All 487 source files pass mypy with 0 errors; 2312 unit tests pass * [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/ Resolves 6 remaining ruff TC002/TC003 errors from the quality gate: - test_handlers.py: Iterator → TYPE_CHECKING - test_quality_gate.py: pathlib → TYPE_CHECKING - test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING - test_streaming.py: Iterator → TYPE_CHECKING - test_notification.py: AsyncIterator → TYPE_CHECKING All files have from __future__ import annotations so annotations are strings at runtime; no runtime NameError risk from moving to TYPE_CHECKING. * [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files * [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets --------- * [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155) * [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/ - Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.) - Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches - Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py - Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/ - No runtime logic changed — annotations and cast() only * [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate - Quote all cast() type arguments per ruff TC006 rule (cast("T", x)) - Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form) - Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.) - No runtime logic changed — annotation-only changeset * [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only) The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast targets already check `roboco/ tests/` — the lint target now matches gate scope. --------- --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
259 lines
6.8 KiB
Python
259 lines
6.8 KiB
Python
"""query_helpers coverage."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
from datetime import UTC, datetime, timedelta
|
|
from typing import TYPE_CHECKING, cast
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.db.tables import AgentTable
|
|
from roboco.models import AgentRole, AgentStatus, Team
|
|
from roboco.services.repositories.query_helpers import (
|
|
agent_id_filter,
|
|
days_ago,
|
|
get_agent_by_slug,
|
|
get_agent_slug,
|
|
pagination,
|
|
resolve_agent_identity,
|
|
resolve_agent_uuid,
|
|
status_filter,
|
|
team_filter,
|
|
timestamp_filter,
|
|
)
|
|
from sqlalchemy import select
|
|
|
|
if TYPE_CHECKING:
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Pure query-builder helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_days_ago_returns_past_datetime() -> None:
|
|
out = days_ago(7)
|
|
assert out < datetime.now(UTC)
|
|
assert (datetime.now(UTC) - out) >= timedelta(days=6)
|
|
|
|
|
|
def test_pagination_applies_limit_offset() -> None:
|
|
q = select(AgentTable)
|
|
out = pagination(q, limit=10, offset=20)
|
|
# SQLAlchemy compiles the query; we just verify it doesn't crash.
|
|
assert out is not None
|
|
|
|
|
|
def test_status_filter_passes_through_when_none() -> None:
|
|
q = select(AgentTable)
|
|
assert status_filter(q, AgentTable, None) is q
|
|
|
|
|
|
def test_status_filter_applies_when_provided() -> None:
|
|
q = select(AgentTable)
|
|
out = status_filter(q, AgentTable, AgentStatus.ACTIVE)
|
|
assert out is not q # Different query.
|
|
|
|
|
|
def test_team_filter_passes_through_when_none() -> None:
|
|
q = select(AgentTable)
|
|
assert team_filter(q, AgentTable, None) is q
|
|
|
|
|
|
def test_team_filter_applies_when_provided() -> None:
|
|
q = select(AgentTable)
|
|
out = team_filter(q, AgentTable, Team.BACKEND)
|
|
assert out is not q
|
|
|
|
|
|
def test_agent_id_filter_passes_through_when_none() -> None:
|
|
q = select(AgentTable)
|
|
assert agent_id_filter(q, AgentTable, None) is q
|
|
|
|
|
|
def test_agent_id_filter_applies_when_provided() -> None:
|
|
q = select(AgentTable)
|
|
out = agent_id_filter(q, AgentTable, uuid4(), field_name="id")
|
|
assert out is not q
|
|
|
|
|
|
def test_timestamp_filter_with_since_and_until() -> None:
|
|
q = select(AgentTable)
|
|
out = timestamp_filter(
|
|
q,
|
|
AgentTable,
|
|
since=days_ago(7),
|
|
until=datetime.now(UTC),
|
|
)
|
|
assert out is not q
|
|
|
|
|
|
def test_timestamp_filter_no_args_unchanged() -> None:
|
|
q = select(AgentTable)
|
|
out = timestamp_filter(q, AgentTable)
|
|
# No filter applied.
|
|
assert out is q
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Async DB resolvers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_agent_uuid_with_uuid_string(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
aid = uuid4()
|
|
resolved = await resolve_agent_uuid(db_session, str(aid))
|
|
assert resolved == aid
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_agent_uuid_with_slug(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"q-dev-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
resolved = await resolve_agent_uuid(db_session, agent.slug)
|
|
assert resolved == agent.id
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_agent_uuid_with_unknown_slug(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
assert await resolve_agent_uuid(db_session, "ghost-slug") is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_agent_identity_with_slug(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"q-id-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
out = await resolve_agent_identity(db_session, agent.slug)
|
|
assert out is not None
|
|
assert out[0] == agent.id
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_agent_identity_unknown(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
assert await resolve_agent_identity(db_session, "ghost") is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_agent_identity_unknown_uuid(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
assert await resolve_agent_identity(db_session, str(uuid4())) is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resolve_agent_identity_with_uuid(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
"""Line 215: passing a UUID resolves to (UUID, slug) tuple."""
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"q-uuid-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
out = await resolve_agent_identity(db_session, str(agent.id))
|
|
assert out is not None
|
|
assert out[0] == agent.id
|
|
assert out[1] == agent.slug
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_agent_slug_known(db_session: AsyncSession) -> None:
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"slug-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
slug = await get_agent_slug(db_session, cast("uuid.UUID", agent.id))
|
|
assert slug == agent.slug
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_agent_slug_missing(db_session: AsyncSession) -> None:
|
|
assert await get_agent_slug(db_session, uuid4()) is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_agent_by_slug(db_session: AsyncSession) -> None:
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"by-slug-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
fetched = await get_agent_by_slug(db_session, agent.slug)
|
|
assert fetched is not None
|
|
assert fetched.id == agent.id
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_agent_by_slug_missing(db_session: AsyncSession) -> None:
|
|
assert await get_agent_by_slug(db_session, "ghost-slug") is None
|