mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
4d4bf084c5
Convention: no type:ignore/noqa, and pre-existing violations still violate. The make-quality gate runs 'mypy roboco/ tests/', but the prior commits' gates only ran mypy on production files, masking 64 type errors across 15 test files (method-assign, unused-ignore, no-untyped-def, attr-defined, union-attr, has-type, index, misc). Fixed without any type:ignore: - method-assign (svc.session.X = / svc.method = AsyncMock()): hold a local 'session: MagicMock'/'AsyncMock' and assert on it, or stub via object.__setattr__ / monkeypatch / a typed '_bind' helper returning Any, or alias 'cc: Any = c' (the pattern the file already used). - unused 'type: ignore[assignment]' (real code was method-assign): removed; replaced with the no-suppression patterns above. - 'Callable[...] has no attribute assert_*': keep a typed local ref to the AsyncMock and assert on the local, not the method-typed attr. - no-untyped-def: annotate helper params (Any / pytest.MonkeyPatch). - attr-defined / index / union-attr: type the helper as Any, narrow with an 'is not None' assert, or add the missing attr to a fake. - has-type / return-value: fix the declared return type to the tuple the function actually returns. - PLC0415 inline imports: hoisted to top-level. test_pr_gate_notifies_pm._stub_gate_path converted fully to the 'cc: Any = c' alias (it already used it for one attr) so its five '# type: ignore[method-assign]' suppressions are gone. mypy tests/: 64 errors -> 0 (538 files). ruff check tests/: clean. All 84 tests in the touched files pass.
79 lines
3.1 KiB
Python
79 lines
3.1 KiB
Python
"""F053: _token_for_project must log a Fernet decryption failure with the
|
|
project context, not swallow it silently as 'no token'.
|
|
|
|
On an encryption-key rotation the stored PAT (encrypted with the old key) can't
|
|
be decrypted — ``crypto.decrypt_token`` raises ``EncryptionError``. The
|
|
crypto layer logs a generic message, but ``_token_for_project`` catches the
|
|
``EncryptionError`` and returns ``None`` with no project context, so every
|
|
best-effort workspace git op (push, PR, clone-with-token) silently looks like
|
|
'this project has no token' — indistinguishable from a project that genuinely
|
|
never set one. The operator can't tell which project is wedged by a key
|
|
rotation. Log the failure with the project slug before returning None (the
|
|
best-effort skip behavior is preserved — this only makes the cause
|
|
diagnosable).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from roboco.services.git import GitService
|
|
from roboco.utils.crypto import EncryptionError
|
|
from structlog.testing import capture_logs
|
|
|
|
_PROJECT_SLUG = "acme-backend"
|
|
|
|
|
|
def _svc() -> GitService:
|
|
return GitService(MagicMock())
|
|
|
|
|
|
def _patch_project_service_raising(exc: Exception) -> Any:
|
|
fake_service = MagicMock()
|
|
fake_service.get_decrypted_token_by_slug = AsyncMock(side_effect=exc)
|
|
return patch("roboco.services.git.get_project_service", return_value=fake_service)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_decryption_failure_logged_with_project_slug() -> None:
|
|
"""An EncryptionError (key rotation) is logged with the project slug so the
|
|
operator can tell WHICH project is wedged — not silently masked as 'no
|
|
token'."""
|
|
svc = _svc()
|
|
with (
|
|
_patch_project_service_raising(
|
|
EncryptionError("Unable to decrypt token - encryption key may have changed")
|
|
),
|
|
capture_logs() as logs,
|
|
):
|
|
result = await svc._token_for_project(_PROJECT_SLUG)
|
|
|
|
# Best-effort behavior preserved: returns None (callers skip remote ops).
|
|
assert result is None
|
|
# ... but the failure is loud + project-scoped, not silent.
|
|
error_logs = [e for e in logs if e["log_level"] == "error"]
|
|
assert error_logs, "decryption failure must be logged at error level"
|
|
log = error_logs[0]
|
|
assert "decrypt" in log["event"].lower() or "token" in log["event"].lower()
|
|
assert log.get("project_slug") == _PROJECT_SLUG or _PROJECT_SLUG in str(log)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_missing_token_returns_none_silently() -> None:
|
|
"""A project that genuinely has no token (None, no exception) returns None
|
|
with NO error log — the fix must not over-log the legitimate no-token
|
|
case (regression guard)."""
|
|
svc = _svc()
|
|
fake_service = MagicMock()
|
|
fake_service.get_decrypted_token_by_slug = AsyncMock(return_value=None)
|
|
with (
|
|
patch("roboco.services.git.get_project_service", return_value=fake_service),
|
|
capture_logs() as logs,
|
|
):
|
|
result = await svc._token_for_project(_PROJECT_SLUG)
|
|
|
|
assert result is None
|
|
assert not [e for e in logs if e["log_level"] == "error"]
|