mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
fdfdc23b72
An agent's make quality runs against no Postgres, so the conftest skips every integration test and coverage collapses far below the 80% threshold — a self-hosted PM read 71% on a suite that is ~96% with a DB and chased it as a code regression. _append_gate_env now injects ROBOCO_TEST_DB_* (host/port/user/password/admin-db) from the orchestrator's own DB settings into each spawn; agents share the Docker network so the host resolves, and the conftest creates throwaway test databases isolated from the live one. The app runtime reads ROBOCO_DATABASE_*, never ROBOCO_TEST_DB_*, so this only feeds the test harness. Gated on toolchain_match_enabled, the faithful-gate flag.
41 lines
1.5 KiB
Python
41 lines
1.5 KiB
Python
"""Faithful-gate env injection.
|
|
|
|
An agent's gate (`make quality` / pytest) needs a reachable Postgres or the
|
|
conftest skips every DB-backed integration test and coverage collapses far
|
|
below the threshold — a hollow gate. `_append_gate_env` injects the test-DB
|
|
connection (from the orchestrator's own settings) so the agent runs the real
|
|
suite, gated on the same faithful-gate flag as interpreter matching.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from roboco.config import settings
|
|
from roboco.runtime.orchestrator import AgentOrchestrator
|
|
|
|
if TYPE_CHECKING:
|
|
import pytest
|
|
|
|
|
|
def test_gate_env_injects_test_db_when_flag_on(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(settings, "toolchain_match_enabled", True)
|
|
monkeypatch.setattr(settings, "database_host", "roboco-postgres")
|
|
monkeypatch.setattr(settings, "database_port", 5432)
|
|
monkeypatch.setattr(settings, "database_user", "roboco")
|
|
monkeypatch.setattr(settings, "database_password", "s3cret")
|
|
cmd: list[str] = []
|
|
AgentOrchestrator._append_gate_env(cmd)
|
|
assert "ROBOCO_TEST_DB_HOST=roboco-postgres" in cmd
|
|
assert "ROBOCO_TEST_DB_PORT=5432" in cmd
|
|
assert "ROBOCO_TEST_DB_USER=roboco" in cmd
|
|
assert "ROBOCO_TEST_DB_PASSWORD=s3cret" in cmd
|
|
assert "ROBOCO_TEST_DB_ADMIN_DB=postgres" in cmd
|
|
|
|
|
|
def test_gate_env_inert_when_flag_off(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(settings, "toolchain_match_enabled", False)
|
|
cmd: list[str] = []
|
|
AgentOrchestrator._append_gate_env(cmd)
|
|
assert cmd == []
|