mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
47d78f50ee
* feat(sandbox): on-demand request_sandbox verb replaces eager provisioning Sandboxes were provisioned at every agent spawn for opted-in projects, so every role paid the sidecar spin-up and a provisioning failure refused the spawn. Provisioning now happens when an agent asks: the request_sandbox do-verb (dev + QA) reaches the orchestrator through ContentActionsDeps, ensure_sandbox provisions idempotently with an in-memory per-agent cache (evicted at teardown and janitor sweep), and creds return in the envelope payload including ready-to-export ROBOCO_TEST_* values. Spawn now only injects a marker env naming the available services plus a briefing line; sandbox failures can no longer refuse a spawn. Teardown lifecycle unchanged. * feat(sandbox): harden request_sandbox + Phase 3 wiring proof and docs Hardening from adversarial review: ensure_sandbox now provisions the project's full opted-in set on first request (a later superset can never tear down a live sandbox mid-use), serializes per-agent behind an asyncio lock (a client timeout-retry no longer races its own in-flight provision), and verifies container liveness on every cache hit (a dead sandbox evicts and re-provisions instead of serving dead creds). MCP client budget 720->1080s for the full-set cold case. Phase 3: e2e smoke wiring test (manifest grants + guard-chain envelopes over the real API), sandbox-db/tools/map docs and CLAUDE.md rewritten for on-demand. * feat(sandbox): release sandboxes when the agent's work ends CEO directive: sidecars must not dangle once the agent is done. The six work-ending verbs (i_am_done, unclaim, i_am_idle, pass_review, fail_review, i_documented) now release the caller's sandbox best-effort on their success path via release_sandbox (lock + teardown + cache evict; a no-sandbox agent costs a dict lookup). Container removal and the janitor remain the backstop; a re-request provisions fresh. * test(sandbox): monkeypatch the release hook instead of method assignment mypy method-assign rejected the direct AsyncMock assignments; the prior static gate ran before this test file landed. * test(sandbox): guard envelope evidence for mypy in verb tests * chore(prompts): regenerate verb tables for request_sandbox * chore: resolve merge with master (breadcrumbs + statement budget) --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
290 lines
10 KiB
Python
290 lines
10 KiB
Python
"""ContentActions.request_sandbox — the on-demand sandbox DB/Redis/Mongo verb.
|
|
|
|
Guard matrix (flag off / no active task / no project / not opted in / subset
|
|
violation / orchestrator unavailable), the success envelope payload shape, and
|
|
cross-agent isolation (ensure_sandbox is always called with the CALLER's own
|
|
resolved slug, never another agent's).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.config import settings
|
|
from roboco.models.sandbox import SandboxConnection, SandboxInfo
|
|
from roboco.runtime.sandbox import SandboxProvisionError
|
|
from roboco.services.gateway.content_actions import ContentActions, ContentActionsDeps
|
|
|
|
|
|
def _make_actions(
|
|
*,
|
|
task_obj: MagicMock | None,
|
|
orchestrator: AsyncMock | None,
|
|
) -> tuple[ContentActions, MagicMock]:
|
|
task = AsyncMock()
|
|
task.get_active_task_for_agent.return_value = task_obj
|
|
task.session = MagicMock()
|
|
deps = ContentActionsDeps(
|
|
task=task,
|
|
git=MagicMock(),
|
|
a2a=MagicMock(),
|
|
journal=MagicMock(),
|
|
workspace=MagicMock(),
|
|
notifications=MagicMock(),
|
|
orchestrator=orchestrator,
|
|
)
|
|
return ContentActions(deps), task
|
|
|
|
|
|
def _task(project_id: object | None = uuid4()) -> MagicMock:
|
|
t = MagicMock()
|
|
t.id = uuid4()
|
|
t.project_id = project_id
|
|
t.status = "in_progress"
|
|
return t
|
|
|
|
|
|
def _stub_project(monkeypatch: pytest.MonkeyPatch, services: list[str] | None) -> None:
|
|
project = MagicMock(sandbox_services=services)
|
|
project_service = MagicMock()
|
|
project_service.get = AsyncMock(return_value=project)
|
|
monkeypatch.setattr(
|
|
"roboco.services.project.get_project_service", lambda _s: project_service
|
|
)
|
|
|
|
|
|
def _sandbox_info() -> SandboxInfo:
|
|
return SandboxInfo(
|
|
services={
|
|
"postgres": SandboxConnection(
|
|
host="roboco-sandbox-pg-dev-1",
|
|
port=5432,
|
|
password="pw",
|
|
user="sandbox",
|
|
database="sandbox",
|
|
)
|
|
}
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Guard matrix
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_flag_off_refuses_before_task_lookup(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", False)
|
|
actions, task = _make_actions(task_obj=None, orchestrator=None)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
assert env.error == "invalid_state"
|
|
task.get_active_task_for_agent.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_no_active_task_refused(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
actions, _task_svc = _make_actions(task_obj=None, orchestrator=None)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
assert env.error == "invalid_state"
|
|
assert "give_me_work" in (env.remediate or "")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_task_without_project_refused(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
actions, _task_svc = _make_actions(
|
|
task_obj=_task(project_id=None), orchestrator=None
|
|
)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
assert env.error == "invalid_state"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_project_not_opted_in_refused(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=None)
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=None)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
assert env.error == "invalid_state"
|
|
assert "not opted" in (env.message or "")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_requested_service_outside_opted_set_names_allowed_set(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres"])
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=None)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4(), services=["redis"])
|
|
|
|
assert env.error == "invalid_state"
|
|
assert "postgres" in (env.remediate or "")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_orchestrator_unavailable_is_retryable(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres"])
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=None)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
assert env.error == "invalid_state"
|
|
assert "retry" in (env.remediate or "").lower()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_provision_failure_surfaces_as_retryable_invalid_state(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres"])
|
|
orch = AsyncMock()
|
|
orch.ensure_sandbox.side_effect = SandboxProvisionError("image pull failed")
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=orch)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
assert env.error == "invalid_state"
|
|
assert "provisioning failed" in (env.message or "")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Success path — envelope payload shape
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_success_returns_creds_in_evidence_with_env_subdict(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres"])
|
|
orch = AsyncMock()
|
|
orch.ensure_sandbox.return_value = _sandbox_info()
|
|
actions, task_svc = _make_actions(task_obj=_task(), orchestrator=orch)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
expected_port = 5432
|
|
assert env.error is None
|
|
assert env.evidence is not None
|
|
payload = env.evidence["postgres"]
|
|
assert payload["host"] == "roboco-sandbox-pg-dev-1"
|
|
assert payload["port"] == expected_port
|
|
assert payload["user"] == "sandbox"
|
|
assert payload["password"] == "pw"
|
|
assert payload["database"] == "sandbox"
|
|
assert payload["env"]["ROBOCO_TEST_DB_HOST"] == "roboco-sandbox-pg-dev-1"
|
|
assert payload["env"]["ROBOCO_TEST_DB_PASSWORD"] == "pw"
|
|
task_svc.heartbeat.assert_awaited_once()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_omitted_services_requests_full_opted_set(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres", "redis"])
|
|
orch = AsyncMock()
|
|
orch.ensure_sandbox.return_value = _sandbox_info()
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=orch)
|
|
|
|
await actions.request_sandbox(agent_id=uuid4())
|
|
|
|
orch.ensure_sandbox.assert_awaited_once()
|
|
called_services = orch.ensure_sandbox.call_args.args[1]
|
|
assert sorted(called_services) == ["postgres", "redis"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_ensure_sandbox_called_with_full_opted_set_not_just_requested(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
"""DEFECT 1 fix: the verb always passes the project's whole opted-in set
|
|
(not just this call's ``services`` subset) as ensure_sandbox's ``opted``
|
|
argument, so a superset request later in the session can never trigger a
|
|
fresh provision() that tears down the agent's live sandbox."""
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres", "redis"])
|
|
orch = AsyncMock()
|
|
orch.ensure_sandbox.return_value = _sandbox_info()
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=orch)
|
|
|
|
await actions.request_sandbox(agent_id=uuid4(), services=["postgres"])
|
|
|
|
called_requested = orch.ensure_sandbox.call_args.args[1]
|
|
called_opted = orch.ensure_sandbox.call_args.args[2]
|
|
assert called_requested == ["postgres"]
|
|
assert sorted(called_opted) == ["postgres", "redis"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_response_payload_filtered_to_requested_services(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
"""`ensure_sandbox` provisions the full opted set under the hood; the
|
|
verb's response only surfaces what THIS call actually asked for."""
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres", "redis"])
|
|
orch = AsyncMock()
|
|
orch.ensure_sandbox.return_value = SandboxInfo(
|
|
services={
|
|
"postgres": SandboxConnection(
|
|
host="h", port=5432, password="pw", user="sandbox", database="sandbox"
|
|
),
|
|
"redis": SandboxConnection(host="h", port=6379, password="rw"),
|
|
}
|
|
)
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=orch)
|
|
|
|
env = await actions.request_sandbox(agent_id=uuid4(), services=["postgres"])
|
|
|
|
assert env.error is None
|
|
assert env.evidence is not None
|
|
assert set(env.evidence) == {"postgres"}
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Cross-agent isolation
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_ensure_sandbox_keyed_off_caller_own_slug(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
"""Two different callers resolve to two different ensure_sandbox slugs —
|
|
a caller can never reach another agent's cached sandbox."""
|
|
monkeypatch.setattr(settings, "sandbox_db_enabled", True)
|
|
_stub_project(monkeypatch, services=["postgres"])
|
|
orch = AsyncMock()
|
|
orch.ensure_sandbox.return_value = _sandbox_info()
|
|
actions, _task_svc = _make_actions(task_obj=_task(), orchestrator=orch)
|
|
|
|
agent_a, agent_b = uuid4(), uuid4()
|
|
await actions.request_sandbox(agent_id=agent_a)
|
|
await actions.request_sandbox(agent_id=agent_b)
|
|
|
|
slugs_called = [c.args[0] for c in orch.ensure_sandbox.call_args_list]
|
|
assert slugs_called[0] != slugs_called[1]
|
|
assert slugs_called[0] == str(agent_a)
|
|
assert slugs_called[1] == str(agent_b)
|