mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* feat(goals): company charter singleton — data layer (Business Goals slice 1)
First slice of the company-in-a-box "Business Goals" phase: a single CEO-owned
charter row (north star + objectives + constraints + operating policy) that
will be injected into every agent's context_briefing so all work is goal-aware.
- CompanyGoalsTable: singleton table (all-zeros id), JSON objectives /
constraints / operating_policy, updated_at / updated_by.
- migration 032: create + seed the singleton row (offline-renderable; column
server-defaults fill an INSERT of just the id).
- CompanyGoalsService: get() (empty defaults when unset) + upsert() (singleton,
partial update, caller commits).
- tests: empty defaults, roundtrip, singleton + partial-update preservation.
Next slices (mapped, not yet built): briefing injection (BriefingInputs +
build_context_briefing + EvidenceRepo), API route (GET any / PUT CEO-only),
panel /goals page, and base/Board/PM prompt mentions.
* feat(goals): inject the company charter into every agent briefing (slice 2)
The charter is now goal-aware context for every agent:
- BriefingInputs gains company_goals; build_context_briefing surfaces it.
- EvidenceRepo.company_goals(): single-row lookup returning a COMPACT charter
(north star + objectives + constraints + operating policy; audit columns
dropped, lists capped) or None when unset, so an empty charter never bloats
the per-verb briefing.
- _briefing_for wires it into every context_briefing.
Tests: briefing surfaces company_goals (defaults None); repo returns None for an
absent/empty charter and the compact dict when set.
* feat(goals): company charter API — GET any agent, PUT CEO-only (slice 3)
- routes/company_goals.py: GET returns the charter (any authenticated agent —
it drives every briefing); PUT is CEO-only (403 otherwise), partial update via
model_dump(exclude_unset=True), explicit commit.
- schemas/company_goals.py: response + partial-update models.
- registered at /api/company-goals.
- tests: GET open to any role, CEO update persists + is readable, non-CEO 403.
* feat(goals): make the company charter actionable in agent prompts (slice 5)
Agents already receive company_goals in the briefing (slice 2); now tell them to
act on it:
- base.md: universal "Align with the company charter" section — favour work and
trade-offs that advance the objectives, honour the constraints, flag conflicts;
never a license to leave your role.
- board / main_pm / cell_pm: role-specific lines tying triage / cell-routing /
subtask decomposition to the charter.
Prompts are composed at spawn from base.md + roles/*.md directly (compose_prompt),
so no _generated regeneration is needed.
* feat(goals): company charter panel page (slice 4)
CEO-facing editor for the charter at /company-goals:
- lib/api/company-goals.ts: get / update (PUT) client.
- company-goals-card.tsx: edit north star + constraints (one per line) +
objectives / operating_policy (JSON, parsed + validated with toast errors);
display derives from server state (no set-state-in-effect).
- (dashboard)/company-goals/page.tsx + a "Company Goals" sidebar nav link.
tsc --noEmit + eslint clean. Completes Phase 1 (Business Goals): data, briefing
injection, API, prompts, panel.
* fix(test): make test_app route assertions robust to FastAPI 0.137 _IncludedRouter
FastAPI 0.137 stopped flattening include_router into app.routes — each include is
now an _IncludedRouter (a BaseRoute with no .path), so `{r.path for r in
app.routes}` raised AttributeError and the two router-registration tests failed
(the bump arrived via the claude-agent-sdk update in uv.lock). Add
_registered_paths(): OpenAPI schema paths (the stable public contract) plus each
included router's prefix, which also covers the websocket /ws mount (never in the
schema). Drops the now-incorrect type: ignore[attr-defined].
* feat(research): pluggable web search/fetch for Board + PM agents
Add a provider-agnostic web-research capability so the Board and PMs can
ground decisions in current external evidence the knowledge base can't
answer.
- ResearchService selects a provider adapter from config: Tavily, Brave,
and Exa adapters plus a NullProvider that degrades gracefully when no
key is set. Result count and fetched-content size are clamped to caps.
- /api/research/search and /api/research/fetch: role-gated to Board + PMs
(and the CEO), with a per-agent/day Redis quota that fails open.
- roboco-search MCP server (web_search / web_fetch) calls those routes;
the provider key stays server-side and agent containers never egress.
Mounted per role by the orchestrator, behind a master switch.
- Charter-aware prompt guidance for Board, Main PM, and Cell PM.
Additive: with no key configured it is a no-op and the existing delivery
lifecycle is unchanged.
* feat(pitch): Board pitch -> CEO approve -> auto-provision repos
Add an additive origination path so a product can be proposed, approved,
and stood up without manual repo/Project setup.
- Pitch entity + migration (pitches table); PitchService create/list/
reject/approve.
- GitHubProvisioningService: the one place that creates repos (POST
/orgs/{org}/repos). Server-side token/org; when unconfigured the whole
approve path is inert and nothing is created.
- On approval: provision one repo per target cell, register a Project per
repo, create a Product when multi-cell, and seed one Main-PM delivery
task — all reusing the existing Product / coordination-task machinery.
- /api/pitches: Board authors (PO/HoM), CEO approves/rejects, Board+PM+CEO
view. Errors mapped via a single translator.
Additive: the delivery lifecycle is untouched; with no provisioning token
the capability is a no-op. Agent-facing pitch tool + panel are follow-ups.
* feat(strategy): dormant autonomous strategy engine (engine 2)
Add a second, optional engine that watches the company against its
standing goals and surfaces what needs the CEO — without touching the
delivery lifecycle (engine 1).
- StrategyEngine.assess() reports observations: the company is idle while
goals stand, and tasks stranded in 'blocked' past a threshold.
- run_cycle() notifies the CEO (notify-only; it never spends, builds, or
auto-approves — originating work stays a CEO decision).
- Orchestrator runs it on its own interval, started/stopped with the other
background loops; the loop returns immediately unless enabled.
DORMANT by default (strategy_engine_enabled=False): the loop never runs and
a standard deployment is unchanged. Auto-origination is a further opt-in.
* docs(changelog): record Business Goals, Web Research, Pitch->Provision, and the dormant strategy engine under Unreleased
* feat(secretary): wire the Secretary role end-to-end (foundation)
Add SECRETARY as a distinct role — the CEO's conversational chief-of-staff,
governed separately from the Prompter (which stays read-only/human-only).
This is the role foundation only; authority, the live agent, and the panel
land in following commits.
- foundation/identity: Role.SECRETARY (board level), seeded secretary-1 agent,
role-level mapping.
- journaling read tier (ALL — it advises the CEO), role_config entry,
per-role model (opus), prompt-layer mapping + roles/secretary.md.
- i_am_idle gains SECRETARY so the role has a verb surface.
- migration 034: add 'secretary' to the agentrole enum (mirrors 025).
- Role-registry tests updated for the new role.
Inert by itself (nothing spawns it yet); additive — existing roles unchanged.
* feat(secretary): directives + gate-list authority (backend)
The Secretary acts only under CEO command. Low-risk directives (relay a
dictated message) execute immediately; high-impact ones — charter edits,
task start/cancel/override, pitch approval, announcements — are recorded
pending and run only after the CEO confirms (the gate list).
- secretary_directives table (migration 035) as the command audit + queue.
- SecretaryService: read company state; submit (direct->run, gated->queue +
notify CEO); confirm/reject; execution runs with the CEO as actor through
the existing services (the Secretary never holds CEO authority itself).
- /api/secretary: submit + state/task reads (Secretary or CEO); list/confirm/
reject (CEO only). Writes commit explicitly.
* feat(secretary): live conversational agent (container + bridge)
Stand up the Secretary as a persistent Claude-SDK container the CEO chats
with, mirroring the Intake agent and reusing its driver/session machinery.
- secretary_driver: build_secretary_options exposes read_company_state /
read_task / submit_directive as SDK tools that call /api/secretary/* with
the agent's HMAC token; backend-call logic is module-level + tested.
- secretary_main: container entrypoint (receiver + relay) reusing IntakeDriver.
- orchestrator: start/spawn/reap secretary session + run-cmd builder; no
workspace clone (reads state via API), mints a role=secretary token.
- secretary_live routes: panel <-> container bridge over the live registry.
- agent-secretary image (Dockerfile + compose build service).
Inert until a session is started; additive — intake and all agents unchanged.
* feat(secretary): panel chat + directive confirmation queue
The CEO's Secretary surface: a live chat (SSE) to talk to the Secretary, and
a 'Needs your confirmation' queue listing gated directives the Secretary
proposed — each with Confirm / Reject. Adds the sidebar nav entry.
- lib/api/secretary.ts: live (start/stream/status/send/stop) + directive
(list/confirm/reject) + state clients (all as the CEO).
- hooks/use-secretary.ts: drives one chat, accumulating SSE token deltas.
- secretary page: chat pane + pending-directive cards.
Completes the Secretary end-to-end (role + authority + live agent + panel).
* feat(pitch): agent-facing pitch tool + pitches panel
Complete the pitch path: the Board can now author pitches through the gateway,
and the CEO reviews/approves them in the panel.
- content_actions.pitch (Board-only) -> PitchService.create, returning an
Envelope; wired as a do-tool (do_server + /api/v1/do/pitch + schema) and
added to the Board's do-tools.
- Panel /pitches page: lists pitches with CEO Approve & provision / Reject;
sidebar nav entry.
Pitch (Phase 4) is now end-to-end: author -> CEO approve -> auto-provision.
* feat(cockpit): read-only 'is the business winning?' summary
A pure aggregation for the CEO over existing data — no new state, no writes.
- CockpitService.summary(): charter north-star/objectives, delivery counts
(in-flight/blocked/awaiting-CEO), 30-day spend vs the charter's budget cap,
pending pitches, and the strategy engine's signals (what needs you). Stamped
basis='proxy' — performance is a proxy until real launches.
- GET /api/cockpit/summary (CEO / Board / Main PM / Secretary).
- Panel /cockpit page + sidebar nav.
Reuses goals + usage + StrategyEngine.assess(); reads only.
* docs(changelog): add the Secretary and Cockpit to Unreleased
* fix(test): isolate the company-goals empty-defaults test from committed state
The shared test DB persists committed writes across tests; a route test
commits a charter, so the unit test's 'unset' assertion must establish its
own clean precondition rather than assume global emptiness.
* fix(gateway): lower evidence_repo complexity to rank A (xenon gate)
company_goals()'s 4-way `or` emptiness check tipped the module average to
rank B; `any(...)` is equivalent and keeps the module under the gate's A bar.
* chore(compose): mirror agent-secretary-image build into docker-compose.yaml
Both compose files are byte-identical and tracked; .yaml carries the same
agent-secretary-image build service already present in docker-compose.yml.
* chore(lifecycle): regenerate artifacts for secretary i_am_idle
The secretary role gained i_am_idle in the lifecycle spec; regenerate the
generated prompt/doc/json artifacts so foundation-check stays green.
* docs(changelog): cut the company-in-a-box phases to 0.4.0
Label the six additive phases (business goals, web research, pitch-provision,
strategy engine, secretary, cockpit) as 0.4.0; tag v0.4.0 is held until the
branch merges to master so it points at the release commit.
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
225 lines
7.1 KiB
Python
225 lines
7.1 KiB
Python
"""Tier 1 — identity self-tests. Fast (no DB, no network)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from enum import IntEnum
|
|
|
|
import pytest
|
|
from roboco.foundation import identity
|
|
from roboco.seeds.initial_data import AGENT_UUIDS
|
|
|
|
|
|
def test_role_enum_has_every_role_inc_system() -> None:
|
|
"""Every role the system uses must be enumerated, including SYSTEM."""
|
|
expected = {
|
|
"developer",
|
|
"qa",
|
|
"documenter",
|
|
"cell_pm",
|
|
"main_pm",
|
|
"product_owner",
|
|
"head_marketing",
|
|
"auditor",
|
|
"prompter",
|
|
"secretary",
|
|
"ceo",
|
|
"system",
|
|
}
|
|
actual = {r.value for r in identity.Role}
|
|
assert actual == expected, f"Role drift: {actual ^ expected}"
|
|
|
|
|
|
def test_team_enum_has_marketing_legacy_and_system() -> None:
|
|
"""Team enum keeps MARKETING for legacy seed-data parity; SYSTEM for sentinel."""
|
|
expected = {
|
|
"backend",
|
|
"frontend",
|
|
"ux_ui",
|
|
"board",
|
|
"main_pm",
|
|
"fullstack",
|
|
"marketing", # legacy — see spec §5.1
|
|
"system",
|
|
}
|
|
actual = {t.value for t in identity.Team}
|
|
assert actual == expected, f"Team drift: {actual ^ expected}"
|
|
|
|
|
|
def test_role_level_is_int_enum() -> None:
|
|
"""RoleLevel is hierarchical (orderable), not a stringly-typed set."""
|
|
assert issubclass(identity.RoleLevel, IntEnum)
|
|
# CEO > everyone else
|
|
assert identity.RoleLevel.CEO > identity.RoleLevel.AUDITOR
|
|
assert identity.RoleLevel.AUDITOR > identity.RoleLevel.MAIN_PM
|
|
assert identity.RoleLevel.MAIN_PM > identity.RoleLevel.CELL_PM
|
|
assert identity.RoleLevel.CELL_PM > identity.RoleLevel.DOCUMENTER
|
|
assert identity.RoleLevel.DOCUMENTER > identity.RoleLevel.QA
|
|
assert identity.RoleLevel.QA > identity.RoleLevel.DEV
|
|
assert identity.RoleLevel.DEV > identity.RoleLevel.SYSTEM
|
|
|
|
|
|
def test_agents_catalog_has_all_seed_slugs() -> None:
|
|
"""Every slug from seeds/initial_data.AGENT_UUIDS is in foundation.AGENTS."""
|
|
expected_slugs = {
|
|
"system",
|
|
"ceo",
|
|
"be-dev-1",
|
|
"be-dev-2",
|
|
"be-qa",
|
|
"be-pm",
|
|
"be-doc",
|
|
"fe-dev-1",
|
|
"fe-dev-2",
|
|
"fe-qa",
|
|
"fe-pm",
|
|
"fe-doc",
|
|
"ux-dev-1",
|
|
"ux-dev-2",
|
|
"ux-qa",
|
|
"ux-pm",
|
|
"ux-doc",
|
|
"main-pm",
|
|
"product-owner",
|
|
"head-marketing",
|
|
"auditor",
|
|
"intake-1",
|
|
"secretary-1",
|
|
}
|
|
actual = set(identity.AGENTS.keys())
|
|
assert actual == expected_slugs, f"agent catalog drift: {actual ^ expected_slugs}"
|
|
|
|
|
|
def test_agents_uuids_match_seed() -> None:
|
|
"""UUIDs match seeds/initial_data.AGENT_UUIDS (the authoritative seed map)."""
|
|
for slug, expected_uuid_str in AGENT_UUIDS.items():
|
|
assert str(identity.AGENTS[slug].uuid) == expected_uuid_str, (
|
|
f"UUID drift for {slug!r}: foundation says "
|
|
f"{identity.AGENTS[slug].uuid}, seed says {expected_uuid_str}"
|
|
)
|
|
|
|
|
|
def test_ceo_is_human() -> None:
|
|
"""CEO is the only is_human=True row."""
|
|
humans = {slug for slug, row in identity.AGENTS.items() if row.is_human}
|
|
assert humans == {"ceo"}, f"unexpected human flag: {humans}"
|
|
|
|
|
|
def test_head_marketing_team_is_board() -> None:
|
|
"""Resolves the head-marketing.team drift (spec §5.1)."""
|
|
assert identity.AGENTS["head-marketing"].team == identity.Team.BOARD
|
|
|
|
|
|
def test_no_agent_declares_marketing_team() -> None:
|
|
"""Team.MARKETING exists for legacy parity; no agent should claim it."""
|
|
using_marketing = [
|
|
slug
|
|
for slug, row in identity.AGENTS.items()
|
|
if row.team == identity.Team.MARKETING
|
|
]
|
|
assert using_marketing == [], (
|
|
f"agents claiming Team.MARKETING (legacy): {using_marketing}"
|
|
)
|
|
|
|
|
|
def test_pm_roles_is_canonical() -> None:
|
|
"""PM_ROLES is exactly {CELL_PM, MAIN_PM} — replaces both forked variants."""
|
|
assert (
|
|
frozenset({identity.Role.CELL_PM, identity.Role.MAIN_PM}) == identity.PM_ROLES
|
|
)
|
|
|
|
|
|
def test_board_roles_includes_auditor() -> None:
|
|
"""BOARD_ROLES is the strategic layer (PO + Head Marketing + Auditor)."""
|
|
assert (
|
|
frozenset(
|
|
{
|
|
identity.Role.PRODUCT_OWNER,
|
|
identity.Role.HEAD_MARKETING,
|
|
identity.Role.AUDITOR,
|
|
}
|
|
)
|
|
== identity.BOARD_ROLES
|
|
)
|
|
|
|
|
|
def test_dev_roles_has_developer_only() -> None:
|
|
"""DEV_ROLES intentionally narrow — devs only, no QA/Doc."""
|
|
assert frozenset({identity.Role.DEVELOPER}) == identity.DEV_ROLES
|
|
|
|
|
|
def test_all_roles_covers_enum() -> None:
|
|
"""ALL_ROLES matches the Role enum exactly."""
|
|
assert frozenset(identity.Role) == identity.ALL_ROLES
|
|
|
|
|
|
def test_role_level_covers_every_role() -> None:
|
|
"""Every Role has a RoleLevel. SYSTEM is the sentinel (lowest)."""
|
|
for role in identity.Role:
|
|
assert role in identity.ROLE_LEVEL, f"Role.{role.name} missing from ROLE_LEVEL"
|
|
assert identity.ROLE_LEVEL[identity.Role.SYSTEM] == identity.RoleLevel.SYSTEM
|
|
assert identity.ROLE_LEVEL[identity.Role.CEO] == identity.RoleLevel.CEO
|
|
|
|
|
|
def test_role_level_orders_correctly() -> None:
|
|
"""CEO > AUDITOR > BOARD > MAIN_PM > CELL_PM > DOC > QA > DEV > SYSTEM."""
|
|
levels = [
|
|
identity.ROLE_LEVEL[r]
|
|
for r in (
|
|
identity.Role.CEO,
|
|
identity.Role.AUDITOR,
|
|
identity.Role.PRODUCT_OWNER, # BOARD level
|
|
identity.Role.MAIN_PM,
|
|
identity.Role.CELL_PM,
|
|
identity.Role.DOCUMENTER,
|
|
identity.Role.QA,
|
|
identity.Role.DEVELOPER,
|
|
identity.Role.SYSTEM,
|
|
)
|
|
]
|
|
assert levels == sorted(levels, reverse=True)
|
|
|
|
|
|
def test_agent_for_slug_returns_row() -> None:
|
|
row = identity.agent_for_slug("be-dev-1")
|
|
assert row.slug == "be-dev-1"
|
|
assert row.role == identity.Role.DEVELOPER
|
|
assert row.team == identity.Team.BACKEND
|
|
|
|
|
|
def test_agent_for_slug_unknown_raises_key_error() -> None:
|
|
with pytest.raises(KeyError) as exc_info:
|
|
identity.agent_for_slug("notreal-1")
|
|
assert "notreal-1" in str(exc_info.value)
|
|
|
|
|
|
def test_slugs_for_role_developer() -> None:
|
|
devs = identity.slugs_for_role(identity.Role.DEVELOPER)
|
|
assert devs == frozenset(
|
|
{"be-dev-1", "be-dev-2", "fe-dev-1", "fe-dev-2", "ux-dev-1", "ux-dev-2"}
|
|
)
|
|
|
|
|
|
def test_slugs_for_role_system_returns_singleton() -> None:
|
|
assert identity.slugs_for_role(identity.Role.SYSTEM) == frozenset({"system"})
|
|
|
|
|
|
def test_slugs_for_team_backend() -> None:
|
|
backend = identity.slugs_for_team(identity.Team.BACKEND)
|
|
assert backend == frozenset({"be-dev-1", "be-dev-2", "be-qa", "be-pm", "be-doc"})
|
|
|
|
|
|
def test_slugs_for_team_marketing_is_empty() -> None:
|
|
"""Team.MARKETING is legacy — no agent declares it."""
|
|
assert identity.slugs_for_team(identity.Team.MARKETING) == frozenset()
|
|
|
|
|
|
def test_role_for_slug() -> None:
|
|
assert identity.role_for_slug("be-pm") == identity.Role.CELL_PM
|
|
assert identity.role_for_slug("ceo") == identity.Role.CEO
|
|
|
|
|
|
def test_team_for_slug() -> None:
|
|
assert identity.team_for_slug("be-dev-1") == identity.Team.BACKEND
|
|
assert identity.team_for_slug("ceo") == identity.Team.BOARD
|
|
assert identity.team_for_slug("head-marketing") == identity.Team.BOARD
|