mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00

Files

T

42f8a5d18e fix(board): nothing_to_propose exit for Board Program explorers + PR checks on slave-based PRs (#712 )

* fix(board): give Board Program explorers a nothing_to_propose exit

Every propose_* verb requires at least one item, so an explorer that
legitimately found nothing — Barfly with no worthwhile X conversations,
Coroner with no autopsy subject — had no way to close its exploration
task. It declined, called i_am_idle(), and the task stayed PENDING
forever: the dispatcher re-matched it every tick and respawned the board
agent (~$0.61 a spawn, ~3 per 5-minute respawn-breaker cooldown window,
indefinitely), and BoardProgramEngine's one-open-cycle dedup wedged that
whole program shut, since the ledger row only closes once its exploration
task goes terminal.

nothing_to_propose(task_id, reason) is the explicit exit. task_id is
required rather than inferred: one explorer role owns several
independently-cadenced programs (head_marketing owns six) and each
assigns its exploration task to the same agent, so several are open at
once by design and guessing "the caller's oldest" completes the WRONG
cycle — stamping its reason onto an unrelated program's ledger while the
task actually being worked stays wedged. Resolution validates the named
task exists, carries a registered program source, is assigned to the
caller, and is non-terminal, then gates on the program's declared
explorer role from the registry, so a program registered later needs no
edit here.

The reason lands on board_program_cycles (migration 089) and renders into
the next cycle's LEARN context, replacing a bare "proposed 0, approved 0"
with why. That write runs in its own savepoint: it flushes on the same
session as the completion, and a bare try/except around a same-session
flush leaves the transaction pending-rollback, so a DB blip there would
discard the completion at the post-response commit while the verb
reported success.

All fourteen exploration prompts offer the exit, pinned by a
registry-parametrized test that fails when a future program is unwired.

* ci: fire PR checks on slave-based PRs, not master alone

All five gating workflows declared `pull_request: branches: [master]`,
but every fleet PR targets slave — cell->root, root->slave, and the CEO's
own. So `pull_request` never fired for any of them, and their only
coverage was the `push` trigger, which is gated on branch PREFIX
(feature/bug/chore/docs/hotfix). A branch named anything else got zero
checks — not a red run, an absent one — and a PR with no required check
present merges on a false green. PR #711 shipped that way on a `fix/`
branch.

Basing on the branch a PR merges INTO rather than what its head is named
makes coverage independent of branch naming, so a non-conforming prefix
can only ever cost the redundant push run, never the whole gate.

The same five also omitted slave from `push` (ci.yml aside, which added
it for the release gate's fail-closed CI read), so the panel suite, both
CodeQL analyses, and the e2e smoke never ran on the trunk master is cut
from.

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>

2026-07-27 01:28:33 +02:00

20 KiB

Raw Blame History

Per-role verb shapes (autogenerated)

Run make foundation-check after changing any role config or schema. Role prompts reference this file's sections as the source of truth for verb signatures.

Driver-based roles (prompter, secretary) are intentionally omitted — their real tools live in their agent_sdk drivers, not role_config.

developer

Flow verbs

Verb	Body schema
`give_me_work`	`give_me_work()`
`i_am_blocked`	`i_am_blocked(task_id: UUID, reason: str, blocker_type: str
`i_am_done`	`i_am_done(task_id: UUID, notes: str = '', resolved_findings: list[ResolvedFindingInput] = PydanticUndefined)`
`i_am_idle`	`i_am_idle()`
`i_will_work_on`	`i_will_work_on(task_id: UUID, plan: str
`open_pr`	`open_pr(task_id: UUID)`
`resume`	`resume(task_id: UUID)`
`sync_branch`	`sync_branch(task_id: UUID, stash: bool = False)`
`unclaim`	`unclaim(task_id: UUID)`

Content (do) tools

Tool	Body schema
`commit`	`commit(message: str, files: list[str]
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`dm`	`dm(recipient: str, text: str, task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`progress`	`progress(task_id: UUID, message: str, plan_step: str
`pr_update`	`pr_update(see do_server)`
`draft_playbook`	`draft_playbook(title: str, problem: str, procedure: str, tags: list[str] = PydanticUndefined, source_task_id: UUID
`propose_video`	`propose_video(composition_id: str, x_caption: str, tiktok_caption: str, platforms: list[str], input_props: str
`request_sandbox`	`request_sandbox(services: list[str]
`request_render`	`request_render(composition_id: str
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`notify_ack`	`notify_ack(notification_id: UUID)`
`read_messages`	`read_messages()`
`read_a2a`	`read_a2a(see do_server)`

qa

Flow verbs

Verb	Body schema
`claim_review`	`claim_review(task_id: UUID)`
`fail_review`	`fail_review(task_id: UUID, issues: list[str] = PydanticUndefined, findings: list[str
`give_me_work`	`give_me_work()`
`i_am_blocked`	`i_am_blocked(task_id: UUID, reason: str, blocker_type: str
`i_am_idle`	`i_am_idle()`
`pass_review`	`pass_review(task_id: UUID, notes: str, ac_verdicts: list[str]
`resume`	`resume(task_id: UUID)`
`unclaim`	`unclaim(task_id: UUID)`

Content (do) tools

Tool	Body schema
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`dm`	`dm(recipient: str, text: str, task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`draft_playbook`	`draft_playbook(title: str, problem: str, procedure: str, tags: list[str] = PydanticUndefined, source_task_id: UUID
`request_sandbox`	`request_sandbox(services: list[str]
`request_render`	`request_render(composition_id: str
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`notify_ack`	`notify_ack(notification_id: UUID)`
`read_messages`	`read_messages()`
`read_a2a`	`read_a2a(see do_server)`

documenter

Flow verbs

Verb	Body schema
`claim_doc_task`	`claim_doc_task(task_id: UUID)`
`give_me_work`	`give_me_work()`
`i_am_blocked`	`i_am_blocked(task_id: UUID, reason: str, blocker_type: str
`i_am_idle`	`i_am_idle()`
`i_documented`	`i_documented(task_id: UUID, notes: str, files: list[str])`
`resume`	`resume(task_id: UUID)`
`unclaim`	`unclaim(task_id: UUID)`

Content (do) tools

Tool	Body schema
`commit`	`commit(message: str, files: list[str]
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`dm`	`dm(recipient: str, text: str, task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`progress`	`progress(task_id: UUID, message: str, plan_step: str
`pr_update`	`pr_update(see do_server)`
`draft_playbook`	`draft_playbook(title: str, problem: str, procedure: str, tags: list[str] = PydanticUndefined, source_task_id: UUID
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`notify_ack`	`notify_ack(notification_id: UUID)`
`read_messages`	`read_messages()`
`read_a2a`	`read_a2a(see do_server)`

cell_pm

Flow verbs

Verb	Body schema
`complete`	`complete(task_id: UUID, notes: str)`
`declare_coverage`	`declare_coverage(task_id: UUID, criteria: list[str])`
`delegate`	`delegate(parent_task_id: UUID, title: str, description: str, assigned_to: str, team: str, task_type: str, nature: str, estimated_complexity: Complexity, acceptance_criteria: list[str], project_id: UUID
`escalate_up`	`escalate_up(task_id: UUID, reason: str)`
`give_me_work`	`give_me_work()`
`i_am_idle`	`i_am_idle()`
`i_will_plan`	`i_will_plan(task_id: UUID, plan: str, approach: str, sub_tasks: list[SubTaskCreate] = PydanticUndefined, technical_considerations: list[str] = PydanticUndefined, risks: list[RiskCreate] = PydanticUndefined, open_questions: list[OpenQuestionCreate] = PydanticUndefined)`
`reassign`	`reassign(task_id: UUID, new_assignee: str)`
`request_changes`	`request_changes(task_id: UUID, issues: list[str] = PydanticUndefined, findings: list[str
`resume`	`resume(task_id: UUID)`
`submit_up`	`submit_up(task_id: UUID, notes: str, resolved_findings: list[ResolvedFindingInput] = PydanticUndefined)`
`triage`	`triage()`
`unblock`	`unblock(task_id: UUID, reason: str, restore: bool = True)`
`unclaim`	`unclaim(task_id: UUID)`

Content (do) tools

Tool	Body schema
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`dm`	`dm(recipient: str, text: str, task_id: UUID
`notify`	`notify(target: str, text: str, priority: str = 'normal', task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`pr_update`	`pr_update(see do_server)`
`draft_playbook`	`draft_playbook(title: str, problem: str, procedure: str, tags: list[str] = PydanticUndefined, source_task_id: UUID
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`notify_ack`	`notify_ack(notification_id: UUID)`
`read_messages`	`read_messages()`
`read_a2a`	`read_a2a(see do_server)`

main_pm

Flow verbs

Verb	Body schema
`complete`	`complete(task_id: UUID, notes: str)`
`declare_coverage`	`declare_coverage(task_id: UUID, criteria: list[str])`
`delegate`	`delegate(parent_task_id: UUID, title: str, description: str, assigned_to: str, team: str, task_type: str, nature: str, estimated_complexity: Complexity, acceptance_criteria: list[str], project_id: UUID
`escalate_to_ceo`	`escalate_to_ceo(task_id: UUID, reason: str)`
`escalate_up`	`escalate_up(task_id: UUID, reason: str)`
`give_me_work`	`give_me_work()`
`i_am_idle`	`i_am_idle()`
`i_will_plan`	`i_will_plan(task_id: UUID, plan: str, approach: str, sub_tasks: list[SubTaskCreate] = PydanticUndefined, technical_considerations: list[str] = PydanticUndefined, risks: list[RiskCreate] = PydanticUndefined, open_questions: list[OpenQuestionCreate] = PydanticUndefined)`
`request_changes`	`request_changes(task_id: UUID, issues: list[str] = PydanticUndefined, findings: list[str
`resume`	`resume(task_id: UUID)`
`submit_root`	`submit_root(task_id: UUID, notes: str, resolved_findings: list[ResolvedFindingInput] = PydanticUndefined)`
`triage`	`triage()`
`triage_all`	`triage_all()`
`unblock`	`unblock(task_id: UUID, reason: str, restore: bool = True)`
`unclaim`	`unclaim(task_id: UUID)`

Content (do) tools

Tool	Body schema
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`dm`	`dm(recipient: str, text: str, task_id: UUID
`notify`	`notify(target: str, text: str, priority: str = 'normal', task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`pr_update`	`pr_update(see do_server)`
`draft_playbook`	`draft_playbook(title: str, problem: str, procedure: str, tags: list[str] = PydanticUndefined, source_task_id: UUID
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`notify_ack`	`notify_ack(notification_id: UUID)`
`read_messages`	`read_messages()`
`read_a2a`	`read_a2a(see do_server)`

product_owner

Flow verbs

Verb	Body schema
`escalate_to_ceo`	`escalate_to_ceo(task_id: UUID, reason: str)`
`i_am_idle`	`i_am_idle()`
`triage`	`triage()`

Content (do) tools

Tool	Body schema
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`pitch`	`pitch(title: str, slug: str, problem: str, proposed_solution: str, target_cells: list[str])`
`dm`	`dm(recipient: str, text: str, task_id: UUID
`notify`	`notify(target: str, text: str, priority: str = 'normal', task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`nothing_to_propose`	`nothing_to_propose(task_id: UUID, reason: str)`
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`notify_ack`	`notify_ack(notification_id: UUID)`
`read_messages`	`read_messages()`
`read_a2a`	`read_a2a(see do_server)`
`propose_roadmap`	`propose_roadmap(cycle_goal: str, items: list[RoadmapItemInput])`
`propose_bug_hunt`	`propose_bug_hunt(items: list[PestHuntItemInput])`
`propose_gap_fill`	`propose_gap_fill(items: list[GapFillItemInput])`
`propose_rebalance`	`propose_rebalance(items: list[RebalanceItemInput])`
`propose_friction_fixes`	`propose_friction_fixes(items: list[FrictionFixItemInput])`

head_marketing

Flow verbs

Verb	Body schema
`escalate_to_ceo`	`escalate_to_ceo(task_id: UUID, reason: str)`
`i_am_idle`	`i_am_idle()`
`triage`	`triage()`

Content (do) tools

Tool	Body schema
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`pitch`	`pitch(title: str, slug: str, problem: str, proposed_solution: str, target_cells: list[str])`
`dm`	`dm(recipient: str, text: str, task_id: UUID
`notify`	`notify(target: str, text: str, priority: str = 'normal', task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`nothing_to_propose`	`nothing_to_propose(task_id: UUID, reason: str)`
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`notify_ack`	`notify_ack(notification_id: UUID)`
`read_messages`	`read_messages()`
`read_a2a`	`read_a2a(see do_server)`
`propose_feature_spotlight`	`propose_feature_spotlight(feature_slug: str = '', feature_title: str = '', body: str = '', wants_video: bool = False, video_script: str = '', skip: bool = False, skip_reason: str = '')`
`propose_market_brief`	`propose_market_brief(headline: str, findings: list[MarketBriefFindingInput], threats: list[str]
`propose_messaging_fixes`	`propose_messaging_fixes(items: list[MessagingFixItemInput])`
`propose_editorial_post`	`propose_editorial_post(angle: str, body: str, rationale: str)`
`propose_campaign`	`propose_campaign(campaign_name: str, posts: list[CampaignPostInput])`
`propose_conversation_replies`	`propose_conversation_replies(items: list[ConversationReplyItemInput])`

auditor

Flow verbs

Verb	Body schema
`i_am_idle`	`i_am_idle()`
`triage`	`triage()`
`waive_finding`	`waive_finding(finding_id: UUID, note: str)`

Content (do) tools

Tool	Body schema
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`dm`	`dm(recipient: str, text: str, task_id: UUID
`read_a2a`	`read_a2a(see do_server)`
`approve_playbook`	`approve_playbook(playbook_id: UUID)`
`reject_playbook`	`reject_playbook(playbook_id: UUID, reason: str)`
`archive_playbook`	`archive_playbook(playbook_id: UUID)`
`curate_vault`	`curate_vault(task_id: UUID, narrative: str)`
`propose_postmortem`	`propose_postmortem(incident_summary: str, root_cause: str, failed_stage: str, process_change: ProcessChangeInput, playbook: PostmortemPlaybookInput
`nothing_to_propose`	`nothing_to_propose(task_id: UUID, reason: str)`
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`
`propose_quality_report`	`propose_quality_report(headline: str, items: list[QualityReportItemInput], overall_assessment: str)`
`propose_playbook_drafts`	`propose_playbook_drafts(drafts: list[PlaybookDraftInput])`

pr_reviewer

Flow verbs

Verb	Body schema
`claim_gate_review`	`claim_gate_review(task_id: UUID)`
`claim_pr_review`	`claim_pr_review(task_id: UUID)`
`give_me_work`	`give_me_work()`
`i_am_idle`	`i_am_idle()`
`post_pr_review`	`post_pr_review(task_id: UUID, body: str, event: str = 'REQUEST_CHANGES', findings: list[str
`pr_fail`	`pr_fail(task_id: UUID, issues: list[str] = PydanticUndefined, findings: list[str
`pr_pass`	`pr_pass(task_id: UUID, notes: str)`
`unclaim`	`unclaim(task_id: UUID)`

Content (do) tools

Tool	Body schema
`note`	`note(text: str, scope: str = 'note', task_id: UUID
`evidence`	`evidence(task_id: UUID)`
`dm`	`dm(recipient: str, text: str, task_id: UUID
`read_a2a`	`read_a2a(see do_server)`
`notify_list`	`notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20)`
`notify_get`	`notify_get(notification_id: UUID)`

20 KiB Raw Blame History

Per-role verb shapes (autogenerated)

developer

Flow verbs

Content (do) tools

qa

Flow verbs

Content (do) tools

documenter

Flow verbs

Content (do) tools

cell_pm

Flow verbs

Content (do) tools

main_pm

Flow verbs

Content (do) tools

product_owner

Flow verbs

Content (do) tools

head_marketing

Flow verbs

Content (do) tools

auditor

Flow verbs

Content (do) tools

pr_reviewer

Flow verbs

Content (do) tools

20 KiB

Raw Blame History