mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
41ef7f6b4e
_check_pm_decision_required now requires the latest journal:decision within pm_decision_window_seconds (default 300). Older decisions no longer satisfy the gate. Adds JournalService.latest_decision_at. Future-tighten (out of scope): per-verb-group consumption tracking would need persistent state — Choreographer is per-request today.
120 lines
3.8 KiB
Python
120 lines
3.8 KiB
Python
"""P2-7: every gateway.rejected audit row carries an attempt_id.
|
|
|
|
The attempt_id (uuid4 per rejection) lets post-mortem queries group
|
|
all attempts on a task within a window, even when multiple calls share
|
|
a correlation_id from a single inbound request.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock
|
|
from uuid import UUID, uuid4
|
|
|
|
import pytest
|
|
from roboco.services.gateway.choreographer import Choreographer, ChoreographerDeps
|
|
|
|
|
|
def _make_deps(**overrides: Any) -> ChoreographerDeps:
|
|
base: dict[str, Any] = {
|
|
"task": AsyncMock(),
|
|
"work_session": AsyncMock(),
|
|
"git": AsyncMock(),
|
|
"a2a": AsyncMock(),
|
|
"journal": AsyncMock(),
|
|
"audit": AsyncMock(),
|
|
"evidence_repo": AsyncMock(),
|
|
}
|
|
base.update(overrides)
|
|
repo = base["evidence_repo"]
|
|
for method in (
|
|
"list_unread_a2a",
|
|
"list_unread_mentions",
|
|
"list_pending_notifications",
|
|
"task_metadata_gaps",
|
|
"recent_team_activity",
|
|
"blockers_in_lane",
|
|
"journal_highlights_for_task",
|
|
):
|
|
getattr(repo, method).return_value = []
|
|
# C8: default-fresh journal:decision so PM-decision gate passes.
|
|
# Tests that exercise the gate boundary stub their own value.
|
|
# The check matches MagicMock and AsyncMock (the two default sentinel
|
|
# types pytest's unittest.mock leaves on un-stubbed return_values).
|
|
_ldef = base["journal"].latest_decision_at.return_value
|
|
if type(_ldef).__name__ in ("MagicMock", "AsyncMock"):
|
|
base["journal"].latest_decision_at.return_value = datetime.now(UTC)
|
|
return ChoreographerDeps(**base)
|
|
|
|
|
|
def _is_uuid(s: str) -> bool:
|
|
try:
|
|
UUID(s)
|
|
except (ValueError, TypeError):
|
|
return False
|
|
return True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_rejection_includes_attempt_id() -> None:
|
|
"""A `not_found` rejection on i_am_done emits an audit row with attempt_id."""
|
|
aid = uuid4()
|
|
tid = uuid4()
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = None # → not_found
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.i_am_done(aid, tid, notes="x")
|
|
|
|
assert env.error == "not_found"
|
|
audit_svc.log_event.assert_awaited()
|
|
args = audit_svc.log_event.await_args
|
|
details = args.kwargs["details"]
|
|
assert "attempt_id" in details, "P2-7: audit row must include attempt_id"
|
|
assert _is_uuid(details["attempt_id"]), "P2-7: attempt_id must be a UUID string"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_distinct_rejections_emit_distinct_attempt_ids() -> None:
|
|
"""Two rejections in sequence get different attempt_ids."""
|
|
aid = uuid4()
|
|
tid = uuid4()
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = None
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
await c.i_am_done(aid, tid, notes="x")
|
|
await c.i_am_done(aid, tid, notes="x")
|
|
|
|
expected_distinct_ids = 2
|
|
calls = audit_svc.log_event.await_args_list
|
|
ids = {call.kwargs["details"]["attempt_id"] for call in calls}
|
|
assert len(ids) == expected_distinct_ids, (
|
|
"P2-7: each rejection emits its own attempt_id"
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_success_envelope_does_not_emit_audit() -> None:
|
|
"""Confirms the contract: audit rows fire on rejection only.
|
|
|
|
attempt_id machinery doesn't trip on success (no row to stamp).
|
|
"""
|
|
aid = uuid4()
|
|
task_svc = AsyncMock()
|
|
task_svc.list_assigned_for_agent.return_value = []
|
|
task_svc.list_paused_for_agent.return_value = []
|
|
audit_svc = AsyncMock()
|
|
deps = _make_deps(task=task_svc, audit=audit_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.give_me_work(aid)
|
|
|
|
assert env.error is None
|
|
audit_svc.log_event.assert_not_awaited()
|