mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* feat(sandbox): throwaway per-agent Postgres/Redis sandbox containers
Orchestrator-provisioned sibling containers per agent spawn
(SandboxProvisioner, roboco/runtime/sandbox.py). Per-project opt-in via
projects.sandbox_services (migration 057); master switch
ROBOCO_SANDBOX_DB_ENABLED, default-off, armed in the NAS compose only.
When active, ROBOCO_TEST_DB_* / ROBOCO_TEST_REDIS_* point at the sandbox
and the prod-creds gate-env injection is suppressed (sandbox replaces,
never coexists). Sandbox lifetime tracks the agent container: teardown at
every removal path, orphan janitor at startup + each reaper tick with a
grace window for mid-flight spawns. The pre-spawn stale-clear spares the
just-provisioned sandbox; provision pre-clears stale same-named
containers from a crash-missed teardown.
Panel: per-project sandbox-service switches in the edit dialog + feature
flag card entry.
* docs: CLAUDE.md entry for the sandboxed dev DB/Redis subsystem
* feat(security): isolate prod Postgres/Redis from agent containers (roboco_data network)
Second user-defined bridge roboco_data carries postgres+redis only; the
orchestrator is multi-homed (default + data). Spawned agents and their
sandbox sidecars stay on roboco_default and can no longer resolve or
reach roboco-postgres:5432 / roboco-redis:6379 (redis has no auth —
membership is its only containment). Normal bridge, so host-published
ports (15432/16379) keep working. Applied to both build composes and
the registry compose; docker-compose.yml re-synced byte-identical with
docker-compose.yaml (it had drifted by the sandbox flag block).
ROBOCO_DB_NETWORK_ISOLATED (config default false, armed alongside the
topology) suppresses the legacy _append_gate_env prod-creds injection:
under isolation those creds dead-end, and unreachable creds are worse
than none. DB-needing projects opt into sandbox_services instead. The
flag is deliberately not a panel feature flag - it must travel with the
compose networks: stanzas.
Preserved by construction: agent<->agent A2A and orchestrator->agent SDK
polls on :9000, MCP->orchestrator on :8000, ollama reachability, docker
exec/inspect (daemon socket), host port publishing.
* feat(panel): full mobile responsiveness pass
Shared primitives: useIsMobile (useSyncExternalStore, hydration-safe,
memoized matchMedia subscribe), ResponsiveTable table->card switch below
md (single subtree mounted, no duplicated interactive rows), scrollable
snap TabsList in the base primitive (justify-center-safe so the first
tab stays reachable on overflow), persistent md:hidden bottom tab bar
(Overview/Tasks/Kanban/Chat, safe-area padded).
Applied: card lists for tasks/projects/products/work-sessions/sessions
+ the three raw metrics tables; CEO approval queue / release proposal /
playbook review action rows stack on narrow; command-center reorders
approvals above the fold on mobile; task-header metadata wraps;
Communications + A2A become URL-driven single-pane drill-downs below lg
(fixes the unconstrained-height ScrollArea bug) with dvh heights;
recharts label density/radius adapts via useIsMobile; git diff viewer
gets mobile font + wrap toggle; vh->dvh sweep; chat composers get
safe-area-inset padding; dashboard main p-4 md:p-6 + pb-20 for the bar.
Verified at 375px on the built app: bottom bar, drawer, approval-first
overview, swipeable kanban tab strip. All gates green (eslint, tsc,
vitest 249, next build 24/24 routes).
* feat(auth): cloud auth via FastAPI Users (default-off, single-user cookie session)
ROBOCO_CLOUD_AUTH_ENABLED (default off) lets the panel/API be exposed
beyond localhost without changing the CEO's local no-login flow while
off — get_agent_context and the WS gate are byte-for-byte unchanged in
off-mode. On: header-trust dies for humans — any agent-role claim (ceo
or a privileged PM/board role) with no valid HMAC token or session
cookie is 401, closing the header-spoof hole on the host-published
:8000 port for every role. The agent-fleet HMAC path and the system
self-PATCH keep working unmodified in both modes.
Single seeded CEO user (migration 058 users table, UserTable), no
registration router — idempotent env-driven upsert at startup by PK.
Cookie transport (httponly/secure/samesite=lax) + a JWTStrategy bound
to a fingerprint of the current password hash (rotating the password
invalidates every prior session). Sliding 30-day session: every
authenticated request re-mints the cookie, so an active session never
expires — no unexpected logouts.
Panel: (auth)/login page + proxy.ts (Next 16 rename of middleware; probes
/auth/status over the docker-internal URL, fails open to off) gate the
dashboard; client.ts gets withCredentials + 401->/login. nginx unchanged.
Review hardening: broadened the on-mode rejection from ceo-only to every
non-CEO role without a valid token (was only closed when
ROBOCO_AGENT_AUTH_REQUIRED was also armed); Next-16 proxy.ts rename to
clear the middleware deprecation warning.
* feat(x): RoboCo X account engine — HoM drafts, per-post CEO approval (default-off)
ROBOCO_X_ENGINE_ENABLED (default off, inert without creds). Mirrors the
ReleaseManagerEngine held-artifact shape: XEngine drafts a post when a
release publishes (via a draft_release_post seam on ReleaseProposalService
.approve) and drafts replies to meaningful mentions (dedicated poll loop,
x_seen_mentions dedup ledger, per-cycle/open caps). Drafting is
local-model-only, clamped to 280 chars. Nothing auto-posts — every tweet
is a held task (source x_post/x_reply, confirmed_by_human=False,
Secretary-owned, dispatcher-skipped) the CEO edits/approves/rejects in a
panel queue.
The four OAuth 1.0a secrets live Fernet-encrypted in a singleton
x_credentials row (migration 059, all-or-nothing, API returns only
has_credentials); decryption is server-side, agents never hold creds or
egress. Hand-rolled OAuth 1.0a HMAC-SHA1 signer, no new dependency;
NullXClient makes the unconfigured path a graceful no-op.
XPostService.approve (CEO-only) is the sole caller of post_tweet.
Review hardening: closed a double-post race — the approve path now
re-reads committed task state inside the Redis lock and commits COMPLETED
before releasing, so a concurrent approve that acquires the lock after the
winner released can't re-post (SET-NX is non-waiting, and the route-level
commit landed after the lock dropped). Added a regression test.
* feat(roadmap): board roadmap engine — PO proposes themed cycles, CEO approves per-item (default-off)
ROBOCO_ROADMAP_ENGINE_ENABLED (default off). Weekly, RoadmapEngine opens
ONE held exploration task (source=board_roadmap, confirmed_by_human=False,
Product-Owner-assigned), deduped to one open cycle. A dedicated one-shot
_dispatch_roadmap_exploration spawns the PO solo (not the two-reviewer
board path, which would also spawn HoM + fire Approve-&-Start). The PO
explores read-only (git/KB/metrics/releases/charter/web) and makes one
propose_roadmap call (PO-only content verb) authoring a themed cycle —
goal + 3-7 item drafts — persisted as a roadmap_cycle marker (no table,
no migration; head stays 059).
The CEO acts per-item in the panel roadmap queue: approve materializes a
BACKLOG task (source=roadmap, no assignee — never auto-starts), reject
records a reason; all-items-terminal completes the exploration task.
RoadmapService is idempotent per item. Dispatchers skip board_roadmap.
Includes a real SQLAlchemy dirty-check fix (deep-copy the JSON marker
before mutating, or the in-place edit + reassign compares equal to its
own baseline and the UPDATE is skipped).
Review hardening: create_task_from_draft now honors a draft-declared
source only from a {prompter, roadmap} whitelist — drafts are
LLM-authored, so an unbounded source could impersonate a privileged
origin (release_manager would even wedge that engine's dedup).
* chore(release): 0.17.0
Wave 3 — six default-off subsystems: sandboxed dev DB/Redis, prod
Postgres/Redis network isolation, full mobile UI pass, cloud auth
(FastAPI Users), the RoboCo X account engine, and the board roadmap
engine. Plus the waves 1+2 work already on master since 0.16.0.
Version bumped across the canonical set (config.py, __init__.py,
pyproject.toml, panel/package.json, uv.lock); CHANGELOG [Unreleased]
cut to [0.17.0]; docs/map delta added.
Compose: every optional feature armed :-true in the NAS composes, OFF
in the user-facing registry compose. Two opt-in exceptions default off
(CLOUD_AUTH — needs email/password/secret + TLS, would otherwise fail
startup; ROUTING_STRICT — fail-closed spawning). DB_NETWORK_ISOLATED
stays on in both (coupled to the roboco_data topology).
* chore(compose): arm cloud_auth + routing_strict ON in the NAS composes
Every feature defaults ON in the NAS composes per policy — these two
were wrongly left off. Both keep the ${VAR:-true} form so the operator
controls the real runtime via .env: cloud auth needs
ROBOCO_CLOUD_AUTH_EMAIL/_PASSWORD/_SECRET + TLS set there before a boot
(else startup fails loud), and routing_strict is fail-closed. Registry
compose keeps both off.
* fix(ci): reflow board.md prose (quality gate) + document v0.17.0 env creds
The roadmap section added hard-wrapped prose that failed the markdown
prose gate; reflowed (token-invariant). Also brought .env.example
current: cloud auth (now armed — needs SECRET or startup fails), routing
strict, the X engine (panel-entered OAuth), and web research.
* fix(ci): reduce cyclomatic complexity of five wave-3 blocks (xenon gate)
The wave-3 subagents introduced C-rank functions the CI xenon gate
rejects (my per-item reviews ran ruff/mypy/pytest but not xenon):
- sandbox.janitor_sweep -> extract _list_labeled_sandboxes /
_list_live_agent_containers / _prune_grace
- x_client.fetch_mentions -> extract _parse_mention_items
- x_engine.run_cycle -> extract _process_mentions
- orchestrator._dispatch_pm_work -> extract the source-skip into a
MODULE-level _is_held_ceo_source (module, not method, so the
wholesale-mocked dispatcher unit tests exercise the real logic)
- auth/seed.ensure_seed_user -> extract _apply_seed_updates (module avg -> A)
Behavior-preserving; full suite green (11902), xenon clean.
* fix(ci): declare pyjwt + fastapi-users-db-sqlalchemy as direct deps (deptry)
The cloud-auth code imports jwt and fastapi_users_db_sqlalchemy directly
but they were only transitive deps (via fastapi-users), which deptry
(quality gate, DEP003) rejects. Declared explicitly; deptry roboco/ clean.
Missed originally because local make quality stopped at earlier gates
before reaching deptry.
* feat(x): gate mention replies behind ROBOCO_X_REPLIES_ENABLED (default off)
Per CEO decision: the X engine should only post about releases by
default. Reading mentions needs a paid X API tier, so the mention-reply
half is now a deliberate opt-in on top of release posting.
New default-off flag x_replies_enabled gates the mentions poll loop
(_x_mentions_poll_loop) and XEngine.run_cycle; release-post drafting
(the release-proposal approve hook) is unaffected and still runs when
x_engine_enabled + credentials are set. Added to FEATURE_FLAGS + the
panel card. Tests: release posting works with replies off; run_cycle +
the poll loop are no-ops with replies off.
* fix: 401 only redirects to /login when cloud auth is on; panel-token strips .env quotes
Two bugs that together dead-ended login in secure mode:
- client.ts redirected to /login on ANY 401, so a mismatched panel
token (header-trust/secure mode, cloud auth off) bounced the user to a
login page whose backend route isn't mounted -> 404. Now it probes
/auth/status (bare fetch, no interceptor re-entry) and only redirects
when cloud_auth_enabled.
- make panel-token read the .env secret with grep|cut without stripping
surrounding quotes, so a quoted ROBOCO_AGENT_AUTH_SECRET produced a
token signed with the quotes included — which never verifies against
the orchestrator (docker-compose/pydantic unquote the secret). Now
strips surrounding single/double quotes.
* fix: git-log 500 on '|' in commit message; X queue shows an empty state
- GET /api/git/log 500'd (ValueError: Invalid isoformat) when a commit
SUBJECT contained a '|' (e.g. the 'curl|sh' lockdown commit): the
fixed '|' field delimiter let the subject's pipe shift the split so
author+date collapsed into one field. Switched to \x1f (Unit
Separator), which can't appear in commit content. Regression test with
a piped subject.
- The X Post Queue returned null when empty, so there was no visible
place for the X drafts. It now renders a discoverable empty state
pointing at Settings -> X credentials.
* docs: bring docs/rag + docs/map current for v0.17.0 (waves 1-3)
Agent-facing RAG corpus and codebase map updated for every feature in
the 0.17.0 span, code-verified:
- wave 3: sandbox DB, DB network isolation, cloud auth, X engine
(+ x_replies_enabled sub-flag), board roadmap engine — new RAG
architecture pages + role/tool/config-reference updates; new symbols,
migrations 057-059, panel surfaces, and the get_agent_context
dual-path across the map slices.
- waves 1-2: A2A live view + switchboard, prompter memory
(search_past_tasks), Secretary edit access + PM-lighter scope, the
PR-gate auto-submit turn cut (ROBOCO_PR_GATE_AUTO_SUBMIT_ENABLED).
- correctness fix: api-routes-schemas.md no longer claims the A2A admin
routes are reachable by any authenticated agent — they carry a
_require_ceo gate (wave 2c).
docs/internal, _front.md deltas, and the frozen _complete_map.md
snapshot untouched.
* fix(rag): atomic upsert for indexed-doc tracking (kills e2e segfault)
The indexed-document tracking write used check-then-insert in two paths
(IndexedDocumentRepository.upsert_batch and the file-source
_upsert_doc_record). Under concurrent indexing both callers saw no row
and both inserted, so the second violated uq_indexed_doc_source and
poisoned its transaction — surfacing in CI as the intermittent
_checkin_failed SIGSEGV on the failed connection's pool checkin.
Both paths now use INSERT ... ON CONFLICT DO UPDATE against the
constraint: coalesce keeps an existing title/preview when the new value
is empty (matching the old guards) and metadata is jsonb-merged. The
batch dedupes within itself first (ON CONFLICT can't touch a row twice
in one statement). expire_all after the Core upsert keeps same-session
ORM reads consistent with the merged DB row.
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
854 lines
29 KiB
TypeScript
854 lines
29 KiB
TypeScript
"use client";
|
|
|
|
import { useState, useMemo } from "react";
|
|
import { Task } from "@/types";
|
|
import { Card, CardContent } from "@/components/ui/card";
|
|
import { Badge } from "@/components/ui/badge";
|
|
import { Button } from "@/components/ui/button";
|
|
import { getAgentDisplayName } from "@/lib/agent-utils";
|
|
import { Skeleton } from "@/components/ui/skeleton";
|
|
import {
|
|
Select,
|
|
SelectContent,
|
|
SelectItem,
|
|
SelectTrigger,
|
|
SelectValue,
|
|
} from "@/components/ui/select";
|
|
import {
|
|
Table,
|
|
TableBody,
|
|
TableCell,
|
|
TableHead,
|
|
TableHeader,
|
|
TableRow,
|
|
} from "@/components/ui/table";
|
|
import {
|
|
ResponsiveTable,
|
|
ResponsiveTableCardList,
|
|
ResponsiveTableCard,
|
|
ResponsiveTableCardRow,
|
|
ResponsiveTableCardEmpty,
|
|
} from "@/components/ui/responsive-table";
|
|
import { TaskStatusBadge } from "./task-status-badge";
|
|
import { TaskActions } from "./task-actions";
|
|
import { GitStatusBadge } from "./git-status-badge";
|
|
import Link from "next/link";
|
|
import {
|
|
ArrowUpDown,
|
|
ArrowUp,
|
|
ArrowDown,
|
|
ChevronLeft,
|
|
ChevronRight,
|
|
ChevronDown,
|
|
ChevronRight as ChevronRightIcon,
|
|
} from "lucide-react";
|
|
import { formatDistanceToNow } from "date-fns";
|
|
import { cn } from "@/lib/utils";
|
|
|
|
// Priority colors and labels
|
|
const priorityColors: Record<number, string> = {
|
|
0: "bg-red-200 text-red-700",
|
|
1: "bg-orange-200 text-orange-700",
|
|
2: "bg-blue-200 text-blue-700",
|
|
3: "bg-gray-200 text-gray-700",
|
|
};
|
|
|
|
const priorityLabels: Record<number, string> = {
|
|
0: "P0 - Highest",
|
|
1: "P1 - High",
|
|
2: "P2 - Medium",
|
|
3: "P3 - Low",
|
|
};
|
|
|
|
// Sorting types - exported for parent components
|
|
export type SortField =
|
|
| "title"
|
|
| "status"
|
|
| "team"
|
|
| "priority"
|
|
| "assigned_to"
|
|
| "created_at";
|
|
export type SortDirection = "asc" | "desc";
|
|
|
|
interface SortConfig {
|
|
field: SortField;
|
|
direction: SortDirection;
|
|
}
|
|
|
|
interface TaskTableProps {
|
|
tasks: Task[] | undefined;
|
|
isLoading: boolean;
|
|
// id -> display name maps for the Project / Product column
|
|
projectNames?: Record<string, string>;
|
|
// id -> git_url, used to build clickable branch/PR links on the row badge
|
|
projectGitUrls?: Record<string, string>;
|
|
productNames?: Record<string, string>;
|
|
// Controlled sort props (optional for backwards compatibility)
|
|
sortField?: SortField;
|
|
sortDirection?: SortDirection;
|
|
onSortChange?: (field: SortField, direction: SortDirection | null) => void;
|
|
// Controlled pagination props
|
|
currentPage?: number;
|
|
pageSize?: number;
|
|
onPageChange?: (page: number) => void;
|
|
onPageSizeChange?: (size: number) => void;
|
|
// Controlled expanded state
|
|
expandedIds?: Set<string>;
|
|
onExpandedChange?: (ids: Set<string>) => void;
|
|
}
|
|
|
|
const PAGE_SIZE_OPTIONS = [10, 25, 50, 100];
|
|
|
|
// Build a tree structure from flat tasks
|
|
interface TaskTreeNode {
|
|
task: Task;
|
|
children: TaskTreeNode[];
|
|
depth: number;
|
|
}
|
|
|
|
function buildTaskTree(tasks: Task[]): {
|
|
roots: TaskTreeNode[];
|
|
childrenMap: Map<string, Task[]>;
|
|
} {
|
|
const taskMap = new Map<string, Task>();
|
|
const childrenMap = new Map<string, Task[]>();
|
|
|
|
// Index all tasks
|
|
tasks.forEach((task) => {
|
|
taskMap.set(task.id, task);
|
|
if (task.parent_task_id) {
|
|
const siblings = childrenMap.get(task.parent_task_id) || [];
|
|
siblings.push(task);
|
|
childrenMap.set(task.parent_task_id, siblings);
|
|
}
|
|
});
|
|
|
|
// Build tree nodes for root tasks (no parent or parent not in current list)
|
|
const roots: TaskTreeNode[] = [];
|
|
|
|
function buildNode(task: Task, depth: number): TaskTreeNode {
|
|
const children = (childrenMap.get(task.id) || []).map((child) =>
|
|
buildNode(child, depth + 1),
|
|
);
|
|
return { task, children, depth };
|
|
}
|
|
|
|
tasks.forEach((task) => {
|
|
// Root if no parent_task_id or parent is not in the current filtered list
|
|
if (!task.parent_task_id || !taskMap.has(task.parent_task_id)) {
|
|
roots.push(buildNode(task, 0));
|
|
}
|
|
});
|
|
|
|
return { roots, childrenMap };
|
|
}
|
|
|
|
// Flatten tree for rendering, respecting expanded state
|
|
function flattenTree(
|
|
nodes: TaskTreeNode[],
|
|
expandedIds: Set<string>,
|
|
result: TaskTreeNode[] = [],
|
|
): TaskTreeNode[] {
|
|
nodes.forEach((node) => {
|
|
result.push(node);
|
|
if (node.children.length > 0 && expandedIds.has(node.task.id)) {
|
|
flattenTree(node.children, expandedIds, result);
|
|
}
|
|
});
|
|
return result;
|
|
}
|
|
|
|
function TaskTableSkeleton() {
|
|
return (
|
|
<>
|
|
{Array.from({ length: 5 }).map((_, i) => (
|
|
<TableRow key={i}>
|
|
<TableCell>
|
|
<Skeleton className="h-4 w-3/4" />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Skeleton className="h-6 w-16" />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Skeleton className="h-6 w-12" />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Skeleton className="h-4 w-14" />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Skeleton className="h-4 w-24" />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Skeleton className="h-4 w-8" />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Skeleton className="h-4 w-20" />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Skeleton className="h-4 w-16" />
|
|
</TableCell>
|
|
<TableCell>
|
|
<Skeleton className="h-8 w-8" />
|
|
</TableCell>
|
|
</TableRow>
|
|
))}
|
|
</>
|
|
);
|
|
}
|
|
|
|
function TaskTableEmpty() {
|
|
return (
|
|
<TableRow>
|
|
<TableCell colSpan={9} className="text-center py-8">
|
|
<div className="text-muted-foreground">No tasks found</div>
|
|
</TableCell>
|
|
</TableRow>
|
|
);
|
|
}
|
|
|
|
function TaskCardSkeletons() {
|
|
return (
|
|
<ResponsiveTableCardList className="p-3">
|
|
{Array.from({ length: 5 }).map((_, i) => (
|
|
<ResponsiveTableCard key={i} className="space-y-2">
|
|
<Skeleton className="h-4 w-3/4" />
|
|
<Skeleton className="h-4 w-1/2" />
|
|
</ResponsiveTableCard>
|
|
))}
|
|
</ResponsiveTableCardList>
|
|
);
|
|
}
|
|
|
|
interface SortableHeaderProps {
|
|
label: string;
|
|
field: SortField;
|
|
sortConfig: SortConfig | null;
|
|
onSort: (field: SortField) => void;
|
|
className?: string;
|
|
}
|
|
|
|
function SortableHeader({
|
|
label,
|
|
field,
|
|
sortConfig,
|
|
onSort,
|
|
className,
|
|
}: SortableHeaderProps) {
|
|
const isActive = sortConfig?.field === field;
|
|
const direction = isActive ? sortConfig.direction : null;
|
|
|
|
return (
|
|
<TableHead className={className}>
|
|
<Button
|
|
onClick={() => onSort(field)}
|
|
variant="ghost"
|
|
className="h-auto -ml-2 px-2 py-1 gap-1 font-normal"
|
|
>
|
|
{label}
|
|
{!isActive && <ArrowUpDown className="h-4 w-4 text-muted-foreground" />}
|
|
{direction === "asc" && <ArrowUp className="h-4 w-4" />}
|
|
{direction === "desc" && <ArrowDown className="h-4 w-4" />}
|
|
</Button>
|
|
</TableHead>
|
|
);
|
|
}
|
|
|
|
export function TaskTable({
|
|
tasks,
|
|
isLoading,
|
|
projectNames = {},
|
|
projectGitUrls = {},
|
|
productNames = {},
|
|
sortField: controlledSortField,
|
|
sortDirection: controlledSortDirection,
|
|
onSortChange,
|
|
currentPage: controlledCurrentPage,
|
|
pageSize: controlledPageSize,
|
|
onPageChange,
|
|
onPageSizeChange,
|
|
expandedIds: controlledExpandedIds,
|
|
onExpandedChange,
|
|
}: TaskTableProps) {
|
|
// Internal state (used when not controlled)
|
|
const [internalSortConfig, setInternalSortConfig] =
|
|
useState<SortConfig | null>({
|
|
field: "created_at",
|
|
direction: "desc",
|
|
});
|
|
const [internalCurrentPage, setInternalCurrentPage] = useState(1);
|
|
const [internalPageSize, setInternalPageSize] = useState(25);
|
|
const [internalExpandedIds, setInternalExpandedIds] = useState<Set<string>>(
|
|
new Set(),
|
|
);
|
|
|
|
// Use controlled or internal state
|
|
const isControlled = onSortChange !== undefined;
|
|
const sortConfig: SortConfig | null = useMemo(() => {
|
|
if (isControlled) {
|
|
return controlledSortField
|
|
? {
|
|
field: controlledSortField,
|
|
direction: controlledSortDirection || "desc",
|
|
}
|
|
: null;
|
|
}
|
|
return internalSortConfig;
|
|
}, [
|
|
isControlled,
|
|
controlledSortField,
|
|
controlledSortDirection,
|
|
internalSortConfig,
|
|
]);
|
|
const currentPage = controlledCurrentPage ?? internalCurrentPage;
|
|
const pageSize = controlledPageSize ?? internalPageSize;
|
|
const expandedIds = controlledExpandedIds ?? internalExpandedIds;
|
|
|
|
const handleSort = (field: SortField) => {
|
|
if (isControlled) {
|
|
// Calculate new state and notify parent
|
|
if (sortConfig?.field === field) {
|
|
if (sortConfig.direction === "asc") {
|
|
onSortChange(field, "desc");
|
|
} else {
|
|
onSortChange(field, null); // Clear sort
|
|
}
|
|
} else {
|
|
onSortChange(field, "asc");
|
|
}
|
|
} else {
|
|
setInternalSortConfig((prev) => {
|
|
if (prev?.field === field) {
|
|
if (prev.direction === "asc") {
|
|
return { field, direction: "desc" };
|
|
} else {
|
|
return null;
|
|
}
|
|
}
|
|
return { field, direction: "asc" };
|
|
});
|
|
setInternalCurrentPage(1);
|
|
}
|
|
};
|
|
|
|
// Build tree and get children map for counting
|
|
const { roots, childrenMap } = useMemo(() => {
|
|
if (!tasks) return { roots: [], childrenMap: new Map() };
|
|
return buildTaskTree(tasks);
|
|
}, [tasks]);
|
|
|
|
// Sort root nodes
|
|
const sortedRoots = useMemo(() => {
|
|
if (!sortConfig) return roots;
|
|
|
|
const sortNodes = (nodes: TaskTreeNode[]): TaskTreeNode[] => {
|
|
const sorted = [...nodes].sort((a, b) => {
|
|
const { field, direction } = sortConfig;
|
|
const multiplier = direction === "asc" ? 1 : -1;
|
|
|
|
switch (field) {
|
|
case "title":
|
|
return multiplier * a.task.title.localeCompare(b.task.title);
|
|
case "status":
|
|
return multiplier * a.task.status.localeCompare(b.task.status);
|
|
case "team":
|
|
return multiplier * a.task.team.localeCompare(b.task.team);
|
|
case "priority":
|
|
return multiplier * (a.task.priority - b.task.priority);
|
|
case "assigned_to":
|
|
const aAssigned = a.task.assigned_to || "";
|
|
const bAssigned = b.task.assigned_to || "";
|
|
return multiplier * aAssigned.localeCompare(bAssigned);
|
|
case "created_at":
|
|
return (
|
|
multiplier *
|
|
(new Date(a.task.created_at).getTime() -
|
|
new Date(b.task.created_at).getTime())
|
|
);
|
|
default:
|
|
return 0;
|
|
}
|
|
});
|
|
|
|
// Also sort children recursively
|
|
return sorted.map((node) => ({
|
|
...node,
|
|
children: sortNodes(node.children),
|
|
}));
|
|
};
|
|
|
|
return sortNodes(roots);
|
|
}, [roots, sortConfig]);
|
|
|
|
// Flatten tree based on expanded state
|
|
const flattenedTasks = useMemo(() => {
|
|
return flattenTree(sortedRoots, expandedIds);
|
|
}, [sortedRoots, expandedIds]);
|
|
|
|
// Pagination on flattened list
|
|
const totalItems = flattenedTasks.length;
|
|
const totalPages = Math.ceil(totalItems / pageSize);
|
|
const startIndex = (currentPage - 1) * pageSize;
|
|
const endIndex = Math.min(startIndex + pageSize, totalItems);
|
|
const paginatedTasks = flattenedTasks.slice(startIndex, endIndex);
|
|
|
|
const handlePageSizeChange = (value: string) => {
|
|
const newSize = Number(value);
|
|
if (onPageSizeChange) {
|
|
onPageSizeChange(newSize);
|
|
} else {
|
|
setInternalPageSize(newSize);
|
|
setInternalCurrentPage(1);
|
|
}
|
|
};
|
|
|
|
const goToPage = (page: number) => {
|
|
const newPage = Math.max(1, Math.min(page, totalPages));
|
|
if (onPageChange) {
|
|
onPageChange(newPage);
|
|
} else {
|
|
setInternalCurrentPage(newPage);
|
|
}
|
|
};
|
|
|
|
const toggleExpand = (taskId: string) => {
|
|
const next = new Set(expandedIds);
|
|
if (next.has(taskId)) {
|
|
next.delete(taskId);
|
|
} else {
|
|
next.add(taskId);
|
|
}
|
|
if (onExpandedChange) {
|
|
onExpandedChange(next);
|
|
} else {
|
|
setInternalExpandedIds(next);
|
|
}
|
|
};
|
|
|
|
const expandAll = () => {
|
|
const allParentIds = new Set<string>();
|
|
tasks?.forEach((task) => {
|
|
if (childrenMap.has(task.id)) {
|
|
allParentIds.add(task.id);
|
|
}
|
|
});
|
|
if (onExpandedChange) {
|
|
onExpandedChange(allParentIds);
|
|
} else {
|
|
setInternalExpandedIds(allParentIds);
|
|
}
|
|
};
|
|
|
|
const collapseAll = () => {
|
|
if (onExpandedChange) {
|
|
onExpandedChange(new Set());
|
|
} else {
|
|
setInternalExpandedIds(new Set());
|
|
}
|
|
};
|
|
|
|
// Count how many tasks have children
|
|
const hasAnyChildren = childrenMap.size > 0;
|
|
|
|
return (
|
|
<Card>
|
|
<CardContent className="p-0">
|
|
{/* Tree controls */}
|
|
{hasAnyChildren && !isLoading && (
|
|
<div className="flex items-center gap-2 px-4 py-2 border-b bg-muted/30">
|
|
<span className="text-sm text-muted-foreground">Tree view:</span>
|
|
<Button
|
|
variant="ghost"
|
|
size="sm"
|
|
className="h-7 text-xs"
|
|
onClick={expandAll}
|
|
>
|
|
Expand all
|
|
</Button>
|
|
<Button
|
|
variant="ghost"
|
|
size="sm"
|
|
className="h-7 text-xs"
|
|
onClick={collapseAll}
|
|
>
|
|
Collapse all
|
|
</Button>
|
|
</div>
|
|
)}
|
|
|
|
<ResponsiveTable
|
|
table={
|
|
<Table>
|
|
<TableHeader>
|
|
<TableRow>
|
|
<SortableHeader
|
|
label="Title"
|
|
field="title"
|
|
sortConfig={sortConfig}
|
|
onSort={handleSort}
|
|
/>
|
|
<SortableHeader
|
|
label="Status"
|
|
field="status"
|
|
sortConfig={sortConfig}
|
|
onSort={handleSort}
|
|
className="whitespace-nowrap"
|
|
/>
|
|
<TableHead className="whitespace-nowrap">Git</TableHead>
|
|
<SortableHeader
|
|
label="Team"
|
|
field="team"
|
|
sortConfig={sortConfig}
|
|
onSort={handleSort}
|
|
className="whitespace-nowrap"
|
|
/>
|
|
<TableHead className="whitespace-nowrap">
|
|
Project / Product
|
|
</TableHead>
|
|
<SortableHeader
|
|
label="Priority"
|
|
field="priority"
|
|
sortConfig={sortConfig}
|
|
onSort={handleSort}
|
|
className="whitespace-nowrap"
|
|
/>
|
|
<SortableHeader
|
|
label="Assigned To"
|
|
field="assigned_to"
|
|
sortConfig={sortConfig}
|
|
onSort={handleSort}
|
|
className="whitespace-nowrap"
|
|
/>
|
|
<SortableHeader
|
|
label="Created"
|
|
field="created_at"
|
|
sortConfig={sortConfig}
|
|
onSort={handleSort}
|
|
className="whitespace-nowrap"
|
|
/>
|
|
<TableHead className="w-10"></TableHead>
|
|
</TableRow>
|
|
</TableHeader>
|
|
<TableBody>
|
|
{isLoading ? (
|
|
<TaskTableSkeleton />
|
|
) : paginatedTasks.length === 0 ? (
|
|
<TaskTableEmpty />
|
|
) : (
|
|
paginatedTasks.map((node) => {
|
|
const task = node.task;
|
|
const hasChildren = node.children.length > 0;
|
|
const isExpanded = expandedIds.has(task.id);
|
|
const childCount = childrenMap.get(task.id)?.length || 0;
|
|
|
|
const handleRowClick = (e: React.MouseEvent) => {
|
|
// Don't toggle if clicking on interactive elements
|
|
const target = e.target as HTMLElement;
|
|
if (
|
|
target.closest("a") ||
|
|
target.closest("button") ||
|
|
target.closest('[role="button"]') ||
|
|
target.closest("[data-no-expand]")
|
|
) {
|
|
return;
|
|
}
|
|
if (hasChildren) {
|
|
toggleExpand(task.id);
|
|
}
|
|
};
|
|
|
|
return (
|
|
<TableRow
|
|
key={task.id}
|
|
className={cn(
|
|
"hover:bg-muted/50",
|
|
node.depth > 0 && "bg-muted/20",
|
|
hasChildren && "cursor-pointer",
|
|
)}
|
|
onClick={handleRowClick}
|
|
>
|
|
<TableCell className="max-w-[22rem]">
|
|
<div
|
|
className="flex items-center gap-1 min-w-0"
|
|
style={{ paddingLeft: `${node.depth * 1.5}rem` }}
|
|
>
|
|
{hasChildren ? (
|
|
<Button
|
|
onClick={() => toggleExpand(task.id)}
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
className="p-0.5 h-5 w-5 shrink-0"
|
|
>
|
|
{isExpanded ? (
|
|
<ChevronDown className="h-4 w-4" />
|
|
) : (
|
|
<ChevronRightIcon className="h-4 w-4" />
|
|
)}
|
|
</Button>
|
|
) : (
|
|
<span className="w-5 shrink-0" />
|
|
)}
|
|
<Link
|
|
prefetch={false}
|
|
href={"/tasks/" + task.id}
|
|
className="block hover:underline min-w-0"
|
|
>
|
|
<div className="font-medium flex items-center gap-2 min-w-0">
|
|
<span className="truncate" title={task.title}>
|
|
{task.title}
|
|
</span>
|
|
{task.batch_id && !task.parent_task_id && (
|
|
<Badge
|
|
variant="outline"
|
|
className="text-xs shrink-0 border-primary/50 text-primary"
|
|
>
|
|
MegaTask
|
|
</Badge>
|
|
)}
|
|
{childCount > 0 && (
|
|
<Badge
|
|
variant="secondary"
|
|
className="text-xs shrink-0"
|
|
>
|
|
{childCount} subtask
|
|
{childCount !== 1 ? "s" : ""}
|
|
</Badge>
|
|
)}
|
|
</div>
|
|
</Link>
|
|
</div>
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<TaskStatusBadge status={task.status} />
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<GitStatusBadge
|
|
task={task}
|
|
repoUrl={
|
|
task.project_id
|
|
? projectGitUrls[task.project_id]
|
|
: undefined
|
|
}
|
|
/>
|
|
</TableCell>
|
|
<TableCell className="capitalize whitespace-nowrap">
|
|
{task.team.replace(/_/g, " ")}
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap text-sm">
|
|
{task.project_id && projectNames[task.project_id] ? (
|
|
<span>{projectNames[task.project_id]}</span>
|
|
) : task.product_id &&
|
|
productNames[task.product_id] ? (
|
|
<span className="text-muted-foreground">
|
|
{productNames[task.product_id]}{" "}
|
|
<span className="text-xs">(product)</span>
|
|
</span>
|
|
) : (
|
|
<span className="text-muted-foreground">—</span>
|
|
)}
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Badge
|
|
className={
|
|
(priorityColors[task.priority] ??
|
|
priorityColors[2]) + " text-xs"
|
|
}
|
|
>
|
|
{priorityLabels[task.priority] ?? "P2 - Medium"}
|
|
</Badge>
|
|
</TableCell>
|
|
<TableCell className="whitespace-nowrap">
|
|
<Badge variant="outline">
|
|
{getAgentDisplayName(task.assigned_to)}
|
|
</Badge>
|
|
</TableCell>
|
|
<TableCell className="text-muted-foreground text-sm whitespace-nowrap">
|
|
{formatDistanceToNow(new Date(task.created_at), {
|
|
addSuffix: true,
|
|
})}
|
|
</TableCell>
|
|
<TableCell>
|
|
<TaskActions task={task} />
|
|
</TableCell>
|
|
</TableRow>
|
|
);
|
|
})
|
|
)}
|
|
</TableBody>
|
|
</Table>
|
|
}
|
|
cards={
|
|
isLoading ? (
|
|
<TaskCardSkeletons />
|
|
) : paginatedTasks.length === 0 ? (
|
|
<ResponsiveTableCardEmpty className="m-3">
|
|
No tasks found
|
|
</ResponsiveTableCardEmpty>
|
|
) : (
|
|
<ResponsiveTableCardList className="p-3">
|
|
{paginatedTasks.map((node) => {
|
|
const task = node.task;
|
|
const hasChildren = node.children.length > 0;
|
|
const isExpanded = expandedIds.has(task.id);
|
|
const childCount = childrenMap.get(task.id)?.length || 0;
|
|
|
|
return (
|
|
<ResponsiveTableCard
|
|
key={task.id}
|
|
style={{ marginLeft: `${node.depth * 1}rem` }}
|
|
>
|
|
<div className="flex items-start justify-between gap-2">
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex items-center gap-1.5">
|
|
{hasChildren && (
|
|
<Button
|
|
onClick={() => toggleExpand(task.id)}
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
className="h-5 w-5 shrink-0 p-0.5"
|
|
aria-label={isExpanded ? "Collapse" : "Expand"}
|
|
>
|
|
{isExpanded ? (
|
|
<ChevronDown className="h-4 w-4" />
|
|
) : (
|
|
<ChevronRightIcon className="h-4 w-4" />
|
|
)}
|
|
</Button>
|
|
)}
|
|
<Link
|
|
prefetch={false}
|
|
href={"/tasks/" + task.id}
|
|
className="min-w-0 truncate font-medium hover:underline"
|
|
title={task.title}
|
|
>
|
|
{task.title}
|
|
</Link>
|
|
</div>
|
|
{(task.batch_id && !task.parent_task_id) ||
|
|
childCount > 0 ? (
|
|
<div className="mt-1 flex flex-wrap gap-1">
|
|
{task.batch_id && !task.parent_task_id && (
|
|
<Badge
|
|
variant="outline"
|
|
className="border-primary/50 text-xs text-primary"
|
|
>
|
|
MegaTask
|
|
</Badge>
|
|
)}
|
|
{childCount > 0 && (
|
|
<Badge variant="secondary" className="text-xs">
|
|
{childCount} subtask
|
|
{childCount !== 1 ? "s" : ""}
|
|
</Badge>
|
|
)}
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
<TaskActions task={task} />
|
|
</div>
|
|
|
|
<div className="mt-3 divide-y">
|
|
<ResponsiveTableCardRow label="Status">
|
|
<TaskStatusBadge status={task.status} />
|
|
</ResponsiveTableCardRow>
|
|
<ResponsiveTableCardRow label="Git">
|
|
<GitStatusBadge
|
|
task={task}
|
|
repoUrl={
|
|
task.project_id
|
|
? projectGitUrls[task.project_id]
|
|
: undefined
|
|
}
|
|
/>
|
|
</ResponsiveTableCardRow>
|
|
<ResponsiveTableCardRow label="Team">
|
|
<span className="capitalize">
|
|
{task.team.replace(/_/g, " ")}
|
|
</span>
|
|
</ResponsiveTableCardRow>
|
|
<ResponsiveTableCardRow label="Project">
|
|
{task.project_id && projectNames[task.project_id]
|
|
? projectNames[task.project_id]
|
|
: task.product_id && productNames[task.product_id]
|
|
? `${productNames[task.product_id]} (product)`
|
|
: "—"}
|
|
</ResponsiveTableCardRow>
|
|
<ResponsiveTableCardRow label="Priority">
|
|
<Badge
|
|
className={
|
|
(priorityColors[task.priority] ??
|
|
priorityColors[2]) + " text-xs"
|
|
}
|
|
>
|
|
{priorityLabels[task.priority] ?? "P2 - Medium"}
|
|
</Badge>
|
|
</ResponsiveTableCardRow>
|
|
<ResponsiveTableCardRow label="Assigned">
|
|
<Badge variant="outline">
|
|
{getAgentDisplayName(task.assigned_to)}
|
|
</Badge>
|
|
</ResponsiveTableCardRow>
|
|
<ResponsiveTableCardRow label="Created">
|
|
{formatDistanceToNow(new Date(task.created_at), {
|
|
addSuffix: true,
|
|
})}
|
|
</ResponsiveTableCardRow>
|
|
</div>
|
|
</ResponsiveTableCard>
|
|
);
|
|
})}
|
|
</ResponsiveTableCardList>
|
|
)
|
|
}
|
|
/>
|
|
|
|
{/* Pagination Controls */}
|
|
{!isLoading && tasks && tasks.length > 0 && (
|
|
<div className="flex flex-wrap items-center justify-end gap-4 px-4 py-3 border-t">
|
|
<div className="flex items-center gap-2 text-sm text-muted-foreground">
|
|
<span>Rows:</span>
|
|
<Select
|
|
value={String(pageSize)}
|
|
onValueChange={handlePageSizeChange}
|
|
>
|
|
<SelectTrigger className="w-auto min-w-14 h-8">
|
|
<SelectValue />
|
|
</SelectTrigger>
|
|
<SelectContent>
|
|
{PAGE_SIZE_OPTIONS.map((size) => (
|
|
<SelectItem key={size} value={String(size)}>
|
|
{size}
|
|
</SelectItem>
|
|
))}
|
|
</SelectContent>
|
|
</Select>
|
|
</div>
|
|
<span className="text-sm text-muted-foreground">
|
|
{startIndex + 1}-{endIndex} of {totalItems}
|
|
</span>
|
|
<div className="flex items-center gap-1">
|
|
<Button
|
|
variant="outline"
|
|
size="icon"
|
|
className="h-8 w-8"
|
|
onClick={() => goToPage(currentPage - 1)}
|
|
disabled={currentPage === 1}
|
|
>
|
|
<ChevronLeft className="h-4 w-4" />
|
|
</Button>
|
|
<Button
|
|
variant="outline"
|
|
size="icon"
|
|
className="h-8 w-8"
|
|
onClick={() => goToPage(currentPage + 1)}
|
|
disabled={currentPage === totalPages}
|
|
>
|
|
<ChevronRight className="h-4 w-4" />
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
)}
|
|
</CardContent>
|
|
</Card>
|
|
);
|
|
}
|