mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
3a67fa4a0f
Sweep found pitch slug was the one content-tool free-text field still outside the anti-soup guard (a product could be slugged 'wip'/'asdf'). Add it to the guard (min 2, so real short slugs like 'ui' pass). Also fix two pitch tests that were false-passing on a 1-char title (the title guard rejected first): give them substantive fields so they actually exercise the role gate (not_authorized) and the non-cell-target rejection (invalid_state).
79 lines
2.6 KiB
Python
79 lines
2.6 KiB
Python
"""roboco.services.gateway.content_actions.pitch — Board-gated product proposal."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.services.gateway.content_actions import ContentActions, ContentActionsDeps
|
|
|
|
|
|
def _actions(role: str) -> ContentActions:
|
|
task = MagicMock()
|
|
agent = MagicMock()
|
|
agent.role = role
|
|
task.agent_for = AsyncMock(return_value=agent)
|
|
task.session = MagicMock()
|
|
deps = ContentActionsDeps(
|
|
task=task,
|
|
git=MagicMock(),
|
|
messaging=MagicMock(),
|
|
a2a=MagicMock(),
|
|
journal=MagicMock(),
|
|
workspace=MagicMock(),
|
|
notifications=MagicMock(),
|
|
)
|
|
return ContentActions(deps)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_pitch_forbidden_for_non_board() -> None:
|
|
# Substantive fields so the soup guard passes and the ROLE gate is what
|
|
# rejects (a developer may not pitch) — not an incidental short-field fail.
|
|
env = await _actions("developer").pitch(
|
|
agent_id=uuid4(),
|
|
title="A self-serve widget catalog",
|
|
slug="widget-catalog",
|
|
problem="customers cannot browse widgets without an account",
|
|
proposed_solution="add a public widget catalog with search",
|
|
target_cells=["backend"],
|
|
)
|
|
assert env.error == "not_authorized"
|
|
assert env.status is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_pitch_creates_for_board(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
created = MagicMock()
|
|
created.id = uuid4()
|
|
svc = MagicMock()
|
|
svc.create = AsyncMock(return_value=created)
|
|
monkeypatch.setattr("roboco.services.pitch.get_pitch_service", lambda _s: svc)
|
|
env = await _actions("product_owner").pitch(
|
|
agent_id=uuid4(),
|
|
title="Widget",
|
|
slug="widget",
|
|
problem="people need widgets",
|
|
proposed_solution="build a widget service",
|
|
target_cells=["backend", "frontend"],
|
|
)
|
|
assert env.error is None
|
|
assert env.status == "proposed"
|
|
svc.create.assert_awaited_once()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_pitch_rejects_non_cell_target() -> None:
|
|
# Substantive fields so the soup guard passes and the non-cell TARGET is
|
|
# what rejects (a pitch can only target cells, not the board).
|
|
env = await _actions("head_marketing").pitch(
|
|
agent_id=uuid4(),
|
|
title="A self-serve widget catalog",
|
|
slug="widget-catalog",
|
|
problem="customers cannot browse widgets without an account",
|
|
proposed_solution="add a public widget catalog with search",
|
|
target_cells=["board"],
|
|
)
|
|
assert env.error == "invalid_state"
|