mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
cea3e56628
* feat(lifecycle): revision findings ledger — structured QA/PR/PM/CEO failure feedback, persisted and delivered down the chain Every bounce used to survive only as flattened prose: rounds overwrote each other in notes_structured, request_changes persisted nothing, two raw dev_notes appends were silently destroyed by the next handoff note, and the dev prompt pointed at fields (qa_notes via evidence(), pm_notes) the API never delivered. Agents re-interpreted and re-discovered every failure before they could start fixing it. - task_review_findings (migration 071, append-only): file/line/severity/ criterion(AC-id-validated)/expected/actual/fix/evidence per finding, with origin (qa|pr_gate|pm|ceo), round, and an open->addressed->verified lifecycle (waived reserved); new tasks.pm_notes + PmReviewContent give request_changes a structured home - producers: fail_review/pr_fail/request_changes take findings=[...] (prose issues shimmed+merged for one release, deprecation-logged); ceo_reject validates its reason (no 500), lands an origin=ceo finding, and bumps round+audit on branchless coordination roots; guardrails at the verb chokepoint (nudge >5, hard reject >10, field caps, traversal-safe file); the dev_notes data-loss appends are removed; new task.request_changes + task.ceo_reject audit events close rework attribution - delivery: qa_notes/pr_reviewer_notes/pm_notes carry the deterministic [F-id8] rendering; claim briefings, evidence(), the REVISION_REQUIRED spawn prompt, PM triage bounced-blocks, and A2A bodies deliver open findings; round-N+1 QA and gate reviewers get the full prior ledger; panel Findings tab + bounced-xN chip; metrics pm_rejects/ceo_rejects + findings counts; vault task notes render a Findings section (fail-open) - resolution closes for every origin: i_am_done and submit_up/submit_root take resolved_findings gated by FINDINGS_ADDRESSED (owner-gated so a stale non-owner PM can never mutate the ledger); pass_review/pr_pass/ complete verify-stamp same-transaction; ceo_approve stamps best-effort - 24 real-DB integration tests drive the full loop through the real choreographer; full suite 12856 green * docs: revision findings ledger sweep — CLAUDE.md, map, RAG corpus - CLAUDE.md: new ledger section + corrected request_changes row - docs/map/review-findings.md (new subsystem map) + surgical updates to task-service/pr-gate-review/metrics-observability/vault/panel maps - docs/rag: producers' findings contract across qa/pr-reviewer/developer/ cell-pm/main-pm/ceo role docs (the PM docs were missing request_changes entirely), verb references, and a new architecture/review-findings.md disambiguating ledger findings from convention findings * test(e2e): resubmit resolves the pr_fail finding per the ledger contract The scripted pr_fail revision loop resubmitted submit_up without resolved_findings — correctly rejected now that FINDINGS_ADDRESSED gates the PM resubmit verbs (green locally, red only in CI since the e2e suite skips without ROBOCO_E2E_SMOKE=1). The scripted PM now reads the open ledger row pr_fail persisted (new open_finding_ids arc helper) and resolves it on resubmit, asserting the open set drains — exercising the coordinator half of the new contract end to end. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
60 lines
1.8 KiB
Python
60 lines
1.8 KiB
Python
"""TaskService._audit_events_for — the rejector-attributed audit event selection.
|
|
|
|
A transition always emits the generic ``task.<status>``; a reviewer bounce to
|
|
needs_revision additionally emits ``task.qa_fail`` / ``task.pr_fail`` /
|
|
``task.request_changes`` / ``task.ceo_reject`` keyed on the acting role, so the
|
|
per-agent rework scorecard can attribute the rejection.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from roboco.services.task import TaskService
|
|
|
|
|
|
def test_generic_transition_emits_only_status_event() -> None:
|
|
assert TaskService._audit_events_for("awaiting_qa", "developer") == [
|
|
"task.awaiting_qa"
|
|
]
|
|
|
|
|
|
def test_qa_fail_adds_named_event() -> None:
|
|
assert TaskService._audit_events_for("needs_revision", "qa") == [
|
|
"task.needs_revision",
|
|
"task.qa_fail",
|
|
]
|
|
|
|
|
|
def test_pr_fail_adds_named_event() -> None:
|
|
assert TaskService._audit_events_for("needs_revision", "pr_reviewer") == [
|
|
"task.needs_revision",
|
|
"task.pr_fail",
|
|
]
|
|
|
|
|
|
def test_request_changes_adds_named_event_for_cell_pm() -> None:
|
|
assert TaskService._audit_events_for("needs_revision", "cell_pm") == [
|
|
"task.needs_revision",
|
|
"task.request_changes",
|
|
]
|
|
|
|
|
|
def test_request_changes_adds_named_event_for_main_pm() -> None:
|
|
assert TaskService._audit_events_for("needs_revision", "main_pm") == [
|
|
"task.needs_revision",
|
|
"task.request_changes",
|
|
]
|
|
|
|
|
|
def test_ceo_reject_to_needs_revision_adds_named_event() -> None:
|
|
assert TaskService._audit_events_for("needs_revision", "ceo") == [
|
|
"task.needs_revision",
|
|
"task.ceo_reject",
|
|
]
|
|
|
|
|
|
def test_named_event_only_on_needs_revision() -> None:
|
|
# A reviewer role on a non-needs_revision transition gets no named event.
|
|
assert TaskService._audit_events_for("awaiting_pm_review", "pr_reviewer") == [
|
|
"task.awaiting_pm_review"
|
|
]
|