mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
6cf99a1b0a
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154) * [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py - Create tests/__init__.py as empty package marker - Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py - Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py - Add return type annotations to _stub_get_optimal, _source, and factory functions - Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin - Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub - Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py - Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object - All 487 source files pass mypy with 0 errors; 2312 unit tests pass * [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/ Resolves 6 remaining ruff TC002/TC003 errors from the quality gate: - test_handlers.py: Iterator → TYPE_CHECKING - test_quality_gate.py: pathlib → TYPE_CHECKING - test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING - test_streaming.py: Iterator → TYPE_CHECKING - test_notification.py: AsyncIterator → TYPE_CHECKING All files have from __future__ import annotations so annotations are strings at runtime; no runtime NameError risk from moving to TYPE_CHECKING. * [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files * [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets --------- * [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155) * [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/ - Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.) - Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches - Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py - Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/ - No runtime logic changed — annotations and cast() only * [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate - Quote all cast() type arguments per ruff TC006 rule (cast("T", x)) - Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form) - Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.) - No runtime logic changed — annotation-only changeset * [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only) The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast targets already check `roboco/ tests/` — the lint target now matches gate scope. --------- --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
80 lines
2.8 KiB
Python
80 lines
2.8 KiB
Python
"""Tests for descriptive-commit-message gate."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from roboco.services.gateway.commit_validator import (
|
|
DEFAULT_MIN_CHARS,
|
|
ValidationResult,
|
|
validate_commit_message,
|
|
)
|
|
|
|
|
|
class TestSubjectLength:
|
|
def test_short_message_rejected(self) -> None:
|
|
r: ValidationResult = validate_commit_message("wip")
|
|
assert r.ok is False
|
|
assert r.reason is not None
|
|
reason = r.reason.lower()
|
|
assert "shorter than" in reason or "too short" in reason
|
|
|
|
def test_exact_min_length_accepted(self) -> None:
|
|
msg = "fix the auth header injection bug" # >=DEFAULT_MIN_CHARS chars
|
|
assert len(msg) >= DEFAULT_MIN_CHARS
|
|
r: ValidationResult = validate_commit_message(msg)
|
|
assert r.ok is True
|
|
|
|
|
|
class TestBannedWords:
|
|
@pytest.mark.parametrize("word", ["wip", "tmp", "asdf", "oops", "fix", "update"])
|
|
def test_single_banned_word_rejected(self, word: str) -> None:
|
|
r: ValidationResult = validate_commit_message(word)
|
|
assert r.ok is False
|
|
|
|
def test_banned_word_in_long_message_accepted(self) -> None:
|
|
# Banned-word check is only on single-token messages
|
|
r: ValidationResult = validate_commit_message(
|
|
"fix: handle null user id in auth middleware"
|
|
)
|
|
assert r.ok is True
|
|
|
|
|
|
class TestConventionalShape:
|
|
def test_conventional_shape_accepted(self) -> None:
|
|
r: ValidationResult = validate_commit_message(
|
|
"feat(gateway): add claimant_lock for single-active-agent invariant"
|
|
)
|
|
assert r.ok is True
|
|
|
|
def test_non_conventional_long_descriptive_accepted_with_hint(self) -> None:
|
|
r: ValidationResult = validate_commit_message(
|
|
"Refactored the workspace cloning logic to use the new path resolver"
|
|
)
|
|
assert r.ok is True
|
|
# Soft hint, not a rejection
|
|
assert r.hint is not None
|
|
assert "conventional" in r.hint.lower()
|
|
|
|
|
|
class TestRemediate:
|
|
def test_remediate_present_on_failure(self) -> None:
|
|
r: ValidationResult = validate_commit_message("wip")
|
|
assert r.remediate is not None
|
|
assert "<type>" in r.remediate or "type" in r.remediate.lower()
|
|
|
|
|
|
def test_empty_message_rejected() -> None:
|
|
"""Lines 57-62: empty/whitespace-only message rejection branch."""
|
|
r = validate_commit_message(" ")
|
|
assert r.ok is False
|
|
assert r.reason == "empty message"
|
|
|
|
|
|
def test_banned_word_long_enough_to_pass_min_chars() -> None:
|
|
"""Lines 76-81: single-token banned word that meets min_chars."""
|
|
# Use min_chars=2 so 'wip' (3 chars) passes length but hits banned-word.
|
|
r = validate_commit_message("wip", min_chars=2)
|
|
assert r.ok is False
|
|
assert r.reason is not None
|
|
assert "banned single-word" in r.reason
|