mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
92 lines
3.2 KiB
Python
92 lines
3.2 KiB
Python
"""End-to-end: the real validator subprocess feeds the real gate decision.
|
|
|
|
Exercises the whole enforcement path against a real repo on disk — effective
|
|
map (auto-derived ⊕ committed file), tree-sitter placement, waiver filtering,
|
|
and the gateway's block/pass decision — without the orchestrator plumbing:
|
|
|
|
1. a model defined in a router blocks the submit with the offending file:line;
|
|
2. after the model moves to ``app/models``, the submit passes;
|
|
3. a committed waiver lets a deliberately-kept model through the gate.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import subprocess
|
|
import sys
|
|
from typing import TYPE_CHECKING, Any
|
|
|
|
from roboco.services.gateway.choreographer import Choreographer
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
_MODEL_SRC = (
|
|
"from pydantic import BaseModel\nclass UserCreate(BaseModel):\n x: int\n"
|
|
)
|
|
_FORBID_MODEL = (
|
|
"modules:\n - path: app/routers\n purpose: routes\n forbidden: [model]\n"
|
|
)
|
|
|
|
|
|
def _run_validator(root: Path, files: list[str]) -> dict[str, Any]:
|
|
proc = subprocess.run(
|
|
[
|
|
sys.executable,
|
|
"-m",
|
|
"roboco.conventions",
|
|
"check",
|
|
"--root",
|
|
str(root),
|
|
"--files",
|
|
*files,
|
|
],
|
|
capture_output=True,
|
|
text=True,
|
|
check=False,
|
|
)
|
|
findings = [json.loads(line) for line in proc.stdout.splitlines() if line.strip()]
|
|
return {"findings": findings, "could_not_run": proc.returncode != 0}
|
|
|
|
|
|
def _write(root: Path, rel: str, content: str) -> None:
|
|
path = root / rel
|
|
path.parent.mkdir(parents=True, exist_ok=True)
|
|
path.write_text(content)
|
|
|
|
|
|
def test_block_then_fix_then_waiver(tmp_path: Path) -> None:
|
|
_write(tmp_path, ".roboco/conventions.yml", _FORBID_MODEL)
|
|
_write(tmp_path, "app/routers/users.py", _MODEL_SRC)
|
|
|
|
# 1. A Pydantic model in the router blocks, naming the offending file:line.
|
|
blocked = _run_validator(tmp_path, ["app/routers/users.py"])
|
|
rejection = Choreographer._conventions_rejection(blocked, {})
|
|
assert rejection is not None
|
|
assert "app/routers/users.py:2" in rejection.as_dict()["remediate"]
|
|
|
|
# 2. Move the model to app/models; the router now only holds a route → passes.
|
|
_write(
|
|
tmp_path,
|
|
"app/routers/users.py",
|
|
"@router.get('/users')\ndef list_users():\n return []\n",
|
|
)
|
|
_write(tmp_path, "app/models/user.py", _MODEL_SRC)
|
|
fixed = _run_validator(tmp_path, ["app/routers/users.py", "app/models/user.py"])
|
|
assert Choreographer._conventions_rejection(fixed, {}) is None
|
|
|
|
# 3. A deliberately-kept model in a router blocks — until a committed waiver
|
|
# (reviewed in the PR) suppresses exactly that finding.
|
|
_write(tmp_path, "app/routers/legacy.py", _MODEL_SRC)
|
|
still_blocked = _run_validator(tmp_path, ["app/routers/legacy.py"])
|
|
assert Choreographer._conventions_rejection(still_blocked, {}) is not None
|
|
|
|
_write(
|
|
tmp_path,
|
|
".roboco/conventions.yml",
|
|
_FORBID_MODEL + "waivers:\n - path: app/routers/legacy.py\n"
|
|
" rule: no_models_in_routers\n reason: extraction tracked\n",
|
|
)
|
|
waived = _run_validator(tmp_path, ["app/routers/legacy.py"])
|
|
assert Choreographer._conventions_rejection(waived, {}) is None
|