mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
69 lines
2.4 KiB
Python
69 lines
2.4 KiB
Python
"""Repo auto-scan + scaffold-draft renderer."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from roboco.conventions.scan import derive_from_scan, render_yaml
|
|
from roboco.foundation.policy.conventions.models import ConventionsStandard
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
def _sample_repo(root: Path) -> None:
|
|
(root / "app" / "routers").mkdir(parents=True)
|
|
(root / "app" / "models").mkdir(parents=True)
|
|
(root / "app" / "services").mkdir(parents=True)
|
|
(root / "app" / "routers" / "users.py").write_text("x = 1\n")
|
|
(root / "app" / "models" / "user.py").write_text("y = 2\n")
|
|
(root / "app" / "services" / "logic.py").write_text("z = 3\n")
|
|
|
|
|
|
def test_scan_derives_router_module_forbidding_models(tmp_path: Path) -> None:
|
|
_sample_repo(tmp_path)
|
|
std = derive_from_scan(tmp_path)
|
|
routers = [m for m in std.modules if m.path == "app/routers"]
|
|
assert routers and "model" in routers[0].forbidden
|
|
|
|
|
|
def test_scan_detects_python_language(tmp_path: Path) -> None:
|
|
_sample_repo(tmp_path)
|
|
assert "python" in derive_from_scan(tmp_path).languages
|
|
|
|
|
|
def test_scan_seeds_builtin_rules(tmp_path: Path) -> None:
|
|
_sample_repo(tmp_path)
|
|
std = derive_from_scan(tmp_path)
|
|
assert std.rules["no_models_in_routers"].level == "block"
|
|
assert std.rules["no_inline_comments"].level == "warn"
|
|
|
|
|
|
def test_scan_ignores_vendored_directories(tmp_path: Path) -> None:
|
|
(tmp_path / "node_modules" / "pkg" / "routers").mkdir(parents=True)
|
|
(tmp_path / ".venv" / "lib" / "models").mkdir(parents=True)
|
|
std = derive_from_scan(tmp_path)
|
|
assert std.modules == []
|
|
|
|
|
|
def test_scan_lifts_claude_md_imperative_into_custom_rule(tmp_path: Path) -> None:
|
|
_sample_repo(tmp_path)
|
|
(tmp_path / "CLAUDE.md").write_text("- Never use `print()`; use the logger.\n")
|
|
custom = derive_from_scan(tmp_path).custom
|
|
assert custom
|
|
assert custom[0].level == "warn"
|
|
assert "print" in custom[0].pattern
|
|
|
|
|
|
def test_render_yaml_round_trips_through_parse(tmp_path: Path) -> None:
|
|
_sample_repo(tmp_path)
|
|
(tmp_path / "CLAUDE.md").write_text("Do not call `eval()` anywhere.\n")
|
|
std = derive_from_scan(tmp_path)
|
|
reparsed = ConventionsStandard.parse_yaml(render_yaml(std))
|
|
assert reparsed == std
|
|
|
|
|
|
def test_render_yaml_round_trips_empty_standard() -> None:
|
|
std = ConventionsStandard()
|
|
assert ConventionsStandard.parse_yaml(render_yaml(std)) == std
|