mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
111 lines
3.7 KiB
Python
111 lines
3.7 KiB
Python
"""TaskService.create appends the project's baseline constraints (flag-gated)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from uuid import UUID, uuid4
|
|
|
|
from roboco.config import settings
|
|
from roboco.db.tables import AgentTable, ProjectTable
|
|
from roboco.models import AgentRole, AgentStatus, Complexity, Team
|
|
from roboco.models.base import TaskNature
|
|
from roboco.models.task import TaskCreateRequest, TaskType
|
|
from roboco.services.task import TaskService
|
|
|
|
if TYPE_CHECKING:
|
|
import pytest
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
|
|
async def _seed(db: AsyncSession) -> tuple[AgentTable, ProjectTable]:
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"be-dev-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="dev",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db.add(agent)
|
|
await db.flush()
|
|
project = ProjectTable(
|
|
id=uuid4(),
|
|
name="C-Proj",
|
|
slug=f"c-proj-{uuid4().hex[:8]}",
|
|
git_url="https://example.com/r.git",
|
|
assigned_cell=Team.BACKEND,
|
|
created_by=agent.id,
|
|
)
|
|
db.add(project)
|
|
await db.flush()
|
|
return agent, project
|
|
|
|
|
|
def _req(
|
|
agent: AgentTable, project: ProjectTable, description: str
|
|
) -> TaskCreateRequest:
|
|
return TaskCreateRequest(
|
|
title="A task",
|
|
description=description,
|
|
acceptance_criteria=["it works"],
|
|
team=Team.BACKEND,
|
|
created_by=UUID(str(agent.id)),
|
|
task_type=TaskType.CODE,
|
|
nature=TaskNature.TECHNICAL,
|
|
estimated_complexity=Complexity.MEDIUM,
|
|
project_id=UUID(str(project.id)),
|
|
)
|
|
|
|
|
|
async def test_baseline_attached_when_flag_on(
|
|
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "conventions_enabled", True)
|
|
agent, project = await _seed(db_session)
|
|
task = await TaskService(db_session).create(_req(agent, project, "Do the work"))
|
|
assert task.description is not None
|
|
assert "## Constraints" in task.description
|
|
assert "no models in routers" in task.description
|
|
|
|
|
|
async def test_flag_off_attaches_nothing(
|
|
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "conventions_enabled", False)
|
|
agent, project = await _seed(db_session)
|
|
task = await TaskService(db_session).create(_req(agent, project, "Do the work"))
|
|
assert task.description == "Do the work"
|
|
|
|
|
|
async def test_baseline_not_suppressed_by_agent_constraints_section(
|
|
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
# An agent-authored ## Constraints section must NOT suppress the mandatory
|
|
# server baseline — both are present.
|
|
monkeypatch.setattr(settings, "conventions_enabled", True)
|
|
agent, project = await _seed(db_session)
|
|
seeded = "Do the work\n\n## Constraints\n- a task-specific note"
|
|
task = await TaskService(db_session).create(_req(agent, project, seeded))
|
|
assert task.description is not None
|
|
assert "a task-specific note" in task.description
|
|
assert "no models in routers" in task.description
|
|
|
|
|
|
async def test_baseline_attach_is_idempotent(
|
|
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "conventions_enabled", True)
|
|
agent, project = await _seed(db_session)
|
|
svc = TaskService(db_session)
|
|
task = await svc.create(_req(agent, project, "Do the work"))
|
|
before = task.description
|
|
await svc._attach_baseline_constraints(task)
|
|
assert task.description == before
|
|
assert task.description is not None
|
|
assert task.description.count("no models in routers") == 1
|