mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
70 lines
2.3 KiB
Python
70 lines
2.3 KiB
Python
"""``python -m roboco.conventions check --root <dir> --files <a> <b> ...``.
|
|
|
|
Builds the effective map from the repo's ``.roboco/conventions.yml`` overlaid
|
|
on auto-derived defaults, runs the validator over the named files, and prints
|
|
one JSON finding per line. Exit 0 when it ran (findings may be empty or
|
|
present); exit 3 when it could not run (a broken config or a grammar failure),
|
|
with ``{"error": ...}`` on stderr — the fail-loud signal the gate blocks on.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
import json
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
from roboco.foundation.policy.conventions.effective_map import effective_map
|
|
from roboco.foundation.policy.conventions.models import (
|
|
ConventionsParseError,
|
|
ConventionsStandard,
|
|
)
|
|
|
|
from .runner import ValidatorCouldNotRun, run
|
|
from .scan import derive_from_scan
|
|
|
|
_CONVENTIONS_FILE = ".roboco/conventions.yml"
|
|
_EXIT_COULD_NOT_RUN = 3
|
|
|
|
|
|
def _load_file(root: Path) -> ConventionsStandard | None:
|
|
path = root / _CONVENTIONS_FILE
|
|
if not path.is_file():
|
|
return None
|
|
return ConventionsStandard.parse_yaml(path.read_text())
|
|
|
|
|
|
def _fail(reason: str) -> int:
|
|
print(json.dumps({"error": reason}), file=sys.stderr)
|
|
return _EXIT_COULD_NOT_RUN
|
|
|
|
|
|
def _run_check(root: Path, files: list[str]) -> int:
|
|
try:
|
|
file_standard = _load_file(root)
|
|
except ConventionsParseError as exc:
|
|
return _fail(f"unparseable {_CONVENTIONS_FILE}: {exc.reason}")
|
|
standard = effective_map(derive_from_scan(root), file_standard)
|
|
try:
|
|
findings = run(root, files, standard)
|
|
except ValidatorCouldNotRun as exc:
|
|
return _fail(str(exc))
|
|
for finding in findings:
|
|
print(finding.as_json())
|
|
return 0
|
|
|
|
|
|
def main(argv: list[str] | None = None) -> int:
|
|
"""Parse args and run the requested command. Returns the process exit code."""
|
|
parser = argparse.ArgumentParser(prog="python -m roboco.conventions")
|
|
subcommands = parser.add_subparsers(dest="command", required=True)
|
|
check = subcommands.add_parser("check", help="check changed files")
|
|
check.add_argument("--root", required=True, type=Path)
|
|
check.add_argument("--files", nargs="*", default=[])
|
|
args = parser.parse_args(argv)
|
|
return _run_check(args.root, list(args.files))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
raise SystemExit(main())
|