mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
41ef7f6b4e
_check_pm_decision_required now requires the latest journal:decision within pm_decision_window_seconds (default 300). Older decisions no longer satisfy the gate. Adds JournalService.latest_decision_at. Future-tighten (out of scope): per-verb-group consumption tracking would need persistent state — Choreographer is per-request today.
220 lines
7.7 KiB
Python
220 lines
7.7 KiB
Python
"""Gate Set F: completion-time guards.
|
|
|
|
cell_pm_complete / main_pm_complete / submit_up must refuse to advance
|
|
the parent past awaiting_pm_review when any subtask is still non-
|
|
terminal. Pre-gateway location: roboco/services/task.py closure check.
|
|
|
|
These tests verify:
|
|
1. The non-terminal-subtask refusal fires.
|
|
2. The remediation NAMES the non-terminal subtasks (improvement over
|
|
the previous generic "find pending subtasks" hint).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.services.gateway.choreographer import Choreographer, ChoreographerDeps
|
|
|
|
|
|
def _make_deps(**overrides: Any) -> ChoreographerDeps:
|
|
base: dict[str, Any] = {
|
|
"task": AsyncMock(),
|
|
"work_session": AsyncMock(),
|
|
"git": AsyncMock(),
|
|
"a2a": AsyncMock(),
|
|
"journal": AsyncMock(),
|
|
"audit": AsyncMock(),
|
|
"evidence_repo": AsyncMock(),
|
|
}
|
|
base.update(overrides)
|
|
# VerbRunner wraps composed atomic actions in
|
|
# ``task.session.begin_nested()``. AsyncMock auto-attribute access
|
|
# would return an unawaitable coroutine, breaking the
|
|
# ``async with`` protocol. Overwrite session with a MagicMock that
|
|
# implements the async-context-manager protocol explicitly.
|
|
task_dep = base["task"]
|
|
task_dep.session = MagicMock()
|
|
task_dep.session.begin_nested = MagicMock(
|
|
return_value=MagicMock(
|
|
__aenter__=AsyncMock(return_value=None),
|
|
__aexit__=AsyncMock(return_value=False),
|
|
)
|
|
)
|
|
repo = base["evidence_repo"]
|
|
for method in (
|
|
"list_unread_a2a",
|
|
"list_unread_mentions",
|
|
"list_pending_notifications",
|
|
"task_metadata_gaps",
|
|
"recent_team_activity",
|
|
"blockers_in_lane",
|
|
"journal_highlights_for_task",
|
|
):
|
|
getattr(repo, method).return_value = []
|
|
# C8: default-fresh journal:decision so PM-decision gate passes.
|
|
# Tests that exercise the gate boundary stub their own value.
|
|
# The check matches MagicMock and AsyncMock (the two default sentinel
|
|
# types pytest's unittest.mock leaves on un-stubbed return_values).
|
|
_ldef = base["journal"].latest_decision_at.return_value
|
|
if type(_ldef).__name__ in ("MagicMock", "AsyncMock"):
|
|
base["journal"].latest_decision_at.return_value = datetime.now(UTC)
|
|
return ChoreographerDeps(**base)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# cell_pm_complete subtask gate
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_cell_pm_complete_blocks_when_subtask_pending() -> None:
|
|
pm_id = uuid4()
|
|
parent_id = uuid4()
|
|
sub_id = uuid4()
|
|
t = MagicMock(
|
|
id=parent_id,
|
|
status="awaiting_pm_review",
|
|
assigned_to=pm_id,
|
|
pr_number=10,
|
|
team="backend",
|
|
branch_name="feature/backend/abc",
|
|
)
|
|
sub = MagicMock(id=sub_id, status="pending", title="Half-done subtask")
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = t
|
|
task_svc.all_subtasks_terminal.return_value = False
|
|
task_svc.get_subtasks.return_value = [sub]
|
|
journal_svc = AsyncMock()
|
|
journal_svc.has_decision_for_task.return_value = True
|
|
journal_svc.latest_decision_at.return_value = datetime.now(UTC)
|
|
journal_svc.has_reflect_for_task.return_value = True
|
|
deps = _make_deps(task=task_svc, journal=journal_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.cell_pm_complete(
|
|
pm_id, parent_id, "reviewed cell scope and merge ready"
|
|
)
|
|
body = env.as_dict()
|
|
assert body["error"] == "tracing_gap"
|
|
# Improvement: non-terminal subtask must be named.
|
|
assert str(sub_id) in body["remediate"]
|
|
task_svc.cell_pm_complete.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_cell_pm_complete_allows_when_all_terminal() -> None:
|
|
pm_id = uuid4()
|
|
parent_id = uuid4()
|
|
t = MagicMock(
|
|
id=parent_id,
|
|
status="awaiting_pm_review",
|
|
assigned_to=pm_id,
|
|
pr_number=10,
|
|
team="backend",
|
|
branch_name="feature/backend/abc",
|
|
parent_task_id=None,
|
|
)
|
|
after = MagicMock(**{**t.__dict__, "status": "completed"})
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = t
|
|
task_svc.all_subtasks_terminal.return_value = True
|
|
task_svc.get_subtasks.return_value = []
|
|
task_svc.cell_pm_complete.return_value = after
|
|
journal_svc = AsyncMock()
|
|
journal_svc.has_decision_for_task.return_value = True
|
|
journal_svc.latest_decision_at.return_value = datetime.now(UTC)
|
|
journal_svc.has_reflect_for_task.return_value = True
|
|
git_svc = AsyncMock()
|
|
git_svc.pr_merge.return_value = {"merge_commit_sha": "abc"}
|
|
deps = _make_deps(task=task_svc, journal=journal_svc, git=git_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.cell_pm_complete(pm_id, parent_id, "cell scope reviewed and approved")
|
|
assert env.error is None
|
|
task_svc.cell_pm_complete.assert_awaited_once()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# main_pm_complete subtask gate (root-task case)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_main_pm_complete_blocks_when_subtask_pending() -> None:
|
|
pm_id = uuid4()
|
|
root_id = uuid4()
|
|
sub_id = uuid4()
|
|
t = MagicMock(
|
|
id=root_id,
|
|
status="awaiting_pm_review",
|
|
assigned_to=pm_id,
|
|
parent_task_id=None,
|
|
pr_number=10,
|
|
team="backend",
|
|
branch_name="feature/backend/abc",
|
|
)
|
|
sub = MagicMock(id=sub_id, status="in_progress", title="Subtask still active")
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = t
|
|
task_svc.all_subtasks_terminal.return_value = False
|
|
task_svc.get_subtasks.return_value = [sub]
|
|
journal_svc = AsyncMock()
|
|
journal_svc.has_decision_for_task.return_value = True
|
|
journal_svc.latest_decision_at.return_value = datetime.now(UTC)
|
|
journal_svc.has_reflect_for_task.return_value = True
|
|
deps = _make_deps(task=task_svc, journal=journal_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.main_pm_complete(
|
|
pm_id, root_id, "root scope ready to ship to production"
|
|
)
|
|
body = env.as_dict()
|
|
assert body["error"] == "tracing_gap"
|
|
assert str(sub_id) in body["remediate"]
|
|
task_svc.escalate_to_ceo.assert_not_awaited()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# submit_up subtask gate (cell PM bubbling up to main PM)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_submit_up_blocks_when_subtask_pending() -> None:
|
|
pm_id = uuid4()
|
|
parent_id = uuid4()
|
|
sub_id = uuid4()
|
|
t = MagicMock(
|
|
id=parent_id,
|
|
status="in_progress",
|
|
assigned_to=pm_id,
|
|
branch_name="feature/backend/abc",
|
|
team="backend",
|
|
)
|
|
sub = MagicMock(id=sub_id, status="paused", title="Paused subtask")
|
|
task_svc = AsyncMock()
|
|
task_svc.get.return_value = t
|
|
task_svc.agent_for.return_value = MagicMock(role="cell_pm")
|
|
task_svc.all_subtasks_terminal.return_value = False
|
|
task_svc.get_subtasks.return_value = [sub]
|
|
journal_svc = AsyncMock()
|
|
journal_svc.has_decision_for_task.return_value = True
|
|
journal_svc.latest_decision_at.return_value = datetime.now(UTC)
|
|
deps = _make_deps(task=task_svc, journal=journal_svc)
|
|
c = Choreographer(deps)
|
|
|
|
env = await c.submit_up(
|
|
pm_id,
|
|
parent_id,
|
|
"ready for main PM review and merge into master branch",
|
|
)
|
|
body = env.as_dict()
|
|
assert body["error"] == "tracing_gap"
|
|
assert str(sub_id) in body["remediate"]
|
|
task_svc.submit_pm_review.assert_not_awaited()
|