mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
aeff60cbe8
* [57f83a44] fix(lint): remove unused imports from autonomous-maintenance code [CI run 28194267886] The Feat/autonomous-maintenance (#264) merge introduced 4 ruff lint errors that broke the quality gate: F401 roboco/api/routes/project.py:7 unused `cast` import F401 roboco/services/self_heal_engine.py:28 unused `cast` import F401 roboco/services/self_heal_engine.py:46 unused `UUID` in TYPE_CHECKING TC003 roboco/services/telemetry/source.py:18 `Sequence` not in TYPE_CHECKING Root cause: automated maintenance PR added self_heal_engine.py and ci_watch_engine.py with imports that became orphaned when the implementation was refactored. `cast` was imported in both project.py and self_heal_engine.py but never called. `UUID` was placed in self_heal_engine.py's TYPE_CHECKING block but not referenced in any annotation. `Sequence` in telemetry/source.py was imported at module level when it is only used in function-signature annotations and therefore belongs in TYPE_CHECKING (the file has `from __future__ import annotations` so this is runtime-safe). The mypy type-narrowing issue in test_pr_gate_records_verdict.py (the original AC context: in-body None assignment making subsequent assertions unreachable, resolved via annotation-typed class attributes) was already fixed in a prior commit before this task was opened. Fix: remove the three unused imports; move Sequence into TYPE_CHECKING. No suppressions, no xfail markers, no coverage threshold changes. `ROBOCO_ENCRYPTION_KEY='...' make quality` exits 0: ruff format, ruff check, markdown prose, mypy (0 errors, 819 files), pytest (10197 passed, 95.51% coverage), xenon, radon mi, vulture, bandit, pip-audit, deptry, alembic --sql, import-linter, and all foundation drift checks. * [57f83a44] docs(changelog): document ruff lint fixes from autonomous-maintenance PR Added comprehensive entry to CHANGELOG documenting the 4 ruff lint errors (F401 unused imports, TC003 import placement) that were introduced by Feat/autonomous-maintenance (#264) and subsequently fixed. Documents root cause (orphaned imports from refactoring) and the TC003 best practice (type-annotation-only imports belong in TYPE_CHECKING block with `from __future__ import annotations` for runtime safety). All quality gates pass: 10197 tests at 95.51% coverage, zero suppressions. --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Documenter <be-doc@agents.roboco.dev>