mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
f826285651
Converts 115 `# type: ignore[...]` suppressions across 23 test files to no-suppression patterns (helper-return widening to Any, local Any aliases, cc:Any aliases, cast at narrow call sites, typed fixtures) so the hard no-type:ignore convention holds across tests/. No test logic or assertions changed — only mock-wiring mechanics and type annotations. Gate: ruff check tests/ clean; mypy tests/ (538 files) clean; 176 changed-file tests pass. Zero real suppressions remain (the 7 grep hits are 3 hygiene- checker string-literal test inputs and 4 prose mentions in comments).
99 lines
3.5 KiB
Python
99 lines
3.5 KiB
Python
"""Startup re-adoption of still-running agent containers into ``_instances``.
|
|
|
|
An orchestrator restart loses the in-memory ``_instances`` registry while the
|
|
agent containers keep running. The reaper has a Docker-liveness fallback for
|
|
that (``_assignee_container_running``), but the spawn gate's ``_is_agent_active``
|
|
does not — so after a restart it sees a live agent as inactive and can
|
|
double-spawn it onto work its forgotten-but-running container is already doing.
|
|
``_readopt_running_agents`` probes each known agent slug's container and
|
|
re-registers a minimal ACTIVE instance for any that is running, so both the
|
|
reaper's live-skip and the spawn gate see the live agent immediately.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
from roboco.runtime.orchestrator import AgentOrchestrator, AgentState
|
|
|
|
_EXPECTED_READOPTED = 2
|
|
|
|
|
|
def _orch() -> Any:
|
|
orch = AgentOrchestrator.__new__(AgentOrchestrator) # bypass __init__
|
|
orch._instances = {}
|
|
return orch
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopts_running_containers_as_active() -> None:
|
|
orch = _orch()
|
|
running = {"be-dev-1", "fe-pm"}
|
|
|
|
async def inspect(name: str) -> tuple[bool, int | None]:
|
|
slug = name.removeprefix("roboco-agent-")
|
|
return (slug in running, 0)
|
|
|
|
orch._inspect_container_state = AsyncMock(side_effect=inspect)
|
|
|
|
n = await orch._readopt_running_agents()
|
|
|
|
assert n == _EXPECTED_READOPTED
|
|
assert orch._instances["be-dev-1"].state == AgentState.ACTIVE
|
|
assert orch._instances["be-dev-1"].agent_id == "be-dev-1"
|
|
assert orch._instances["fe-pm"].state == AgentState.ACTIVE
|
|
assert "be-dev-2" not in orch._instances # probed, not running → untracked
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_leaves_already_tracked_instance_untouched() -> None:
|
|
orch = _orch()
|
|
sentinel = MagicMock()
|
|
orch._instances = {"be-dev-1": sentinel}
|
|
orch._inspect_container_state = AsyncMock(return_value=(True, 0))
|
|
|
|
await orch._readopt_running_agents()
|
|
|
|
assert orch._instances["be-dev-1"] is sentinel # not re-adopted over
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_inert_when_nothing_running() -> None:
|
|
orch = _orch()
|
|
orch._inspect_container_state = AsyncMock(return_value=(False, None))
|
|
|
|
n = await orch._readopt_running_agents()
|
|
|
|
assert n == 0
|
|
assert orch._instances == {}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_swallows_probe_errors() -> None:
|
|
orch = _orch()
|
|
orch._inspect_container_state = AsyncMock(side_effect=RuntimeError("no docker"))
|
|
|
|
n = await orch._readopt_running_agents()
|
|
|
|
assert n == 0 # best-effort: a probe failure never raises into startup
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_records_container_id_so_health_check_can_see_exit() -> None:
|
|
# F033: a re-adopted instance registered with container_id=None is skipped by
|
|
# _check_health (`if instance.container_id is None: continue`), so when the
|
|
# container later exits the stopped-container handler never runs — the task
|
|
# is stranded under a phantom ACTIVE instance forever. Re-adopt must capture
|
|
# the real container id so the health loop can observe the later exit.
|
|
orch = _orch()
|
|
orch._inspect_container_state = AsyncMock(return_value=(True, 0))
|
|
orch._resolve_container_id = AsyncMock(return_value="deadbeef1234")
|
|
|
|
await orch._readopt_running_agents()
|
|
|
|
inst = orch._instances[next(iter(orch._instances))]
|
|
assert inst.container_id == "deadbeef1234"
|
|
assert inst.state == AgentState.ACTIVE
|