mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
5612375cba
* feat(release): add release-manager feature flag (default off) * feat(release): change classification + semver-bump derivation * feat(release): readiness audit (changelog/version-ref/docs/migration/gate) * feat(release): release-manager engine proposes a gated release * feat(release): fail-closed release executor (bump, gate, publish) * feat(release): CEO approve/reject release-proposal surface * docs(release): document the gated release manager * feat(memory): add org-memory feature flags (default off) * feat(memory): add playbooks table + status enum + migration * feat(memory): playbook service with auditor curation transitions * feat(memory): playbooks RAG index plugin * feat(memory): index a playbook into RAG on approval * feat(memory): distill a high-signal lesson at task completion * feat(memory): keep private journal reflections out of the shared RAG corpus * feat(memory): draft_playbook verb + auditor curation verbs * fix(ci): resolve mypy tests/ errors blocking the gate (UUID casts, annotations) * feat(memory): auto-inject similar lessons/playbooks into the briefing * feat(memory): auditor playbook review queue (api + panel) * docs(memory): document the org-memory loop + playbook verbs * fix(provisioning): idempotent pitch provisioning (reuse product/project by slug on re-approval) * fix(memory): add chunks_playbooks to the chunk schema + isolate release route tests - Migration 030's CHUNK_TABLES was missing chunks_playbooks, breaking the IndexType<->migration parity guard once the PLAYBOOKS index landed. The upgrade is ALTER ... IF EXISTS so adding it is safe on any DB shape. - The release-route fixture's approve/reject paths call db.commit() (real behavior), so a held proposal outlived the per-test rollback and leaked into engine tests that read the global list_open_release_proposals(). Tear down source=release_manager rows after each test. - Make the gather_snapshot real-repo smoke version-agnostic (semver match) so it stops pinning the literal repo version. * chore(release): 0.13.0 * ++ --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
87 lines
2.9 KiB
Python
87 lines
2.9 KiB
Python
"""The orchestrator sweeper prunes dangling Docker images (gated + throttled).
|
|
|
|
Each agent-image rebuild orphans the prior build's layers as an untagged
|
|
``<none>`` image; over many deploys these pile up. The sweeper reclaims them
|
|
with ``docker image prune -f --filter dangling=true`` (dangling only — never a
|
|
tagged image or one backing a running container), gated by
|
|
``image_prune_enabled`` and throttled to ``image_prune_interval_seconds``.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from roboco.config import settings
|
|
from roboco.runtime.orchestrator import AgentOrchestrator
|
|
|
|
|
|
def _orch() -> AgentOrchestrator:
|
|
orch = AgentOrchestrator.__new__(AgentOrchestrator) # bypass __init__
|
|
orch._last_image_prune = None
|
|
return orch
|
|
|
|
|
|
def _fake_proc(returncode: int = 0) -> MagicMock:
|
|
proc = MagicMock()
|
|
proc.returncode = returncode
|
|
proc.communicate = AsyncMock(return_value=(b"Total reclaimed space: 1.2GB", b""))
|
|
return proc
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_prunes_dangling_when_enabled_and_due(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "image_prune_enabled", True)
|
|
orch = _orch()
|
|
spawn = AsyncMock(return_value=_fake_proc())
|
|
with patch("roboco.runtime.orchestrator.asyncio.create_subprocess_exec", spawn):
|
|
await orch._sweep_dangling_images()
|
|
spawn.assert_awaited_once()
|
|
assert spawn.await_args is not None
|
|
args: tuple[Any, ...] = spawn.await_args.args
|
|
assert args[:6] == (
|
|
"docker",
|
|
"image",
|
|
"prune",
|
|
"-f",
|
|
"--filter",
|
|
"dangling=true",
|
|
)
|
|
assert orch._last_image_prune is not None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_no_prune_when_disabled(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(settings, "image_prune_enabled", False)
|
|
orch = _orch()
|
|
spawn = AsyncMock()
|
|
with patch("roboco.runtime.orchestrator.asyncio.create_subprocess_exec", spawn):
|
|
await orch._sweep_dangling_images()
|
|
spawn.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_throttled_when_recently_pruned(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
monkeypatch.setattr(settings, "image_prune_enabled", True)
|
|
orch = _orch()
|
|
orch._last_image_prune = datetime.now(UTC) # pruned moments ago
|
|
spawn = AsyncMock()
|
|
with patch("roboco.runtime.orchestrator.asyncio.create_subprocess_exec", spawn):
|
|
await orch._sweep_dangling_images()
|
|
spawn.assert_not_awaited()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_best_effort_swallows_errors(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(settings, "image_prune_enabled", True)
|
|
orch = _orch()
|
|
spawn = AsyncMock(side_effect=RuntimeError("no docker"))
|
|
with patch("roboco.runtime.orchestrator.asyncio.create_subprocess_exec", spawn):
|
|
await orch._sweep_dangling_images() # must not raise
|