mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* feat(board): Pest Control — the first project-scoped Board Program The Product Owner hunts latent defects (what the org records but nobody reads): a weekly cycle — accelerated off-schedule when the trailing-7-day rework rate crosses pest_rework_threshold, with the cheap dedup/scope gates evaluated before the metrics queries — opens one held exploration task against the least-recently-explored opted-in project (deterministic round-robin; opted_in_projects gains a stable ORDER BY), with server- assembled evidence in the spawn prompt (rework hotspots, recurring-findings and waived-minor ledger aggregates, all capped) plus prior-cycle LEARN context. The PO calls the new PO-only propose_bug_hunt verb once: ≤5 items, evidence required per item, targets validated against pest_control participation. CEO decides per item — approve materializes a BACKLOG task (source pest_control, never auto-starts), reject records the reason; both feed the LEARN ledger by exploration task id; all-terminal completes the cycle. Telegram queue pushes carry working Approve/Reject handlers mirroring the roadmap kind. Doctrine: board.md Pest Control section + product-owner verb entry + regenerated verb tables. * feat(panel): Pest Control review queue Command Center gains the pest review queue (per-item approve/reject with reason, mirroring the roadmap queue); the Programs card and the project settings participates-in checkboxes pick the new program up registry-driven — the settings section renders for the first time now that a project-scoped program exists. * feat(board): Periscope — HoM market-research brief program Weekly org-scoped cycle: a solo HoM spawn researches the market (web research with mandatory source URLs — uncited findings are rejected) and files one structured brief via the new HoM-only propose_market_brief verb: headline, cited findings, threats/opportunities, positioning note, all soup-checked and screened through the injection guard at persist time (web-derived text later reaches prompts; flags recorded, content never dropped). A brief is a report, not a proposal: the verb completes the exploration in the same call (the x_feature asymmetry), the cycle ledger auto-closes, and the CEO gets a best-effort notification with no approve/reject surface (periscope deliberately never joins Telegram's action kinds). The latest brief is injected into the roadmap exploration prompt — Periscope feeds Printer, the first cross-role program input. * feat(panel): Market Briefs tab (read-only) Business page gains a Market Briefs tab listing Periscope briefs — headline, cited findings, threats/opportunities — read-only by design; a report has nothing to approve. * feat(board): Coroner — event-triggered Auditor postmortems The first EVENT program: no cron — three best-effort hooks open an autopsy when a task bounces to its 3rd revision (the audit chokepoint), is cancelled after work started, or is budget-blocked; all gated on arming + one-open-autopsy dedup, none can fail the underlying transition. A solo Auditor spawn reads the incident (server-assembled findings + transition context) and files one propose_postmortem: incident summary, root cause, failed stage (validated against the real status vocabulary), and ONE process change — a playbook-kind change drafts via PlaybookService directly into the normal pending-curation queue; the briefed draft_playbook manifest grant was deliberately NOT added, preserving the existing 'auditor curates but never drafts' invariant test. Complete-at-propose (report asymmetry), cycle ledger auto-closes, CEO notified link-only. Integrated as a union with Periscope across the shared program surfaces. * feat(panel): Coroner postmortems card Read-only postmortems list under Business → Programs — incident, root cause, failed stage, process change; nothing to approve, the process-change artifact (a draft playbook) rides the existing curation queue. * feat(board): Sentinel — Auditor drift-watch quality reports Weekly org-scoped cycle: a solo Auditor spawn receives a server-assembled drift context (waived-findings trend, open findings by severity, conventions-violation hotspots, top spend — all capped, pure ORM) and files one propose_quality_report: headline, 1-7 area-validated items with evidence and suggested actions, overall assessment. Report semantics — complete-at-propose, cycle auto-closes, CEO notified display-only (never on Telegram's approve/reject surface); items are structured so a later convert-to-task control is cheap. Integration adopts Sentinel's module- level dict-dispatch for board-program routing (xenon-driven), folding all prior programs in; app router mounting extracted to a helper for the same budget. * feat(panel): Quality Reports tab (read-only) Business page gains the Sentinel quality-reports tab — headline, per-area observations with evidence and suggested actions; read-only, a report has nothing to approve. * feat(board): Spackle — gap-fill audit program Biweekly project-scoped PO cycle over the half-shipped surface area: API routes without panel surfaces (and vice versa), armed flags without docs, docs promises the code doesn't keep, dead-end tabs — the inventory diffing is the PO's own read-tool work, ordered by the spawn prompt with file:line citations required; the server injects only prior-cycle LEARN and the rotation target. Rotation is now a shared module-level helper (pick_rotation_target, parameterized by source) both project-scoped engines use — pest_control delegates to it, behavior-identical, with a cross-pollution test proving the two programs' rotations stay independent. propose_gap_fill mirrors the bug-hunt verb (≤5 items, two-sided evidence required, participation gate); per-item CEO decide materializes BACKLOG source=spackle tasks; full Telegram kind incl. approve/reject handlers. All seven program routers now mount from one helper. * feat(panel): Spackle gap-fill review queue Command Center gains the gap-fill queue mirroring the pest-control one — per-item approve/reject with the two-sided gap evidence rendered. * feat(board): Scales — monthly portfolio rebalance Org-scoped PO cycle over the stale backlog: the spawn receives a capped stale-task snapshot (BACKLOG/PENDING unclaimed >30 days) plus the charter and prior-cycle LEARN, and files one propose_rebalance — 1-7 items, each a resolvable task_ref with action reprioritize (validated new priority) or cancel, rationale required. Per-item CEO decide: approve EXECUTES the action (audited priority update, or the normal cancel path) — the first program whose materializer mutates existing tasks instead of creating them; reject records the reason; LEARN by exploration task id; all-terminal completes the cycle. Full Telegram decide-kind wiring. Integrated as the eight-program union (registry, dict dispatch, routers helper, teardown enumerations). * feat(panel): Scales rebalance review queue Command Center gains the rebalance queue — per-item approve/reject with the action, target task, and rationale rendered. * feat(board): Mirror — quarterly positioning audit Project-scoped HoM cycle over messaging surfaces: README claims vs shipped reality, docs-site promises vs code, charter alignment — the audit is the HoM's own read-tool work with citations required; the server injects the charter, prior-cycle LEARN, and the shared rotation target. propose_ messaging_fixes mirrors the gap-fill verb (≤5 items, drift evidence naming claim + contradicting reality, participation gate); per-item CEO decide materializes BACKLOG source=mirror documentation tasks; full Telegram decide-kind wiring. Nine-program union across the shared surfaces. * feat(panel): Mirror messaging-fixes review queue * feat(board): Megaphone — HoM standing editorial calendar Cron cycle (3 days, org-scoped, gated on X credentials — drafting content nobody can post is pointless): the HoM receives a shipped-this-week digest plus Unreleased changelog bullets and files one propose_editorial_post (angle-validated, ≤280, brand voice) that materializes a held x_editorial draft through the SAME X-queue origination chokepoint release posts use — zero new approval surface, notifications and CEO decide for free. Complete-at-propose; cycle auto-closes. Ten-program union. * feat(panel): x_editorial source labels in the X queue surfaces * feat(board): Librarian — proactive playbook mining Biweekly org-scoped Auditor cycle: mines recurring non-private learning journals (≥2-count grouping with a recency fallback) against the existing playbook-title inventory and files one propose_playbook_drafts — 1-3 drafts, each with the repeated-pattern evidence that justifies it, duplicate titles rejected in-batch and against the live store. Drafts are created via PlaybookService directly (the Coroner precedent — the 'auditor curates but never drafts' do-verb invariant stays intact and tested) and land in the normal pending-curation queue the Auditor's own triage already surfaces; no new panel surface. Complete-at-propose; display-only CEO notification. Eleven-program union. * feat(board): War Room — release campaign planning EVENT program with a REAL originator (unlike coroner's stub): a release publish hooks a campaign brief beside the release-post seam, and the CEO's run-now originates on demand — the cron loop never fires it. The HoM designs a 2-6 post arc (teaser → launch → follow-up → spotlight; 280-cap, future strictly-ascending publish_after, stage vocabulary) and one propose_campaign call materializes each post as a held x_campaign draft through the X-queue chokepoint. V1 is manual-cadence by design: publish_ after renders as queue guidance and the CEO approves each post at its moment — nothing auto-posts, ever; the auto-schedule upgrade is a documented ceiling. Twelve-program union: full registry complete. * feat(panel): x_campaign labels + publish-after guidance in the X queue * feat(board): Barfly — adjacent-conversation replies Cron cycle (2 days, org-scoped, X-credentials gated): the engine searches X for conversations where RoboCo is relevant but unmentioned (new OAuth- signed search_recent on the client; queries + candidate cap configurable), screens every fetched tweet through the injection guard (stored unclamped — a clamp was truncating the candidate under the envelope, caught by the dev's own tests), dedupes via the existing x_seen_mentions ledger (no migration; also prevents double-drafting against the mentions poll), and opens one held HoM exploration carrying the screened candidates. propose_ conversation_replies enforces candidate-id-only replies (≤5, 280-cap); each materializes a held x_barfly draft through the X-queue chokepoint, threaded via a new in_reply_to seam on post_tweet that only x_barfly drafts use. The X redraft machinery is now dict-dispatch over per-source extractors with reply-ref carry for x_barfly. Thirteen-program registry. War Room's test fakes gained the new abstract search_recent stub. * feat(board): Dogfood — the PO walks the product The fourteenth and final registry entry, completing the catalog. EVENT program (release-publish hook beside the war-room hook + CEO run-now, both through the same real originator; the cron loop never fires it), project- scoped with shared rotation. The permission surface is the careful part: the PO's dogfood spawn — and ONLY that spawn — gets the Playwright MCP mounted, via a task-scoped fail-closed probe mirroring the video-authoring precedent (a PO spawned for roadmap/pest/scales never sees browser tools; tested both ways); the PM agent image bakes chromium unconditionally like the ux image, the mount stays task-gated in code. The walk targets the rotation target's live surfaces (panel_base_url only when the target is the org's own project, honest degradation otherwise); propose_friction_ fixes files ≤5 walked-path-evidenced items; per-item CEO decide materializes BACKLOG source=dogfood tasks; full Telegram decide kind. Also: megaphone/librarian/war_room arming keys restored to the settings validator — their panel toggles would have been rejected (dropped in earlier unions; the same silent-arming class the drill killed once already). * feat(panel): Dogfood friction review queue * chore(board): final whole-branch sweep fixes The night's closing adversarial pass over the integrated fourteen-program registry found ONE functional defect — the war-room test fakes' post_tweet predated Barfly's in_reply_to_tweet_id kwarg (LSP violation, the only red in an otherwise fully green gate) — plus doc/test drift, all fixed: the source-parity test completes to fourteen (spackle/mirror were silently absent while its neighboring comment claimed full coverage), the PO identity doc gains its missing Dogfood verb, the auditor quick-list gains propose_postmortem, three stale comments corrected (rotation docstring, panel registry header, X source enumerations), the dogfood release-hook gains the exception-swallow test its four sibling hooks already had, and the CHANGELOG's Unreleased section documents the whole Board Programs train. Full make quality: exit 0, all gates green. * docs: full documentation sweep for the Board Programs train CLAUDE.md's roadmap-engine entry superseded by the Board Program registry entry (all fourteen programs, arming, scoping, LEARN, guardrails) with the role verb tables and playwright row refreshed; docs/rag gains the agent- facing architecture doc plus full propose_* call-shape sections in the three board role docs, and corrects the strategy-engine section to shipped reality (only idle→roadmap is wired); docs/map covers the registry + all twelve engines with flags, gotchas, and drift notes. The 0.27.0 reference inventory confirmed only the release-executor's canonical set carries the version — left for the 0.28.0 cut. * feat(board): human titles + descriptions on every program surface Raw registry keys rendered as bare panel labels — an operator reading x_feature had no idea what enabling or running it does. The registry dataclass gains title/description (test-enforced non-empty for every entry, unique titles), the API passes them through, and every surface renders title-with-description-tooltip instead of the key: the Programs card (label, toggle hint, run-now toast), and the project settings participates-in/excluded-from checkboxes. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
158 lines
7.0 KiB
Python
158 lines
7.0 KiB
Python
"""PeriscopeEngine — Periscope (Board Program), org-scoped.
|
|
|
|
Mirrors ``roboco.services.roadmap_engine.RoadmapEngine``'s "detect ->
|
|
originate a CEO-gated artifact -> hold" shape: org-scoped (spec §4 — it reads
|
|
the market, not a repo, so it needs no per-project opt-in to RUN, unlike
|
|
Pest Control), but the exploration task itself still needs a resolvable
|
|
``project_id`` — ``TaskService._require_target_or_umbrella`` is a hard
|
|
service-layer invariant every non-coordination task must satisfy, the same
|
|
constraint roadmap/x_feature already carry despite being org-scoped too. It
|
|
resolves against the RoboCo project (``settings.self_heal_project_slug``,
|
|
the same resolution roadmap/x_feature use) purely as an FK anchor — HoM's
|
|
research itself is web/KB-driven, not a repo read.
|
|
|
|
* **No master enable flag.** Armed via ``roboco.services.board_programs.
|
|
program_armed`` — the settings-store ``board_program.periscope.enabled``
|
|
key is the ONLY arming path (no legacy flag exists for it); off by default
|
|
like every other program.
|
|
* **One open cycle at a time.** Dedup by ``source=board_periscope``
|
|
non-terminal tasks.
|
|
* **The engine never authors content.** It opens ONE held, PENDING
|
|
exploration task assigned to the Head of Marketing (``Team.BOARD``,
|
|
``confirmed_by_human=False``); the board dispatcher spawns HoM, who
|
|
researches the market and calls ``propose_market_brief`` exactly once,
|
|
which completes the exploration task in the same call (a report has no
|
|
per-item CEO decision to wait on — mirrors ``XEngine.
|
|
materialize_feature_spotlight``'s complete-at-propose asymmetry, not
|
|
roadmap/pest-control's per-item queue).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING, Any, cast
|
|
|
|
from roboco.config import settings
|
|
from roboco.foundation import identity as _foundation
|
|
from roboco.foundation.policy.content import markers
|
|
from roboco.models.base import Complexity, TaskNature, TaskStatus, TaskType, Team
|
|
from roboco.services.base import BaseService
|
|
from roboco.services.board_programs import program_armed
|
|
from roboco.services.project import get_project_service
|
|
from roboco.services.task import PERISCOPE_SOURCE, TaskCreateRequest, get_task_service
|
|
|
|
if TYPE_CHECKING:
|
|
from uuid import UUID
|
|
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from roboco.db.tables import ProjectTable, TaskTable
|
|
from roboco.services.task import TaskService
|
|
|
|
_EXPLORATION_TITLE = "Periscope market-research cycle"
|
|
_EXPLORATION_DESCRIPTION = (
|
|
"Research the market — competitors, adjacent-tool releases, positioning "
|
|
"shifts — and file ONE weekly brief for the CEO via propose_market_brief(). "
|
|
"This is a report, not a task queue: nothing here materializes work, and "
|
|
"there is no per-item approve/reject. Cite a source URL for every claim — "
|
|
"the verb rejects an uncited finding."
|
|
)
|
|
|
|
# Render cap for the "latest brief" injected into the roadmap exploration
|
|
# prompt (spec §4: Periscope's brief is Printer's cross-role input) — bounds
|
|
# the section regardless of how many findings a brief carries.
|
|
_PROMPT_RENDER_CHAR_CAP = 2000
|
|
|
|
|
|
class PeriscopeEngine(BaseService):
|
|
"""Originate ONE held Periscope-exploration cycle for the Head of Marketing."""
|
|
|
|
service_name = "periscope_engine"
|
|
|
|
async def run_cycle(self) -> TaskTable | None:
|
|
"""Originate one held exploration task, or None (no-op).
|
|
|
|
No-ops when the program isn't armed, a cycle is already open, or the
|
|
RoboCo project (the task's required FK anchor) isn't resolvable.
|
|
Never authors content itself — the Head of Marketing does, via
|
|
``propose_market_brief`` once spawned by the board dispatcher.
|
|
"""
|
|
if not await program_armed(self.session, "periscope"):
|
|
return None
|
|
task_svc = get_task_service(self.session)
|
|
if await task_svc.list_open_periscope_cycles():
|
|
return None # one open cycle at a time
|
|
project = await self._roboco_project()
|
|
if project is None or project.id is None:
|
|
self.log.warning(
|
|
"periscope-engine: RoboCo project not resolvable; skipping"
|
|
)
|
|
return None
|
|
return await self._originate(task_svc, cast("UUID", project.id))
|
|
|
|
async def _roboco_project(self) -> ProjectTable | None:
|
|
slug = (settings.self_heal_project_slug or "roboco-api").strip()
|
|
return await get_project_service(self.session).get_by_slug(slug)
|
|
|
|
async def _originate(self, task_svc: TaskService, project_id: UUID) -> TaskTable:
|
|
"""Open ONE PENDING, HELD exploration task assigned to the Head of
|
|
Marketing."""
|
|
task = await task_svc.create(
|
|
TaskCreateRequest(
|
|
title=_EXPLORATION_TITLE,
|
|
description=_EXPLORATION_DESCRIPTION,
|
|
acceptance_criteria=[
|
|
"propose_market_brief() is called once with a headline "
|
|
"and 1-7 cited findings"
|
|
],
|
|
team=Team.BOARD,
|
|
assigned_to=_foundation.AGENTS["head-marketing"].uuid,
|
|
created_by=_foundation.AGENTS["system"].uuid,
|
|
task_type=TaskType.ADMINISTRATIVE,
|
|
nature=TaskNature.NON_TECHNICAL,
|
|
estimated_complexity=Complexity.LOW,
|
|
project_id=project_id,
|
|
status=TaskStatus.PENDING,
|
|
source=PERISCOPE_SOURCE,
|
|
confirmed_by_human=False, # HELD; board-dispatched, not delivery
|
|
)
|
|
)
|
|
await self.session.flush()
|
|
self.log.info(
|
|
"periscope exploration cycle opened (Head of Marketing)",
|
|
task_id=str(task.id),
|
|
)
|
|
return task
|
|
|
|
async def latest_brief_context(self) -> str:
|
|
"""Compact rendering of the most recent completed brief, for the
|
|
roadmap exploration prompt's cross-role injection (spec §4).
|
|
Best-effort shape: empty string when no brief exists yet or the
|
|
latest cycle carries no marker (never blocks the caller)."""
|
|
briefs = await get_task_service(self.session).list_periscope_briefs(limit=1)
|
|
if not briefs:
|
|
return ""
|
|
payload = markers.get_market_brief(briefs[0])
|
|
if not payload:
|
|
return ""
|
|
return _render_brief_compact(payload)
|
|
|
|
|
|
def _render_brief_compact(payload: dict[str, Any]) -> str:
|
|
"""Headline + each finding's claim (with its source) — capped so the
|
|
roadmap prompt's injected section stays bounded regardless of how large
|
|
a brief's finding list is."""
|
|
lines = [f"Headline: {payload.get('headline', '')}"]
|
|
for finding in payload.get("findings") or []:
|
|
claim = finding.get("claim", "")
|
|
source = finding.get("source_url", "")
|
|
lines.append(f"- {claim} (source: {source})")
|
|
rendered = "\n".join(lines)
|
|
if len(rendered) > _PROMPT_RENDER_CHAR_CAP:
|
|
rendered = rendered[:_PROMPT_RENDER_CHAR_CAP].rstrip() + "…"
|
|
return rendered
|
|
|
|
|
|
def get_periscope_engine(session: AsyncSession) -> PeriscopeEngine:
|
|
"""Build a PeriscopeEngine for ``session``."""
|
|
return PeriscopeEngine(session)
|