6 Commits

Include renames

Author	SHA1	Message	Date
3 people	889f3689e7	MegaTask (#248) ... * feat(batch): batch_id + collision descriptor columns Sequenced batch intake ("Mega task") foundation: tasks.batch_id (indexed) groups a batch of top-level tasks created together; intends_to_touch (text[]), adds_migration and touches_shared (bool, NOT NULL default false) are the per-task collision surface the SequencingService will read to wire dependency waves. Mirrored on the Task model + TaskCreateRequest and wired through TaskService.create. Migration 046 (real upgrade->downgrade->upgrade verified vs a throwaway pgvector PG); a non-batch task declares no surface (defaults). Task 1 of the 0.11.0 sequenced-batch-intake plan. * feat(batch): flag + draft collision descriptors Default-off ROBOCO_BATCH_INTAKE_ENABLED (config + FEATURE_FLAGS + panel card); the propose_draft tool doc + the TS DraftProposal gain the per-task collision surface intends_to_touch / adds_migration / touches_shared. The draft is a loose dict so the descriptors ride it through the relay intact (test asserts the forwarded payload); the analyzer (Task 3) reads them to wire dependency waves. Task 2 of the 0.11.0 sequenced-batch-intake plan. * feat(batch): deterministic collision-sequencing analyzer SequencingService.analyze turns a batch's per-task collision surfaces into a dependency DAG + execution waves — correctness in CODE, not agent judgment. Rules in order: file overlap serializes (more-important first), migrations form a serial chain (no concurrent Alembic heads), touches_shared runs last, cell contention warns (never serializes); then dedupe, existence + cycle check, and Kahn topological layering. Pure (no DB/services); SequencingError on a cycle or out-of-range edge. Golden test reproduces the CEO's hand-sequenced 4 waves of the 11-item guard-core-app batch (the effort that deadlocked the Main PM): S6 alone last, the R1/R3/R4 migration chain, R2/R3/S8 serialized on the shared threat service, S1/S2/S7 in one parallel wave. Task 3 of the 0.11.0 sequenced-batch-intake plan. * chore(batch): brand the user-facing surfaces "MegaTask" The user-facing name is MegaTask: the feature-flag label is "MegaTask intake", the panel flag-card and the config description lead with MegaTask. Internal names stay technical (batch_intake_enabled, batch_id, SequencingService). * chore(batch): drop the feature flag — MegaTask is a core intake scope MegaTask is additive and opt-in by its own nature (the Prompter proposes a batch only when the CEO asks for several tasks; single-task intake is unchanged), so there is no risk surface a flag protects — 'don't create a MegaTask' is the off switch. Remove batch_intake_enabled from config, the FEATURE_FLAGS registry, the panel flag card, and its tests. MegaTask will be a third scope option in the Intake modal (single-cell / multi-project / MegaTask), not a toggle. * feat(batch): MegaTask identity predicate + orchestrator branchless recognition The single source of truth for the umbrella's exemptions: pure is_batch_umbrella / is_batch_root_subtask / is_branchless_coordination (foundation/policy/batch.py) — an umbrella has a batch_id and is top-level; a root-subtask shares the batch_id but is parented. The orchestrator's _is_coordination_task now consults is_branchless_coordination, so a MegaTask umbrella is recognized as doing no git of its own (git-exempt at spawn-readiness / stuck-detection) exactly like a product fan-out root. Non-batch behavior is identical (the predicate reduces to the old no-project+product check; the orchestrator coordination suite stays green), and the umbrella branch is inert until the create path exists. First slice of the MegaTask umbrella enforcement (branchless guard). * feat(batch): branchless umbrella guard across the git-exemption sites A MegaTask umbrella does no git of its own — every git-exemption site in TaskService now consults the shared is_branchless_coordination predicate instead of an inline product-only check, so the umbrella's exemptions cannot drift between sites: - the claimed->in_progress branch gate (GitContext.is_coordination) lets an unbranched umbrella reach in_progress and delegate; - _ensure_branch_for_task short-circuits an umbrella to "" instead of the misconfigured raise (the claim path ignores the return, treating it as branchless); - CEO-reject routing sends a rejected umbrella to the Main PM in PENDING (needs_revision is developer-claim-only and would deadlock it). Covers both shapes via the predicate (product fan-out root OR umbrella); a batch root-subtask keeps its own branch/PR. Adds orchestrator recognition tests for the umbrella plus claim/branch/reject integration tests. * feat(batch): umbrella assembles no PR; completes branchless submit_root now hard-rejects a MegaTask umbrella up front (a preflight that also folds in the unknown-role refusal to stay within the return-count budget): the umbrella spans many projects with no single master, so each root-subtask opens and is reviewed on its own PR — the umbrella never enters the in-path review gate. The Main PM completes it directly once every root-subtask is terminal. Umbrella completion needs no new code: it is branchless (no branch_name), so _main_pm_complete_guard already accepts it from in_progress, checks all_subtasks_terminal, and main_pm_complete walks it to awaiting_pm_review and escalates to the CEO with no PR creation — exactly the product fan-out root path. Adds the submit_root-reject and umbrella-completion gateway tests; pins batch_id=None on the normal-root submit_root test (a MagicMock auto-attr would otherwise read as an umbrella). * feat(batch): MegaTask create path — umbrella + sequenced root-subtasks PrompterService.confirm_live_batch turns N confirmed drafts into a real MegaTask: it builds each draft's collision surface, runs the pure SequencingService to get conflict-free waves, creates the branchless umbrella (batch_id, no project/product), then one root-subtask per draft (own project, parent=umbrella, sequence=wave index, descriptors), and wires the analyzer's edges through add_dependency so the existing dependency-gate runs the waves in order. The route picks the start path like a single confirm: 'board' holds the root-subtasks in BACKLOG for the batch review; 'main_pm' creates them PENDING so wave 0 dispatches at once. create_task_from_draft gains a BatchPlacement (parent/batch/sequence/ team_override) and forwards the collision descriptors; the exactly-one- target rule (here and the TaskService.create invariant) is relaxed for an umbrella, which legitimately targets neither. New route POST /live/{session}/confirm-batch + BatchConfirmRequest mirror the single confirm. Adds the structural-invariant + board-hold + empty-batch tests. * feat(batch): release MegaTask root-subtasks on CEO approval; board awareness The board route holds a MegaTask's root-subtasks in BACKLOG so the work waits for the batch review. approve_and_start (CEO gate #1, board->Main PM) now releases them via _activate_batch_root_subtasks: each held child flips BACKLOG -> PENDING + team=main_pm so the dependency-gate dispatches wave 0. No-op for a non-umbrella; idempotent (children past BACKLOG untouched). The Product Owner and Head of Marketing identity prompts gain a MegaTask section so they review the whole batch + wave plan and adjust scope before sign-off (they review drafts; the umbrella is their unit). Also extracts the create() target invariant into _require_target_or_umbrella to keep the method under the complexity gate after the umbrella exemption. Adds the umbrella-approval activation test. * feat(batch): multi-project intake scope for MegaTask A MegaTask spans several possibly-unrelated repos, so the intake chat can now be scoped to an explicit project list (not just one project or one product). StartLiveRequest gains project_ids; /live/start threads it through start/spawn_intake_session -> _spawn_intake_container -> _clone_intake_scope. The multi-repo clone machinery already existed for products; _intake_scope_slugs now also resolves an explicit project_ids set (split into _slugs_for_project_ids / _slugs_for_product), cloning each repo with the first as the primary cwd and the siblings readable. Scope validation is now 'exactly one of project_slug / product_id / project_ids' via the shared _require_one_intake_scope. Adds scope-resolution, spawn, and route tests for the MegaTask path. * feat(batch): propose_batch intake tool (MegaTask multi-draft hand-off) The intake agent can now hand the panel a whole MegaTask in one tool call. Both intake paths gain propose_batch alongside propose_draft: - Claude (intake_driver): a propose_batch tool registered on the in-SDK MCP server + allowlisted; the driver intercepts the ToolUseBlock and emits ONE StreamChunk(kind="batch") carrying {drafts:[...], title}. - grok (intake_server): a propose_batch tool that POSTs a "batch" relay event via the shared _post_event helper (post_draft/post_batch). A batch carries N drafts, each the propose_draft shape PLUS its own project_id (a MegaTask spans unrelated repos) and collision surface so the analyzer sequences the waves. The prompter prompt documents the MegaTask scope + when to call propose_batch. Adds Claude-normalize and grok-relay tests for the batch path. * feat(batch): MegaTask intake panel — third scope, batch review, waves The panel now drives a MegaTask end to end. The intake modal gains a third scope, 'MegaTask', beside Single cell and Board-led: a multi-project checklist (a MegaTask spans several possibly-unrelated repos), validated to at least two. start() sends project_ids; use-prompter accumulates the agent's single propose_batch hand-off as a 'batch' SSE event into a BatchProposal and lands in a new batch_preview state. A new BatchReviewCard lists every proposed task with its target project + collision-surface badges (migration / shared) and offers one start path for the whole batch — Board review & Start or Approve & Start — wired to confirmBatch → POST /confirm-batch. The success card shows the sequenced result: N tasks in M waves (+ any advisory notes). prompter.ts gains the DraftScale 'megatask' + the BatchConfirm payload/result types; the SSE client allows the 'batch' kind. Panel typecheck + lint + 113 tests green. * docs(batch): MegaTask across changelog, CLAUDE.md, site, and RAG The four documentation obligations for the MegaTask feature: - CHANGELOG: an Unreleased entry covering the umbrella model, sequencing, multi-project intake, propose_batch, and the create/approval path. - CLAUDE.md: a MegaTask section (identity predicate, umbrella/root-subtask hierarchy, sequencing rules, intake + create path, board activation). - Published site: a user-facing company/megatask.md (scopes, waves, the umbrella, the two start buttons) + nav entry; a pointer added to the intake chapter of the Tour. - RAG corpus: workflows/megatask.md so the Main PM (and any agent) can retrieve the umbrella's branchless / no-PR / completion rules at runtime. The runtime concurrent-migration guard is intentionally NOT added: the analyzer already chains migration-adders into dependencies and the dependency-gate serializes them, so a separate guard would be dead code. * feat(batch): batch_id guardrail + wave preview + batch_id on TaskResponse Guardrail (CEO): a batch_id is denied on any task that is not a well-formed MegaTask member. is_valid_batch_shape permits batch_id only on an umbrella (no parent → must target neither project nor product) or a root-subtask (has a parent → exactly one target); TaskService.create enforces it AND verifies a root-subtask's parent is the batch umbrella (same batch_id, top-level). This closes a latent hole: is_batch_umbrella is true for a batch_id + no-parent task even with a project, so a stray batch_id could have spoofed the branchless branch-gate / no-PR exemption. (The public task API never exposed batch_id for write; this guards the service layer.) Wave preview: PrompterService.preview_batch + POST .../preview-batch compute a MegaTask's waves from the proposed drafts WITHOUT creating anything, so the panel can show the sequencing before confirm. Extracted _sequence_drafts as the single source shared by preview and confirm, so the previewed waves are exactly the ones wired. TaskResponse now carries batch_id so the panel can badge the umbrella. * feat(batch): MegaTask review — project editor, wave preview, persistence, badge Closes the panel gaps in the MegaTask review experience: - Per-task project editor: each proposed task gets an inline project Select (updateBatchDraftProject), so a task the agent put in the wrong or no repo can be fixed before launch — not only by re-chatting. Launch stays blocked until every task has a project. - Wave preview: on a batch proposal the panel fetches POST .../preview-batch (no task created) and shows the conflict-free wave plan, so the human reviews the sequencing before confirming. - Refresh durability: the MegaTask review (batch + waves + projectIds) is persisted, so a browser reload mid-review restores it like a single draft. - MegaTask badge: TaskResponse exposes batch_id, the panel Task type carries it, and the task table badges the umbrella row 'MegaTask'. Panel typecheck + lint + 113 tests green. * test(batch): stub task carries batch_id for task_to_response task_to_response now serializes batch_id (TaskResponse field), so the _stub_task SimpleNamespace fixture must provide it — without it the reader hit AttributeError, failing the 8 task-schema serialization/enrichment tests. Test-only; the real TaskTable carries the column (migration 046). * fix(batch): close MegaTask audit gaps — completion crash, analyzer cycle, guardrails An adversarial multi-agent audit of the feature surfaced 20 verified gaps; this closes the backend ones. HIGH: - Umbrella completion crashed. escalate_to_ceo hard-required a pr_number, which a branchless umbrella never has, so main_pm_complete dereferenced None. Both pr_number gates now waive a MegaTask umbrella (escalate_to_ceo + the awaiting_pm_review->awaiting_ceo_approval lifecycle gate via a new GitContext.is_umbrella), and main_pm_complete guards a None return. The completion test had mocked escalate_to_ceo, hiding it — now a real service test covers the waiver. - The collision analyzer could fabricate a cycle (a touches_shared + adds_migration draft overlapping another migration draft) and raise SequencingError — a bare ValueError that escaped as an opaque 500. The migration chain is now shared-last-aware (never contradicts rule 3), and _sequence_drafts translates SequencingError to a clean 400. MEDIUM: - Collisions are now project-scoped: two repos can't collide on a coincidental path or serialize independent migrations (DraftSurface carries project_id; rules 1/2/3 respect it). - The batch_id guardrail ran only at create. update() + the PATCH null-clear path now re-assert is_valid_batch_shape, so a mutation can't break a member's shape and spoof the branchless exemption. - A draft missing title/acceptance_criteria now raises ValidationError (was a bare KeyError -> 500). - confirm_live_batch re-asserts every draft targets a scoped project and the batch spans >=2 distinct projects (project_ids added to the request). - Route-level tests for confirm-batch / preview-batch. LOW: strict multi-repo clone (fail loud on any unresolvable project); malformed/empty propose_batch surfaces an error chunk (Claude) / refuses to POST (grok) instead of silently acking; dropped malformed drafts are counted and surfaced; stale grok intake docstrings updated. * fix(batch): MegaTask panel + doc audit gaps Frontend half of the audit fixes: - The confirm payload now carries project_ids (the schema requires it), and the panel re-checks every task targets one of the scoped repos before launching, naming the offending task. - The Review-MegaTask project picker is filtered to the scoped repos and the per-task validity (border + launch gate) keys off scoped membership, so a task can only be (re)pointed at an in-scope project — also fixing the case where the agent emitted a non-UUID / unknown project. - Dropped malformed drafts are surfaced as a chat error so the human knows the batch shrank instead of silently confirming fewer tasks. - Doc wording: a wave releases on the previous wave's terminal state (normally a merge; a cancellation releases it too), not strictly 'merged'. * test(batch): lock the CEO's EXACT 4-wave hand-sequencing as the golden bar The golden test asserted the constraints (S6 last, the migration chain, the shared-threats serialization, S1/S2/S7 parallel) but not the full wave partition. The bar for MegaTask is 'reproduce my exact waves or it's not done', so assert the exact 4-wave partition the analyzer produces for the guard-core-app batch: wave 1: R1 R2 S1 S2 S3 S5 S7 · wave 2: R3 · wave 3: R4 S8 · wave 4: S6 Confirmed unchanged by the audit's analyzer fixes (no migration is shared; single project). * fix(batch): tolerate a stub task in assert_batch_shape_intact The batch-shape re-validation read task.batch_id directly, but update()'s partial-caller contract is exercised with a SimpleNamespace stub that has no batch_id column → AttributeError. Use getattr(..., None) for batch_id and the shape fields so the guard no-ops on any task lacking the column (a stub, or a non-batch task) while still enforcing on a real batch member. * fix(orchestrator): authenticate internal API self-calls with the system identity The dispatcher httpx clients were built without an agent identity, so the orchestrator's self-PATCHes to /api/tasks/{id} (auto-block, auto-resume, auto-recover, SLA annotation) were rejected 401 "Missing X-Agent-ID" and silently no-op'd. The auto-resume that lifts a PM's paused parent could never write, so paused/blocked parents stayed wedged and stranded their dependents (the fe-pm/be-pm respawn churn seen in prod). Header propagation was inconsistent across the separate AsyncClient call-sites: only the main dispatch client carried the system identity; the readiness and sweep clients did not. Hoist the identity into a shared _SYSTEM_API_HEADERS constant and apply it to every API-facing dispatcher client. The system role holds TaskAction.ASSIGN, so it is authorized for the audited admin_set_status path those write routes use. The external provider-recovery probe client is intentionally left untouched. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-06-24 01:15:57 +02:00
Renn F	0740dc141e	feat(panel): clickable Branch/PR links + branch copy button ... The Branch value in the task-detail card and the Branch/PR badges in the task list were static text. Make them open the real thing on GitHub, keeping their exact look: - New repo-url helper normalizes a project git_url (https/ssh, with/without .git) into web URLs for a branch (/tree/<branch>) and PR (/pull/<n>), returning null so callers fall back to a plain label. - Task-detail Branch card: the branch is now a link to its GitHub tree URL and gains a copy button (reuses CopyButton); PR was already linked. - List-row git badge (git-status-badge): the PR badge links to task.pr_url (or the built pull URL) and the Branch badge links to the branch tree URL. The row's click handler already ignores <a> clicks, so opening a branch/PR never toggles the row. git_url is threaded via a projectGitUrls map from the tasks page, alongside the existing projectNames map. panel typecheck + eslint clean.	2026-06-21 07:15:58 +02:00
Renn F	b342de2913	feat(panel): show + filter tasks by project and product ... The task list had no way to see or filter by which project/product a task belongs to. Add a "Project / Product" column to the table (resolving the id to a name, with a "(product)" hint for fan-out tasks) and Project + Product multi-select filters alongside Status/Team/Type, URL-backed and client-side like the others. Options and names come from the projects/products lists.	2026-06-20 21:14:49 +02:00
7 people	818f2ac7a6	[21e195cd] Panel-wide UI standardization and usability pass (#194) ... * [4c179e3a] Add git pull, fetch, and rebase backend endpoints (#190) * [f966f772] feat(git): add pull, fetch, and rebase endpoints with integration tests (#185) - Add GitPullRequest/Response, GitFetchRequest/Response, GitRebaseRequest/Response schemas - Add GitService.pull(), fetch(), and rebase() methods using _network_git_timeout() - Add POST /api/git/pull, /api/git/fetch, /api/git/rebase route handlers - Rebase detects conflicts via git diff --name-only --diff-filter=U and aborts cleanly - Integration tests cover success path and GitCommandError→500 for all three endpoints - Rebase conflict test verifies conflict=True with populated conflicted_files list Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> * [26e2b7af] test(git): add AsyncMock unit tests for rebase_onto_base conflict-state handling (#186) New test_git_rebase.py covers three branches of rebase_onto_base: - success path: rebase exits 0, returns rebased status, abort never called - conflict path: non-zero exit → diff → abort → returns conflict+files - resilience: both rebase and abort exit non-zero, still returns conflict dict without exception All tests use AsyncMock with side_effect sequences to mock _run_git at the service-method level. Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev> --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev> * [551b1dbf] Panel-wide frontend UI standardization and page fixes (#193) * [1ec787b2] feat(panel): design-system sweep — full-width layouts, scrollbar fix, Secretary button, component audit (#188) - Settings page: remove max-w-3xl, wrap cards in grid-cols-1 lg:grid-cols-2 two-column layout - AI Providers page: remove max-w-5xl so AIRoutingCard fills available width - Journals AgentList: replace ScrollArea with overflow-y-auto div to eliminate nested scrollbar - Secretary chat input: add items-stretch to flex row so Send/Start button matches Textarea height - Component audit: replace all raw <button>/<input>/hand-rolled badge spans outside components/ui/ with canonical Button, Checkbox, Badge variants across 15 files: - ai-routing-card.tsx: ModeButton → Button, checkbox → Checkbox, badge spans → Badge - self-hosted-section.tsx: eye-toggle → Button ghost icon-sm, badge spans → Badge - journals/agent-item.tsx, communications/channel-item.tsx → Button ghost - kb-search-bar.tsx, kb-filters.tsx → Button ghost - kb-category-nav.tsx, git-log-panel.tsx → Button ghost - communications/page.tsx (channel + group lists) → Button ghost - projects/project-table.tsx, products/product-table.tsx → Button link - git-branch-panel.tsx (local + remote lists) → Button ghost - tasks/dependency-selector.tsx: Button ghost + Checkbox for visual indicator - tasks/task-table.tsx: sortable header + expand toggle → Button ghost - business/goals-tab.tsx: hidden button → Button Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [435b37b4] feat(metrics,notifications): URL-persisted tab state, semantic chart colors, humanized counts (#187) - Notifications page: replace useState with useSearchParams/useRouter for ?tab= URL parameter (all/unread/pending, default: unread); Suspense wrapper with skeleton fallback for SSR compatibility. - Metrics page: split into Performance tab (Velocity + Task Status + Agent Status + Team Health) and Token Usage tab (TokenUsageCostsSection) with ?tab= URL parameter (default: performance); Suspense wrapper; Refresh button moved inside PerformanceTabContent; humanizeCount() helper applies K/M suffixes to all MetricCard numeric values >= 1000. - Chart components (usage-time-series, agent-usage, team-usage, model-donut): replace var(--chart-N) CSS vars with explicit semantic hex colors — #3b82f6 blue for informational, #f59e0b amber for warning/pending, #22c55e green for success/healthy, #ef4444 red for error/blocked, #a855f7 purple for supplemental. pnpm lint and pnpm typecheck pass with zero new errors. Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> * [ccd256f4] Kanban mobile viewport: 375px layout, column navigation, 44px touch targets (#191) * [ccd256f4] feat(kanban): mobile 375px layout with column navigator and 44px touch targets - KanbanBoard: add activeColumnIndex state + mobile prev/next column navigator (lg:hidden); existing horizontal-scroll layout hidden on mobile (hidden lg:flex). Desktop DnD behavior unchanged. - KanbanColumn: add optional className prop (cn-based) so mobile view can pass w-full/sm:w-full to fill the viewport. - KanbanCard: bump all action buttons to min-h-11 (44px) touch targets (Assign, Pass, Fail, Move-forward). * [ccd256f4] fix(kanban): change breakpoint from lg to sm for mobile/desktop layout switch AC3 requires >=640px viewport to show multi-column layout (sm: breakpoint). Previous impl used lg: (1024px), leaving 640-1023px in single-column mode. Change: - Mobile navigator div: lg:hidden → sm:hidden - Desktop multi-column div: hidden lg:flex → hidden sm:flex At <640px: single-column with prev/next navigator (375px mobile use case). At >=640px: full horizontal-scroll multi-column layout (per AC3). DnD behavior and all other layout unchanged. --------- Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [23f02af4] Agents page On-Demand section + Board composition; Overview Quick Actions visibility + Team Health Intake/Secretary (#189) * [23f02af4] feat(agents,overview): On-Demand section, Board composition fix, Intake/Secretary in Quick Actions + Team Health - agent-definitions.ts: remove AgentRole.MAIN_PM from getBoardAgents (Main PM has its own dedicated section; including it there was redundant). Add getOnDemandAgents() that catches agents not in any standard team (board/main_pm/backend/frontend/ux_ui/marketing) and not a standard cell role — surfaces prompter/intake agents that the API may return. - agents/page.tsx: import getOnDemandAgents; add a conditional 'On-Demand Agents' AgentGrid section (only rendered when the API returns at least one matching agent, e.g. the Intake interviewer). - quick-actions-bar.tsx: add 'Task Intake' button (→/prompter, Sparkles icon) and 'Secretary' button (→/business?tab=secretary, Bot icon) alongside existing quick actions so operators can reach on-demand agents from the Overview in one click. - team-health-cards.tsx: add OnDemandAgentCard sub-component (link card with On-Demand badge) and render static cards for 'Task Intake' and 'Secretary' appended after the API-driven TeamHealthCard list, giving them equal visual presence in the Team Health section. pnpm lint and pnpm typecheck pass with zero new errors. * [23f02af4] fix(agents,overview): QA revision — enum entries, QuickActions placement, On-Demand title, Board PR_REVIEWER AC3: types/index.ts AgentRole enum adds PR_REVIEWER, PROMPTER, SECRETARY. agent-selector.tsx ROLE_LABELS exhaustive Record updated accordingly. AC4: command-center.tsx QuickActionsBar moved to after Team Health section, before CEO Approval Queue and data-heavy grid rows — visible without scrolling on a 900px viewport. AC1: agents/page.tsx On-Demand AgentGrid title fixed to 'On-Demand' (was 'On-Demand Agents' in prior commit). AC2: agent-definitions.ts getBoardAgents adds explicit PR_REVIEWER inclusion and uses inclusion-based getOnDemandAgents (PROMPTER|SECRETARY roles). AC5: team-health-cards.tsx static OnDemandAgentCard implementation refined with correct fallback rendering when no API team data. AC6: pnpm lint and pnpm typecheck (src only) pass with zero new errors. --------- Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [b1c59206] Git page: Pull, Fetch, Rebase buttons wired to backend; Rebase destructive confirmation dialog (#192) * [b1c59206] feat(git): add Pull, Fetch, Rebase operations to Git page with destructive confirmation dialog for Rebase - Add GitPullRequest/Response, GitFetchRequest/Response, GitRebaseRequest/Response types - Add gitApi.pull(), gitApi.fetch(), gitApi.rebase() with mock stubs for /git/pull, /git/fetch, /git/rebase - Add useGitPull, useGitFetch, useGitRebase mutation hooks with cache invalidation; exported via useGitOperations - Add Pull (Download icon), Fetch (RefreshCcw icon), Rebase (GitGraph icon) buttons to GitActionsPanel - Rebase button triggers AlertDialog with destructive confirmation before calling API - Wire handlePull, handleFetch, handleRebase handlers in git-browser.tsx with toast feedback * [b1c59206] fix(git): add destructive styling and branch name to Rebase AlertDialog - Add className='border-destructive bg-destructive/5' to AlertDialogContent so the dialog container has the required red-tinted styling (AC3) - Update AlertDialogDescription to interpolate status?.current_branch so the dialog body explicitly names the branch being rebased (AC3) --------- Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> --------- Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> * [3f305ed9] Frontend: Fix git control contract, complete Secretary restyling, and apply polish (CEO revision) (#199) * [72de8a65] fix(git): correct Pull/Fetch/Rebase types, API mocks, request fields, and toast handlers (#197) - types/git.ts: GitPullResponse and GitFetchResponse now have current_branch, has_changes, staged_files, unstaged_files, untracked_files, ahead, behind (matching backend GitStatusResponse); removed nonexistent commits_received/ refs_updated/remote fields - types/git.ts: GitRebaseRequest now uses target_branch: string (not onto?: string); GitRebaseResponse now has conflict: boolean and conflicted_files: string[] (removed branch/onto/commits_rebased); task_id made optional on all three request types - lib/api/git.ts: Updated mock returns for pull/fetch/rebase to match new types - git-actions-panel.tsx: onRebase prop now (targetBranch: string) => void; Rebase AlertDialog now contains an Input for target_branch; AlertDialogAction disabled when targetBranch empty and passes the value to onRebase - git-browser.tsx: handlePull and handleFetch toast references result.current_branch; handleRebase accepts targetBranch, sends target_branch in payload, toasts result.conflict and result.conflicted_files; no 'manual' task_id for any pull/fetch/rebase operation Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [be6a17fc] feat(ui): design-system polish — chart tokens, KB aria-label, Kanban touch targets (#196) - kb-search-bar.tsx: add aria-label="Clear search" to the clear (X) button - model-usage-donut.tsx: replace hex CHART_COLORS with var(--chart-1)…var(--chart-5) - usage-time-series-chart.tsx: replace hex stopColor/stroke with var(--chart-1)/var(--chart-2) - agent-usage-chart.tsx: Bar fill hex → var(--chart-1) - team-usage-chart.tsx: Bar fill hex → var(--chart-1) - kanban-card.tsx: min-h-11 → max-sm:min-h-11 (44px touch target mobile-only, 3 buttons) - secretary-tab.tsx: already compliant (Button + design-system tokens), no change needed Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> --------- Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> * [d62036bd] Backend: Fix git endpoint schemas, add safety gates, and unit tests (CEO revision) (#200) * [d0593fe3] feat(git): remove agent_id from schemas and add service-layer safety gates (#195) - Remove agent_id field from all 9 git request schemas (GitCreateBranchRequest, GitCheckoutRequest, GitCommitRequest, GitPushRequest, GitCreatePRRequest, GitMergePRRequest, GitPullRequest, GitFetchRequest, GitRebaseRequest); agent identity comes from JWT auth context - Make task_id Optional[UUID]=None in GitPullRequest, GitFetchRequest, GitRebaseRequest - Add field_validator to GitRebaseRequest rejecting target_branch starting with '-' or equal to 'master'/'main' - Add lightweight PullRequest, FetchRequest, RebaseRequest schemas for gateway layer - Add dirty-workspace check to GitService.pull() (raises ValidationError if porcelain output) - Switch GitService.pull() to --ff-only; raises ValidationError with diverged-branch message on non-zero exit - Add master/main guard to GitService.rebase() for both head_branch and target_branch - Update callers: routes/tasks.py (2x), services/task.py, tests/unit/services/test_git.py (2x) Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> * [a2f96961] Add role-gated rebase endpoint and unit tests (test_git_rebase.py) (#198) * [a2f96961] feat(git): add role-gated rebase endpoint and unit tests Add role-gate to POST /rebase restricting access to DEVELOPER and CELL_PM roles; add master/main protected-branch guard to GitService.rebase() before any git subprocess runs; add 4 unit tests in tests/unit/services/test_git_rebase.py covering both target-branch and head-branch REBASE_FORBIDDEN cases * [a2f96961] fix(git): invert rebase role gate, add ownership check, schema validator, and missing tests - _REBASE_ALLOWED_ROLES changed from {DEVELOPER, CELL_PM} to {CEO, CELL_PM, MAIN_PM} so developers correctly receive 403 per AC1/AC2 - rebase_branch() now verifies task ownership for non-CEO PM callers: if task_id is provided and the task is not assigned to the calling agent, returns 403/404 - GitRebaseRequest.target_branch gets a @field_validator rejecting '-' prefix names and protected branch names (main, master, develop) - GitService.pull() gains pre-flight safety gates: raises ValidationError DIRTY_TREE when staged/unstaged changes exist, DIVERGED_BRANCH when ahead > 0 and behind > 0 - test_git_rebase.py adds 9 new tests: pull() dirty-tree ValidationError, pull() diverged-branch ValidationError, pull() success path, schema validator for '-' prefix and protected names, and route-level tests confirming HTTP 403 for DEVELOPER and HTTP 200 for CELL_PM on POST /rebase * [a2f96961] fix(tests): add type annotations for tuple variables in test_git_rebase.py mypy needs explicit tuple type annotations when assigning bare tuples to variables used as mock side_effect return values — fixes var-annotated error caught by the server-side quality gate --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Renn F <rennf93@users.noreply.github.com> --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Renn F <rennf93@users.noreply.github.com> * [94015c6d] Frontend R3: Fix legacy git taskId coercion + rebase placeholder + phantom fields (#204) * [401ddb40] fix(git): remove phantom fields from GitPullRequest/GitFetchRequest and make task_id optional in write request interfaces; use taskId || undefined in git-browser.tsx handlers to avoid 422 errors when no task context is active (#201) Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [cca8d0c0] fix(git): fix rebase placeholder and surface backend error in toast (#202) git-actions-panel.tsx: change rebase target_branch Input placeholder from "e.g. main or origin/main" to "Remote ref (e.g. origin/HEAD)" so no default branch name (main/master/develop) is suggested. git-browser.tsx: import getErrorMessage from @/lib/api/client and use it in handleRebase catch block instead of the hardcoded string "Failed to rebase". getErrorMessage extracts the real detail from AxiosError.response.data.detail and falls back to a non-empty generic message, satisfying both the detail-surfacing and fallback criteria. Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> --------- Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> * [1ea0fbcb] Backend R3: Relax legacy git schemas + fix integration tests (#206) * [219c539b] Make task_id Optional in git request schemas and update service methods (#205) * [219c539b] feat(git): make task_id Optional in git schemas and add None-guards in service methods - GitCommitRequest, GitPushRequest, GitCreatePRRequest, GitMergePRRequest now have task_id: UUID | None = None - commit_for_task, push_for_task, create_pr_for_task, merge_pr_for_task skip ownership/state checks when task_id is None and proceed to the git operation - Added 16 unit tests in tests/unit/api/routes/test_git_optional_task_id.py covering schema validation and HTTP endpoint responses - Added 4 integration tests in tests/integration/test_git_routes.py for no-422 behaviour - All quality gates pass: ruff format, ruff check, mypy, pytest * [219c539b] fix(tests): remove unused type-ignore comments, redundant cast, and invalid agent_id kwarg in git_optional_task_id unit tests --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> * [de95ce94] test(git): fix 3 rebase integration tests to use non-protected target_branch (#203) - Add pm_git_client fixture (CELL_PM role) needed for the role-gated rebase endpoint - Change target_branch from 'main' to 'develop' in test_rebase_success, test_rebase_conflict, and test_rebase_git_command_error - Remove task_id from request bodies (optional field; random UUIDs trigger 404) - Switch all 3 rebase tests to use pm_git_client instead of git_client Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev> --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev> * chore: ruff format test_agent_image_registry.py (unblock quality gate) --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev> Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-06-17 06:36:28 +02:00
5 people	a89d3cc885	[a1e2bfb4] Fix 26 verified UI bugs across the panel dashboard (#175) ... * [41219301] Fix 26 verified UI bugs in the panel dashboard (#174) * [115788ef] API/state bugs batch 1 — PATCH fix, WebSocket reconnect, agent roster, sessions export, timestamp (#173) * fix(orchestrator): launch agent MCP servers with uv run --no-sync Agent MCP servers (flow/do/git-readonly/optimal/docs/search) are launched as `uv run python -m roboco.mcp.<server>` with cwd = the agent's workspace clone. When that clone's uv.lock drifts from the baked image, `uv run` re-syncs the dependency set mid-spawn and the servers never reach "connected" — they sit at status="pending", so the agent gets zero gateway verbs. It then can't claim, commit, or even i_am_idle (all MCP verbs), so its Stop is rejected and it respawns in a loop, re-doing work it can't submit. UV_PROJECT_ENVIRONMENT pins the venv location but does not stop the cwd-relative resolve/sync; --no-sync does, so the servers reuse the baked /app/.venv as-is and start instantly. PMs were unaffected only because they run from /app where the env already matches the lock. * fix(agent): launch agent uv-run subprocesses with --no-sync Agents with a write workspace (developer/product_owner/head_marketing/documenter) run with cwd = their git workspace clone. Claude Code launches each MCP server (flow/do/git-readonly/optimal/docs/search) and the SDK server as `uv run python -m ...` from that cwd. When the clone's uv.lock drifts from the baked image, `uv run` re-resolves and re-syncs /app/.venv against the clone's lock — a multi-minute stall on a cold wheel cache — so the servers never reach "connected": they sit at status="pending" and the agent gets ZERO gateway verbs. It then can't claim/commit/idle (all MCP verbs), its Stop is rejected, and it respawns in a loop redoing work it can't submit. UV_PROJECT_ENVIRONMENT pins the venv location but does NOT stop the cwd-relative resolve/sync (confirmed empirically on uv 0.11.1); `--no-sync` does, so the servers reuse the baked /app/.venv as-is and start instantly. The /app-cwd roles (qa/cell_pm/main_pm/auditor) were unaffected because their env already matches. - orchestrator.py: --no-sync on all 6 generated MCP servers - docker/scripts/sdk-startup-hook.sh: --no-sync on the agent_sdk.server launch - test_spawn_strict_mcp.py: assert every server's args start with run,--no-sync * [115788ef] fix(api): use PATCH not PUT in tasksApi.update(), remove WS double-increment, fix staleTime/roster id, remove sessions groupsApi dup, add < 1h ago label --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com> Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [db2c341f] UI/visual bugs batch 1 — priority labels, QA columns, DnD prompt, CEO dialog, dark mode (#172) * fix(orchestrator): launch agent MCP servers with uv run --no-sync Agent MCP servers (flow/do/git-readonly/optimal/docs/search) are launched as `uv run python -m roboco.mcp.<server>` with cwd = the agent's workspace clone. When that clone's uv.lock drifts from the baked image, `uv run` re-syncs the dependency set mid-spawn and the servers never reach "connected" — they sit at status="pending", so the agent gets zero gateway verbs. It then can't claim, commit, or even i_am_idle (all MCP verbs), so its Stop is rejected and it respawns in a loop, re-doing work it can't submit. UV_PROJECT_ENVIRONMENT pins the venv location but does not stop the cwd-relative resolve/sync; --no-sync does, so the servers reuse the baked /app/.venv as-is and start instantly. PMs were unaffected only because they run from /app where the env already matches the lock. * fix(agent): launch agent uv-run subprocesses with --no-sync Agents with a write workspace (developer/product_owner/head_marketing/documenter) run with cwd = their git workspace clone. Claude Code launches each MCP server (flow/do/git-readonly/optimal/docs/search) and the SDK server as `uv run python -m ...` from that cwd. When the clone's uv.lock drifts from the baked image, `uv run` re-resolves and re-syncs /app/.venv against the clone's lock — a multi-minute stall on a cold wheel cache — so the servers never reach "connected": they sit at status="pending" and the agent gets ZERO gateway verbs. It then can't claim/commit/idle (all MCP verbs), its Stop is rejected, and it respawns in a loop redoing work it can't submit. UV_PROJECT_ENVIRONMENT pins the venv location but does NOT stop the cwd-relative resolve/sync (confirmed empirically on uv 0.11.1); `--no-sync` does, so the servers reuse the baked /app/.venv as-is and start instantly. The /app-cwd roles (qa/cell_pm/main_pm/auditor) were unaffected because their env already matches. - orchestrator.py: --no-sync on all 6 generated MCP servers - docker/scripts/sdk-startup-hook.sh: --no-sync on the agent_sdk.server launch - test_spawn_strict_mcp.py: assert every server's args start with run,--no-sync * [db2c341f] fix(ui): priority badges, QA columns, DnD dialog, CEO label, dark mode - priority-indicator.tsx: update labels P0→P0-Highest etc, add text-xs to all color strings, fix className operator precedence bug - task-table.tsx: match priority label format and add text-xs to badge className - kanban-column.tsx: show QA Pass/Fail buttons in VERIFYING column alongside AWAITING_QA - kanban-board.tsx: intercept DnD drops onto NEEDS_REVISION/AWAITING_DOCUMENTATION to show notes dialog when showQaActions is true - task-action-dialogs.tsx: change CeoApproveDialog Label from 'Approval notes' to 'Notes required'; fix all Cancel buttons to call handleOpenChange(false) so state is cleared on dismiss - create-task-dialog.tsx: reset form when dialog is closed without submitting - active-blockers-panel.tsx: add dark:border-red-900 dark:bg-red-950 dark:hover:bg-red-900 to blocker items - notifications/page.tsx: add dark: Tailwind variants for NORMAL, HIGH, URGENT priority badge colors --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com> Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> * [123e2ec2] Fix remaining 15 UI bugs — revision pass after CEO rejection (#178) * [cdb9b22a] fix(ui): task-header BACKLOG/NEEDS_REVISION actions, P0 priority label, chat-composer safe clear, and inline-edit double-mutation guards (#176) - task-header.tsx: add BACKLOG ('Activate Task') and NEEDS_REVISION ('Start Revision') cases to getAvailableActions() switch so the Actions dropdown is never empty for those statuses - draft-proposal-card.tsx: PRIORITY_LABELS[0] changed from 'Urgent' to 'Highest' to match backend contract - chat-composer.tsx: move setValue('') inside try-block after onSend resolves; a failed send now preserves the textarea text - acceptance-criteria.tsx: onMouseDown={(e)=>e.preventDefault()} on inline-edit save button to prevent onBlur+onClick double API mutation - tab-dependencies.tsx: same onMouseDown guard on parent-task inline-edit save button - tab-plan.tsx: onMouseDown guards on all inline-edit/add save buttons (ApproachSection, SubTasks, TechConsiderations, Risks, OpenQuestions) Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * [01852d69] fix(dashboard): wire real agent status, refetch all 4 queries, error indicator, Coming Soon tooltip on search, sentinel div auto-scroll in message-list and mentor-chat, and New Report / Generate Report button mutations in reports-panel and auditor-dashboard — all 9 files fixed (#177) Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> --------- Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev> * [3f35f502] feat(tasks): add case activate and case start-revision to handleAction switch in task detail page (#179) (#180) Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> * fix(tasks): route Start Revision through the operator status override The new "Start Revision" action on a NEEDS_REVISION task called lifecycle.start (POST /tasks/{id}/start), which is assignee-only — so an operator/CEO clicking it from the task detail page got a 403 ("Only the assigned agent can start this task") instead of a transition. Route it through useUpdateTask (PATCH /tasks/{id} with status=in_progress) instead. The backend treats status as an audited admin override applied via admin_set_status and gated on elevated (ASSIGN) permissions — the same god-mode path the kanban board uses for operator status changes — so the operator can nudge a needs_revision task back into progress for its assignee to rework. Mirrors the existing kanban updateTask.mutateAsync shape. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com> Co-authored-by: Frontend Developer 1 <fe-dev-1@agents.roboco.dev> Co-authored-by: Frontend Developer 2 <fe-dev-2@agents.roboco.dev>	2026-06-16 06:57:00 +02:00
Renn F	8e201901c0	I mean, it's at a good place rn...	2026-04-20 15:10:54 +02:00