roboco

External/roboco

Fork 0

mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00

Commit Graph

Author	SHA1	Message	Date
Renn F	f8e07d47e3	fix(optimal): make IndexJournalEntryParams.entry_id required Task 22 added a runtime ValueError when entry_id is None, but the dataclass still typed it Optional. Contract-vs-runtime split — callers get no IDE/mypy hint about the required field. Tighten the type to UUID (required) and remove the misleading "can be None for system events" docstring note. Lifecycle events already use their synthetic uuid5 path, so no real caller is broken.	2026-05-03 10:38:59 +02:00
Renn F	b0107f8c12	fix(optimal): raise instead of falling back to 'unknown' doc source Silent fallback hid an upstream bug where journal_entry.id wasn't flushed before indexing. Raise so we see the regression.	2026-05-03 10:31:59 +02:00

Author

SHA1

Message

Date

Renn F

f8e07d47e3

fix(optimal): make IndexJournalEntryParams.entry_id required

Task 22 added a runtime ValueError when entry_id is None, but the
dataclass still typed it Optional. Contract-vs-runtime split — callers
get no IDE/mypy hint about the required field. Tighten the type to
UUID (required) and remove the misleading "can be None for system
events" docstring note. Lifecycle events already use their synthetic
uuid5 path, so no real caller is broken.

2026-05-03 10:38:59 +02:00

Renn F

b0107f8c12

fix(optimal): raise instead of falling back to 'unknown' doc source

Silent fallback hid an upstream bug where journal_entry.id wasn't
flushed before indexing. Raise so we see the regression.

2026-05-03 10:31:59 +02:00