3 Commits

Include renames

Author	SHA1	Message	Date
5 people	f0f09b2204	[1197c975] Re-add Playwright chromium to FE/UX QA images and add browser-verification prompt guidance (#406) ... * [3e552255] Re-add Playwright chromium to QA images + prompt guidance (#395) (#405) * [3e552255] feat(docker): re-add Playwright chromium-headless-shell to QA images * [3e552255] ci(docker): add Playwright QA image build + headless smoke check workflow * [3e552255] fix(ci): scope agent-image-smoke.yml trigger to paths only, add PR comment The workflow was gated by `branches: [master]` on both push and pull_request, but this repo's task-hierarchy PRs open against nested parent feature branches, not master, until root->master assembly - so the workflow never fired on a dev-level PR and produced zero evidence. Drop the branch filter (path scoping is sufficient) and post the size-delta table + smoke-check output as a PR comment via actions/github-script, since no agent role has gh CLI or GitHub API read access to pull check-run output directly. * [3e552255] fix(ci): post agent-image-smoke PR comment even on step failure The 'Post results as a PR comment' step only had `if: github.event_name == 'pull_request'`, which GitHub implicitly ANDs with success() — so if the docker build or headless-launch smoke check failed, the PR comment (the only evidence-delivery path QA/PM has, since no agent role can read the Checks tab) silently never posted. Added always() so a partial report always lands on the PR. This commit also re-lands the branches-filter removal + PR-comment step from 747e4d74 to make sure this fix actually reaches the remote PR branch — QA's needs_revision at 05:48 came after that commit's local timestamp (05:43) but still saw the pre-fix workflow, indicating the prior push never reached GitHub. * [3e552255] docs(qa): add browser verification guide and CHANGELOG entry for Playwright chromium - Added comprehensive QA browser verification guide at docs/backend/qa/browser-verification.md covering setup, examples for fe-qa/ux-qa, limitations, and troubleshooting - Updated CHANGELOG.md with Unreleased entry documenting Playwright chromium-headless-shell re-add to agent-qa-fe and agent-ux images, CI smoke workflow, and links to QA guidance - Guide explains when to use browser verification (rendered output, computed styles, a11y, visual design), how to launch headless chromium, and provides practical examples for both FE and UX QA use cases - References built-in guidance in fe-qa.md/ux-qa.md identity prompts and CI smoke workflow verification --------- Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> Co-authored-by: Backend Documenter <be-doc@roboco.tech> * [9aafe8f5] Revision: fix reflow-check CI failure and resolve orchestrator Playwright-allowance gap (#421) * [9973237c] fix(docs): separate reflow-joined metadata lines in browser-verification.md (#419) scripts/reflow_md.py --check treats two adjacent non-blank lines as one paragraph and flags it as hard-wrapped prose needing a join. Insert a blank line between the `**For:**` and `**Purpose:**` metadata lines so each stays its own single-line paragraph; verified the reflow is now a no-op and the non-whitespace token sequence is unchanged. Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> * [cc355a2b] docs(qa): add no-op analysis for orchestrator.py Playwright allowance (#422) Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> * [a506cc10] docs(qa): quote real Dockerfile Playwright snippets in no-op analysis (#424) Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> --------- Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> * [2b35dd4e] Resolve merge conflict, confirm green CI, add Playwright MCP registration, re-verify 5 ACs (#447) (#450) * [2b35dd4e] docs(changelog): resolve Unreleased/0.22.0 ordering conflict, keep Playwright entry * [2b35dd4e] feat(runtime): register Playwright MCP server for fe-qa/ux-qa, per CEO round-3 note Adds @playwright/mcp to agent-qa-fe and agent-ux images, wired via a wrapper entrypoint that points the server at each image's already-baked chromium-headless-shell instead of downloading a second browser. The orchestrator registers the `playwright` MCP server only for the qa role on the frontend/ux_ui teams, so be-qa and ux-dev never see it. Updates the QA identity prompts and docs/backend/qa/browser-verification.md to document the structured mcp__playwright__* tools in place of hand-scripted Bash+Python, adds CI smoke coverage (binary + baked-chromium resolution + a real panel-page screenshot from inside the ux-qa image), and records the change in CHANGELOG.md. --------- Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> * [1197c975] type the mcpServers extraction so mypy's no-any-return passes * [1197c975] extract role-scoped MCP registration — orchestrator back under the complexity budget The playwright branch pushed _generate_mcp_config to rank C in the merge ref; docs/research/playwright registrations move to one helper, behavior identical. * [1197c975] basename-sanitize the MCP config filename CodeQL's path-injection query re-fired on the (moved, unchanged) config write; agent ids are orchestrator-issued, but the filename now rides the same os.path.basename sanitizer _grok_usage_json established. * [1197c975] basename the agent id variable itself — the sanitizer shape CodeQL models --------- Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> Co-authored-by: Backend Documenter <be-doc@roboco.tech> Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-11 07:39:53 +02:00
Renn FandRenzo F	cc07c580e2	chore(docker): lean images — drop unused playwright, dedupe grok layer, cache-stable /app layering ... - agent-dev-fe / agent-qa-fe: remove playwright chromium + its system libs (~770MB each; verified unused — panel tests are vitest, e2e harness is scripted Python; pnpm kept) - agent-grok: drop the redundant chown -R that duplicated the 149MB CLI tree into a second layer (install already runs as agent) - agent-base + orchestrator runners: split the single /app COPY into .venv-first / source-last layers so a source-only deploy re-layers ~13MB instead of ~380MB per image - agent-base: split the 813MB apt+node+claude-code RUN so a CLI bump no longer re-downloads the OS/node layer - .dockerignore: exclude gitignored docs/internal from the orchestrator's docs COPY; pin uv helper image to 0.11 - verified: all four images rebuilt + runtime-probed (claude/git/jq/node/uv/pnpm/grok, import roboco, docs/alembic/agents present); .venv layer proven CACHED across a source-only change	2026-07-08 06:39:20 +02:00
Renn F	204b959733	1. Blueprint updates - Added NO_GROUPS escalation docs to all 12 agent blueprints ... 2. Multi-image Docker architecture - Created role-specific Dockerfiles: - agent-base.Dockerfile (shared foundation) - agent-pm.Dockerfile, agent-dev-be.Dockerfile, agent-dev-fe.Dockerfile - agent-qa-be.Dockerfile, agent-qa-fe.Dockerfile, agent-doc.Dockerfile, agent-ux.Dockerfile 3. Orchestrator updates - roboco/runtime/orchestrator.py: - Added AGENT_IMAGES mapping and get_agent_image() function - Updated _ensure_agent_image() to build base + specialized images - Updated _spawn_container() to use role-specific image - Made _generate_mcp_config() role-aware (though kept notify for all since they need to receive)	2025-12-23 21:23:50 +01:00